From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B53B03858D32 for ; Sun, 2 Oct 2022 13:15:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B53B03858D32 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-599-YBzXwvYpP7GTuWUCyId2sA-1; Sun, 02 Oct 2022 09:15:37 -0400 X-MC-Unique: YBzXwvYpP7GTuWUCyId2sA-1 Received: by mail-wm1-f71.google.com with SMTP id i132-20020a1c3b8a000000b003b339a8556eso4923256wma.4 for ; Sun, 02 Oct 2022 06:15:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=vAoN5JFXZK12tEFdLrft6R7O948g2wsgw1cnHksBqTk=; b=uy8ciq0bSpDf2g8jnWigD8aiNGr9Y59sV1elbmcBmE6h+6Ahx5HEsrRNRgoxwDfzlY euuMax/oUZFTGSyUx5D6SppTNec3naL0rygG4xyl7Fs2Jf0VnEiPY/uiELy2qxN8x9bd kgn0z/z5bcASzSPlEsT3ltweDc0EaCCRezkh9JRLWVQ3eerBxgSXF/58ePqKv3gUHVr9 wG/gfhA4TLVa4AWOM42YiZcpVMk//qZjJ+JqWUQNiMN2Cni6LwOn+G2jak+kO8i2ZDIF 7jJfhpEFfM8mMZ7DJKFotsB5JEY74qWbPabniMUC9EiCVsagtWJvjoL7I0yn6L92bjkI GA3Q== X-Gm-Message-State: ACrzQf2FREt+6RzVVwBqTW1xOaXPg+TCYQlJyJ02lXhfDj3AfOvab7bE a1EeDetlvycRB/OA8hbL9e6OBlqs13pjKxH9zbBAWdyvQ/7K8mMvT5iXXxrdvf/I75pHq+Pq6KS zK/+yODTZ4TqrLySzD7asEw== X-Received: by 2002:adf:d4c3:0:b0:22e:326f:e8ef with SMTP id w3-20020adfd4c3000000b0022e326fe8efmr3054269wrk.242.1664716535907; Sun, 02 Oct 2022 06:15:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4w+AK1tqymgQoOXx+17TiN6l6+9vw56myyVqECbKTNCJUL7C+gD22bMRcSZv4AvYFMuWi2ng== X-Received: by 2002:adf:d4c3:0:b0:22e:326f:e8ef with SMTP id w3-20020adfd4c3000000b0022e326fe8efmr3054261wrk.242.1664716535630; Sun, 02 Oct 2022 06:15:35 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id 12-20020a05600c240c00b003b4764442f0sm8524477wmp.11.2022.10.02.06.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Oct 2022 06:15:35 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 0/9] Disassembler opcode display and text alignment In-Reply-To: <87pmfo3cjv.fsf@tromey.com> References: <87pmfo3cjv.fsf@tromey.com> Date: Sun, 02 Oct 2022 14:15:31 +0100 Message-ID: <87v8p2gydo.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Oct 2022 13:15:39 -0000 Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> This series makes two related changes to GDB's disassembler. Both > Andrew> changes flow naturally from having GDB make use of libopcodes > Andrew> bytes_per_line and bytes_per_chunk presentation hints that are set on > Andrew> a per-architecure basis with each call into the disassembler. > > I read through this series and it all looked fine to me. > Thank you for doing this. Thanks, pushed. Andrew