From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E53253857010 for ; Mon, 12 Sep 2022 09:09:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E53253857010 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-580-GJfYTo8ENX6gi0HApybimQ-1; Mon, 12 Sep 2022 05:09:02 -0400 X-MC-Unique: GJfYTo8ENX6gi0HApybimQ-1 Received: by mail-wm1-f72.google.com with SMTP id t14-20020a1c770e000000b003b4856a6ecaso1204261wmi.2 for ; Mon, 12 Sep 2022 02:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=VvCSJFzX7Z2cxzGUUknxYo9ubEC+G0QRqB+pqck9JdA=; b=2x0U75FTb7d0H7QdpO5M04t55MukzaF1rG/9WJG0rCwgf0MLZi1iShzHgza2BRULXM EXlzP26siaod6QBInYk8VIS3GSTByOSrpUPIoo0+hcNSUaM7al4mYBR6k/nS6xNVSCoI ys7pJFBxE2sOCRSTC/7B9qgq4pLMa07H+DTApr+ak1neA1huSQi0v7Nc768rchXuaG6T vf6F9bhKJU+WAs05JJ33TcoRrGP3SAooyupF5ZNx/9yACWRa8nHqC57jxeN8R8P9rR5+ bR/oEgFzUG/AGe8LCPT2blLhFx4fwqusfdvk6rB8AVRTMulejTtCKUvzXthcqXIHNJ7h Om0g== X-Gm-Message-State: ACgBeo1iurl+j2TqsvNaVJsnOVZcNWhmqNzk2koOKGj5zmxgnb09xlIl 5ohX9Xbo7+MDezuH+LhIJ5q5jOo9VrStOvLGy8zt0lgnj6sIvsC1nX7Mk/Z26veZm+gR/vU2mq3 rnnnfIK73EI7THwOK13KPWw== X-Received: by 2002:a05:6000:2ab:b0:228:e3b1:c3b2 with SMTP id l11-20020a05600002ab00b00228e3b1c3b2mr13612893wry.313.1662973740760; Mon, 12 Sep 2022 02:09:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR6IlOhXbRLeAseB8QU5ap6vmyfJ3kq4014tX/Vf0YtsLGmTkXUhaoN/UPyENkd2GlOa6/HFOA== X-Received: by 2002:a05:6000:2ab:b0:228:e3b1:c3b2 with SMTP id l11-20020a05600002ab00b00228e3b1c3b2mr13612880wry.313.1662973740496; Mon, 12 Sep 2022 02:09:00 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id j33-20020a05600c1c2100b003b47a99d928sm5154242wms.18.2022.09.12.02.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 02:09:00 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH v4 04/15] gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang In-Reply-To: <20220720194441.168906-6-blarsen@redhat.com> References: <20220720194441.168906-1-blarsen@redhat.com> <20220720194441.168906-6-blarsen@redhat.com> Date: Mon, 12 Sep 2022 10:08:59 +0100 Message-ID: <87v8ptklhw.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 09:09:09 -0000 Bruno Larsen via Gdb-patches writes: > Clang organizes the variables differently to gcc in the original version > of this code, leading to the following differences when testing > p (int*) &dataglobal + 1 > > gcc: > $16 = (int *) 0x404034 > > clang: > $16 = (int *) 0x404034 > > However, since the important part of this test doesn't seem to be which > symbol is linked, but rather if GDB is correctly increasing the > address. This test was changed to actually measure address changes, > instead of assuming the ordering and naming of symbols. > > Co-Authored-By: Andrew Burgess This looks good. I think this patch can be merged. Thanks, Andrew > --- > gdb/testsuite/gdb.base/nodebug.exp | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/nodebug.exp b/gdb/testsuite/gdb.base/nodebug.exp > index 68a21eb07dd..1deed596095 100644 > --- a/gdb/testsuite/gdb.base/nodebug.exp > +++ b/gdb/testsuite/gdb.base/nodebug.exp > @@ -170,6 +170,7 @@ if [nodebug_runto inner] then { > set unk_type_re "has unknown type.*to its declared type" > set ptr_math_re "Cannot perform pointer math on incomplete type \"$data_var_type\", try casting to a known type, or void \\*\\." > set not_mem_re "Attempt to take address of value not located in memory\\." > + set any_label_regexp "<\[^>\]+>" > > set dataglobal_unk_re "dataglobal.*$unk_type_re" > > @@ -183,7 +184,7 @@ if [nodebug_runto inner] then { > {"dataglobal + 1" "" $dataglobal_unk_re $dataglobal_unk_re} > {"&dataglobal" "" "\\($data_var_type \\*\\) $hex " " = $data_var_type \\*"} > {"&dataglobal + 1" "" $ptr_math_re $ptr_math_re} > - {"(int *) &dataglobal + 1" "" " = \\(int \\*\\) $hex " "int \\*"} > + {"(int *) &dataglobal + 1" "" " = \\(int \\*\\) $hex $any_label_regexp" "int \\*"} > {"&(int) dataglobal + 1" "" $not_mem_re $not_mem_re} > {"&dataglobal, &dataglobal" "" "\\($data_var_type \\*\\) $hex " " = $data_var_type \\*"} > {"*dataglobal" "" $dataglobal_unk_re $dataglobal_unk_re} > @@ -214,7 +215,14 @@ if [nodebug_runto inner] then { > gdb_test "whatis $exp" $whatis > gdb_test "ptype $exp" $whatis > } > - > + > + # Check that pointer arithmetic works as expected. > + set addr1 [get_hexadecimal_valueof "&dataglobal" "*UNKNOWN*"] > + set addr2 [get_hexadecimal_valueof "(int *) &dataglobal + 1" "*UNKNOWN*"] > + set offset [expr $addr2 - $addr1] > + set int_size [get_integer_valueof "sizeof (int)" "*UNKNOWN*"] > + gdb_assert { $offset == $int_size } > + > # The only symbol xcoff puts out for statics is for the TOC entry. > # Possible, but hairy, for gdb to deal. Right now it doesn't, it > # doesn't know the variables exist at all. > -- > 2.31.1