From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 558753858284 for ; Mon, 18 Jul 2022 16:11:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 558753858284 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 25E0110047B87 for ; Mon, 18 Jul 2022 16:11:25 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DTLAoaEzDjIMdDTLAoDmDd; Mon, 18 Jul 2022 16:11:25 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ebP4w5IH c=1 sm=1 tr=0 ts=62d5862d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=cTlxYEnLI3kPf3dg_8YA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CugifyRO+wUF53Ho2NKgG2wUWAUynwVTQNaOnYXpcMo=; b=GYDX3GXrP0QwdbDK+dmF5W9BPq MNpNO8w+Bws1lPLD7jryebHoGuKSecL+8r5FNmwTuLLJfeX1PInElgoEv7/yQCpYgPGZYSp7nZJ/B iiOjQX0VDjaSg2bVVGQUix5Nl; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56152 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oDTL9-000Mvw-Cf; Mon, 18 Jul 2022 10:11:23 -0600 From: Tom Tromey To: "George, Jini Susan via Gdb-patches" Cc: "Kempke, Nils-Christian" , "George, Jini Susan" Subject: Re: [PATCH 1/3] gdb: add support for DW_AT_trampoline in DWARF reader References: <20220707121538.1317473-2-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Mon, 18 Jul 2022 10:11:18 -0600 In-Reply-To: (Jini Susan via Gdb-patches George's message of "Sun, 17 Jul 2022 12:57:57 +0000") Message-ID: <87v8rul7tl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oDTL9-000Mvw-Cf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56152 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 16:11:36 -0000 >>> I considered this when implementing it but it seemed like an unrelated change to >>> me. Assuming int is 4 bytes and we align to 8 bytes moving is_trampoline to the >>> 3rd position would also not do anything, would it? We'd be at [...] > I think you missed taking the bitfields (is_noreturn and > is_trampoline) into consideration. If these get placed together, they > would be fitted into one int since both these are just 1 bit each. FWIW you can check the packing using 'ptype/o'. I'm also inclined to say the bitfields should be adjacent. thanks, Tom