From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id BFFE73839C69 for ; Thu, 26 May 2022 17:17:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFFE73839C69 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 380E410047C3F for ; Thu, 26 May 2022 17:17:42 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id uH7FnyGYphWk0uH7GndB2u; Thu, 26 May 2022 17:17:42 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=IrfbzJzg c=1 sm=1 tr=0 ts=628fb636 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=TPua7044wRbJ8iJUo8UA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u/N/qKHb2hdPuMn3ctHXBRcDNersIyV9WZRs0DKnnTA=; b=a0oEVLospBS4W11huvXrBIwnQ3 8uMYU8DHqIRT7YItDdqWRbrny0PLdJOytnNGviMKZRVuHRLsXt6R3FBFFVbMntp2xUcrsAUTI+xVo bDrNBtQzllD4qrkdlNbgFyAAm; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55844 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nuH7F-002N9P-JX; Thu, 26 May 2022 11:17:41 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Subject: Re: [PATCH 6/8] [gdb/rust] Fix literal truncation References: <20220523110518.2447-1-tdevries@suse.de> <20220523110518.2447-6-tdevries@suse.de> X-Attribution: Tom Date: Thu, 26 May 2022 11:17:40 -0600 In-Reply-To: <20220523110518.2447-6-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 23 May 2022 13:05:16 +0200") Message-ID: <87v8ts6wnf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1nuH7F-002N9P-JX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55844 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 17:17:43 -0000 >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Make sure we error out on overflow instead of truncating in all cases. Tom> I've used as overflow string: "Integer literal is too large", based Tom> on what I found at Tom> /src/test/ui/parser/int-literal-too-large-span.rs Tom> but perhaps someone has a better idea. Tom> - value = strtoulst (number.c_str () + offset, NULL, radix); Tom> + const char *trailer; Tom> + value = strtoulst (number.c_str () + offset, &trailer, radix); Tom> + if (*trailer != '\0') Tom> + error ("Integer literal is too large"); This seems fine, though I think it's normal to use _() around the argument to error. Tom> + } elseif { $lang == "rust" } { Tom> + set re_overflow "Integer literal is too large" I don't mind if this is there, but normally the Rust lexer uses unit tests. They are in rust-parse.c, see rust_lex_tests. Tom