From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BA34A3857C50 for ; Thu, 26 May 2022 15:43:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA34A3857C50 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-6QyEzvmZOwGcFzNcWcE28w-1; Thu, 26 May 2022 11:43:48 -0400 X-MC-Unique: 6QyEzvmZOwGcFzNcWcE28w-1 Received: by mail-wr1-f70.google.com with SMTP id y11-20020a5d614b000000b00210001a71dfso378560wrt.21 for ; Thu, 26 May 2022 08:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=pKRBZScZsSnbZ4+xeEJL6qDSYN8WR1Lgn9NEuq/WNxM=; b=5rsacNq0CWOf/qlrS2DkE91Xl6wqzqhhNVAZuykRPosuC6DLBDhmELiaCLa+jkEfH3 coqf310AXVvECzvuC1kE0aikbRbIuRAmQv635EIKmdYuGobf1EDwThAF9cW79y9Y68Qs R738Rp25Qbv0L5/7xC8areYLv6PqhwDWfBCx9Jlytm/Be8w2/7BQSsrq886TwB/jxBFO udA5HPCD0v4V/9nUNBF9PpLWfL0hA8UEArOZzUCUHW07ze1JY2Dh+SLfXufLtdA3qfVK gzUhnjqlKh/HJMpEBA1Er8tE/5Hxpvo6mrU6Y6sAF555AjwEWrgKr0S7FJt01QgLwDW9 xTUA== X-Gm-Message-State: AOAM531oTIQyxRuM5w+BySN8rSvz+hKujrjtIFZ0AESgh9zvrR2w9JBq nbMUPgGzvQ3/M7Pu/l7Y9GNxux0IrEcdwmFkN1DbFzYd0tl78NwQ1noHnTWlrv6/pmg2cyNiYXc vPmkGOZNPT0CVEtEhRhmv1hQMpsNtHMUkIqvIqY8ERcZK9TO8y8YZ5vhizYpyao91UZ7MHOB2/Q == X-Received: by 2002:a05:600c:354a:b0:394:8fa4:73bc with SMTP id i10-20020a05600c354a00b003948fa473bcmr2918963wmq.37.1653579826660; Thu, 26 May 2022 08:43:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZgzb7sFhQxfcihSeedKwbDdXkIYnvocHRCa0Um049zMHaXDb36ru/Ft+lGquiHgOhcMNqjw== X-Received: by 2002:a05:600c:354a:b0:394:8fa4:73bc with SMTP id i10-20020a05600c354a00b003948fa473bcmr2918944wmq.37.1653579826439; Thu, 26 May 2022 08:43:46 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id bd25-20020a05600c1f1900b0039466988f6csm5520976wmb.31.2022.05.26.08.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 08:43:46 -0700 (PDT) From: Andrew Burgess To: Ilya Leoshkevich via Gdb-patches , Tom Tromey Cc: Ilya Leoshkevich , Pedro Alves , Ulrich Weigand , Andreas Arnez , gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] gdb.perf/: Compile the binary with -DSHLIB In-Reply-To: <20220525223711.845475-4-iii@linux.ibm.com> References: <20220525223711.845475-1-iii@linux.ibm.com> <20220525223711.845475-4-iii@linux.ibm.com> Date: Thu, 26 May 2022 16:43:45 +0100 Message-ID: <87v8tsguz2.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 15:43:51 -0000 Ilya Leoshkevich via Gdb-patches writes: > Performance tests that dynamically load shared libraries may need to > know their number. Pass it via the preprocessor define. > --- > gdb/testsuite/lib/gen-perf-test.exp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/lib/gen-perf-test.exp b/gdb/testsuite/lib/gen-perf-test.exp > index f0bfdc9317d..8c5413eaa19 100644 > --- a/gdb/testsuite/lib/gen-perf-test.exp > +++ b/gdb/testsuite/lib/gen-perf-test.exp > @@ -1321,7 +1321,8 @@ namespace eval GenPerfTest { > set input_files [_make_binary_input_file_names self $static $run_nr] > set extra_headers [_get_param $self(binary_extra_headers) $run_nr] > set binary_file [_make_binary_name self $run_nr] > - set compile_options [_compile_options self] > + set nr_gen_shlibs [_get_param $self(nr_gen_shlibs) $run_nr] > + set compile_options "[_compile_options self] additional_flags=-DSHLIB=$nr_gen_shlibs" I wonder if we should use a different name to avoid any chance of confusion with the SHLIB define that is passed when compiling a shared library? We use the same name, but they have subtly different meanings... I'd propose something like TOTAL_NR_SHLIBS or something similar. Thanks, Andrew > set shlib_options [_make_shlib_options self $static $run_nr] > if { [llength $shlib_options] > 0 } { > append compile_options " " $shlib_options > -- > 2.35.3