From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 46A603857C4E for ; Fri, 15 Apr 2022 15:27:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46A603857C4E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 9E4CF10047E25 for ; Fri, 15 Apr 2022 15:27:45 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id fNrNneiw3wm8ifNrNng3ka; Fri, 15 Apr 2022 15:27:45 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DpSTREz+ c=1 sm=1 tr=0 ts=62598ef1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=YwgV2qwl4SQtNoUFmekA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AUtbdql2e7Y08Gg9OrtK8Jy0KbDis+l7ItN+fbmvZXo=; b=SvTkkxZqe9joxViC6Kh6hWKYG4 dDHHiWOgNoWW8rTte26HnA5cppCtZleTCd/EWkD8orY1Jiu7o62AZYW+Vm/Vm6mUDzt19AjKwXe3V S6g64p8ebY66Ypm8jUbTeVg2u; Received: from 71-211-154-204.hlrn.qwest.net ([71.211.154.204]:55554 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nfNrM-003UAb-LD; Fri, 15 Apr 2022 09:27:44 -0600 From: Tom Tromey To: Nils-Christian Kempke via Gdb-patches Cc: Nils-Christian Kempke , jinisusan.george@amd.com, Tim Wiederhake , Bernhard Heckel Subject: Re: [PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point References: <20220414094108.2758482-1-nils-christian.kempke@intel.com> <20220414094108.2758482-2-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Fri, 15 Apr 2022 09:27:43 -0600 In-Reply-To: <20220414094108.2758482-2-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Thu, 14 Apr 2022 11:41:08 +0200") Message-ID: <87v8va1i4w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.154.204 X-Source-L: No X-Exim-ID: 1nfNrM-003UAb-LD X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-154-204.hlrn.qwest.net (murgatroyd) [71.211.154.204]:55554 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2022 15:27:48 -0000 >>>>> Nils-Christian Kempke via Gdb-patches writes: > diff --git a/gdb/dwarf2/abbrev.c b/gdb/dwarf2/abbrev.c > index 2db5ea15ac..3b47987a0e 100644 > --- a/gdb/dwarf2/abbrev.c > +++ b/gdb/dwarf2/abbrev.c > @@ -88,6 +88,7 @@ tag_interesting_for_index (dwarf_tag tag) > case DW_TAG_base_type: > case DW_TAG_class_type: > case DW_TAG_constant: > + case DW_TAG_entry_point: > case DW_TAG_enumeration_type: > case DW_TAG_enumerator: > case DW_TAG_imported_declaration: I wonder what happens if this is removed. If it's needed I suppose I would expect some other changes to the indexer. Like maybe cooked_indexer::index_dies has to handle it, or cooked_index_entry::matches(search_domain). Tom