From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 42FD83858D1E for ; Thu, 10 Feb 2022 21:15:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42FD83858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id A2A5A1004846D for ; Thu, 10 Feb 2022 21:15:11 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id IGmVnD5GBEaNCIGmVn8HHo; Thu, 10 Feb 2022 21:15:11 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=fNX8YbWe c=1 sm=1 tr=0 ts=6205805f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oGFeUVbbRNcA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=13KGAo4DAAAA:8 a=sd6dP9bqzM3V1M3c1EAA:9 a=0Frvj7WxKqMA:10:uccc_2email_address a=ul9cdbp4aOFLsgKbc677:22 a=DdAeqqNASC6T8jxox_Jq:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nOoRIRm6NzliksQBvHIrtajnOopDku4+5e+F5WC1GRA=; b=Na7FsPh9IxUsiyYKS9lTjbJhcI rUe9M+fQ/t6GCP4f1T+IhC7Ah+DHtK/nBpihWhN9wKhbCpz1mnfBRV8/V68ECEV6CRjaH8GNtN8aF BRjVB6j/b9feN/Y5U0tpdn3/s; Received: from 75-166-128-165.hlrn.qwest.net ([75.166.128.165]:55998 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIGmU-0046AV-Ow; Thu, 10 Feb 2022 14:15:10 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess , Andrew Burgess Subject: Re: [PATCHv4 2/2] gdb/python: move styling support to gdb.styling References: X-Attribution: Tom Date: Thu, 10 Feb 2022 14:15:09 -0700 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Tue, 11 Jan 2022 14:31:01 +0000") Message-ID: <87v8xms9sy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.128.165 X-Source-L: No X-Exim-ID: 1nIGmU-0046AV-Ow X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-128-165.hlrn.qwest.net (murgatroyd) [75.166.128.165]:55998 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 21:15:13 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> From: Andrew Burgess Andrew> This commit moves the two Python functions that are used for styling Andrew> into a new module, gdb.styling, there's then a small update in Andrew> python.c so GDB can find the functions in their new location. Makes sense to me. Andrew> Still, despite these functions never having been part of a documented Andrew> API, it is possible that a user out there has overridden these to, in Andrew> some way, customize how GDB performs styling. Moving the function as Andrew> I propose in this patch could break things for that user, however, Andrew> fixing this breakage is trivial, and, as these functions were never Andrew> documented, I don't think we should be obliged to not break user code Andrew> that relies on them. Also, in Python it's easy to have the code dynamically adjust, because it can examine the module and change its behavior. So this sort of change is pretty easy to adapt to if need be. Tom