From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.145.3]) by sourceware.org (Postfix) with ESMTPS id 84CA8385803A for ; Tue, 19 Oct 2021 18:12:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 84CA8385803A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 3C6131EC2E for ; Tue, 19 Oct 2021 13:10:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ctZdmJfJHOnCIctZdmxhiY; Tue, 19 Oct 2021 13:10:53 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+kvY22VOvYWzKARh04oGdaqzGt3eLScxRup4HjFknwQ=; b=ld+ym4w02v5+02oP1GkLkZ4ZnM +KkujJCRZJS/a87MBkVhlocH8o0HbFi2x49bOpY6k/hx6PTr745NxVTFcgAPhGJfwyDPowxJJ5hVK EWV2+mW4EXoW+WFHD41rGRFd/; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:54006 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mctZc-001Jk8-TT; Tue, 19 Oct 2021 12:10:52 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [PATCH][gdb/testsuite] Reimplement gdb.gdb/python-interrupts.exp as unittest References: <20210911120254.GA19083@delia.home> X-Attribution: Tom Date: Tue, 19 Oct 2021 12:10:52 -0600 In-Reply-To: (Tom de Vries via Gdb-patches's message of "Wed, 22 Sep 2021 12:17:46 +0200") Message-ID: <87v91sx4ur.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mctZc-001Jk8-TT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:54006 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 18:12:29 -0000 >>>>> "Tom" == Tom de Vries via Gdb-patches writes: >> +#if GDB_SELF_TEST >> + if (selftests::hook_set_active_ext_lang) >> + selftests::hook_set_active_ext_lang (); >> +#endif Tom> In particular, I'd like feedback on whether this is acceptable. Tom> F.i., I could do instead the less intrusive (but also less flexible): Either way is fine by me. It's clearly code just for testing purposes, so, for me at least, I don't mind if it's too flexible or whatever. Tom> Perhaps this could be handled using a Tom> DEVEL_GDB_SELF_TEST, which is disabled in release branches independent Tom> of --enable-unit-tests? I don't really understand what you meant by this. Do you mean having some way to disable some subset of the self-tests? If so, I think it's fine to just have them all around. Tom