From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Remove dwarf2_cu::language
Date: Mon, 28 Jun 2021 14:11:39 -0600 [thread overview]
Message-ID: <87v95xrbpg.fsf@tromey.com> (raw)
In-Reply-To: <2a23ada7-efaf-189c-e147-db24b4e339ef@suse.de> (Tom de Vries's message of "Tue, 15 Jun 2021 00:16:43 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Now if CU A doesn't import CU B, the namespace for CU A has two entries,
Tom> and the namespace for CU B has two entries.
Tom> And if CU A does import CU B, then the namespace for CU A has four
Tom> entries, and the CU B has two entries. It's not safe to ignore the
Tom> import because semantically there is a difference.
>> What sort of test case would this affect?
Tom> I've written a dwarf assembly test-case.
I still don't understand why this test should differ between C and C++.
IIUC -- it declares the 'inty' typedef two different ways in two
different scopes, then tests that the expected output depends on the
scope:
Tom> +gdb_test "ptype inty" "type = int" "ptype in main"
Tom> +
Tom> +gdb_breakpoint "foo"
Tom> +gdb_continue_to_breakpoint "continue to breakpoint for foo"
Tom> +
Tom> +gdb_test "ptype inty" "type = unsigned int" "ptype in foo"
... if this is correct for C, why wouldn't it be correct for C++?
Tom
prev parent reply other threads:[~2021-06-28 20:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 15:26 [PATCH 0/2] Clean up language handling in the DWARF reader Tom Tromey
2021-06-08 15:26 ` [PATCH 1/2] Consolidate CU language setting Tom Tromey
2021-06-09 1:32 ` Simon Marchi
2021-06-09 20:22 ` Tom Tromey
2021-06-08 15:26 ` [PATCH 2/2] Remove dwarf2_cu::language Tom Tromey
2021-06-09 1:58 ` Simon Marchi
2021-06-09 20:26 ` Tom Tromey
2021-06-09 21:00 ` Tom Tromey
2021-06-10 2:28 ` Tom Tromey
2021-06-10 13:50 ` Simon Marchi
2021-06-10 18:24 ` Tom Tromey
2021-06-10 22:35 ` Tom de Vries
2021-06-11 15:00 ` Tom Tromey
2021-06-14 22:16 ` Tom de Vries
2021-06-16 11:09 ` Tom de Vries
2021-06-28 20:11 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v95xrbpg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).