public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
	 Tom Tromey <tom@tromey.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails
Date: Sat, 05 Jun 2021 08:04:35 -0600	[thread overview]
Message-ID: <87v96sz9u4.fsf@tromey.com> (raw)
In-Reply-To: <AM8PR10MB4708368A60CC576596985506E43A9@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM> (Bernd Edlinger's message of "Sat, 5 Jun 2021 14:27:15 +0200")

>>>>> "Bernd" == Bernd Edlinger <bernd.edlinger@hotmail.de> writes:

>>> +#ifdef SIGTTOU
>> SIGPIPE?
>> 

Bernd> Ah, yes of course!

Bernd> Consider this fixed.

Thanks, this is ok with this fix.

I thought at first that '#ifdef SIGPIPE' was overkill, but I see that
the other uses of SIGPIPE in the tree are guarded, so we might as well
do it here.

Also I see that gdb already randomly disables SIGPIPE globally, e.g. in
ser-tcp.c.  So maybe your original patch should have gone in.  But, I
suppose I'd still prefer that the new one land, since it's clearly
cleaner.

thank you,
Tom

  reply	other threads:[~2021-06-05 14:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 17:31 Bernd Edlinger
2021-06-02 18:21 ` Tom Tromey
2021-06-02 22:19   ` Christian Biesinger
2021-06-03  5:45     ` Bernd Edlinger
2021-06-04 13:39       ` Tom Tromey
2021-06-05 11:44         ` Bernd Edlinger
2021-06-05 12:04           ` Andrew Burgess
2021-06-05 12:27             ` Bernd Edlinger
2021-06-05 14:04               ` Tom Tromey [this message]
2021-06-14 11:41           ` Rainer Orth
2021-06-14 12:57             ` Bernd Edlinger
2021-06-14 12:59               ` Rainer Orth
2021-06-14 14:36                 ` Bernd Edlinger
2021-06-14 14:39                   ` Rainer Orth
2021-06-14 15:07                 ` Tom Tromey
2021-06-15 11:10                   ` Rainer Orth
2021-06-14 15:04               ` Tom Tromey
2021-06-14 23:35         ` Pedro Alves
2021-06-15  5:14           ` Bernd Edlinger
2021-06-15 11:16             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v96sz9u4.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).