From: Tom Tromey <tom@tromey.com>
To: Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Shahab Vahedi <shahab@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH v2] arc: Add 'set disassembler-options' support
Date: Fri, 04 Jun 2021 07:49:51 -0600 [thread overview]
Message-ID: <87v96toi2o.fsf@tromey.com> (raw)
In-Reply-To: <20210604073833.5411-1-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Fri, 4 Jun 2021 09:38:34 +0200")
>>>>> "Shahab" == Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> writes:
Shahab> From: Shahab Vahedi <shahab@synopsys.com>
Shahab> Implement ARC target support for passing options to the disassembler
Shahab> through the command interface. e.g.:
gdb> set disassembler-options cpu=hs38_linux ...
Shahab> v2:
Shahab> - break the long line in the test (arc_disassemble_test {}).
Shahab> gdb/ChangeLog:
Shahab> * NEWS: Document 'set disassembler-options' support for the ARC
Shahab> target.
Shahab> * arc-tdep.c (arc_gdbarch_init): Set
Shahab> 'gdbarch_valid_disassembler_options'.
Shahab> gdb/doc/ChangeLog:
Shahab> * gdb.texinfo (Source and Machine Code): Document 'set
Shahab> disassembler-options' support for the ARC target.
Shahab> gdb/testsuite/ChangeLog:
Shahab> * gdb.arch/arc-disassembler-options.exp: New test.
Shahab> * gdb.arch/arc-disassembler-options.s: New test source.
Looks good to me. Thank you.
Tom
next prev parent reply other threads:[~2021-06-04 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 17:42 [PATCH] " Shahab Vahedi
2021-06-03 18:55 ` Eli Zaretskii
2021-06-04 7:38 ` [PATCH v2] " Shahab Vahedi
2021-06-04 13:49 ` Tom Tromey [this message]
2021-06-05 9:50 ` [PUSHED] " Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v96toi2o.fsf@tromey.com \
--to=tom@tromey.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).