From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.218]) by sourceware.org (Postfix) with ESMTPS id 296B13844062 for ; Mon, 8 Feb 2021 21:35:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 296B13844062 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id AB4093B3E5 for ; Mon, 8 Feb 2021 15:35:19 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9EBjlZzvTsvw99EBjlfRGF; Mon, 08 Feb 2021 15:35:19 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DrWOapjWsZrrRwK7NXVV+SIfjdv9AI4TfaVOKoqwPuk=; b=KhxfyBxT6QfWf7MwKqmkzMVsTb NX2rCpKlQRf6jUfuSbtHSw07lgYoJ1hrwIivcIQDYBLu5/I7Bo+MCqRxree0EsXT70SC7PIw225GT t2z08jNRCXpkCe7LaUvXDCru1; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:38418 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9EBi-003F69-Vm; Mon, 08 Feb 2021 14:35:19 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 13/30] Make DWARF evaluator return a single struct value References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-14-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Mon, 08 Feb 2021 14:35:18 -0700 In-Reply-To: <20201207190031.13341-14-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:14 +0000") Message-ID: <87v9b2dyzt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9EBi-003F69-Vm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:38418 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 21:35:21 -0000 >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> From: Zoran Zaric Zoran> The patch is addressing the issue of class users writing and reading Zoran> the internal data of the dwarf_expr_context class. Zoran> At this point, all conditions are met for the DWARF evaluator to return Zoran> an evaluation result in a form of a single struct value object. Zoran> gdb/ChangeLog: Zoran> * dwarf2/expr.c (pieced_value_funcs): Chenge to static Zoran> function. Zoran> (allocate_piece_closure): Change to static function. Zoran> (dwarf_expr_context::fetch_result): New function. Zoran> * dwarf2/expr.h (struct piece_closure): Remove declaration. Zoran> (struct dwarf_expr_context): fetch_result new declaration. Zoran> fetch, fetch_address and fetch_in_stack_memory members move Zoran> to private. Zoran> (allocate_piece_closure): Remove. Zoran> * dwarf2/frame.c (execute_stack_op): Change to use Zoran> fetch_result. Zoran> * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Change to use Zoran> fetch_result. Zoran> (dwarf2_locexpr_baton_eval): Change to use fetch_result. Thanks, this looks good. I guess this is where invalid_synthetic_pointer is used. I don't mind if you just leave the previous patch as-is. Tom