From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Extract symbol-writing function from parsers
Date: Thu, 28 Jan 2021 19:42:26 -0700 [thread overview]
Message-ID: <87v9bg5ur1.fsf@tromey.com> (raw)
In-Reply-To: <b55e6fa6-8906-7df8-3e56-fbda9f95dec1@simark.ca> (Simon Marchi's message of "Mon, 14 Dec 2020 12:47:54 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> The behavior seems to change a little bit here. Imagine we go in
Simon> write_exp_msymbol (in the original code), we will then go into that
Simon> block that starts with "Check if the qualified name". In the new code,
Simon> we won't. I don't know if that's important.
I think the old code was wrong. It would emit a minsym reference,
followed by an OP_SCOPE. However, that doesn't mean anything and would
probably result in an invalid, or at least confusing, expression.
Tom
next prev parent reply other threads:[~2021-01-29 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 21:44 Tom Tromey
2020-12-14 17:47 ` Simon Marchi
2021-01-27 23:39 ` Tom Tromey
2021-01-29 2:42 ` Tom Tromey [this message]
2021-01-29 3:20 ` Tom Tromey
2021-02-05 14:10 ` Tom Tromey
2021-02-09 2:30 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9bg5ur1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).