From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6FCD33851C09 for ; Sun, 28 Jun 2020 14:20:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FCD33851C09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ludo@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:43207) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpYAz-0004Mz-Vu for gdb-patches@sourceware.org; Sun, 28 Jun 2020 10:20:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40384 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpYAz-00048w-4f; Sun, 28 Jun 2020 10:20:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 1/2] guile: Add support for Guile 2.2. References: <87k103ik0v.fsf@gnu.org> <20200626081333.23412-1-ludo@gnu.org> <20200626081333.23412-2-ludo@gnu.org> <83a70qruqp.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 Messidor an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 28 Jun 2020 16:20:54 +0200 In-Reply-To: <83a70qruqp.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jun 2020 13:23:26 +0300") Message-ID: <87v9jbi855.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2020 14:20:59 -0000 Hello Eli, Eli Zaretskii skribis: >> @deffn {Scheme Procedure} set-memory-port-read-buffer-size! memory-port= size >> Set the size of the read buffer of @code{} >> @var{memory-port} to @var{size}. The result is unspecified. >> + >> +This procedure is deprecated and will be removed in @value{GDBN} 11. >> +When using Guile 2.2 or later, you can call @code{setvbuf} instead >> +(@pxref{Buffering, @code{setvbuf},, guile, GNU Guile Reference Manual}). > > First, instead of "When using" I'd suggest to say "When @value{GDBN} > was built with". Agreed. > And second, there's a certain conundrum here: the node "Buffering" > doesn't exist in the Guile v2.0.x manual, so I wonder whether we > should say something here about that to prevent user surprise when the > hyperlink causes an error. We explicitly write =E2=80=9CWhen GDB is built with Guile 2.2=E2=80=9D, so = I think we can=E2=80=99t really do better; removing the link would annoy users of curr= ent Guile versions. WDYT? >> @deffn {Scheme Procedure} set-memory-port-write-buffer-size! memory-por= t size >> Set the size of the write buffer of @code{} >> @var{memory-port} to @var{size}. The result is unspecified. >> + >> +This procedure is deprecated and will be removed in @value{GDBN} 11. >> +When using Guile 2.2 or later, you can call @code{setvbuf} instead >> +(@pxref{Buffering, @code{setvbuf},, guile, GNU Guile Reference Manual}). >> @end deffn > > Here, I'd remove the @pxref: we already have the same hyperlink a > short ways above, so repetition is not necessary. Agreed. > The documentation parts are okay with those nits fixed. > >> +/* Whether we're using Guile < 2.2 and its clumsy port API. */ >> + >> +#define USING_GUILE_BEFORE_2_2 \ >> + (SCM_MAJOR_VERSION < 2 \ >> + || (SCM_MAJOR_VERSION =3D=3D 2 && SCM_MINOR_VERSION =3D=3D 0)) > > Since Guile < 2.0 is not supported, do we need the first part of the > macro? It=E2=80=99s not. I=E2=80=99m sending v4; changes since v3: =E2=80=A2 Adjust wording for deprecated procedures as you suggested above. =E2=80=A2 Simplify USING_GUILE_BEFORE_2_2 C macro. Any other suggestions? It would be perfect if this could land in time for GDB 10. Thank you, Ludo=E2=80=99.