From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.133]) by sourceware.org (Postfix) with ESMTPS id BF2FE389366C for ; Fri, 24 Apr 2020 13:50:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF2FE389366C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id D407C400CBFEC for ; Fri, 24 Apr 2020 08:50:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id RyidjRHbsVQh0RyidjZl0V; Fri, 24 Apr 2020 08:50:15 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7iJV78laLOsSeu8Vb3n2ikFH8ngqvTnKC0i5gbObrkA=; b=KTnVumVr6lXYiOe9v182V7Jyq4 /cdI59UkQBpV7hDSnOvZpvAbq0fcEYR5zhtbGwp/haq8YTNBZtr44bysjxp1m1KbvrgkhoTuSH9If tTGZFd8AruHxbXkjnj0b3JYUu; Received: from 184-96-229-138.hlrn.qwest.net ([184.96.229.138]:50700 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jRyid-001zwT-GW; Fri, 24 Apr 2020 07:50:15 -0600 From: Tom Tromey To: Shahab Vahedi via Gdb-patches Cc: Shahab Vahedi , Shahab Vahedi , Anton Kolesov , Francois Bedard Subject: Re: [PATCH 2/4] arc: Recognize registers available on Linux targets References: <20200326125206.13120-1-shahab.vahedi@gmail.com> <20200326125206.13120-3-shahab.vahedi@gmail.com> X-Attribution: Tom Date: Fri, 24 Apr 2020 07:50:14 -0600 In-Reply-To: <20200326125206.13120-3-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Thu, 26 Mar 2020 13:52:04 +0100") Message-ID: <87v9lpdmcp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.229.138 X-Source-L: No X-Exim-ID: 1jRyid-001zwT-GW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-229-138.hlrn.qwest.net (murgatroyd) [184.96.229.138]:50700 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 13:50:18 -0000 >>>>> ">" == Shahab Vahedi via Gdb-patches writes: >> + const char *const r58_names[] = { >> + core_regs[58], This should probably say ARC_R58_REGNUM? >> + core_regs[59], ARC_R59_REGNUM ? >> /* Allocate the ARC-private target-dependent information structure, and the >> GDB target-independent information structure. */ >> struct gdbarch_tdep *tdep = XCNEW (struct gdbarch_tdep); >> tdep-> jb_pc = -1; /* No longjmp support by default. */ >> + >> + if (!arc_tdesc_init (info, &tdesc, &tdesc_data, tdep)) >> + { >> + XDELETE (tdep); >> + return NULL; >> + } gdb doesn't use XDELETE, but rather "xfree". You might as well "return nullptr;" while you're at it. thanks, Tom