From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.91]) by sourceware.org (Postfix) with ESMTPS id D6A14389906D for ; Fri, 3 Apr 2020 18:07:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D6A14389906D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 822F974F01 for ; Fri, 3 Apr 2020 13:07:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KQjIjzNhR8vkBKQjIjnkv4; Fri, 03 Apr 2020 13:07:44 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n9TSgfdGqsMhHBR30D1aPBIAt6TXOb5+mdVgw6bbVlI=; b=jt6fEYnkr+/lnWRcL8lRSOdYhI oQWH0KF/o2bLCkdHQFBp2u3/Jdob1S+4hSl62MdjNccA8biKnGpQQs8igCshqADVIqmzNks0moRfd +DFLovAaZJvyJq7djRwiOqKyn; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:45096 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jKQjI-0014Ka-5V; Fri, 03 Apr 2020 12:07:44 -0600 From: Tom Tromey To: nitachra Cc: gdb-patches@sourceware.org, tom@tromey.com, JiniSusan.George@amd.com Subject: Re: [PATCH v2 1/3] Support for DW_AT_loclists_base and DW_FORM_loclistx. References: <20200403161517.27557-1-Nitika.Achra@amd.com> X-Attribution: Tom Date: Fri, 03 Apr 2020 12:07:43 -0600 In-Reply-To: <20200403161517.27557-1-Nitika.Achra@amd.com> (nitachra's message of "Fri, 3 Apr 2020 21:45:17 +0530") Message-ID: <87v9mgphn4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jKQjI-0014Ka-5V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (murgatroyd) [174.16.110.145]:45096 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 18:07:46 -0000 >>>>> ">" == nitachra writes: >> gdb/dwarf2/ChangeLog: >> *read.c (cu_debug_loc_section): Added the declaration for the function. >> (read_loclist_index): New function declaration. >> (lookup_loclist_base): New function declaration. >> (read_loclist_header): New function declaration >> (dwarf2_cu): Added loclist_base and loclist_header field. >> (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section. >> (read_full_die_1): Read the value of DW_AT_loclists_base. >> (read_attribute_reprocess): Handle DW_FORM_loclistx. >> (read_attribute_value): Handle DW_FORM_loclistx. >> (skip_one_die): Handle DW_FORM_loclistx. >> (loclist_header): New structure declaration. >> *attribute.c (form_is_section_offset): Handle DW_FORM_loclistx. Thank you. This still has one formatting nit, I think: >> + if (cu->dwo_unit != nullptr) >> + { >> + if (cu->header.initial_length_size == 4) >> + return LOCLIST_HEADER_SIZE32; >> + return LOCLIST_HEADER_SIZE64; >> + } The braces and their contents should be shifted right by 2 spaces. This is ok with that change. Tom