From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28506 invoked by alias); 23 Jan 2020 19:45:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28498 invoked by uid 89); 23 Jan 2020 19:45:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=interest X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.39) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jan 2020 19:45:51 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 3764327B37 for ; Thu, 23 Jan 2020 13:45:50 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uiQIizuMu8a1puiQIiG4Ys; Thu, 23 Jan 2020 13:45:50 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V8HTh/gx6sRpuggPWKAj36LOYLa8p5ExTkMCSqlTaAg=; b=jZ102fUEvY6r/cvPQtYE1KzgJZ vt9c/vz6s/wXVHWq0FuGEOripNSdUHTGgOu2738if1ADzjIXKkzgiM0rnHxwm+cVIHjO+W8kgOl3x e6yXsuAnJEaYlxT2Z1VfcM9ih; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:44172 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iuiQI-0009cV-09; Thu, 23 Jan 2020 12:45:50 -0700 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Make "disassemble" always use TUI disassembly window References: <20191227235034.5453-1-tom@tromey.com> <20191227235034.5453-3-tom@tromey.com> <877e1n43ct.fsf@tromey.com> <20200119232327.GF3865@embecosm.com> Date: Thu, 23 Jan 2020 19:54:00 -0000 In-Reply-To: <20200119232327.GF3865@embecosm.com> (Andrew Burgess's message of "Sun, 19 Jan 2020 23:23:27 +0000") Message-ID: <87v9p2vtw2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00753.txt.bz2 Tom> I wonder if this should be limited to the case where the options to Tom> disassemble are compatible with what the TUI does. Andrew> I've wondered for a while if we should have something like: Andrew> set tui disassemble-flags ... Andrew> where a user can set the flags used by the disassembler. My main Andrew> interest initially was /r, but it might be nice if /m and /s could be Andrew> supported too, though I'm not quite sure how that might look or work. I've considered this too (and also adding support for the new binutils mode that graphically shows jump targets). However, I wasn't sure how these flags would interact with the current TUI model of disassembly, where it shows a window on the entire memory space, and not just a single function. Tom