From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2847 invoked by alias); 13 Dec 2019 21:19:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2836 invoked by uid 89); 13 Dec 2019 21:19:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:466 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 21:19:14 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 497A5447E9 for ; Fri, 13 Dec 2019 15:19:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fsLBiA6gk3Qi0fsLBi2cOk; Fri, 13 Dec 2019 15:19:13 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YYCePt4Jx++TTfTIsI4tJzRkbOvMalmZujRb4o9OJkc=; b=dl/GUtQutfR+oLEf2P3JXiatu9 8oePiq6+1BDoO3uoW7gPHQLri/jySLB7XY1R/VutvhEE8KWjvny37DdWRwa1B3J93cY7w53lT7kYS hsbmfT42FmcK8ONafFteAOigm; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:55098 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ifsLB-002f36-2R; Fri, 13 Dec 2019 14:19:13 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Fix and cleanups in jit.c References: <20191213060323.1799590-1-simon.marchi@polymtl.ca> Date: Fri, 13 Dec 2019 21:19:00 -0000 In-Reply-To: <20191213060323.1799590-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Fri, 13 Dec 2019 01:03:16 -0500") Message-ID: <87v9qjvs8f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00615.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Patch 1 fixes a bug I found while playing with the jit debug info reader Simon> interface. Simon> The other patches apply some C++ magic to make the code (IMO) easier to Simon> work with. I read through these. I just had one comment but I also agree with the comments from the other reviews -- I just didn't have anything to add there. thanks, Tom