From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49479 invoked by alias); 1 Dec 2019 18:55:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49470 invoked by uid 89); 1 Dec 2019 18:55:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=unavailable version=3.3.1 spammy=Configuration, intensity, colors, HX-Languages-Length:1320 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.141) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Dec 2019 18:55:20 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 0A5307531 for ; Sun, 1 Dec 2019 12:55:19 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id bUNKigfUj4kpjbUNLiHx40; Sun, 01 Dec 2019 12:55:19 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q0O3cowvEYG5CxJfBfTEblex2F6C7arpGR4eNtstr3k=; b=RQrhUbjA6+6CyOVsFy3NshaaDu iMiX1Pke22XKFp38SKEUXaxfpxZlnZ4lppVdxUT2q3Dyx3czlVe6hJsql37K13xGcxCSWiMjcV3A0 FXvWPOsZs8SxS4SjCgORTnIVQ; Received: from 97-118-104-188.hlrn.qwest.net ([97.118.104.188]:47152 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ibUNK-0029Yw-PT; Sun, 01 Dec 2019 11:55:18 -0700 From: Tom Tromey To: Eli Zaretskii Cc: tromey@sourceware.org, gdb-patches@sourceware.org Subject: Re: [review v2] Add TUI border colors References: <20191122235414.9AB352816F@gnutoolchain-gerrit.osci.io> <83eexzukbj.fsf@gnu.org> Date: Sun, 01 Dec 2019 18:55:00 -0000 In-Reply-To: <83eexzukbj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Nov 2019 09:24:16 +0200") Message-ID: <87v9qzq3jd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00011.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: >> Date: Fri, 22 Nov 2019 18:54:13 -0500 >> From: "Tom Tromey (Code Review)" >> >> +@item tui-border >> +Control the styling of the TUI border. Note that, unlike other >> +styling options, only the color of the border can be controlled via >> +@code{set style}. This was done for compatibility reasons, as TUI >> +controls to set the border's intensity predated the addition of >> +general styling to @value{GDBN}. @xref{TUI Configuration}. >> + >> +@item tui-active-border >> +Control the styling of the active TUI border; that is, the TUI window >> +that has the focus. Note that, unlike other styling options, only the >> +color of the border can be controlled via @code{set style}. This was >> +done for compatibility reasons, as TUI controls to set the active >> +border's intensity predated the addition of general styling to >> +@value{GDBN}. @xref{TUI Configuration}. Eli> I wonder if we could say the "Note" part only once, for both Eli> tui-border and tui-active-border. It sounds redundant to repeat the Eli> same text so close to one another. Eli> Otherwise, the documentation parts are OK. Thanks. Thanks. I removed one of the notes. I'm going to check this in shortly. Tom