[PATCH 2/2] Fix PR gdb/23558: Use system's 'getcwd' when cross-compiling GDB

[PATCH 2/2] Fix PR gdb/23558: Use system's 'getcwd' when cross-compiling GDB

[Sergio Durigan Junior]

This is a backport of a gnulib fix for the following bug:

  https://sourceware.org/bugzilla/show_bug.cgi?id=23558

The problem reported there is about the replacement of 'getcwd' when
cross-compiling GDB.  With our current gnulib copy, the mechanism for
deciding whether to use the system's 'getcwd' or gnulib's version is
too simplistic and pessimistic, so when cross-compiling we always end
up using gnulib's version, which has a limitation: it cannot handle
the situation when the parent directory doesn't have read permissions.

The solution is to backport the following gnulib commit:

  commit a96d2e67052c879b1bcc5bc461722beac75fc372
  Author: Bruno Haible <bruno@clisp.org>
  Date:   Thu Aug 23 21:13:19 2018 +0200

      getcwd: Add cross-compilation guesses.

gdb/ChangeLog:
2018-09-03  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR gdb/23555
	PR gdb/23558
	* gnulib/import/m4/getcwd-path-max.m4: Add cross-compilation
	guesses.
---
 gdb/ChangeLog                           |  7 +++++++
 gdb/gnulib/import/m4/getcwd-path-max.m4 | 20 ++++++++++++++++----
 2 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fdeaf8a302..aaa4590ae6 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-09-10  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	PR gdb/23555
+	PR gdb/23558
+	* gnulib/import/m4/getcwd-path-max.m4: Add cross-compilation
+	guesses.
+
 2018-09-10  Sergio Durigan Junior  <sergiodj@redhat.com>
 
 	Revert:
diff --git a/gdb/gnulib/import/m4/getcwd-path-max.m4 b/gdb/gnulib/import/m4/getcwd-path-max.m4
index 2531ccff65..90bbc77dea 100644
--- a/gdb/gnulib/import/m4/getcwd-path-max.m4
+++ b/gdb/gnulib/import/m4/getcwd-path-max.m4
@@ -209,9 +209,21 @@ main ()
      32) gl_cv_func_getcwd_path_max='yes, but with shorter paths';;
      *) gl_cv_func_getcwd_path_max=no;;
      esac],
-    [case "$host_os" in
-       aix*) gl_cv_func_getcwd_path_max='no, it has the AIX bug';;
-       *) gl_cv_func_getcwd_path_max=no;;
-     esac])
+    [# Cross-compilation guesses:
+     case "$host_os" in
+       aix*) # On AIX, it has the AIX bug.
+         gl_cv_func_getcwd_path_max='no, it has the AIX bug' ;;
+       gnu*) # On Hurd, it is 'yes'.
+         gl_cv_func_getcwd_path_max=yes ;;
+       linux* | kfreebsd*)
+         # On older Linux+glibc it's 'no, but it is partly working',
+         # on newer Linux+glibc it's 'yes'.
+         # On Linux+musl libc, it's 'no, but it is partly working'.
+         # On kFreeBSD+glibc, it's 'no, but it is partly working'.
+         gl_cv_func_getcwd_path_max='no, but it is partly working' ;;
+       *) # If we don't know, assume the worst.
+         gl_cv_func_getcwd_path_max=no ;;
+     esac
+    ])
   ])
 ])
-- 
2.17.1

[PATCH 0/2] Revert gnulib update and backport gnulib fix for PR gdb/23558

[Sergio Durigan Junior]

This patch series finally fixes the problem introduced by the gnulib
update.  It's a simple series: the first patch totally reverts the
update, and the second patch just cherry-picks the fix for PR
gdb/23558 from gnulib master.

[PATCH 1/2] Revert "Update gnulib to current upstream master"

[Sergio Durigan Junior]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

On Monday, September 10 2018, I wrote:

> This patch series finally fixes the problem introduced by the gnulib
> update.  It's a simple series: the first patch totally reverts the
> update, and the second patch just cherry-picks the fix for PR
> gdb/23558 from gnulib master.

I forgot that sourceware has a size limit for e-mails, so the first one
bounced.  Here it is, compressed.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


[-- Attachment #2: 0001-Revert-Update-gnulib-to-current-upstream-master.patch.gz --]
[-- Type: application/gzip, Size: 255146 bytes --]

Re: [PATCH 0/2] Revert gnulib update and backport gnulib fix for PR gdb/23558

[Kevin Buettner]

On Mon, 10 Sep 2018 13:12:03 -0400
Sergio Durigan Junior <sergiodj@redhat.com> wrote:

> This patch series finally fixes the problem introduced by the gnulib
> update.  It's a simple series: the first patch totally reverts the
> update, and the second patch just cherry-picks the fix for PR
> gdb/23558 from gnulib master.

This is okay.

Kevin

Re: [PATCH 0/2] Revert gnulib update and backport gnulib fix for PR gdb/23558

[Sergio Durigan Junior]

On Monday, September 10 2018, Kevin Buettner wrote:

> On Mon, 10 Sep 2018 13:12:03 -0400
> Sergio Durigan Junior <sergiodj@redhat.com> wrote:
>
>> This patch series finally fixes the problem introduced by the gnulib
>> update.  It's a simple series: the first patch totally reverts the
>> update, and the second patch just cherry-picks the fix for PR
>> gdb/23558 from gnulib master.
>
> This is okay.

Thanks, pushed:

e2fc52e745757a11f7a4a256984cabbe5474f55a
5e8754f90abbbf832987477eea4ee91a9d2f694c

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: [PATCH 0/2] Revert gnulib update and backport gnulib fix for PR gdb/23558

[Tom Tromey]

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> On Monday, September 10 2018, Kevin Buettner wrote:
>> On Mon, 10 Sep 2018 13:12:03 -0400
>> Sergio Durigan Junior <sergiodj@redhat.com> wrote:
>> 
>>> This patch series finally fixes the problem introduced by the gnulib
>>> update.  It's a simple series: the first patch totally reverts the
>>> update, and the second patch just cherry-picks the fix for PR
>>> gdb/23558 from gnulib master.
>> 
>> This is okay.

Sergio> Thanks, pushed:

Sergio> e2fc52e745757a11f7a4a256984cabbe5474f55a
Sergio> 5e8754f90abbbf832987477eea4ee91a9d2f694c

Thanks for doing this.

If you're not planning to work on fixing the gnulib
compiler-flag-choosing thing soon, could you file a gdb bug with some
links to the various threads, so that we have an easy way to refer
back to them?

Tom

Re: [PATCH 0/2] Revert gnulib update and backport gnulib fix for PR gdb/23558

[Sergio Durigan Junior]

On Monday, September 10 2018, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> On Monday, September 10 2018, Kevin Buettner wrote:
>>> On Mon, 10 Sep 2018 13:12:03 -0400
>>> Sergio Durigan Junior <sergiodj@redhat.com> wrote:
>>> 
>>>> This patch series finally fixes the problem introduced by the gnulib
>>>> update.  It's a simple series: the first patch totally reverts the
>>>> update, and the second patch just cherry-picks the fix for PR
>>>> gdb/23558 from gnulib master.
>>> 
>>> This is okay.
>
> Sergio> Thanks, pushed:
>
> Sergio> e2fc52e745757a11f7a4a256984cabbe5474f55a
> Sergio> 5e8754f90abbbf832987477eea4ee91a9d2f694c
>
> Thanks for doing this.
>
> If you're not planning to work on fixing the gnulib
> compiler-flag-choosing thing soon, could you file a gdb bug with some
> links to the various threads, so that we have an easy way to refer
> back to them?

Yeah, absolutely, I was going to do that, sorry for not mentioning.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: [PATCH 0/2] Revert gnulib update and backport gnulib fix for PR gdb/23558

[Sergio Durigan Junior]

On Monday, September 10 2018, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> On Monday, September 10 2018, Kevin Buettner wrote:
>>> On Mon, 10 Sep 2018 13:12:03 -0400
>>> Sergio Durigan Junior <sergiodj@redhat.com> wrote:
>>> 
>>>> This patch series finally fixes the problem introduced by the gnulib
>>>> update.  It's a simple series: the first patch totally reverts the
>>>> update, and the second patch just cherry-picks the fix for PR
>>>> gdb/23558 from gnulib master.
>>> 
>>> This is okay.
>
> Sergio> Thanks, pushed:
>
> Sergio> e2fc52e745757a11f7a4a256984cabbe5474f55a
> Sergio> 5e8754f90abbbf832987477eea4ee91a9d2f694c
>
> Thanks for doing this.
>
> If you're not planning to work on fixing the gnulib
> compiler-flag-choosing thing soon, could you file a gdb bug with some
> links to the various threads, so that we have an easy way to refer
> back to them?

Sorry for the delay, here's the bug:

  https://sourceware.org/bugzilla/show_bug.cgi?id=23643

Feel free to add more info/comments if needed.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/