* [PATCH 0/9] C++ Support for Compile
@ 2018-08-10 23:25 Keith Seitz
2018-08-10 23:25 ` [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures Keith Seitz
` (8 more replies)
0 siblings, 9 replies; 45+ messages in thread
From: Keith Seitz @ 2018-08-10 23:25 UTC (permalink / raw)
To: gdb-patches
This series of patches implements basic C++ compile support.
The series includes a handful of linespec.c cleanups and a small linespec
API change and addition. I've discussed those changes in the patches.
C++ compile support started largely as a cut-n-paste of the original C
compile work done by Jan Kratochvil, Phil Muldoon, and Tom Tromey, so I'd
like to "send a shout out" to those guys for their pioneering (for GDB)
effort. Thank you, Jan, Phil, and Tom!
I want to stress that this support is quite experimental and likely has some
problems -- maybe even a lot of problems. Nonetheless, the code is usable.
Support is quite incomplete, but I've already made inroads into many missing
features. These will be submitted in the near future.
Despite the (many) shortcomings, I am submitting this upstream in an attempt
to widen exposure and open further development of this feature to other
interested parties.
Keith Seitz (9):
Change `file_symtabs' to std::vector
Change `function_symbols' to std::vector
Change `label_symbols' to std::vector in linespec.c structures
Change `minimal_symbols' to std::vector in linespec.c structures
Change decode_compound_collector to use std::vector
Remove VEC definitions from linespec.c
Use block_symbol_d in linespec APIs
Add new search_symbols_multiple API
C++ compile support
gdb/ChangeLog | 115 ++
gdb/Makefile.in | 5 +
gdb/NEWS | 14 +
gdb/ada-lang.c | 2 +-
gdb/c-lang.c | 4 +-
gdb/c-lang.h | 19 +
gdb/compile/compile-c-support.c | 205 ++-
gdb/compile/compile-cplus-support.c | 30 +
gdb/compile/compile-cplus-symbols.c | 511 +++++++
gdb/compile/compile-cplus-types.c | 1430 ++++++++++++++++++++
gdb/compile/compile-cplus.h | 207 +++
gdb/compile/compile-internal.h | 8 +
gdb/compile/compile-object-load.c | 7 +-
gdb/compile/compile.c | 1 -
gdb/compile/gcc-cp-plugin.h | 85 ++
gdb/doc/ChangeLog | 5 +
gdb/doc/gdb.texinfo | 20 +
gdb/linespec.c | 553 ++++----
gdb/symtab.c | 4 +-
gdb/symtab.h | 45 +-
gdb/testsuite/ChangeLog | 25 +
.../gdb.compile/compile-cplus-anonymous.cc | 76 ++
.../gdb.compile/compile-cplus-anonymous.exp | 64 +
.../gdb.compile/compile-cplus-array-decay.cc | 31 +
.../gdb.compile/compile-cplus-array-decay.exp | 50 +
gdb/testsuite/gdb.compile/compile-cplus-inherit.cc | 58 +
.../gdb.compile/compile-cplus-inherit.exp | 53 +
gdb/testsuite/gdb.compile/compile-cplus-member.cc | 83 ++
gdb/testsuite/gdb.compile/compile-cplus-member.exp | 77 ++
gdb/testsuite/gdb.compile/compile-cplus-method.cc | 91 ++
gdb/testsuite/gdb.compile/compile-cplus-method.exp | 67 +
gdb/testsuite/gdb.compile/compile-cplus-mod.c | 28 +
.../gdb.compile/compile-cplus-namespace.cc | 52 +
.../gdb.compile/compile-cplus-namespace.exp | 51 +
gdb/testsuite/gdb.compile/compile-cplus-nested.cc | 58 +
gdb/testsuite/gdb.compile/compile-cplus-nested.exp | 53 +
gdb/testsuite/gdb.compile/compile-cplus-print.c | 32 +
gdb/testsuite/gdb.compile/compile-cplus-print.exp | 81 ++
gdb/testsuite/gdb.compile/compile-cplus-virtual.cc | 54 +
.../gdb.compile/compile-cplus-virtual.exp | 71 +
gdb/testsuite/gdb.compile/compile-cplus.c | 241 ++++
gdb/testsuite/gdb.compile/compile-cplus.exp | 341 +++++
gdb/testsuite/lib/compile-support.exp | 227 ++++
43 files changed, 4920 insertions(+), 314 deletions(-)
create mode 100644 gdb/compile/compile-cplus-support.c
create mode 100644 gdb/compile/compile-cplus-symbols.c
create mode 100644 gdb/compile/compile-cplus-types.c
create mode 100644 gdb/compile/compile-cplus.h
create mode 100644 gdb/compile/gcc-cp-plugin.h
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-inherit.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-inherit.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-member.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-member.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-method.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-method.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-mod.c
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-namespace.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-namespace.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-nested.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-nested.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-print.c
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-print.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-virtual.cc
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-virtual.exp
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus.c
create mode 100644 gdb/testsuite/gdb.compile/compile-cplus.exp
create mode 100644 gdb/testsuite/lib/compile-support.exp
--
2.13.6
^ permalink raw reply [flat|nested] 45+ messages in thread* [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz @ 2018-08-10 23:25 ` Keith Seitz 2018-08-11 14:50 ` Tom Tromey 2018-08-10 23:25 ` [PATCH 1/9] Change `file_symtabs' to std::vector Keith Seitz ` (7 subsequent siblings) 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:25 UTC (permalink / raw) To: gdb-patches This patch converts linespec.c's linespec.label_symbols member from a VEC to a std::vector. gdb/ChangeLog: * linespec.c (struct linespec) <label_symbols>: Change type to std::vector. Update all users. (find_label_symbols_in_block): Change `result' parameter to std::vector. Update all callers. (find_label_symbols): Return std::vector. Update all callers. --- gdb/ChangeLog | 8 ++++++++ gdb/linespec.c | 54 +++++++++++++++++++++++++++--------------------------- 2 files changed, 35 insertions(+), 27 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5a71381262..b3f5a5d039 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <label_symbols>: Change type to + std::vector. Update all users. + (find_label_symbols_in_block): Change `result' parameter to + std::vector. Update all callers. + (find_label_symbols): Return std::vector. Update all callers. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <function_symbols>: Change type to std::vector. Update all users. (struct collect_info) <function_symbols>: Likewise. diff --git a/gdb/linespec.c b/gdb/linespec.c index 8070db68ec..4e7f9b08b0 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -123,7 +123,7 @@ struct linespec or both must be non-NULL. */ struct { - VEC (symbolp) *label_symbols; + std::vector<symbol *> *label_symbols; std::vector<symbol *> *function_symbols; } labels; }; @@ -352,7 +352,7 @@ static std::vector<symtab_and_line> decode_objc (struct linespec_state *self, static std::vector<symtab *> *symtabs_from_filename (const char *, struct program_space *pspace); -static VEC (symbolp) *find_label_symbols +static std::vector<symbol *> *find_label_symbols (struct linespec_state *self, std::vector<symbol *> *function_symbols, std::vector<symbol *> *label_funcs_ret, const char *name, bool completion_mode = false); @@ -1767,7 +1767,7 @@ linespec_parse_basic (linespec_parser *parser) gdb::unique_xmalloc_ptr<char> name; linespec_token token; std::vector<symbol *> symbols; - VEC (symbolp) *labels; + std::vector<symbol *> *labels; VEC (bound_minimal_symbol_d) *minimal_symbols; /* Get the next token. */ @@ -2241,12 +2241,9 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) if (ls->labels.label_symbols != NULL) { /* We have just a bunch of functions/methods or labels. */ - int i; - struct symtab_and_line sal; - struct symbol *sym; - - for (i = 0; VEC_iterate (symbolp, ls->labels.label_symbols, i, sym); ++i) + for (const auto &sym : *ls->labels.label_symbols) { + struct symtab_and_line sal; struct program_space *pspace = SYMTAB_PSPACE (symbol_symtab (sym)); if (symbol_to_sal (&sal, state->funfirstline, sym) @@ -2388,7 +2385,7 @@ convert_explicit_location_to_linespec (struct linespec_state *self, struct line_offset line_offset) { std::vector<symbol *> symbols; - VEC (symbolp) *labels; + std::vector<symbol *> *labels; VEC (bound_minimal_symbol_d) *minimal_symbols; result->explicit_loc.func_name_match_type = fname_match_type; @@ -2780,9 +2777,7 @@ linespec_parser_delete (void *arg) if (PARSER_RESULT (parser)->minimal_symbols != NULL) VEC_free (bound_minimal_symbol_d, PARSER_RESULT (parser)->minimal_symbols); - if (PARSER_RESULT (parser)->labels.label_symbols != NULL) - VEC_free (symbolp, PARSER_RESULT (parser)->labels.label_symbols); - + delete PARSER_RESULT (parser)->labels.label_symbols; delete PARSER_RESULT (parser)->labels.function_symbols; linespec_state_destructor (PARSER_STATE (parser)); @@ -2917,20 +2912,21 @@ complete_label (completion_tracker &tracker, const char *label_name) { std::vector<symbol *> label_function_symbols; - VEC (symbolp) *labels + std::vector<symbol *> *labels = find_label_symbols (PARSER_STATE (parser), PARSER_RESULT (parser)->function_symbols, &label_function_symbols, label_name, true); - symbol *label; - for (int ix = 0; - VEC_iterate (symbolp, labels, ix, label); ++ix) + if (labels != nullptr) { - char *match = xstrdup (SYMBOL_SEARCH_NAME (label)); - tracker.add_completion (gdb::unique_xmalloc_ptr<char> (match)); + for (const auto &label : *labels) + { + char *match = xstrdup (SYMBOL_SEARCH_NAME (label)); + tracker.add_completion (gdb::unique_xmalloc_ptr<char> (match)); + } + delete labels; } - VEC_free (symbolp, labels); } /* See linespec.h. */ @@ -4045,7 +4041,7 @@ static void find_label_symbols_in_block (const struct block *block, const char *name, struct symbol *fn_sym, bool completion_mode, - VEC (symbolp) **result, + std::vector<symbol *> *result, std::vector<symbol *> *label_funcs_ret) { if (completion_mode) @@ -4063,7 +4059,7 @@ find_label_symbols_in_block (const struct block *block, SYMBOL_DOMAIN (sym), LABEL_DOMAIN) && cmp (SYMBOL_SEARCH_NAME (sym), name, name_len) == 0) { - VEC_safe_push (symbolp, *result, sym); + result->push_back (sym); label_funcs_ret->push_back (fn_sym); } } @@ -4074,19 +4070,21 @@ find_label_symbols_in_block (const struct block *block, if (sym != NULL) { - VEC_safe_push (symbolp, *result, sym); + result->push_back (sym); label_funcs_ret->push_back (fn_sym); } } } -/* Return all labels that match name NAME in FUNCTION_SYMBOLS. Return - the actual function symbol in which the label was found in +/* Return all labels that match name NAME in FUNCTION_SYMBOLS or NULL + if no matches were found. + + Return the actual function symbol in which the label was found in LABEL_FUNC_RET. If COMPLETION_MODE is true, then NAME is interpreted as a label name prefix. Otherwise, only labels named exactly NAME match. */ -static VEC (symbolp) * +static std::vector<symbol *> * find_label_symbols (struct linespec_state *self, std::vector<symbol *> *function_symbols, std::vector<symbol *> *label_funcs_ret, const char *name, @@ -4094,7 +4092,7 @@ find_label_symbols (struct linespec_state *self, { const struct block *block; struct symbol *fn_sym; - VEC (symbolp) *result = NULL; + std::vector<symbol *> result; if (function_symbols == NULL) { @@ -4124,7 +4122,9 @@ find_label_symbols (struct linespec_state *self, } } - return result; + if (!result.empty ()) + return new std::vector<symbol *> (std::move (result)); + return nullptr; } \f -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures 2018-08-10 23:25 ` [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures Keith Seitz @ 2018-08-11 14:50 ` Tom Tromey 0 siblings, 0 replies; 45+ messages in thread From: Tom Tromey @ 2018-08-11 14:50 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch converts linespec.c's linespec.label_symbols member from a Keith> VEC to a std::vector. Keith> gdb/ChangeLog: Keith> * linespec.c (struct linespec) <label_symbols>: Change type to Keith> std::vector. Update all users. Keith> (find_label_symbols_in_block): Change `result' parameter to Keith> std::vector. Update all callers. Keith> (find_label_symbols): Return std::vector. Update all callers. Thanks. This is ok. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 1/9] Change `file_symtabs' to std::vector 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz 2018-08-10 23:25 ` [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures Keith Seitz @ 2018-08-10 23:25 ` Keith Seitz 2018-08-11 14:47 ` Tom Tromey 2018-08-10 23:25 ` [PATCH 2/9] Change `function_symbols' " Keith Seitz ` (6 subsequent siblings) 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:25 UTC (permalink / raw) To: gdb-patches This patch changes the `file_symtabs' members in linespec.c structures from a VEC to a std::vector, eliminating a cleanup in the process. gdb/ChangeLog: * linespec.c (symtab_vector_up): Define. (struct linespec) <file_symtabs>: Change type to std::vector. Update all uses. (struct collect_info) <file_symtabs>: Likewise. (decode_objc): Remove cleanup. (symtab_collector::symtab_collector): Initialize `m_symtabs'. (symtab_collector::release_symtabs): Return std::vector. Update all callers. (class symtab_collector) <m_symtabs>: Change type to std::vector. Update all users. (collect_symtabs_from_filename, symtabs_from_filename): Return std::vector. Update all callers. --- gdb/ChangeLog | 15 ++++++++ gdb/linespec.c | 113 +++++++++++++++++++++++++-------------------------------- 2 files changed, 65 insertions(+), 63 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e046b64b5c..07a4531a4d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,18 @@ +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + + * linespec.c (symtab_vector_up): Define. + (struct linespec) <file_symtabs>: Change type to std::vector. + Update all uses. + (struct collect_info) <file_symtabs>: Likewise. + (decode_objc): Remove cleanup. + (symtab_collector::symtab_collector): Initialize `m_symtabs'. + (symtab_collector::release_symtabs): Return std::vector. + Update all callers. + (class symtab_collector) <m_symtabs>: Change type to std::vector. + Update all users. + (collect_symtabs_from_filename, symtabs_from_filename): Return + std::vector. Update all callers. + 2018-08-10 Keith Seitz <keiths@redhat.com> * compile/compile-c-support.c (add_code_header, add_code_footer): diff --git a/gdb/linespec.c b/gdb/linespec.c index 790ddf4740..418e5f8ba2 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -77,6 +77,10 @@ enum class linespec_complete_what KEYWORD, }; +/* Typedef for unique_ptrs of vectors of symtabs. */ + +typedef std::unique_ptr<std::vector<symtab *>> symtab_vector_up; + typedef struct symbol *symbolp; DEF_VEC_P (symbolp); @@ -107,7 +111,7 @@ struct linespec be NULL. If explicit.SOURCE_FILENAME is NULL (no user-specified filename), FILE_SYMTABS should contain one single NULL member. This will cause the code to use the default symtab. */ - VEC (symtab_ptr) *file_symtabs; + std::vector<symtab *> *file_symtabs; /* A list of matching function symbols and minimal symbols. Both lists may be NULL if no matching symbols were found. */ @@ -192,7 +196,7 @@ struct collect_info struct linespec_state *state; /* A list of symtabs to which to restrict matches. */ - VEC (symtab_ptr) *file_symtabs; + std::vector<symtab *> *file_symtabs; /* The result being accumulated. */ struct @@ -345,8 +349,8 @@ static std::vector<symtab_and_line> decode_objc (struct linespec_state *self, linespec_p ls, const char *arg); -static VEC (symtab_ptr) *symtabs_from_filename (const char *, - struct program_space *pspace); +static std::vector<symtab *> *symtabs_from_filename + (const char *, struct program_space *pspace); static VEC (symbolp) *find_label_symbols (struct linespec_state *self, VEC (symbolp) *function_symbols, @@ -355,7 +359,7 @@ static VEC (symbolp) *find_label_symbols (struct linespec_state *self, bool completion_mode = false); static void find_linespec_symbols (struct linespec_state *self, - VEC (symtab_ptr) *file_symtabs, + std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, VEC (symbolp) **symbols, @@ -378,7 +382,7 @@ static void add_all_symbol_names_from_pspace (struct collect_info *info, struct program_space *pspace, const std::vector<const char *> &names, enum search_domain search_domain); -static VEC (symtab_ptr) * +static std::vector<symtab *> * collect_symtabs_from_filename (const char *file, struct program_space *pspace); @@ -2093,8 +2097,8 @@ create_sals_line_offset (struct linespec_state *self, set_default_source_symtab_and_line uses select_source_symtab that calls us with such an argument. */ - if (VEC_length (symtab_ptr, ls->file_symtabs) == 1 - && VEC_index (symtab_ptr, ls->file_symtabs, 0) == NULL) + if (ls->file_symtabs->size () == 1 + && ls->file_symtabs->front () == nullptr) { const char *fullname; @@ -2104,8 +2108,7 @@ create_sals_line_offset (struct linespec_state *self, set_default_source_symtab_and_line (); initialize_defaults (&self->default_symtab, &self->default_line); fullname = symtab_to_fullname (self->default_symtab); - VEC_pop (symtab_ptr, ls->file_symtabs); - VEC_free (symtab_ptr, ls->file_symtabs); + delete ls->file_symtabs; ls->file_symtabs = collect_symtabs_from_filename (fullname, self->search_pspace); use_default = 1; @@ -2411,7 +2414,7 @@ convert_explicit_location_to_linespec (struct linespec_state *self, else { /* A NULL entry means to use the default symtab. */ - VEC_safe_push (symtab_ptr, result->file_symtabs, NULL); + result->file_symtabs->push_back (nullptr); } if (function_name != NULL) @@ -2580,7 +2583,7 @@ parse_linespec (linespec_parser *parser, const char *arg, { /* A NULL entry means to use GLOBAL_DEFAULT_SYMTAB. */ if (parser->completion_tracker == NULL) - VEC_safe_push (symtab_ptr, PARSER_RESULT (parser)->file_symtabs, NULL); + PARSER_RESULT (parser)->file_symtabs->push_back (nullptr); /* User specified a convenience variable or history value. */ gdb::unique_xmalloc_ptr<char> var = copy_token_string (token); @@ -2645,7 +2648,7 @@ parse_linespec (linespec_parser *parser, const char *arg, else { /* A NULL entry means to use GLOBAL_DEFAULT_SYMTAB. */ - VEC_safe_push (symtab_ptr, PARSER_RESULT (parser)->file_symtabs, NULL); + PARSER_RESULT (parser)->file_symtabs->push_back (nullptr); } } /* If the next token is not EOI, KEYWORD, or COMMA, issue an error. */ @@ -2661,7 +2664,7 @@ parse_linespec (linespec_parser *parser, const char *arg, else { /* A NULL entry means to use GLOBAL_DEFAULT_SYMTAB. */ - VEC_safe_push (symtab_ptr, PARSER_RESULT (parser)->file_symtabs, NULL); + PARSER_RESULT (parser)->file_symtabs->push_back (nullptr); } /* Parse the rest of the linespec. */ @@ -2746,6 +2749,7 @@ linespec_parser_new (linespec_parser *parser, memset (parser, 0, sizeof (linespec_parser)); parser->lexer.current.type = LSTOKEN_CONSUMED; memset (PARSER_RESULT (parser), 0, sizeof (struct linespec)); + PARSER_RESULT (parser)->file_symtabs = new std::vector<symtab *> (); PARSER_EXPLICIT (parser)->func_name_match_type = symbol_name_match_type::WILD; PARSER_EXPLICIT (parser)->line_offset.sign = LINE_OFFSET_UNKNOWN; @@ -2773,8 +2777,7 @@ linespec_parser_delete (void *arg) xfree (PARSER_EXPLICIT (parser)->label_name); xfree (PARSER_EXPLICIT (parser)->function_name); - if (PARSER_RESULT (parser)->file_symtabs != NULL) - VEC_free (symtab_ptr, PARSER_RESULT (parser)->file_symtabs); + delete PARSER_RESULT (parser)->file_symtabs; if (PARSER_RESULT (parser)->function_symbols != NULL) VEC_free (symbolp, PARSER_RESULT (parser)->function_symbols); @@ -3443,19 +3446,16 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) const char *new_argptr; info.state = self; - info.file_symtabs = NULL; - VEC_safe_push (symtab_ptr, info.file_symtabs, NULL); - struct cleanup *cleanup = make_cleanup (VEC_cleanup (symtab_ptr), - &info.file_symtabs); + std::vector<symtab *> symtabs; + symtabs.push_back (nullptr); + + info.file_symtabs = &symtabs; info.result.symbols = NULL; info.result.minimal_symbols = NULL; new_argptr = find_imps (arg, &symbol_names); if (symbol_names.empty ()) - { - do_cleanups (cleanup); - return {}; - } + return {}; add_all_symbol_names_from_pspace (&info, NULL, symbol_names, FUNCTIONS_DOMAIN); @@ -3497,8 +3497,6 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) } } - do_cleanups (cleanup); - return values; } @@ -3575,18 +3573,17 @@ decode_compound_collector::operator () (symbol *sym) /* Return any symbols corresponding to CLASS_NAME in FILE_SYMTABS. */ static VEC (symbolp) * -lookup_prefix_sym (struct linespec_state *state, VEC (symtab_ptr) *file_symtabs, +lookup_prefix_sym (struct linespec_state *state, + std::vector<symtab *> *file_symtabs, const char *class_name) { - int ix; - struct symtab *elt; decode_compound_collector collector; lookup_name_info lookup_name (class_name, symbol_name_match_type::FULL); - for (ix = 0; VEC_iterate (symtab_ptr, file_symtabs, ix, elt); ++ix) + for (const auto &elt : *file_symtabs) { - if (elt == NULL) + if (elt == nullptr) { iterate_over_all_matching_symtabs (state, lookup_name, STRUCT_DOMAIN, ALL_DOMAIN, @@ -3712,7 +3709,7 @@ find_superclass_methods (std::vector<struct type *> &&superclasses, in SYMBOLS (for debug symbols) and MINSYMS (for minimal symbols). */ static void -find_method (struct linespec_state *self, VEC (symtab_ptr) *file_symtabs, +find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, VEC (symbolp) *sym_classes, VEC (symbolp) **symbols, VEC (bound_minimal_symbol_d) **minsyms) @@ -3808,8 +3805,8 @@ class symtab_collector { public: symtab_collector () + : m_symtabs (new std::vector<symtab *> ()) { - m_symtabs = NULL; m_symtab_table = htab_create (1, htab_hash_pointer, htab_eq_pointer, NULL); } @@ -3824,16 +3821,14 @@ public: bool operator () (symtab *sym); /* Releases ownership of the collected symtabs and returns them. */ - VEC (symtab_ptr) *release_symtabs () + std::vector<symtab *> *release_symtabs () { - VEC (symtab_ptr) *res = m_symtabs; - m_symtabs = NULL; - return res; + return m_symtabs.release (); } private: /* The result vector of symtabs. */ - VEC (symtab_ptr) *m_symtabs; + symtab_vector_up m_symtabs; /* This is used to ensure the symtabs are unique. */ htab_t m_symtab_table; @@ -3848,7 +3843,7 @@ symtab_collector::operator () (struct symtab *symtab) if (!*slot) { *slot = symtab; - VEC_safe_push (symtab_ptr, m_symtabs, symtab); + m_symtabs->push_back (symtab); } return false; @@ -3856,11 +3851,13 @@ symtab_collector::operator () (struct symtab *symtab) } // namespace -/* Given a file name, return a VEC of all matching symtabs. If +/* Given a file name, return a list of all matching symtabs. If SEARCH_PSPACE is not NULL, the search is restricted to just that - program space. */ + program space. + + The result must be freed by the caller. */ -static VEC (symtab_ptr) * +static std::vector<symtab *> * collect_symtabs_from_filename (const char *file, struct program_space *search_pspace) { @@ -3892,16 +3889,16 @@ collect_symtabs_from_filename (const char *file, /* Return all the symtabs associated to the FILENAME. If SEARCH_PSPACE is not NULL, the search is restricted to just that program space. */ -static VEC (symtab_ptr) * +static std::vector<symtab *> * symtabs_from_filename (const char *filename, struct program_space *search_pspace) { - VEC (symtab_ptr) *result; - - result = collect_symtabs_from_filename (filename, search_pspace); + std::vector<symtab *> *result + = collect_symtabs_from_filename (filename, search_pspace); - if (VEC_empty (symtab_ptr, result)) + if (result->empty ()) { + delete result; if (!have_full_symbols () && !have_partial_symbols ()) throw_error (NOT_FOUND_ERROR, _("No symbol table is loaded. " @@ -3918,7 +3915,7 @@ symtabs_from_filename (const char *filename, static void find_function_symbols (struct linespec_state *state, - VEC (symtab_ptr) *file_symtabs, const char *name, + std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, VEC (symbolp) **symbols, VEC (bound_minimal_symbol_d) **minsyms) @@ -3962,7 +3959,7 @@ find_function_symbols (struct linespec_state *state, static void find_linespec_symbols (struct linespec_state *state, - VEC (symtab_ptr) *file_symtabs, + std::vector<symtab *> *file_symtabs, const char *lookup_name, symbol_name_match_type name_match_type, VEC (symbolp) **symbols, @@ -4154,15 +4151,11 @@ decode_digits_list_mode (struct linespec_state *self, linespec_p ls, struct symtab_and_line val) { - int ix; - struct symtab *elt; - gdb_assert (self->list_mode); std::vector<symtab_and_line> values; - for (ix = 0; VEC_iterate (symtab_ptr, ls->file_symtabs, ix, elt); - ++ix) + for (const auto &elt : *ls->file_symtabs) { /* The logic above should ensure this. */ gdb_assert (elt != NULL); @@ -4192,11 +4185,8 @@ decode_digits_ordinary (struct linespec_state *self, int line, struct linetable_entry **best_entry) { - int ix; - struct symtab *elt; - std::vector<symtab_and_line> sals; - for (ix = 0; VEC_iterate (symtab_ptr, ls->file_symtabs, ix, elt); ++ix) + for (const auto &elt : *ls->file_symtabs) { std::vector<CORE_ADDR> pcs; @@ -4486,14 +4476,11 @@ add_matching_symbols_to_info (const char *name, struct collect_info *info, struct program_space *pspace) { - int ix; - struct symtab *elt; - lookup_name_info lookup_name (name, name_match_type); - for (ix = 0; VEC_iterate (symtab_ptr, info->file_symtabs, ix, elt); ++ix) + for (const auto &elt : *info->file_symtabs) { - if (elt == NULL) + if (elt == nullptr) { iterate_over_all_matching_symtabs (info->state, lookup_name, VAR_DOMAIN, search_domain, -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/9] Change `file_symtabs' to std::vector 2018-08-10 23:25 ` [PATCH 1/9] Change `file_symtabs' to std::vector Keith Seitz @ 2018-08-11 14:47 ` Tom Tromey 2018-08-17 17:56 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-11 14:47 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch changes the `file_symtabs' members in linespec.c structures from Keith> a VEC to a std::vector, eliminating a cleanup in the process. Thank you for doing this. As you know, cleanup removal is something I'm very fond of. Keith> +typedef std::unique_ptr<std::vector<symtab *>> symtab_vector_up; Keith> + std::vector<symtab *> *file_symtabs; It took me a while to figure out why these were pointers and not just ordinary vectors. But in the end I agree with the decision -- we can always do later passes to clean things up even more, and my own experience C++-ifying linespec was that it's all too tangled to do in one big go. Keith> -static VEC (symtab_ptr) * Keith> +static std::vector<symtab *> * Keith> collect_symtabs_from_filename (const char *file, Keith> struct program_space *pspace); IIUC, this transfers ownership of the symtab_vector_up from the collector to the caller. So how about having this, symtabs_from_filename, and symtab_collector::release_symbols return a symtab_vector_up instead? That would make the ownership transfer part of the API. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/9] Change `file_symtabs' to std::vector 2018-08-11 14:47 ` Tom Tromey @ 2018-08-17 17:56 ` Keith Seitz 2018-08-28 17:30 ` Tom Tromey 0 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-17 17:56 UTC (permalink / raw) To: Tom Tromey; +Cc: gdb-patches On 08/11/2018 07:47 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: > Keith> +typedef std::unique_ptr<std::vector<symtab *>> symtab_vector_up; > > Keith> + std::vector<symtab *> *file_symtabs; > > It took me a while to figure out why these were pointers and not just > ordinary vectors. But in the end I agree with the decision -- we can > always do later passes to clean things up even more, and my own > experience C++-ifying linespec was that it's all too tangled to do in > one big go. Yup. I apologize if I wasn't clear enough on this point. This patch is really just meant to facilitate the new symbol-searching API added in a later patch. I have more of this cleanup for linespec lying around, but it is not ready for submission just yet. Eventually, though, this symbol_vector_up thing will disappear entirely as struct linespec et al move to a more common RAII redesign. > Keith> -static VEC (symtab_ptr) * > Keith> +static std::vector<symtab *> * > Keith> collect_symtabs_from_filename (const char *file, > Keith> struct program_space *pspace); > > IIUC, this transfers ownership of the symtab_vector_up from the > collector to the caller. So how about having this, > symtabs_from_filename, and symtab_collector::release_symbols return a > symtab_vector_up instead? That would make the ownership transfer part > of the API. Indeed. How about the below? [This is the only change in the following patch.] Keith Subject: [PATCH] Change `file_symtabs' to std::vector This patch changes the `file_symtabs' members in linespec.c structures from a VEC to a std::vector (or unique_ptr thereof), eliminating a cleanup in the process. gdb/ChangeLog: * linespec.c (symtab_vector_up): Define. (struct linespec) <file_symtabs>: Change type to std::vector *. Update all uses. (struct collect_info) <file_symtabs>: Likewise. (collect_symtabs_from_filename): Return symtab_vector_up. Update all callers. (decode_objc): Remove cleanup. (symtab_collector::symtab_collector): Initialize `m_symtabs'. (symtab_collector::release_symtabs): Return symtab_vector_up. Update all callers. (class symtab_collector) <m_symtabs>: Change type to symtab_vector_up. Update all users. (collect_symtabs_from_filename, symtabs_from_filename): Return symtab_vector_up. Update all callers. --- gdb/ChangeLog | 17 +++++++++ gdb/linespec.c | 118 +++++++++++++++++++++++++-------------------------------- 2 files changed, 69 insertions(+), 66 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e046b64b5c..b9d6cb165a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,20 @@ +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + + * linespec.c (symtab_vector_up): Define. + (struct linespec) <file_symtabs>: Change type to std::vector *. + Update all uses. + (struct collect_info) <file_symtabs>: Likewise. + (collect_symtabs_from_filename): Return symtab_vector_up. + Update all callers. + (decode_objc): Remove cleanup. + (symtab_collector::symtab_collector): Initialize `m_symtabs'. + (symtab_collector::release_symtabs): Return symtab_vector_up. + Update all callers. + (class symtab_collector) <m_symtabs>: Change type to symtab_vector_up. + Update all users. + (collect_symtabs_from_filename, symtabs_from_filename): Return + symtab_vector_up. Update all callers. + 2018-08-10 Keith Seitz <keiths@redhat.com> * compile/compile-c-support.c (add_code_header, add_code_footer): diff --git a/gdb/linespec.c b/gdb/linespec.c index 790ddf4740..032f6af0d4 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -77,6 +77,10 @@ enum class linespec_complete_what KEYWORD, }; +/* Typedef for unique_ptrs of vectors of symtabs. */ + +typedef std::unique_ptr<std::vector<symtab *>> symtab_vector_up; + typedef struct symbol *symbolp; DEF_VEC_P (symbolp); @@ -107,7 +111,7 @@ struct linespec be NULL. If explicit.SOURCE_FILENAME is NULL (no user-specified filename), FILE_SYMTABS should contain one single NULL member. This will cause the code to use the default symtab. */ - VEC (symtab_ptr) *file_symtabs; + std::vector<symtab *> *file_symtabs; /* A list of matching function symbols and minimal symbols. Both lists may be NULL if no matching symbols were found. */ @@ -192,7 +196,7 @@ struct collect_info struct linespec_state *state; /* A list of symtabs to which to restrict matches. */ - VEC (symtab_ptr) *file_symtabs; + std::vector<symtab *> *file_symtabs; /* The result being accumulated. */ struct @@ -345,8 +349,8 @@ static std::vector<symtab_and_line> decode_objc (struct linespec_state *self, linespec_p ls, const char *arg); -static VEC (symtab_ptr) *symtabs_from_filename (const char *, - struct program_space *pspace); +static symtab_vector_up symtabs_from_filename + (const char *, struct program_space *pspace); static VEC (symbolp) *find_label_symbols (struct linespec_state *self, VEC (symbolp) *function_symbols, @@ -355,7 +359,7 @@ static VEC (symbolp) *find_label_symbols (struct linespec_state *self, bool completion_mode = false); static void find_linespec_symbols (struct linespec_state *self, - VEC (symtab_ptr) *file_symtabs, + std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, VEC (symbolp) **symbols, @@ -378,7 +382,7 @@ static void add_all_symbol_names_from_pspace (struct collect_info *info, struct program_space *pspace, const std::vector<const char *> &names, enum search_domain search_domain); -static VEC (symtab_ptr) * +static symtab_vector_up collect_symtabs_from_filename (const char *file, struct program_space *pspace); @@ -2093,8 +2097,8 @@ create_sals_line_offset (struct linespec_state *self, set_default_source_symtab_and_line uses select_source_symtab that calls us with such an argument. */ - if (VEC_length (symtab_ptr, ls->file_symtabs) == 1 - && VEC_index (symtab_ptr, ls->file_symtabs, 0) == NULL) + if (ls->file_symtabs->size () == 1 + && ls->file_symtabs->front () == nullptr) { const char *fullname; @@ -2104,10 +2108,9 @@ create_sals_line_offset (struct linespec_state *self, set_default_source_symtab_and_line (); initialize_defaults (&self->default_symtab, &self->default_line); fullname = symtab_to_fullname (self->default_symtab); - VEC_pop (symtab_ptr, ls->file_symtabs); - VEC_free (symtab_ptr, ls->file_symtabs); - ls->file_symtabs = collect_symtabs_from_filename (fullname, - self->search_pspace); + symtab_vector_up r = + collect_symtabs_from_filename (fullname, self->search_pspace); + ls->file_symtabs = r.release (); use_default = 1; } @@ -2399,7 +2402,8 @@ convert_explicit_location_to_linespec (struct linespec_state *self, TRY { result->file_symtabs - = symtabs_from_filename (source_filename, self->search_pspace); + = symtabs_from_filename (source_filename, + self->search_pspace).release (); } CATCH (except, RETURN_MASK_ERROR) { @@ -2411,7 +2415,7 @@ convert_explicit_location_to_linespec (struct linespec_state *self, else { /* A NULL entry means to use the default symtab. */ - VEC_safe_push (symtab_ptr, result->file_symtabs, NULL); + result->file_symtabs->push_back (nullptr); } if (function_name != NULL) @@ -2580,7 +2584,7 @@ parse_linespec (linespec_parser *parser, const char *arg, { /* A NULL entry means to use GLOBAL_DEFAULT_SYMTAB. */ if (parser->completion_tracker == NULL) - VEC_safe_push (symtab_ptr, PARSER_RESULT (parser)->file_symtabs, NULL); + PARSER_RESULT (parser)->file_symtabs->push_back (nullptr); /* User specified a convenience variable or history value. */ gdb::unique_xmalloc_ptr<char> var = copy_token_string (token); @@ -2621,9 +2625,10 @@ parse_linespec (linespec_parser *parser, const char *arg, /* Check if the input is a filename. */ TRY { - PARSER_RESULT (parser)->file_symtabs + symtab_vector_up r = symtabs_from_filename (user_filename.get (), PARSER_STATE (parser)->search_pspace); + PARSER_RESULT (parser)->file_symtabs = r.release (); } CATCH (ex, RETURN_MASK_ERROR) { @@ -2645,7 +2650,7 @@ parse_linespec (linespec_parser *parser, const char *arg, else { /* A NULL entry means to use GLOBAL_DEFAULT_SYMTAB. */ - VEC_safe_push (symtab_ptr, PARSER_RESULT (parser)->file_symtabs, NULL); + PARSER_RESULT (parser)->file_symtabs->push_back (nullptr); } } /* If the next token is not EOI, KEYWORD, or COMMA, issue an error. */ @@ -2661,7 +2666,7 @@ parse_linespec (linespec_parser *parser, const char *arg, else { /* A NULL entry means to use GLOBAL_DEFAULT_SYMTAB. */ - VEC_safe_push (symtab_ptr, PARSER_RESULT (parser)->file_symtabs, NULL); + PARSER_RESULT (parser)->file_symtabs->push_back (nullptr); } /* Parse the rest of the linespec. */ @@ -2746,6 +2751,7 @@ linespec_parser_new (linespec_parser *parser, memset (parser, 0, sizeof (linespec_parser)); parser->lexer.current.type = LSTOKEN_CONSUMED; memset (PARSER_RESULT (parser), 0, sizeof (struct linespec)); + PARSER_RESULT (parser)->file_symtabs = new std::vector<symtab *> (); PARSER_EXPLICIT (parser)->func_name_match_type = symbol_name_match_type::WILD; PARSER_EXPLICIT (parser)->line_offset.sign = LINE_OFFSET_UNKNOWN; @@ -2773,8 +2779,7 @@ linespec_parser_delete (void *arg) xfree (PARSER_EXPLICIT (parser)->label_name); xfree (PARSER_EXPLICIT (parser)->function_name); - if (PARSER_RESULT (parser)->file_symtabs != NULL) - VEC_free (symtab_ptr, PARSER_RESULT (parser)->file_symtabs); + delete PARSER_RESULT (parser)->file_symtabs; if (PARSER_RESULT (parser)->function_symbols != NULL) VEC_free (symbolp, PARSER_RESULT (parser)->function_symbols); @@ -3443,19 +3448,16 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) const char *new_argptr; info.state = self; - info.file_symtabs = NULL; - VEC_safe_push (symtab_ptr, info.file_symtabs, NULL); - struct cleanup *cleanup = make_cleanup (VEC_cleanup (symtab_ptr), - &info.file_symtabs); + std::vector<symtab *> symtabs; + symtabs.push_back (nullptr); + + info.file_symtabs = &symtabs; info.result.symbols = NULL; info.result.minimal_symbols = NULL; new_argptr = find_imps (arg, &symbol_names); if (symbol_names.empty ()) - { - do_cleanups (cleanup); - return {}; - } + return {}; add_all_symbol_names_from_pspace (&info, NULL, symbol_names, FUNCTIONS_DOMAIN); @@ -3497,8 +3499,6 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) } } - do_cleanups (cleanup); - return values; } @@ -3575,18 +3575,17 @@ decode_compound_collector::operator () (symbol *sym) /* Return any symbols corresponding to CLASS_NAME in FILE_SYMTABS. */ static VEC (symbolp) * -lookup_prefix_sym (struct linespec_state *state, VEC (symtab_ptr) *file_symtabs, +lookup_prefix_sym (struct linespec_state *state, + std::vector<symtab *> *file_symtabs, const char *class_name) { - int ix; - struct symtab *elt; decode_compound_collector collector; lookup_name_info lookup_name (class_name, symbol_name_match_type::FULL); - for (ix = 0; VEC_iterate (symtab_ptr, file_symtabs, ix, elt); ++ix) + for (const auto &elt : *file_symtabs) { - if (elt == NULL) + if (elt == nullptr) { iterate_over_all_matching_symtabs (state, lookup_name, STRUCT_DOMAIN, ALL_DOMAIN, @@ -3712,7 +3711,7 @@ find_superclass_methods (std::vector<struct type *> &&superclasses, in SYMBOLS (for debug symbols) and MINSYMS (for minimal symbols). */ static void -find_method (struct linespec_state *self, VEC (symtab_ptr) *file_symtabs, +find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, VEC (symbolp) *sym_classes, VEC (symbolp) **symbols, VEC (bound_minimal_symbol_d) **minsyms) @@ -3808,8 +3807,8 @@ class symtab_collector { public: symtab_collector () + : m_symtabs (new std::vector<symtab *> ()) { - m_symtabs = NULL; m_symtab_table = htab_create (1, htab_hash_pointer, htab_eq_pointer, NULL); } @@ -3824,16 +3823,14 @@ public: bool operator () (symtab *sym); /* Releases ownership of the collected symtabs and returns them. */ - VEC (symtab_ptr) *release_symtabs () + symtab_vector_up release_symtabs () { - VEC (symtab_ptr) *res = m_symtabs; - m_symtabs = NULL; - return res; + return std::move (m_symtabs); } private: /* The result vector of symtabs. */ - VEC (symtab_ptr) *m_symtabs; + symtab_vector_up m_symtabs; /* This is used to ensure the symtabs are unique. */ htab_t m_symtab_table; @@ -3848,7 +3845,7 @@ symtab_collector::operator () (struct symtab *symtab) if (!*slot) { *slot = symtab; - VEC_safe_push (symtab_ptr, m_symtabs, symtab); + m_symtabs->push_back (symtab); } return false; @@ -3856,11 +3853,11 @@ symtab_collector::operator () (struct symtab *symtab) } // namespace -/* Given a file name, return a VEC of all matching symtabs. If +/* Given a file name, return a list of all matching symtabs. If SEARCH_PSPACE is not NULL, the search is restricted to just that program space. */ -static VEC (symtab_ptr) * +static symtab_vector_up collect_symtabs_from_filename (const char *file, struct program_space *search_pspace) { @@ -3892,15 +3889,14 @@ collect_symtabs_from_filename (const char *file, /* Return all the symtabs associated to the FILENAME. If SEARCH_PSPACE is not NULL, the search is restricted to just that program space. */ -static VEC (symtab_ptr) * +static symtab_vector_up symtabs_from_filename (const char *filename, struct program_space *search_pspace) { - VEC (symtab_ptr) *result; - - result = collect_symtabs_from_filename (filename, search_pspace); + symtab_vector_up result + = collect_symtabs_from_filename (filename, search_pspace); - if (VEC_empty (symtab_ptr, result)) + if (result->empty ()) { if (!have_full_symbols () && !have_partial_symbols ()) throw_error (NOT_FOUND_ERROR, @@ -3918,7 +3914,7 @@ symtabs_from_filename (const char *filename, static void find_function_symbols (struct linespec_state *state, - VEC (symtab_ptr) *file_symtabs, const char *name, + std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, VEC (symbolp) **symbols, VEC (bound_minimal_symbol_d) **minsyms) @@ -3962,7 +3958,7 @@ find_function_symbols (struct linespec_state *state, static void find_linespec_symbols (struct linespec_state *state, - VEC (symtab_ptr) *file_symtabs, + std::vector<symtab *> *file_symtabs, const char *lookup_name, symbol_name_match_type name_match_type, VEC (symbolp) **symbols, @@ -4154,15 +4150,11 @@ decode_digits_list_mode (struct linespec_state *self, linespec_p ls, struct symtab_and_line val) { - int ix; - struct symtab *elt; - gdb_assert (self->list_mode); std::vector<symtab_and_line> values; - for (ix = 0; VEC_iterate (symtab_ptr, ls->file_symtabs, ix, elt); - ++ix) + for (const auto &elt : *ls->file_symtabs) { /* The logic above should ensure this. */ gdb_assert (elt != NULL); @@ -4192,11 +4184,8 @@ decode_digits_ordinary (struct linespec_state *self, int line, struct linetable_entry **best_entry) { - int ix; - struct symtab *elt; - std::vector<symtab_and_line> sals; - for (ix = 0; VEC_iterate (symtab_ptr, ls->file_symtabs, ix, elt); ++ix) + for (const auto &elt : *ls->file_symtabs) { std::vector<CORE_ADDR> pcs; @@ -4486,14 +4475,11 @@ add_matching_symbols_to_info (const char *name, struct collect_info *info, struct program_space *pspace) { - int ix; - struct symtab *elt; - lookup_name_info lookup_name (name, name_match_type); - for (ix = 0; VEC_iterate (symtab_ptr, info->file_symtabs, ix, elt); ++ix) + for (const auto &elt : *info->file_symtabs) { - if (elt == NULL) + if (elt == nullptr) { iterate_over_all_matching_symtabs (info->state, lookup_name, VAR_DOMAIN, search_domain, -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/9] Change `file_symtabs' to std::vector 2018-08-17 17:56 ` Keith Seitz @ 2018-08-28 17:30 ` Tom Tromey 0 siblings, 0 replies; 45+ messages in thread From: Tom Tromey @ 2018-08-28 17:30 UTC (permalink / raw) To: Keith Seitz; +Cc: Tom Tromey, gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: >> IIUC, this transfers ownership of the symtab_vector_up from the >> collector to the caller. So how about having this, >> symtabs_from_filename, and symtab_collector::release_symbols return a >> symtab_vector_up instead? That would make the ownership transfer part >> of the API. Keith> Indeed. How about the below? [This is the only change in the following Keith> patch.] Thanks! This is ok. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 2/9] Change `function_symbols' to std::vector 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz 2018-08-10 23:25 ` [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures Keith Seitz 2018-08-10 23:25 ` [PATCH 1/9] Change `file_symtabs' to std::vector Keith Seitz @ 2018-08-10 23:25 ` Keith Seitz 2018-08-11 14:49 ` Tom Tromey 2018-08-10 23:31 ` [PATCH 7/9] Use block_symbol_d in linespec APIs Keith Seitz ` (5 subsequent siblings) 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:25 UTC (permalink / raw) To: gdb-patches This patch changes the `function_symbols' members in linespec.c structures from a VEC to a std::vector. gdb/ChangeLog: * linespec.c (struct linespec) <function_symbols>: Change type to std::vector. Update all users. (struct collect_info) <function_symbols>: Likewise. (find_method, find_function_symbols, find_linespec_symbols) (find_label_symbols_in_block): Change `symbols' parameter to std::vector. Update all callers. (find_label_symbols): Likewise for `function_symbols' and `label_funcs_ret'. --- gdb/ChangeLog | 11 +++++ gdb/linespec.c | 139 +++++++++++++++++++++++++-------------------------------- 2 files changed, 73 insertions(+), 77 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 07a4531a4d..5a71381262 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,16 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <function_symbols>: Change type to + std::vector. Update all users. + (struct collect_info) <function_symbols>: Likewise. + (find_method, find_function_symbols, find_linespec_symbols) + (find_label_symbols_in_block): Change `symbols' parameter to + std::vector. Update all callers. + (find_label_symbols): Likewise for `function_symbols' and + `label_funcs_ret'. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (symtab_vector_up): Define. (struct linespec) <file_symtabs>: Change type to std::vector. Update all uses. diff --git a/gdb/linespec.c b/gdb/linespec.c index 418e5f8ba2..8070db68ec 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -114,8 +114,8 @@ struct linespec std::vector<symtab *> *file_symtabs; /* A list of matching function symbols and minimal symbols. Both lists - may be NULL if no matching symbols were found. */ - VEC (symbolp) *function_symbols; + may be NULL (or empty) if no matching symbols were found. */ + std::vector<symbol *> *function_symbols; VEC (bound_minimal_symbol_d) *minimal_symbols; /* A structure of matching label symbols and the corresponding @@ -124,7 +124,7 @@ struct linespec struct { VEC (symbolp) *label_symbols; - VEC (symbolp) *function_symbols; + std::vector<symbol *> *function_symbols; } labels; }; typedef struct linespec *linespec_p; @@ -201,7 +201,7 @@ struct collect_info /* The result being accumulated. */ struct { - VEC (symbolp) *symbols; + std::vector<symbol *> *symbols; VEC (bound_minimal_symbol_d) *minimal_symbols; } result; @@ -215,7 +215,7 @@ collect_info::add_symbol (symbol *sym) /* In list mode, add all matching symbols, regardless of class. This allows the user to type "list a_global_variable". */ if (SYMBOL_CLASS (sym) == LOC_BLOCK || this->state->list_mode) - VEC_safe_push (symbolp, this->result.symbols, sym); + this->result.symbols->push_back (sym); /* Continue iterating. */ return true; @@ -352,17 +352,16 @@ static std::vector<symtab_and_line> decode_objc (struct linespec_state *self, static std::vector<symtab *> *symtabs_from_filename (const char *, struct program_space *pspace); -static VEC (symbolp) *find_label_symbols (struct linespec_state *self, - VEC (symbolp) *function_symbols, - VEC (symbolp) **label_funcs_ret, - const char *name, - bool completion_mode = false); +static VEC (symbolp) *find_label_symbols + (struct linespec_state *self, std::vector<symbol *> *function_symbols, + std::vector<symbol *> *label_funcs_ret, const char *name, + bool completion_mode = false); static void find_linespec_symbols (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, - VEC (symbolp) **symbols, + std::vector<symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms); static struct line_offset @@ -1767,7 +1766,8 @@ linespec_parse_basic (linespec_parser *parser) { gdb::unique_xmalloc_ptr<char> name; linespec_token token; - VEC (symbolp) *symbols, *labels; + std::vector<symbol *> symbols; + VEC (symbolp) *labels; VEC (bound_minimal_symbol_d) *minimal_symbols; /* Get the next token. */ @@ -1871,12 +1871,12 @@ linespec_parse_basic (linespec_parser *parser) PARSER_EXPLICIT (parser)->func_name_match_type, &symbols, &minimal_symbols); - if (symbols != NULL || minimal_symbols != NULL) + if (!symbols.empty () || minimal_symbols != NULL) { - PARSER_RESULT (parser)->function_symbols = symbols; + PARSER_RESULT (parser)->function_symbols + = new std::vector<symbol *> (std::move (symbols)); PARSER_RESULT (parser)->minimal_symbols = minimal_symbols; PARSER_EXPLICIT (parser)->function_name = name.release (); - symbols = NULL; } else { @@ -1887,9 +1887,9 @@ linespec_parse_basic (linespec_parser *parser) if (labels != NULL) { PARSER_RESULT (parser)->labels.label_symbols = labels; - PARSER_RESULT (parser)->labels.function_symbols = symbols; + PARSER_RESULT (parser)->labels.function_symbols + = new std::vector<symbol *> (std::move (symbols)); PARSER_EXPLICIT (parser)->label_name = name.release (); - symbols = NULL; } else if (token.type == LSTOKEN_STRING && *LS_TOKEN_STOKEN (token).ptr == '$') @@ -1993,9 +1993,9 @@ linespec_parse_basic (linespec_parser *parser) if (labels != NULL) { PARSER_RESULT (parser)->labels.label_symbols = labels; - PARSER_RESULT (parser)->labels.function_symbols = symbols; + PARSER_RESULT (parser)->labels.function_symbols + = new std::vector<symbol *> (std::move (symbols)); PARSER_EXPLICIT (parser)->label_name = name.release (); - symbols = NULL; } else { @@ -2061,13 +2061,10 @@ canonicalize_linespec (struct linespec_state *state, const linespec_p ls) if (explicit_loc->function_name == NULL) { - struct symbol *s; - /* No function was specified, so add the symbol name. */ - gdb_assert (ls->labels.function_symbols != NULL - && (VEC_length (symbolp, ls->labels.function_symbols) - == 1)); - s = VEC_index (symbolp, ls->labels.function_symbols, 0); + gdb_assert (!ls->labels.function_symbols->empty () + && (ls->labels.function_symbols->size () == 1)); + struct symbol *s = ls->labels.function_symbols->front (); explicit_loc->function_name = xstrdup (SYMBOL_NATURAL_NAME (s)); } } @@ -2265,12 +2262,10 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) { /* Sort symbols so that symbols with the same program space are next to each other. */ - qsort (VEC_address (symbolp, ls->function_symbols), - VEC_length (symbolp, ls->function_symbols), - sizeof (symbolp), compare_symbols); + qsort (ls->function_symbols->data (), ls->function_symbols->size (), + sizeof (symbol *), compare_symbols); - struct symbol *sym; - for (int i = 0; VEC_iterate (symbolp, ls->function_symbols, i, sym); ++i) + for (const auto &sym : *ls->function_symbols) { program_space *pspace = SYMTAB_PSPACE (symbol_symtab (sym)); set_current_program_space (pspace); @@ -2392,7 +2387,8 @@ convert_explicit_location_to_linespec (struct linespec_state *self, const char *label_name, struct line_offset line_offset) { - VEC (symbolp) *symbols, *labels; + std::vector<symbol *> symbols; + VEC (symbolp) *labels; VEC (bound_minimal_symbol_d) *minimal_symbols; result->explicit_loc.func_name_match_type = fname_match_type; @@ -2423,18 +2419,18 @@ convert_explicit_location_to_linespec (struct linespec_state *self, function_name, fname_match_type, &symbols, &minimal_symbols); - if (symbols == NULL && minimal_symbols == NULL) + if (symbols.empty () && minimal_symbols == NULL) symbol_not_found_error (function_name, result->explicit_loc.source_filename); result->explicit_loc.function_name = xstrdup (function_name); - result->function_symbols = symbols; + result->function_symbols + = new std::vector<symbol *> (std::move (symbols)); result->minimal_symbols = minimal_symbols; } if (label_name != NULL) { - symbols = NULL; labels = find_label_symbols (self, result->function_symbols, &symbols, label_name); @@ -2444,7 +2440,8 @@ convert_explicit_location_to_linespec (struct linespec_state *self, result->explicit_loc.label_name = xstrdup (label_name); result->labels.label_symbols = labels; - result->labels.function_symbols = symbols; + result->labels.function_symbols + = new std::vector<symbol *> (std::move (symbols)); } if (line_offset.sign != LINE_OFFSET_UNKNOWN) @@ -2778,9 +2775,7 @@ linespec_parser_delete (void *arg) xfree (PARSER_EXPLICIT (parser)->function_name); delete PARSER_RESULT (parser)->file_symtabs; - - if (PARSER_RESULT (parser)->function_symbols != NULL) - VEC_free (symbolp, PARSER_RESULT (parser)->function_symbols); + delete PARSER_RESULT (parser)->function_symbols; if (PARSER_RESULT (parser)->minimal_symbols != NULL) VEC_free (bound_minimal_symbol_d, PARSER_RESULT (parser)->minimal_symbols); @@ -2788,8 +2783,7 @@ linespec_parser_delete (void *arg) if (PARSER_RESULT (parser)->labels.label_symbols != NULL) VEC_free (symbolp, PARSER_RESULT (parser)->labels.label_symbols); - if (PARSER_RESULT (parser)->labels.function_symbols != NULL) - VEC_free (symbolp, PARSER_RESULT (parser)->labels.function_symbols); + delete PARSER_RESULT (parser)->labels.function_symbols; linespec_state_destructor (PARSER_STATE (parser)); } @@ -2922,7 +2916,7 @@ complete_label (completion_tracker &tracker, linespec_parser *parser, const char *label_name) { - VEC (symbolp) *label_function_symbols = NULL; + std::vector<symbol *> label_function_symbols; VEC (symbolp) *labels = find_label_symbols (PARSER_STATE (parser), PARSER_RESULT (parser)->function_symbols, @@ -3045,14 +3039,15 @@ linespec_complete (completion_tracker &tracker, const char *text, const char *func_name = PARSER_EXPLICIT (&parser)->function_name; - VEC (symbolp) *function_symbols; + std::vector<symbol *> function_symbols; VEC (bound_minimal_symbol_d) *minimal_symbols; find_linespec_symbols (PARSER_STATE (&parser), PARSER_RESULT (&parser)->file_symtabs, func_name, match_type, &function_symbols, &minimal_symbols); - PARSER_RESULT (&parser)->function_symbols = function_symbols; + PARSER_RESULT (&parser)->function_symbols + = new std::vector<symbol *> (std::move (function_symbols)); PARSER_RESULT (&parser)->minimal_symbols = minimal_symbols; complete_label (tracker, &parser, parser.completion_word); @@ -3450,7 +3445,9 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) symtabs.push_back (nullptr); info.file_symtabs = &symtabs; - info.result.symbols = NULL; + + std::vector<symbol *> symbols; + info.result.symbols = &symbols; info.result.minimal_symbols = NULL; new_argptr = find_imps (arg, &symbol_names); @@ -3461,7 +3458,7 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) FUNCTIONS_DOMAIN); std::vector<symtab_and_line> values; - if (!VEC_empty (symbolp, info.result.symbols) + if (!symbols.empty () || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) { char *saved_arg; @@ -3471,7 +3468,7 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) saved_arg[new_argptr - arg] = '\0'; ls->explicit_loc.function_name = xstrdup (saved_arg); - ls->function_symbols = info.result.symbols; + ls->function_symbols = new std::vector<symbol *> (std::move (symbols)); ls->minimal_symbols = info.result.minimal_symbols; values = convert_linespec_to_sals (self, ls); @@ -3711,7 +3708,7 @@ find_superclass_methods (std::vector<struct type *> &&superclasses, static void find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, - VEC (symbolp) *sym_classes, VEC (symbolp) **symbols, + VEC (symbolp) *sym_classes, std::vector<symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms) { struct symbol *sym; @@ -3730,7 +3727,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, info.state = self; info.file_symtabs = file_symtabs; - info.result.symbols = NULL; + info.result.symbols = symbols; info.result.minimal_symbols = NULL; /* Iterate over all the types, looking for the names of existing @@ -3781,10 +3778,9 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, } } - if (!VEC_empty (symbolp, info.result.symbols) + if (!symbols->empty () || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) { - *symbols = info.result.symbols; *minsyms = info.result.minimal_symbols; return; } @@ -3917,14 +3913,14 @@ static void find_function_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, - VEC (symbolp) **symbols, + std::vector<symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms) { struct collect_info info; std::vector<const char *> symbol_names; info.state = state; - info.result.symbols = NULL; + info.result.symbols = symbols; info.result.minimal_symbols = NULL; info.file_symtabs = file_symtabs; @@ -3937,14 +3933,6 @@ find_function_symbols (struct linespec_state *state, add_matching_symbols_to_info (name, name_match_type, FUNCTIONS_DOMAIN, &info, state->search_pspace); - if (VEC_empty (symbolp, info.result.symbols)) - { - VEC_free (symbolp, info.result.symbols); - *symbols = NULL; - } - else - *symbols = info.result.symbols; - if (VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) { VEC_free (bound_minimal_symbol_d, info.result.minimal_symbols); @@ -3962,7 +3950,7 @@ find_linespec_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *lookup_name, symbol_name_match_type name_match_type, - VEC (symbolp) **symbols, + std::vector <symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms) { std::string canon = cp_canonicalize_string_no_typedefs (lookup_name); @@ -3979,13 +3967,12 @@ find_linespec_symbols (struct linespec_state *state, 2) break class::method where method is in class (and not a baseclass) */ find_function_symbols (state, file_symtabs, lookup_name, - name_match_type, - symbols, minsyms); + name_match_type, symbols, minsyms); /* If we were unable to locate a symbol of the same name, try dividing the name into class and method names and searching the class and its baseclasses. */ - if (VEC_empty (symbolp, *symbols) + if (symbols->empty () && VEC_empty (bound_minimal_symbol_d, *minsyms)) { std::string klass, method; @@ -4059,7 +4046,7 @@ find_label_symbols_in_block (const struct block *block, const char *name, struct symbol *fn_sym, bool completion_mode, VEC (symbolp) **result, - VEC (symbolp) **label_funcs_ret) + std::vector<symbol *> *label_funcs_ret) { if (completion_mode) { @@ -4077,7 +4064,7 @@ find_label_symbols_in_block (const struct block *block, && cmp (SYMBOL_SEARCH_NAME (sym), name, name_len) == 0) { VEC_safe_push (symbolp, *result, sym); - VEC_safe_push (symbolp, *label_funcs_ret, fn_sym); + label_funcs_ret->push_back (fn_sym); } } } @@ -4088,7 +4075,7 @@ find_label_symbols_in_block (const struct block *block, if (sym != NULL) { VEC_safe_push (symbolp, *result, sym); - VEC_safe_push (symbolp, *label_funcs_ret, fn_sym); + label_funcs_ret->push_back (fn_sym); } } } @@ -4101,11 +4088,10 @@ find_label_symbols_in_block (const struct block *block, static VEC (symbolp) * find_label_symbols (struct linespec_state *self, - VEC (symbolp) *function_symbols, - VEC (symbolp) **label_funcs_ret, const char *name, + std::vector<symbol *> *function_symbols, + std::vector<symbol *> *label_funcs_ret, const char *name, bool completion_mode) { - int ix; const struct block *block; struct symbol *fn_sym; VEC (symbolp) *result = NULL; @@ -4128,13 +4114,12 @@ find_label_symbols (struct linespec_state *self, } else { - for (ix = 0; - VEC_iterate (symbolp, function_symbols, ix, fn_sym); ++ix) + for (const auto &elt : *function_symbols) { - set_current_program_space (SYMTAB_PSPACE (symbol_symtab (fn_sym))); - block = SYMBOL_BLOCK_VALUE (fn_sym); + set_current_program_space (SYMTAB_PSPACE (symbol_symtab (elt))); + block = SYMBOL_BLOCK_VALUE (elt); - find_label_symbols_in_block (block, name, fn_sym, completion_mode, + find_label_symbols_in_block (block, name, elt, completion_mode, &result, label_funcs_ret); } } @@ -4490,7 +4475,7 @@ add_matching_symbols_to_info (const char *name, } else if (pspace == NULL || pspace == SYMTAB_PSPACE (elt)) { - int prev_len = VEC_length (symbolp, info->result.symbols); + int prev_len = info->result.symbols->size (); /* Program spaces that are executing startup should have been filtered out earlier. */ @@ -4504,7 +4489,7 @@ add_matching_symbols_to_info (const char *name, is in assembler, we might actually be looking for a label for which we don't have debug info. Check for a minimal symbol in this case. */ - if (prev_len == VEC_length (symbolp, info->result.symbols) + if (prev_len == info->result.symbols->size () && elt->language == language_asm) search_minsyms_for_name (info, lookup_name, pspace, elt); } -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 2/9] Change `function_symbols' to std::vector 2018-08-10 23:25 ` [PATCH 2/9] Change `function_symbols' " Keith Seitz @ 2018-08-11 14:49 ` Tom Tromey 2018-08-17 17:59 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-11 14:49 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch changes the `function_symbols' members in linespec.c structures Keith> from a VEC to a std::vector. Keith> gdb/ChangeLog: Keith> * linespec.c (struct linespec) <function_symbols>: Change type to Keith> std::vector. Update all users. Keith> (struct collect_info) <function_symbols>: Likewise. Keith> (find_method, find_function_symbols, find_linespec_symbols) Keith> (find_label_symbols_in_block): Change `symbols' parameter to Keith> std::vector. Update all callers. Keith> (find_label_symbols): Likewise for `function_symbols' and Keith> `label_funcs_ret'. Thank you for the patch. This one looks ok to me. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 2/9] Change `function_symbols' to std::vector 2018-08-11 14:49 ` Tom Tromey @ 2018-08-17 17:59 ` Keith Seitz 2018-08-28 17:43 ` Tom Tromey 0 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-17 17:59 UTC (permalink / raw) To: Tom Tromey; +Cc: gdb-patches On 08/11/2018 07:49 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: > > Keith> This patch changes the `function_symbols' members in linespec.c structures > Keith> from a VEC to a std::vector. > > Keith> gdb/ChangeLog: > > Keith> * linespec.c (struct linespec) <function_symbols>: Change type to > Keith> std::vector. Update all users. > Keith> (struct collect_info) <function_symbols>: Likewise. > Keith> (find_method, find_function_symbols, find_linespec_symbols) > Keith> (find_label_symbols_in_block): Change `symbols' parameter to > Keith> std::vector. Update all callers. > Keith> (find_label_symbols): Likewise for `function_symbols' and > Keith> `label_funcs_ret'. > > Thank you for the patch. > This one looks ok to me. I know you approved this, but based on feedback on the minimal_symbols patch (#4 in this series), I thought I would also switch to sorting function_symbols with std::sort instead of qsort. This does involve introducing a new "std_compare_symbols" function since the one remaining qsort cannot be eliminated until later. [By the end of the series, though, we will be back to one Compare function again.] This is the only change in this revision. Keith Subject: [PATCH] Change `function_symbols' to std::vector This patch changes the `function_symbols' members in linespec.c structures from a VEC to a std::vector. gdb/ChangeLog: * linespec.c (struct linespec) <function_symbols>: Change type to std::vector. Update all users. (struct collect_info) <function_symbols>: Likewise. (convert_linespec_to_sals): Use std::sort to sort function_symbols. (std_compare_symbols): New function. (find_method, find_function_symbols, find_linespec_symbols) (find_label_symbols_in_block): Change `symbols' parameter to std::vector. Update all callers. (find_label_symbols): Likewise for `function_symbols' and `label_funcs_ret'. --- gdb/ChangeLog | 13 +++++ gdb/linespec.c | 168 +++++++++++++++++++++++++++++++-------------------------- 2 files changed, 104 insertions(+), 77 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b9d6cb165a..d3d2e6e644 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,18 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <function_symbols>: Change type to + std::vector. Update all users. + (struct collect_info) <function_symbols>: Likewise. + (convert_linespec_to_sals): Use std::sort to sort function_symbols. + (std_compare_symbols): New function. + (find_method, find_function_symbols, find_linespec_symbols) + (find_label_symbols_in_block): Change `symbols' parameter to + std::vector. Update all callers. + (find_label_symbols): Likewise for `function_symbols' and + `label_funcs_ret'. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (symtab_vector_up): Define. (struct linespec) <file_symtabs>: Change type to std::vector *. Update all uses. diff --git a/gdb/linespec.c b/gdb/linespec.c index 032f6af0d4..7fff8a2b71 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -114,8 +114,8 @@ struct linespec std::vector<symtab *> *file_symtabs; /* A list of matching function symbols and minimal symbols. Both lists - may be NULL if no matching symbols were found. */ - VEC (symbolp) *function_symbols; + may be NULL (or empty) if no matching symbols were found. */ + std::vector<symbol *> *function_symbols; VEC (bound_minimal_symbol_d) *minimal_symbols; /* A structure of matching label symbols and the corresponding @@ -124,7 +124,7 @@ struct linespec struct { VEC (symbolp) *label_symbols; - VEC (symbolp) *function_symbols; + std::vector<symbol *> *function_symbols; } labels; }; typedef struct linespec *linespec_p; @@ -201,7 +201,7 @@ struct collect_info /* The result being accumulated. */ struct { - VEC (symbolp) *symbols; + std::vector<symbol *> *symbols; VEC (bound_minimal_symbol_d) *minimal_symbols; } result; @@ -215,7 +215,7 @@ collect_info::add_symbol (symbol *sym) /* In list mode, add all matching symbols, regardless of class. This allows the user to type "list a_global_variable". */ if (SYMBOL_CLASS (sym) == LOC_BLOCK || this->state->list_mode) - VEC_safe_push (symbolp, this->result.symbols, sym); + this->result.symbols->push_back (sym); /* Continue iterating. */ return true; @@ -352,17 +352,16 @@ static std::vector<symtab_and_line> decode_objc (struct linespec_state *self, static symtab_vector_up symtabs_from_filename (const char *, struct program_space *pspace); -static VEC (symbolp) *find_label_symbols (struct linespec_state *self, - VEC (symbolp) *function_symbols, - VEC (symbolp) **label_funcs_ret, - const char *name, - bool completion_mode = false); +static VEC (symbolp) *find_label_symbols + (struct linespec_state *self, std::vector<symbol *> *function_symbols, + std::vector<symbol *> *label_funcs_ret, const char *name, + bool completion_mode = false); static void find_linespec_symbols (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, - VEC (symbolp) **symbols, + std::vector<symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms); static struct line_offset @@ -402,6 +401,8 @@ static void minsym_found (struct linespec_state *self, struct objfile *objfile, std::vector<symtab_and_line> *result); static int compare_symbols (const void *a, const void *b); +static bool std_compare_symbols (const struct symbol *a, + const struct symbol *b); static int compare_msymbols (const void *a, const void *b); @@ -1767,7 +1768,8 @@ linespec_parse_basic (linespec_parser *parser) { gdb::unique_xmalloc_ptr<char> name; linespec_token token; - VEC (symbolp) *symbols, *labels; + std::vector<symbol *> symbols; + VEC (symbolp) *labels; VEC (bound_minimal_symbol_d) *minimal_symbols; /* Get the next token. */ @@ -1871,12 +1873,12 @@ linespec_parse_basic (linespec_parser *parser) PARSER_EXPLICIT (parser)->func_name_match_type, &symbols, &minimal_symbols); - if (symbols != NULL || minimal_symbols != NULL) + if (!symbols.empty () || minimal_symbols != NULL) { - PARSER_RESULT (parser)->function_symbols = symbols; + PARSER_RESULT (parser)->function_symbols + = new std::vector<symbol *> (std::move (symbols)); PARSER_RESULT (parser)->minimal_symbols = minimal_symbols; PARSER_EXPLICIT (parser)->function_name = name.release (); - symbols = NULL; } else { @@ -1887,9 +1889,9 @@ linespec_parse_basic (linespec_parser *parser) if (labels != NULL) { PARSER_RESULT (parser)->labels.label_symbols = labels; - PARSER_RESULT (parser)->labels.function_symbols = symbols; + PARSER_RESULT (parser)->labels.function_symbols + = new std::vector<symbol *> (std::move (symbols)); PARSER_EXPLICIT (parser)->label_name = name.release (); - symbols = NULL; } else if (token.type == LSTOKEN_STRING && *LS_TOKEN_STOKEN (token).ptr == '$') @@ -1993,9 +1995,9 @@ linespec_parse_basic (linespec_parser *parser) if (labels != NULL) { PARSER_RESULT (parser)->labels.label_symbols = labels; - PARSER_RESULT (parser)->labels.function_symbols = symbols; + PARSER_RESULT (parser)->labels.function_symbols + = new std::vector<symbol *> (std::move (symbols)); PARSER_EXPLICIT (parser)->label_name = name.release (); - symbols = NULL; } else { @@ -2061,13 +2063,10 @@ canonicalize_linespec (struct linespec_state *state, const linespec_p ls) if (explicit_loc->function_name == NULL) { - struct symbol *s; - /* No function was specified, so add the symbol name. */ - gdb_assert (ls->labels.function_symbols != NULL - && (VEC_length (symbolp, ls->labels.function_symbols) - == 1)); - s = VEC_index (symbolp, ls->labels.function_symbols, 0); + gdb_assert (!ls->labels.function_symbols->empty () + && (ls->labels.function_symbols->size () == 1)); + struct symbol *s = ls->labels.function_symbols->front (); explicit_loc->function_name = xstrdup (SYMBOL_NATURAL_NAME (s)); } } @@ -2265,12 +2264,11 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) { /* Sort symbols so that symbols with the same program space are next to each other. */ - qsort (VEC_address (symbolp, ls->function_symbols), - VEC_length (symbolp, ls->function_symbols), - sizeof (symbolp), compare_symbols); + std::sort (ls->function_symbols->begin (), + ls->function_symbols->end (), + std_compare_symbols); - struct symbol *sym; - for (int i = 0; VEC_iterate (symbolp, ls->function_symbols, i, sym); ++i) + for (const auto &sym : *ls->function_symbols) { program_space *pspace = SYMTAB_PSPACE (symbol_symtab (sym)); set_current_program_space (pspace); @@ -2392,7 +2390,8 @@ convert_explicit_location_to_linespec (struct linespec_state *self, const char *label_name, struct line_offset line_offset) { - VEC (symbolp) *symbols, *labels; + std::vector<symbol *> symbols; + VEC (symbolp) *labels; VEC (bound_minimal_symbol_d) *minimal_symbols; result->explicit_loc.func_name_match_type = fname_match_type; @@ -2424,18 +2423,18 @@ convert_explicit_location_to_linespec (struct linespec_state *self, function_name, fname_match_type, &symbols, &minimal_symbols); - if (symbols == NULL && minimal_symbols == NULL) + if (symbols.empty () && minimal_symbols == NULL) symbol_not_found_error (function_name, result->explicit_loc.source_filename); result->explicit_loc.function_name = xstrdup (function_name); - result->function_symbols = symbols; + result->function_symbols + = new std::vector<symbol *> (std::move (symbols)); result->minimal_symbols = minimal_symbols; } if (label_name != NULL) { - symbols = NULL; labels = find_label_symbols (self, result->function_symbols, &symbols, label_name); @@ -2445,7 +2444,8 @@ convert_explicit_location_to_linespec (struct linespec_state *self, result->explicit_loc.label_name = xstrdup (label_name); result->labels.label_symbols = labels; - result->labels.function_symbols = symbols; + result->labels.function_symbols + = new std::vector<symbol *> (std::move (symbols)); } if (line_offset.sign != LINE_OFFSET_UNKNOWN) @@ -2780,9 +2780,7 @@ linespec_parser_delete (void *arg) xfree (PARSER_EXPLICIT (parser)->function_name); delete PARSER_RESULT (parser)->file_symtabs; - - if (PARSER_RESULT (parser)->function_symbols != NULL) - VEC_free (symbolp, PARSER_RESULT (parser)->function_symbols); + delete PARSER_RESULT (parser)->function_symbols; if (PARSER_RESULT (parser)->minimal_symbols != NULL) VEC_free (bound_minimal_symbol_d, PARSER_RESULT (parser)->minimal_symbols); @@ -2790,8 +2788,7 @@ linespec_parser_delete (void *arg) if (PARSER_RESULT (parser)->labels.label_symbols != NULL) VEC_free (symbolp, PARSER_RESULT (parser)->labels.label_symbols); - if (PARSER_RESULT (parser)->labels.function_symbols != NULL) - VEC_free (symbolp, PARSER_RESULT (parser)->labels.function_symbols); + delete PARSER_RESULT (parser)->labels.function_symbols; linespec_state_destructor (PARSER_STATE (parser)); } @@ -2924,7 +2921,7 @@ complete_label (completion_tracker &tracker, linespec_parser *parser, const char *label_name) { - VEC (symbolp) *label_function_symbols = NULL; + std::vector<symbol *> label_function_symbols; VEC (symbolp) *labels = find_label_symbols (PARSER_STATE (parser), PARSER_RESULT (parser)->function_symbols, @@ -3047,14 +3044,15 @@ linespec_complete (completion_tracker &tracker, const char *text, const char *func_name = PARSER_EXPLICIT (&parser)->function_name; - VEC (symbolp) *function_symbols; + std::vector<symbol *> function_symbols; VEC (bound_minimal_symbol_d) *minimal_symbols; find_linespec_symbols (PARSER_STATE (&parser), PARSER_RESULT (&parser)->file_symtabs, func_name, match_type, &function_symbols, &minimal_symbols); - PARSER_RESULT (&parser)->function_symbols = function_symbols; + PARSER_RESULT (&parser)->function_symbols + = new std::vector<symbol *> (std::move (function_symbols)); PARSER_RESULT (&parser)->minimal_symbols = minimal_symbols; complete_label (tracker, &parser, parser.completion_word); @@ -3452,7 +3450,9 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) symtabs.push_back (nullptr); info.file_symtabs = &symtabs; - info.result.symbols = NULL; + + std::vector<symbol *> symbols; + info.result.symbols = &symbols; info.result.minimal_symbols = NULL; new_argptr = find_imps (arg, &symbol_names); @@ -3463,7 +3463,7 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) FUNCTIONS_DOMAIN); std::vector<symtab_and_line> values; - if (!VEC_empty (symbolp, info.result.symbols) + if (!symbols.empty () || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) { char *saved_arg; @@ -3473,7 +3473,7 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) saved_arg[new_argptr - arg] = '\0'; ls->explicit_loc.function_name = xstrdup (saved_arg); - ls->function_symbols = info.result.symbols; + ls->function_symbols = new std::vector<symbol *> (std::move (symbols)); ls->minimal_symbols = info.result.minimal_symbols; values = convert_linespec_to_sals (self, ls); @@ -3608,6 +3608,32 @@ lookup_prefix_sym (struct linespec_state *state, return collector.release_symbols (); } +/* A std::sort comparison function for symbols. The resulting order does + not actually matter; we just need to be able to sort them so that + symbols with the same program space end up next to each other. */ + +static bool +std_compare_symbols (const struct symbol *a, const struct symbol *b) +{ + uintptr_t uia, uib; + + uia = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (a)); + uib = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (b)); + + if (uia < uib) + return true; + if (uia > uib) + return false; + + uia = (uintptr_t) a; + uib = (uintptr_t) b; + + if (uia < uib) + return true; + + return false; +} + /* A qsort comparison function for symbols. The resulting order does not actually matter; we just need to be able to sort them so that symbols with the same program space end up next to each other. */ @@ -3713,7 +3739,7 @@ find_superclass_methods (std::vector<struct type *> &&superclasses, static void find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, - VEC (symbolp) *sym_classes, VEC (symbolp) **symbols, + VEC (symbolp) *sym_classes, std::vector<symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms) { struct symbol *sym; @@ -3732,7 +3758,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, info.state = self; info.file_symtabs = file_symtabs; - info.result.symbols = NULL; + info.result.symbols = symbols; info.result.minimal_symbols = NULL; /* Iterate over all the types, looking for the names of existing @@ -3783,10 +3809,9 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, } } - if (!VEC_empty (symbolp, info.result.symbols) + if (!symbols->empty () || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) { - *symbols = info.result.symbols; *minsyms = info.result.minimal_symbols; return; } @@ -3916,14 +3941,14 @@ static void find_function_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, - VEC (symbolp) **symbols, + std::vector<symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms) { struct collect_info info; std::vector<const char *> symbol_names; info.state = state; - info.result.symbols = NULL; + info.result.symbols = symbols; info.result.minimal_symbols = NULL; info.file_symtabs = file_symtabs; @@ -3936,14 +3961,6 @@ find_function_symbols (struct linespec_state *state, add_matching_symbols_to_info (name, name_match_type, FUNCTIONS_DOMAIN, &info, state->search_pspace); - if (VEC_empty (symbolp, info.result.symbols)) - { - VEC_free (symbolp, info.result.symbols); - *symbols = NULL; - } - else - *symbols = info.result.symbols; - if (VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) { VEC_free (bound_minimal_symbol_d, info.result.minimal_symbols); @@ -3961,7 +3978,7 @@ find_linespec_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *lookup_name, symbol_name_match_type name_match_type, - VEC (symbolp) **symbols, + std::vector <symbol *> *symbols, VEC (bound_minimal_symbol_d) **minsyms) { std::string canon = cp_canonicalize_string_no_typedefs (lookup_name); @@ -3978,13 +3995,12 @@ find_linespec_symbols (struct linespec_state *state, 2) break class::method where method is in class (and not a baseclass) */ find_function_symbols (state, file_symtabs, lookup_name, - name_match_type, - symbols, minsyms); + name_match_type, symbols, minsyms); /* If we were unable to locate a symbol of the same name, try dividing the name into class and method names and searching the class and its baseclasses. */ - if (VEC_empty (symbolp, *symbols) + if (symbols->empty () && VEC_empty (bound_minimal_symbol_d, *minsyms)) { std::string klass, method; @@ -4058,7 +4074,7 @@ find_label_symbols_in_block (const struct block *block, const char *name, struct symbol *fn_sym, bool completion_mode, VEC (symbolp) **result, - VEC (symbolp) **label_funcs_ret) + std::vector<symbol *> *label_funcs_ret) { if (completion_mode) { @@ -4076,7 +4092,7 @@ find_label_symbols_in_block (const struct block *block, && cmp (SYMBOL_SEARCH_NAME (sym), name, name_len) == 0) { VEC_safe_push (symbolp, *result, sym); - VEC_safe_push (symbolp, *label_funcs_ret, fn_sym); + label_funcs_ret->push_back (fn_sym); } } } @@ -4087,7 +4103,7 @@ find_label_symbols_in_block (const struct block *block, if (sym != NULL) { VEC_safe_push (symbolp, *result, sym); - VEC_safe_push (symbolp, *label_funcs_ret, fn_sym); + label_funcs_ret->push_back (fn_sym); } } } @@ -4100,11 +4116,10 @@ find_label_symbols_in_block (const struct block *block, static VEC (symbolp) * find_label_symbols (struct linespec_state *self, - VEC (symbolp) *function_symbols, - VEC (symbolp) **label_funcs_ret, const char *name, + std::vector<symbol *> *function_symbols, + std::vector<symbol *> *label_funcs_ret, const char *name, bool completion_mode) { - int ix; const struct block *block; struct symbol *fn_sym; VEC (symbolp) *result = NULL; @@ -4127,13 +4142,12 @@ find_label_symbols (struct linespec_state *self, } else { - for (ix = 0; - VEC_iterate (symbolp, function_symbols, ix, fn_sym); ++ix) + for (const auto &elt : *function_symbols) { - set_current_program_space (SYMTAB_PSPACE (symbol_symtab (fn_sym))); - block = SYMBOL_BLOCK_VALUE (fn_sym); + set_current_program_space (SYMTAB_PSPACE (symbol_symtab (elt))); + block = SYMBOL_BLOCK_VALUE (elt); - find_label_symbols_in_block (block, name, fn_sym, completion_mode, + find_label_symbols_in_block (block, name, elt, completion_mode, &result, label_funcs_ret); } } @@ -4489,7 +4503,7 @@ add_matching_symbols_to_info (const char *name, } else if (pspace == NULL || pspace == SYMTAB_PSPACE (elt)) { - int prev_len = VEC_length (symbolp, info->result.symbols); + int prev_len = info->result.symbols->size (); /* Program spaces that are executing startup should have been filtered out earlier. */ @@ -4503,7 +4517,7 @@ add_matching_symbols_to_info (const char *name, is in assembler, we might actually be looking for a label for which we don't have debug info. Check for a minimal symbol in this case. */ - if (prev_len == VEC_length (symbolp, info->result.symbols) + if (prev_len == info->result.symbols->size () && elt->language == language_asm) search_minsyms_for_name (info, lookup_name, pspace, elt); } -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 2/9] Change `function_symbols' to std::vector 2018-08-17 17:59 ` Keith Seitz @ 2018-08-28 17:43 ` Tom Tromey 0 siblings, 0 replies; 45+ messages in thread From: Tom Tromey @ 2018-08-28 17:43 UTC (permalink / raw) To: Keith Seitz; +Cc: Tom Tromey, gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> I know you approved this, but based on feedback on the minimal_symbols patch Keith> (#4 in this series), I thought I would also switch to sorting function_symbols Keith> with std::sort instead of qsort. Keith> This does involve introducing a new "std_compare_symbols" function since the Keith> one remaining qsort cannot be eliminated until later. [By the end of the Keith> series, though, we will be back to one Compare function again.] Keith> This is the only change in this revision. Thanks, this is ok. It's always fine to push back on a review, like in this case if it was simpler to tack on a patch to convert to std::sort, rather than fixing it mid-stream, that would have been fine. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 7/9] Use block_symbol_d in linespec APIs 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz ` (2 preceding siblings ...) 2018-08-10 23:25 ` [PATCH 2/9] Change `function_symbols' " Keith Seitz @ 2018-08-10 23:31 ` Keith Seitz 2018-08-11 15:05 ` Tom Tromey 2018-08-10 23:31 ` [PATCH 6/9] Remove VEC definitions from linespec.c Keith Seitz ` (4 subsequent siblings) 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:31 UTC (permalink / raw) To: gdb-patches This patch changes the linespec.c APIs to use block_symbol instead of just a symbol. lookup_symbol et al already return block_symbol's. gdb/ChangeLog: * linespec.c (struct linespec) <function_symbols, label_symbols>: Change to vector of block_symbol. Update all users. (struct collect_info) <symbols>: Likewise. (collect_info::add_symbol): Take block_symbol as argument. Update all callers. (decode_compound_collector) <m_symbols>: Change type to vector of block_symbol. Update all users. (decode_compound_collector::operator ()): Change parameter type to block_symbol. (find_method, find_function_symbols, find_linespec_symbols) (find_label_symbols_in_block, find_label_symbols): Change symbol vectors to block_symbol vectors. * symtab.h (symbol_found_callback_ftype): Change parameter type to block_symbol. --- gdb/ChangeLog | 17 ++++++ gdb/ada-lang.c | 2 +- gdb/linespec.c | 180 +++++++++++++++++++++++++++++++-------------------------- gdb/symtab.c | 4 +- gdb/symtab.h | 2 +- 5 files changed, 119 insertions(+), 86 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8bd7ac01df..6fc1ce5262 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,22 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <function_symbols, label_symbols>: + Change to vector of block_symbol. Update all users. + (struct collect_info) <symbols>: Likewise. + (collect_info::add_symbol): Take block_symbol as argument. + Update all callers. + (decode_compound_collector) <m_symbols>: Change type to vector + of block_symbol. Update all users. + (decode_compound_collector::operator ()): Change parameter type + to block_symbol. + (find_method, find_function_symbols, find_linespec_symbols) + (find_label_symbols_in_block, find_label_symbols): Change symbol + vectors to block_symbol vectors. + * symtab.h (symbol_found_callback_ftype): Change parameter type to + block_symbol. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (symbolp): Remove typedef and VEC definitions. (bound_minimal_symbol_d): Likewise. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 07a0536684..d4169254f5 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -5841,7 +5841,7 @@ ada_iterate_over_symbols for (i = 0; i < ndefs; ++i) { - if (!callback (results[i].symbol)) + if (!callback (&results[i])) break; } } diff --git a/gdb/linespec.c b/gdb/linespec.c index dea02381b9..ef4556d8ea 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -108,7 +108,7 @@ struct linespec /* A list of matching function symbols and minimal symbols. Both lists may be NULL (or empty) if no matching symbols were found. */ - std::vector<symbol *> *function_symbols; + std::vector<block_symbol> *function_symbols; std::vector<bound_minimal_symbol> *minimal_symbols; /* A structure of matching label symbols and the corresponding @@ -116,8 +116,8 @@ struct linespec or both must be non-NULL. */ struct { - std::vector<symbol *> *label_symbols; - std::vector<symbol *> *function_symbols; + std::vector<block_symbol> *label_symbols; + std::vector<block_symbol> *function_symbols; } labels; }; typedef struct linespec *linespec_p; @@ -194,21 +194,21 @@ struct collect_info /* The result being accumulated. */ struct { - std::vector<symbol *> *symbols; + std::vector<block_symbol> *symbols; std::vector<bound_minimal_symbol> *minimal_symbols; } result; /* Possibly add a symbol to the results. */ - bool add_symbol (symbol *sym); + bool add_symbol (block_symbol *bsym); }; bool -collect_info::add_symbol (symbol *sym) +collect_info::add_symbol (block_symbol *bsym) { /* In list mode, add all matching symbols, regardless of class. This allows the user to type "list a_global_variable". */ - if (SYMBOL_CLASS (sym) == LOC_BLOCK || this->state->list_mode) - this->result.symbols->push_back (sym); + if (SYMBOL_CLASS (bsym->symbol) == LOC_BLOCK || this->state->list_mode) + this->result.symbols->push_back (*bsym); /* Continue iterating. */ return true; @@ -345,16 +345,16 @@ static std::vector<symtab_and_line> decode_objc (struct linespec_state *self, static std::vector<symtab *> *symtabs_from_filename (const char *, struct program_space *pspace); -static std::vector<symbol *> *find_label_symbols - (struct linespec_state *self, std::vector<symbol *> *function_symbols, - std::vector<symbol *> *label_funcs_ret, const char *name, +static std::vector<block_symbol> *find_label_symbols + (struct linespec_state *self, std::vector<block_symbol> *function_symbols, + std::vector<block_symbol> *label_funcs_ret, const char *name, bool completion_mode = false); static void find_linespec_symbols (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, - std::vector<symbol *> *symbols, + std::vector<block_symbol> *symbols, std::vector<bound_minimal_symbol> *minsyms); static struct line_offset @@ -1149,12 +1149,12 @@ iterate_over_all_matching_symtabs { block = BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (symtab), i); state->language->la_iterate_over_symbols - (block, lookup_name, name_domain, [&] (symbol *sym) + (block, lookup_name, name_domain, [&] (block_symbol *bsym) { /* Restrict calls to CALLBACK to symbols representing inline symbols only. */ - if (SYMBOL_INLINED (sym)) - return callback (sym); + if (SYMBOL_INLINED (bsym->symbol)) + return callback (bsym); return true; }); } @@ -1759,8 +1759,8 @@ linespec_parse_basic (linespec_parser *parser) { gdb::unique_xmalloc_ptr<char> name; linespec_token token; - std::vector<symbol *> symbols; - std::vector<symbol *> *labels; + std::vector<block_symbol> symbols; + std::vector<block_symbol> *labels; std::vector<bound_minimal_symbol> minimal_symbols; /* Get the next token. */ @@ -1867,7 +1867,7 @@ linespec_parse_basic (linespec_parser *parser) if (!symbols.empty () || !minimal_symbols.empty ()) { PARSER_RESULT (parser)->function_symbols - = new std::vector<symbol *> (std::move (symbols)); + = new std::vector<block_symbol> (std::move (symbols)); PARSER_RESULT (parser)->minimal_symbols = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); @@ -1883,7 +1883,7 @@ linespec_parse_basic (linespec_parser *parser) { PARSER_RESULT (parser)->labels.label_symbols = labels; PARSER_RESULT (parser)->labels.function_symbols - = new std::vector<symbol *> (std::move (symbols)); + = new std::vector<block_symbol> (std::move (symbols)); PARSER_EXPLICIT (parser)->label_name = name.release (); } else if (token.type == LSTOKEN_STRING @@ -1989,7 +1989,7 @@ linespec_parse_basic (linespec_parser *parser) { PARSER_RESULT (parser)->labels.label_symbols = labels; PARSER_RESULT (parser)->labels.function_symbols - = new std::vector<symbol *> (std::move (symbols)); + = new std::vector<block_symbol> (std::move (symbols)); PARSER_EXPLICIT (parser)->label_name = name.release (); } else @@ -2059,8 +2059,9 @@ canonicalize_linespec (struct linespec_state *state, const linespec_p ls) /* No function was specified, so add the symbol name. */ gdb_assert (!ls->labels.function_symbols->empty () && (ls->labels.function_symbols->size () == 1)); - struct symbol *s = ls->labels.function_symbols->front (); - explicit_loc->function_name = xstrdup (SYMBOL_NATURAL_NAME (s)); + block_symbol s = ls->labels.function_symbols->front (); + explicit_loc->function_name + = xstrdup (SYMBOL_NATURAL_NAME (s.symbol)); } } @@ -2236,15 +2237,17 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) if (ls->labels.label_symbols != NULL) { /* We have just a bunch of functions/methods or labels. */ + struct symtab_and_line sal; + for (const auto &sym : *ls->labels.label_symbols) { - struct symtab_and_line sal; - struct program_space *pspace = SYMTAB_PSPACE (symbol_symtab (sym)); + struct program_space *pspace + = SYMTAB_PSPACE (symbol_symtab (sym.symbol)); - if (symbol_to_sal (&sal, state->funfirstline, sym) + if (symbol_to_sal (&sal, state->funfirstline, sym.symbol) && maybe_add_address (state->addr_set, pspace, sal.pc)) add_sal_to_sals (state, &sals, &sal, - SYMBOL_NATURAL_NAME (sym), 0); + SYMBOL_NATURAL_NAME (sym.symbol), 0); } } else if (ls->function_symbols != NULL || ls->minimal_symbols != NULL) @@ -2255,11 +2258,11 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) /* Sort symbols so that symbols with the same program space are next to each other. */ qsort (ls->function_symbols->data (), ls->function_symbols->size (), - sizeof (symbol *), compare_symbols); - + sizeof (block_symbol), compare_symbols); for (const auto &sym : *ls->function_symbols) { - program_space *pspace = SYMTAB_PSPACE (symbol_symtab (sym)); + program_space *pspace + = SYMTAB_PSPACE (symbol_symtab (sym.symbol)); set_current_program_space (pspace); /* Don't skip to the first line of the function if we @@ -2270,10 +2273,10 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) if (state->funfirstline && ls->minimal_symbols != NULL - && SYMBOL_CLASS (sym) == LOC_BLOCK) + && SYMBOL_CLASS (sym.symbol) == LOC_BLOCK) { const CORE_ADDR addr - = BLOCK_START (SYMBOL_BLOCK_VALUE (sym)); + = BLOCK_START (SYMBOL_BLOCK_VALUE (sym.symbol)); for (const auto &elem : *ls->minimal_symbols) { @@ -2304,10 +2307,10 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) if (!found_ifunc) { symtab_and_line sal; - if (symbol_to_sal (&sal, state->funfirstline, sym) + if (symbol_to_sal (&sal, state->funfirstline, sym.symbol) && maybe_add_address (state->addr_set, pspace, sal.pc)) add_sal_to_sals (state, &sals, &sal, - SYMBOL_NATURAL_NAME (sym), 0); + SYMBOL_NATURAL_NAME (sym.symbol), 0); } } } @@ -2369,8 +2372,8 @@ convert_explicit_location_to_linespec (struct linespec_state *self, const char *label_name, struct line_offset line_offset) { - std::vector<symbol *> symbols; - std::vector<symbol *> *labels; + std::vector<block_symbol> symbols; + std::vector<block_symbol> *labels; std::vector<bound_minimal_symbol> minimal_symbols; result->explicit_loc.func_name_match_type = fname_match_type; @@ -2407,7 +2410,7 @@ convert_explicit_location_to_linespec (struct linespec_state *self, result->explicit_loc.function_name = xstrdup (function_name); result->function_symbols - = new std::vector<symbol *> (std::move (symbols)); + = new std::vector<block_symbol> (std::move (symbols)); result->minimal_symbols = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); } @@ -2424,7 +2427,7 @@ convert_explicit_location_to_linespec (struct linespec_state *self, result->explicit_loc.label_name = xstrdup (label_name); result->labels.label_symbols = labels; result->labels.function_symbols - = new std::vector<symbol *> (std::move (symbols)); + = new std::vector<block_symbol> (std::move (symbols)); } if (line_offset.sign != LINE_OFFSET_UNKNOWN) @@ -2894,8 +2897,8 @@ complete_label (completion_tracker &tracker, linespec_parser *parser, const char *label_name) { - std::vector<symbol *> label_function_symbols; - std::vector<symbol *> *labels + std::vector<block_symbol> label_function_symbols; + std::vector<block_symbol> *labels = find_label_symbols (PARSER_STATE (parser), PARSER_RESULT (parser)->function_symbols, &label_function_symbols, @@ -2905,7 +2908,7 @@ complete_label (completion_tracker &tracker, { for (const auto &label : *labels) { - char *match = xstrdup (SYMBOL_SEARCH_NAME (label)); + char *match = xstrdup (SYMBOL_SEARCH_NAME (label.symbol)); tracker.add_completion (gdb::unique_xmalloc_ptr<char> (match)); } delete labels; @@ -3018,7 +3021,7 @@ linespec_complete (completion_tracker &tracker, const char *text, const char *func_name = PARSER_EXPLICIT (&parser)->function_name; - std::vector<symbol *> function_symbols; + std::vector<block_symbol> function_symbols; std::vector<bound_minimal_symbol> minimal_symbols; find_linespec_symbols (PARSER_STATE (&parser), PARSER_RESULT (&parser)->file_symtabs, @@ -3026,7 +3029,7 @@ linespec_complete (completion_tracker &tracker, const char *text, &function_symbols, &minimal_symbols); PARSER_RESULT (&parser)->function_symbols - = new std::vector<symbol *> (std::move (function_symbols)); + = new std::vector<block_symbol> (std::move (function_symbols)); PARSER_RESULT (&parser)->minimal_symbols = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); @@ -3426,7 +3429,7 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) info.file_symtabs = &symtabs; - std::vector<symbol *> symbols; + std::vector<block_symbol> symbols; info.result.symbols = &symbols; std::vector<bound_minimal_symbol> minimal_symbols; info.result.minimal_symbols = &minimal_symbols; @@ -3448,7 +3451,8 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) saved_arg[new_argptr - arg] = '\0'; ls->explicit_loc.function_name = xstrdup (saved_arg); - ls->function_symbols = new std::vector<symbol *> (std::move (symbols)); + ls->function_symbols + = new std::vector<block_symbol> (std::move (symbols)); ls->minimal_symbols = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); values = convert_linespec_to_sals (self, ls); @@ -3500,13 +3504,13 @@ public: } /* Return all symbols collected. */ - std::vector<symbol *> release_symbols () + std::vector<block_symbol> release_symbols () { return m_symbols; } /* Callable as a symbol_found_callback_ftype callback. */ - bool operator () (symbol *sym); + bool operator () (block_symbol *bsym); private: /* A hash table of all symbols we found. We use this to avoid @@ -3514,14 +3518,15 @@ private: htab_t m_unique_syms; /* The result vector. */ - std::vector<symbol *> m_symbols; + std::vector<block_symbol> m_symbols; }; bool -decode_compound_collector::operator () (symbol *sym) +decode_compound_collector::operator () (block_symbol *bsym) { void **slot; struct type *t; + struct symbol *sym = bsym->symbol; if (SYMBOL_CLASS (sym) != LOC_TYPEDEF) return true; /* Continue iterating. */ @@ -3537,7 +3542,7 @@ decode_compound_collector::operator () (symbol *sym) if (!*slot) { *slot = sym; - m_symbols.push_back (sym); + m_symbols.push_back (*bsym); } return true; /* Continue iterating. */ @@ -3547,7 +3552,7 @@ decode_compound_collector::operator () (symbol *sym) /* Return any symbols corresponding to CLASS_NAME in FILE_SYMTABS. */ -static std::vector<symbol *> +static std::vector<block_symbol> lookup_prefix_sym (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *class_name) @@ -3588,20 +3593,22 @@ lookup_prefix_sym (struct linespec_state *state, static int compare_symbols (const void *a, const void *b) { - struct symbol * const *sa = (struct symbol * const*) a; - struct symbol * const *sb = (struct symbol * const*) b; + const struct block_symbol *ba = (const struct block_symbol *) a; + const struct block_symbol *bb = (const struct block_symbol *) b; + const struct symbol *sa = ba->symbol; + const struct symbol *sb = bb->symbol; uintptr_t uia, uib; - uia = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (*sa)); - uib = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (*sb)); + uia = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (sa)); + uib = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (sb)); if (uia < uib) return -1; if (uia > uib) return 1; - uia = (uintptr_t) *sa; - uib = (uintptr_t) *sb; + uia = (uintptr_t) sa; + uib = (uintptr_t) sb; if (uia < uib) return -1; @@ -3686,7 +3693,8 @@ find_superclass_methods (std::vector<struct type *> &&superclasses, static void find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, - std::vector<symbol *> *sym_classes, std::vector<symbol *> *symbols, + std::vector<block_symbol> *sym_classes, + std::vector<block_symbol> *symbols, std::vector<bound_minimal_symbol> *minsyms) { size_t last_result_len; @@ -3697,7 +3705,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, /* Sort symbols so that symbols with the same program space are next to each other. */ qsort (sym_classes->data (), sym_classes->size (), - sizeof (symbol *), compare_symbols); + sizeof (block_symbol), compare_symbols); info.state = self; info.file_symtabs = file_symtabs; @@ -3715,10 +3723,11 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, what to do. */ last_result_len = 0; unsigned int ix = 0; - for (const auto &sym : *sym_classes) + for (const auto &elt : *sym_classes) { struct type *t; struct program_space *pspace; + struct symbol *sym = elt.symbol; /* Program spaces that are executing startup should have been filtered out earlier. */ @@ -3733,7 +3742,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, sure not to miss the last batch. */ if (ix == sym_classes->size () - 1 || (pspace - != SYMTAB_PSPACE (symbol_symtab (sym_classes->at (ix + 1))))) + != SYMTAB_PSPACE (symbol_symtab (sym_classes->at (ix + 1).symbol)))) { /* If we did not find a direct implementation anywhere in this program space, consider superclasses. */ @@ -3884,7 +3893,7 @@ static void find_function_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, - std::vector<symbol *> *symbols, + std::vector<block_symbol> *symbols, std::vector<bound_minimal_symbol> *minsyms) { struct collect_info info; @@ -3913,7 +3922,7 @@ find_linespec_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *lookup_name, symbol_name_match_type name_match_type, - std::vector <symbol *> *symbols, + std::vector <block_symbol> *symbols, std::vector<bound_minimal_symbol> *minsyms) { std::string canon = cp_canonicalize_string_no_typedefs (lookup_name); @@ -3967,7 +3976,7 @@ find_linespec_symbols (struct linespec_state *state, method = last; /* Find a list of classes named KLASS. */ - std::vector<symbol *> classes + std::vector<block_symbol> classes = lookup_prefix_sym (state, file_symtabs, klass.c_str ()); if (!classes.empty ()) { @@ -4002,8 +4011,8 @@ static void find_label_symbols_in_block (const struct block *block, const char *name, struct symbol *fn_sym, bool completion_mode, - std::vector<symbol *> *result, - std::vector<symbol *> *label_funcs_ret) + std::vector<block_symbol> *result, + std::vector<block_symbol> *label_funcs_ret) { if (completion_mode) { @@ -4020,19 +4029,20 @@ find_label_symbols_in_block (const struct block *block, SYMBOL_DOMAIN (sym), LABEL_DOMAIN) && cmp (SYMBOL_SEARCH_NAME (sym), name, name_len) == 0) { - result->push_back (sym); - label_funcs_ret->push_back (fn_sym); + result->push_back ({sym, block}); + label_funcs_ret->push_back ({fn_sym, block}); } } } else { - struct symbol *sym = lookup_symbol (name, block, LABEL_DOMAIN, 0).symbol; + struct block_symbol label_sym + = lookup_symbol (name, block, LABEL_DOMAIN, 0); - if (sym != NULL) + if (label_sym.symbol != NULL) { - result->push_back (sym); - label_funcs_ret->push_back (fn_sym); + result->push_back (label_sym); + label_funcs_ret->push_back ({fn_sym, block}); } } } @@ -4045,15 +4055,17 @@ find_label_symbols_in_block (const struct block *block, interpreted as a label name prefix. Otherwise, only labels named exactly NAME match. */ -static std::vector<symbol *> * + +static std::vector<block_symbol> * find_label_symbols (struct linespec_state *self, - std::vector<symbol *> *function_symbols, - std::vector<symbol *> *label_funcs_ret, const char *name, + std::vector<block_symbol> *function_symbols, + std::vector<block_symbol> *label_funcs_ret, + const char *name, bool completion_mode) { const struct block *block; struct symbol *fn_sym; - std::vector<symbol *> result; + std::vector<block_symbol> result; if (function_symbols == NULL) { @@ -4075,16 +4087,17 @@ find_label_symbols (struct linespec_state *self, { for (const auto &elt : *function_symbols) { - set_current_program_space (SYMTAB_PSPACE (symbol_symtab (elt))); - block = SYMBOL_BLOCK_VALUE (elt); + fn_sym = elt.symbol; + set_current_program_space (SYMTAB_PSPACE (symbol_symtab (fn_sym))); + block = SYMBOL_BLOCK_VALUE (fn_sym); - find_label_symbols_in_block (block, name, elt, completion_mode, + find_label_symbols_in_block (block, name, fn_sym, completion_mode, &result, label_funcs_ret); } } if (!result.empty ()) - return new std::vector<symbol *> (std::move (result)); + return new std::vector<block_symbol> (std::move (result)); return nullptr; } @@ -4429,8 +4442,9 @@ add_matching_symbols_to_info (const char *name, { iterate_over_all_matching_symtabs (info->state, lookup_name, VAR_DOMAIN, search_domain, - pspace, true, [&] (symbol *sym) - { return info->add_symbol (sym); }); + pspace, true, + [&] (block_symbol *bsym) + { return info->add_symbol (bsym); }); search_minsyms_for_name (info, lookup_name, pspace, NULL); } else if (pspace == NULL || pspace == SYMTAB_PSPACE (elt)) @@ -4442,8 +4456,8 @@ add_matching_symbols_to_info (const char *name, gdb_assert (!SYMTAB_PSPACE (elt)->executing_startup); set_current_program_space (SYMTAB_PSPACE (elt)); iterate_over_file_blocks (elt, lookup_name, VAR_DOMAIN, - [&] (symbol *sym) - { return info->add_symbol (sym); }); + [&] (block_symbol *bsym) + { return info->add_symbol (bsym); }); /* If no new symbols were found in this iteration and this symtab is in assembler, we might actually be looking for a label for diff --git a/gdb/symtab.c b/gdb/symtab.c index 73c79833ce..5a8cfa20b8 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -2860,7 +2860,9 @@ iterate_over_symbols (const struct block *block, if (symbol_matches_domain (SYMBOL_LANGUAGE (sym), SYMBOL_DOMAIN (sym), domain)) { - if (!callback (sym)) + struct block_symbol block_sym = {sym, block}; + + if (!callback (&block_sym)) return; } } diff --git a/gdb/symtab.h b/gdb/symtab.h index 0b155d0659..da498cdb95 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -2073,7 +2073,7 @@ std::vector<CORE_ADDR> find_pcs_for_symtab_line true to indicate that LA_ITERATE_OVER_SYMBOLS should continue iterating, or false to indicate that the iteration should end. */ -typedef bool (symbol_found_callback_ftype) (symbol *sym); +typedef bool (symbol_found_callback_ftype) (struct block_symbol *bsym); void iterate_over_symbols (const struct block *block, const lookup_name_info &name, -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 7/9] Use block_symbol_d in linespec APIs 2018-08-10 23:31 ` [PATCH 7/9] Use block_symbol_d in linespec APIs Keith Seitz @ 2018-08-11 15:05 ` Tom Tromey 2018-08-17 18:04 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-11 15:05 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch changes the linespec.c APIs to use block_symbol instead of just Keith> a symbol. lookup_symbol et al already return block_symbol's. Thanks again for the patches. The subject of this patch mentions block_symbol_d but the patch itself is just using block_symbol. Otherwise, this looks good to me, thanks. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 7/9] Use block_symbol_d in linespec APIs 2018-08-11 15:05 ` Tom Tromey @ 2018-08-17 18:04 ` Keith Seitz 0 siblings, 0 replies; 45+ messages in thread From: Keith Seitz @ 2018-08-17 18:04 UTC (permalink / raw) To: Tom Tromey; +Cc: gdb-patches On 08/11/2018 08:05 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: > > Keith> This patch changes the linespec.c APIs to use block_symbol instead of just > Keith> a symbol. lookup_symbol et al already return block_symbol's. > > Thanks again for the patches. > > The subject of this patch mentions block_symbol_d but the patch itself > is just using block_symbol. Bah. Yeah, that's just an old patch name. I've fixed that locally. Thank you for the review. Keith ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 6/9] Remove VEC definitions from linespec.c 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz ` (3 preceding siblings ...) 2018-08-10 23:31 ` [PATCH 7/9] Use block_symbol_d in linespec APIs Keith Seitz @ 2018-08-10 23:31 ` Keith Seitz 2018-08-11 15:03 ` Tom Tromey 2018-08-10 23:32 ` [PATCH 5/9] Change decode_compound_collector to use std::vector Keith Seitz ` (3 subsequent siblings) 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:31 UTC (permalink / raw) To: gdb-patches Since they are now no longer necessary, this patch removes the typedefs and VEC definitions for bound_minimal_symbol_d and symbolp. gdb/ChangeLog: * linespec.c (symbolp): Remove typedef and VEC definitions. (bound_minimal_symbol_d): Likewise. --- gdb/ChangeLog | 5 +++++ gdb/linespec.c | 7 ------- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8e0bbd9a9f..8bd7ac01df 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (symbolp): Remove typedef and VEC definitions. + (bound_minimal_symbol_d): Likewise. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (decode_compound_collector::decode_compound_collector): Remove initialization for `m_symtabs'. (decode_compound_collector::release_symbols): Change return type diff --git a/gdb/linespec.c b/gdb/linespec.c index c3e5f484b8..dea02381b9 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -81,9 +81,6 @@ enum class linespec_complete_what typedef std::unique_ptr<std::vector<symtab *>> symtab_vector_up; -typedef struct symbol *symbolp; -DEF_VEC_P (symbolp); - /* An address entry is used to ensure that any given location is only added to the result a single time. It holds an address and the program space from which the address came. */ @@ -94,10 +91,6 @@ struct address_entry CORE_ADDR addr; }; -typedef struct bound_minimal_symbol bound_minimal_symbol_d; - -DEF_VEC_O (bound_minimal_symbol_d); - /* A linespec. Elements of this structure are filled in by a parser (either parse_linespec or some other function). The structure is then converted into SALs by convert_linespec_to_sals. */ -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 6/9] Remove VEC definitions from linespec.c 2018-08-10 23:31 ` [PATCH 6/9] Remove VEC definitions from linespec.c Keith Seitz @ 2018-08-11 15:03 ` Tom Tromey 0 siblings, 0 replies; 45+ messages in thread From: Tom Tromey @ 2018-08-11 15:03 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> Since they are now no longer necessary, this patch removes the typedefs Keith> and VEC definitions for bound_minimal_symbol_d and symbolp. Keith> gdb/ChangeLog: Keith> * linespec.c (symbolp): Remove typedef and VEC definitions. Keith> (bound_minimal_symbol_d): Likewise. Nice. This is ok. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 5/9] Change decode_compound_collector to use std::vector 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz ` (4 preceding siblings ...) 2018-08-10 23:31 ` [PATCH 6/9] Remove VEC definitions from linespec.c Keith Seitz @ 2018-08-10 23:32 ` Keith Seitz 2018-08-11 15:02 ` Tom Tromey 2018-08-10 23:32 ` [PATCH 9/9] C++ compile support Keith Seitz ` (2 subsequent siblings) 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:32 UTC (permalink / raw) To: gdb-patches This patch changes decode_compound_collector to use std::vector instead of VEC, eliminating a cleanup in the process. gdb/ChangeLog: * linespec.c (decode_compound_collector::decode_compound_collector): Remove initialization for `m_symtabs'. (decode_compound_collector::release_symbols): Change return type to std::vector. Update all callers. (class decode_compound_collector) <m_symbols>: Change type to std::vector. (lookup_prefix_sym): Change return type to std::vector. Update all callers. (find_method): Change `sym_classes' parameter to std::vector. Update all callers. (find_linespec_symbols): Remove cleanup. --- gdb/ChangeLog | 14 ++++++++++++++ gdb/linespec.c | 47 ++++++++++++++++++----------------------------- 2 files changed, 32 insertions(+), 29 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f762196cbc..8e0bbd9a9f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,19 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (decode_compound_collector::decode_compound_collector): + Remove initialization for `m_symtabs'. + (decode_compound_collector::release_symbols): Change return type + to std::vector. Update all callers. + (class decode_compound_collector) <m_symbols>: Change type to + std::vector. + (lookup_prefix_sym): Change return type to std::vector. Update all + callers. + (find_method): Change `sym_classes' parameter to std::vector. + Update all callers. + (find_linespec_symbols): Remove cleanup. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <minimal_symbols>: Change type to std::vector. Update all users. (struct collect_info) <minimal_symbols>: Likewise. diff --git a/gdb/linespec.c b/gdb/linespec.c index bc20001df9..c3e5f484b8 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -3494,7 +3494,6 @@ class decode_compound_collector { public: decode_compound_collector () - : m_symbols (NULL) { m_unique_syms = htab_create_alloc (1, htab_hash_pointer, htab_eq_pointer, NULL, @@ -3507,12 +3506,10 @@ public: htab_delete (m_unique_syms); } - /* Releases ownership of the collected symbols and returns them. */ - VEC (symbolp) *release_symbols () + /* Return all symbols collected. */ + std::vector<symbol *> release_symbols () { - VEC (symbolp) *res = m_symbols; - m_symbols = NULL; - return res; + return m_symbols; } /* Callable as a symbol_found_callback_ftype callback. */ @@ -3524,7 +3521,7 @@ private: htab_t m_unique_syms; /* The result vector. */ - VEC (symbolp) *m_symbols; + std::vector<symbol *> m_symbols; }; bool @@ -3547,7 +3544,7 @@ decode_compound_collector::operator () (symbol *sym) if (!*slot) { *slot = sym; - VEC_safe_push (symbolp, m_symbols, sym); + m_symbols.push_back (sym); } return true; /* Continue iterating. */ @@ -3557,7 +3554,7 @@ decode_compound_collector::operator () (symbol *sym) /* Return any symbols corresponding to CLASS_NAME in FILE_SYMTABS. */ -static VEC (symbolp) * +static std::vector<symbol *> lookup_prefix_sym (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *class_name) @@ -3696,11 +3693,9 @@ find_superclass_methods (std::vector<struct type *> &&superclasses, static void find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, - VEC (symbolp) *sym_classes, std::vector<symbol *> *symbols, + std::vector<symbol *> *sym_classes, std::vector<symbol *> *symbols, std::vector<bound_minimal_symbol> *minsyms) { - struct symbol *sym; - int ix; size_t last_result_len; std::vector<struct type *> superclass_vec; std::vector<const char *> result_names; @@ -3708,10 +3703,8 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, /* Sort symbols so that symbols with the same program space are next to each other. */ - qsort (VEC_address (symbolp, sym_classes), - VEC_length (symbolp, sym_classes), - sizeof (symbolp), - compare_symbols); + qsort (sym_classes->data (), sym_classes->size (), + sizeof (symbol *), compare_symbols); info.state = self; info.file_symtabs = file_symtabs; @@ -3728,7 +3721,8 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, because we collect data across the program space before deciding what to do. */ last_result_len = 0; - for (ix = 0; VEC_iterate (symbolp, sym_classes, ix, sym); ++ix) + unsigned int ix = 0; + for (const auto &sym : *sym_classes) { struct type *t; struct program_space *pspace; @@ -3744,10 +3738,9 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, /* Handle all items from a single program space at once; and be sure not to miss the last batch. */ - if (ix == VEC_length (symbolp, sym_classes) - 1 + if (ix == sym_classes->size () - 1 || (pspace - != SYMTAB_PSPACE (symbol_symtab (VEC_index (symbolp, sym_classes, - ix + 1))))) + != SYMTAB_PSPACE (symbol_symtab (sym_classes->at (ix + 1))))) { /* If we did not find a direct implementation anywhere in this program space, consider superclasses. */ @@ -3763,6 +3756,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, superclass_vec.clear (); last_result_len = result_names.size (); + ++ix; } } @@ -3952,7 +3946,6 @@ find_linespec_symbols (struct linespec_state *state, { std::string klass, method; const char *last, *p, *scope_op; - VEC (symbolp) *classes; /* See if we can find a scope operator and break this symbol name into namespaces${SCOPE_OPERATOR}class_name and method_name. */ @@ -3981,18 +3974,16 @@ find_linespec_symbols (struct linespec_state *state, method = last; /* Find a list of classes named KLASS. */ - classes = lookup_prefix_sym (state, file_symtabs, klass.c_str ()); - struct cleanup *old_chain - = make_cleanup (VEC_cleanup (symbolp), &classes); - - if (!VEC_empty (symbolp, classes)) + std::vector<symbol *> classes + = lookup_prefix_sym (state, file_symtabs, klass.c_str ()); + if (!classes.empty ()) { /* Now locate a list of suitable methods named METHOD. */ TRY { find_method (state, file_symtabs, klass.c_str (), method.c_str (), - classes, symbols, minsyms); + &classes, symbols, minsyms); } /* If successful, we're done. If NOT_FOUND_ERROR @@ -4004,8 +3995,6 @@ find_linespec_symbols (struct linespec_state *state, } END_CATCH } - - do_cleanups (old_chain); } } -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 5/9] Change decode_compound_collector to use std::vector 2018-08-10 23:32 ` [PATCH 5/9] Change decode_compound_collector to use std::vector Keith Seitz @ 2018-08-11 15:02 ` Tom Tromey 2018-08-17 18:04 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-11 15:02 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch changes decode_compound_collector to use std::vector instead of Keith> VEC, eliminating a cleanup in the process. Keith> - /* Releases ownership of the collected symbols and returns them. */ Keith> - VEC (symbolp) *release_symbols () Keith> + /* Return all symbols collected. */ Keith> + std::vector<symbol *> release_symbols () Keith> { Keith> - VEC (symbolp) *res = m_symbols; Keith> - m_symbols = NULL; Keith> - return res; Keith> + return m_symbols; Keith> } Won't this end up copying m_symbols? Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 5/9] Change decode_compound_collector to use std::vector 2018-08-11 15:02 ` Tom Tromey @ 2018-08-17 18:04 ` Keith Seitz 2018-08-20 1:20 ` Simon Marchi 2018-08-28 17:46 ` Tom Tromey 0 siblings, 2 replies; 45+ messages in thread From: Keith Seitz @ 2018-08-17 18:04 UTC (permalink / raw) To: Tom Tromey; +Cc: gdb-patches On 08/11/2018 08:02 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: > > Keith> This patch changes decode_compound_collector to use std::vector instead of > Keith> VEC, eliminating a cleanup in the process. > > Keith> - /* Releases ownership of the collected symbols and returns them. */ > Keith> - VEC (symbolp) *release_symbols () > Keith> + /* Return all symbols collected. */ > Keith> + std::vector<symbol *> release_symbols () > Keith> { > Keith> - VEC (symbolp) *res = m_symbols; > Keith> - m_symbols = NULL; > Keith> - return res; > Keith> + return m_symbols; > Keith> } > > Won't this end up copying m_symbols? Yup. Forgot to move the return value (which would also clear/reset m_symbols as expected today). This patch has one additional change over v1: the final qsort is replaced with std::sort and the temporary std_compare_symbol function replaces the qsort-oriented compare_symbol function (mentioned in a previous patch email). Keith Subject: [PATCH] Change decode_compound_collector to use std::vector This patch changes decode_compound_collector to use std::vector instead of VEC, eliminating a cleanup in the process. gdb/ChangeLog: * linespec.c (decode_compound_collector::decode_compound_collector): Remove initialization for `m_symtabs'. (decode_compound_collector::release_symbols): Change return type to std::vector. Update all callers. (class decode_compound_collector) <m_symbols>: Change type to std::vector. (lookup_prefix_sym): Change return type to std::vector. Update all callers. (compare_symbols): Remove. (std_compare_symbols): Rename to `compare_symbols'. (find_method): Change `sym_classes' parameter to std::vector. Update all callers. Use std::sort to sort sym_classes. (find_linespec_symbols): Remove cleanup. --- gdb/ChangeLog | 16 +++++++++++ gdb/linespec.c | 85 +++++++++++++++------------------------------------------- 2 files changed, 37 insertions(+), 64 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a94e1cdd68..d81e6f0fbd 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,21 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (decode_compound_collector::decode_compound_collector): + Remove initialization for `m_symtabs'. + (decode_compound_collector::release_symbols): Change return type + to std::vector. Update all callers. + (class decode_compound_collector) <m_symbols>: Change type to + std::vector. + (lookup_prefix_sym): Change return type to std::vector. Update all + callers. + (compare_symbols): Remove. + (std_compare_symbols): Rename to `compare_symbols'. + (find_method): Change `sym_classes' parameter to std::vector. + Update all callers. Use std::sort to sort sym_classes. + (find_linespec_symbols): Remove cleanup. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <minimal_symbols>: Change type to std::vector. Update all users. (convert_linespec_to_sals): Use std::sort to sort minimal symbols. diff --git a/gdb/linespec.c b/gdb/linespec.c index e7e19cab67..926fbb868f 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -400,9 +400,7 @@ static void minsym_found (struct linespec_state *self, struct objfile *objfile, struct minimal_symbol *msymbol, std::vector<symtab_and_line> *result); -static int compare_symbols (const void *a, const void *b); -static bool std_compare_symbols (const struct symbol *a, - const struct symbol *b); +static bool compare_symbols (const struct symbol *a, const struct symbol *b); static bool compare_msymbols (const bound_minimal_symbol &a, const bound_minimal_symbol &b); @@ -2266,7 +2264,7 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) to each other. */ std::sort (ls->function_symbols->begin (), ls->function_symbols->end (), - std_compare_symbols); + compare_symbols); for (const auto &sym : *ls->function_symbols) { @@ -3501,7 +3499,6 @@ class decode_compound_collector { public: decode_compound_collector () - : m_symbols (NULL) { m_unique_syms = htab_create_alloc (1, htab_hash_pointer, htab_eq_pointer, NULL, @@ -3514,12 +3511,10 @@ public: htab_delete (m_unique_syms); } - /* Releases ownership of the collected symbols and returns them. */ - VEC (symbolp) *release_symbols () + /* Return all symbols collected. */ + std::vector<symbol *> release_symbols () { - VEC (symbolp) *res = m_symbols; - m_symbols = NULL; - return res; + return std::move (m_symbols); } /* Callable as a symbol_found_callback_ftype callback. */ @@ -3531,7 +3526,7 @@ private: htab_t m_unique_syms; /* The result vector. */ - VEC (symbolp) *m_symbols; + std::vector<symbol *> m_symbols; }; bool @@ -3554,7 +3549,7 @@ decode_compound_collector::operator () (symbol *sym) if (!*slot) { *slot = sym; - VEC_safe_push (symbolp, m_symbols, sym); + m_symbols.push_back (sym); } return true; /* Continue iterating. */ @@ -3564,7 +3559,7 @@ decode_compound_collector::operator () (symbol *sym) /* Return any symbols corresponding to CLASS_NAME in FILE_SYMTABS. */ -static VEC (symbolp) * +static std::vector<symbol *> lookup_prefix_sym (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *class_name) @@ -3603,7 +3598,7 @@ lookup_prefix_sym (struct linespec_state *state, symbols with the same program space end up next to each other. */ static bool -std_compare_symbols (const struct symbol *a, const struct symbol *b) +compare_symbols (const struct symbol *a, const struct symbol *b) { uintptr_t uia, uib; @@ -3624,36 +3619,6 @@ std_compare_symbols (const struct symbol *a, const struct symbol *b) return false; } -/* A qsort comparison function for symbols. The resulting order does - not actually matter; we just need to be able to sort them so that - symbols with the same program space end up next to each other. */ - -static int -compare_symbols (const void *a, const void *b) -{ - struct symbol * const *sa = (struct symbol * const*) a; - struct symbol * const *sb = (struct symbol * const*) b; - uintptr_t uia, uib; - - uia = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (*sa)); - uib = (uintptr_t) SYMTAB_PSPACE (symbol_symtab (*sb)); - - if (uia < uib) - return -1; - if (uia > uib) - return 1; - - uia = (uintptr_t) *sa; - uib = (uintptr_t) *sb; - - if (uia < uib) - return -1; - if (uia > uib) - return 1; - - return 0; -} - /* Like compare_symbols but for minimal symbols. */ static bool @@ -3723,11 +3688,9 @@ find_superclass_methods (std::vector<struct type *> &&superclasses, static void find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, - VEC (symbolp) *sym_classes, std::vector<symbol *> *symbols, + std::vector<symbol *> *sym_classes, std::vector<symbol *> *symbols, std::vector<bound_minimal_symbol> *minsyms) { - struct symbol *sym; - int ix; size_t last_result_len; std::vector<struct type *> superclass_vec; std::vector<const char *> result_names; @@ -3735,10 +3698,8 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, /* Sort symbols so that symbols with the same program space are next to each other. */ - qsort (VEC_address (symbolp, sym_classes), - VEC_length (symbolp, sym_classes), - sizeof (symbolp), - compare_symbols); + std::sort (sym_classes->begin (), sym_classes->end (), + compare_symbols); info.state = self; info.file_symtabs = file_symtabs; @@ -3755,7 +3716,8 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, because we collect data across the program space before deciding what to do. */ last_result_len = 0; - for (ix = 0; VEC_iterate (symbolp, sym_classes, ix, sym); ++ix) + unsigned int ix = 0; + for (const auto &sym : *sym_classes) { struct type *t; struct program_space *pspace; @@ -3771,10 +3733,9 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, /* Handle all items from a single program space at once; and be sure not to miss the last batch. */ - if (ix == VEC_length (symbolp, sym_classes) - 1 + if (ix == sym_classes->size () - 1 || (pspace - != SYMTAB_PSPACE (symbol_symtab (VEC_index (symbolp, sym_classes, - ix + 1))))) + != SYMTAB_PSPACE (symbol_symtab (sym_classes->at (ix + 1))))) { /* If we did not find a direct implementation anywhere in this program space, consider superclasses. */ @@ -3790,6 +3751,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, superclass_vec.clear (); last_result_len = result_names.size (); + ++ix; } } @@ -3976,7 +3938,6 @@ find_linespec_symbols (struct linespec_state *state, { std::string klass, method; const char *last, *p, *scope_op; - VEC (symbolp) *classes; /* See if we can find a scope operator and break this symbol name into namespaces${SCOPE_OPERATOR}class_name and method_name. */ @@ -4005,18 +3966,16 @@ find_linespec_symbols (struct linespec_state *state, method = last; /* Find a list of classes named KLASS. */ - classes = lookup_prefix_sym (state, file_symtabs, klass.c_str ()); - struct cleanup *old_chain - = make_cleanup (VEC_cleanup (symbolp), &classes); - - if (!VEC_empty (symbolp, classes)) + std::vector<symbol *> classes + = lookup_prefix_sym (state, file_symtabs, klass.c_str ()); + if (!classes.empty ()) { /* Now locate a list of suitable methods named METHOD. */ TRY { find_method (state, file_symtabs, klass.c_str (), method.c_str (), - classes, symbols, minsyms); + &classes, symbols, minsyms); } /* If successful, we're done. If NOT_FOUND_ERROR @@ -4028,8 +3987,6 @@ find_linespec_symbols (struct linespec_state *state, } END_CATCH } - - do_cleanups (old_chain); } } -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 5/9] Change decode_compound_collector to use std::vector 2018-08-17 18:04 ` Keith Seitz @ 2018-08-20 1:20 ` Simon Marchi 2018-08-20 13:28 ` Tom Tromey 2018-08-28 17:46 ` Tom Tromey 1 sibling, 1 reply; 45+ messages in thread From: Simon Marchi @ 2018-08-20 1:20 UTC (permalink / raw) To: Keith Seitz; +Cc: Tom Tromey, gdb-patches On 2018-08-17 14:04, Keith Seitz wrote: > @@ -3514,12 +3511,10 @@ public: > htab_delete (m_unique_syms); > } > > - /* Releases ownership of the collected symbols and returns them. */ > - VEC (symbolp) *release_symbols () > + /* Return all symbols collected. */ > + std::vector<symbol *> release_symbols () > { > - VEC (symbolp) *res = m_symbols; > - m_symbols = NULL; > - return res; > + return std::move (m_symbols); I've always read that it was bad to use std::move on a return value: https://diego.assencio.com/?index=f57f25fd5a187c70fc7f34fcf5374773 though in this case it seems like the right thing to do. Simon ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 5/9] Change decode_compound_collector to use std::vector 2018-08-20 1:20 ` Simon Marchi @ 2018-08-20 13:28 ` Tom Tromey 2018-08-20 14:03 ` Simon Marchi 0 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-20 13:28 UTC (permalink / raw) To: Simon Marchi; +Cc: Keith Seitz, Tom Tromey, gdb-patches >>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes: Simon> I've always read that it was bad to use std::move on a return value: Simon> https://diego.assencio.com/?index=f57f25fd5a187c70fc7f34fcf5374773 Simon> though in this case it seems like the right thing to do. It would be nice if gcc warned when a std::move was either redundant or recommended. Maybe this is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86981 ... I thought I heard that clang 8 has a new warning in this area but I couldn't find it anywhere online, only a hint here: https://bugzilla.mozilla.org/show_bug.cgi?id=1483985 So I'm not really sure how to file this. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 5/9] Change decode_compound_collector to use std::vector 2018-08-20 13:28 ` Tom Tromey @ 2018-08-20 14:03 ` Simon Marchi 0 siblings, 0 replies; 45+ messages in thread From: Simon Marchi @ 2018-08-20 14:03 UTC (permalink / raw) To: Tom Tromey; +Cc: Keith Seitz, gdb-patches On 2018-08-20 09:28, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes: > > Simon> I've always read that it was bad to use std::move on a return > value: > Simon> > https://diego.assencio.com/?index=f57f25fd5a187c70fc7f34fcf5374773 > Simon> though in this case it seems like the right thing to do. > > It would be nice if gcc warned when a std::move was either redundant or > recommended. Maybe this is > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86981 > > ... I thought I heard that clang 8 has a new warning in this area but I > couldn't find it anywhere online, only a hint here: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1483985 > > So I'm not really sure how to file this. > > Tom Ah ok, but at least the wording of the warning confirms that this case here is fine: moving a local object in a return statement prevents copy elision Here, we are not moving a local object. Simon ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 5/9] Change decode_compound_collector to use std::vector 2018-08-17 18:04 ` Keith Seitz 2018-08-20 1:20 ` Simon Marchi @ 2018-08-28 17:46 ` Tom Tromey 1 sibling, 0 replies; 45+ messages in thread From: Tom Tromey @ 2018-08-28 17:46 UTC (permalink / raw) To: Keith Seitz; +Cc: Tom Tromey, gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: >> Won't this end up copying m_symbols? Keith> Yup. Forgot to move the return value (which would also clear/reset m_symbols Keith> as expected today). Keith> This patch has one additional change over v1: the final qsort is replaced with Keith> std::sort and the temporary std_compare_symbol function replaces the Keith> qsort-oriented compare_symbol function (mentioned in a previous patch email). Thanks, this is ok. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 9/9] C++ compile support 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz ` (5 preceding siblings ...) 2018-08-10 23:32 ` [PATCH 5/9] Change decode_compound_collector to use std::vector Keith Seitz @ 2018-08-10 23:32 ` Keith Seitz 2018-08-11 7:22 ` Eli Zaretskii ` (2 more replies) 2018-08-10 23:32 ` [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures Keith Seitz 2018-08-10 23:34 ` [PATCH 8/9] Add new search_symbols_multiple API Keith Seitz 8 siblings, 3 replies; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:32 UTC (permalink / raw) To: gdb-patches This patch adds *basic* support for C++ to the compile feature. It does most simple type conversions, including everything that C compile does and your basic "with-classes" type of C++. I've written a new compile-support.exp support file which adds a new test facility for automating and simplifying "compile print" vs "compile code" testing. See testsuite/lib/compile-support.exp and CompileExpression for more on that. The tests use this facility extensively. This initial support has several glaring omissions: - No template support at all I have follow-on patches for this, but they add much complexity to this "basic" support. Consequently, they will be submitted separately. - Cannot print functions The code template needs tweaking, and I simply haven't gotten to it yet. - So-called "special function" support is not included Using constructors, destructors, operators, etc will not work. I have follow-on patches for that, but they require some work because of the recent churn in symbol searching. - There are several test suite references to "compile/1234" bugs. I will file bugs and update the test suite's bug references before pushing these patches. The test suite started as a copy of the original C-language support, but I have written tests to exercise the basic functionality of the plug-in. Debug options have been expanded a bit. I've added options for outputting debug messages for the oracle and C++ type-conversion. These are the "debug compile-oracle" and "debug compile-cplus-types" options. gdb/ChangeLog: * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Add compile-cplus-support.c, compile-cplus-symbols.c, and compile-cplus-types.c. (HFILES_NO_SRCDIR): Add gcc-cp-plugin.h. * c-lang.c (cplus_language_defn): Set C++ compile functions. * c-lang.h (cplus_get_compile_context, cplus_compute_program): Declare. * compile/compile-c-support.c: Include compile-cplus.h. (load_libcompile): Templatize. (get_compile_context): "New" function. (c_get_compile_context): Use get_compile_context. (cplus_get_compile_context): New function. (cplus_push_user_expression, cplus_pop_user_expression) (cplus_add_code_header, cplus_add_input, cplus_compile_program) (cplus_compute_program): Define new structs/functions. * compile/compile-cplus-support.c: New file. * compile/compile-cplus-symmbols.c: New file. * compile/compile-cplus-types.c: New file. * compile/compile-cplus.h: New file. * compile/compile-internal.h (debug_compile_oracle, GCC_TYPE_NONE): Declare. * compile/compile-object-load.c (get_out_value_type): Use strncmp_iw when comparing symbol names. (compile_object_load): Add mst_bss and mst_data. * compile/compile.c (_initialize_compile): Remove -Wno-implicit-function-declaration from `compile_args'. * compile/gcc-cp-plugin.h: New file. * NEWS: Mention C++ compile support and new debug options. gdb/testsuite/ChangeLog: * gdb.compile/compile-cplus-anonymous.cc: New file. * gdb.compile/compile-cplus-anonymous.exp: New file. * gdb.compile/compile-cplus-array-decay.cc: New file. * gdb.compile/compile-cplus-array-decay.exp: New file. * gdb.compile/compile-cplus-inherit.cc: New file. * gdb.compile/compile-cplus-inherit.exp: New file. * gdb.compile/compile-cplus-member.cc: New file. * gdb.compile/compile-cplus-member.exp: New file. * gdb.compile/compile-cplus-method.cc: New file. * gdb.compile/compile-cplus-method.exp: New file. * gdb.compile/compile-cplus-mod.c: "New" file. * gdb.compile/compile-cplus-namespace.cc: New file. * gdb.compile/compile-cplus-namespace.exp: New file. * gdb.compile/compile-cplus-nested.cc: New file. * gdb.compile/compile-cplus-nested.exp: New file. * gdb.compile/compile-cplus-print.c: "New" file. * gdb.compile/compile-cplus-print.exp: "New" file. * gdb.compile/compile-cplus-virtual.cc: New file. * gdb.compile/compile-cplus-virtual.exp: New file. * gdb.compile/compile-cplus.c: "New" file. * gdb.compile/compile-cplus.exp: "New" file. * lib/compile-support.exp: New file. doc/ChangeLog: * gdb.texinfo (Compiling and injecting code in GDB): Document set/show "compile-oracle" and "compile-cplus-types" commands. --- gdb/ChangeLog | 30 + gdb/Makefile.in | 5 + gdb/NEWS | 14 + gdb/c-lang.c | 4 +- gdb/c-lang.h | 19 + gdb/compile/compile-c-support.c | 205 ++- gdb/compile/compile-cplus-support.c | 30 + gdb/compile/compile-cplus-symbols.c | 511 +++++++ gdb/compile/compile-cplus-types.c | 1430 ++++++++++++++++++++ gdb/compile/compile-cplus.h | 207 +++ gdb/compile/compile-internal.h | 8 + gdb/compile/compile-object-load.c | 7 +- gdb/compile/compile.c | 1 - gdb/compile/gcc-cp-plugin.h | 85 ++ gdb/doc/ChangeLog | 5 + gdb/doc/gdb.texinfo | 20 + gdb/testsuite/ChangeLog | 25 + .../gdb.compile/compile-cplus-anonymous.cc | 76 ++ .../gdb.compile/compile-cplus-anonymous.exp | 64 + .../gdb.compile/compile-cplus-array-decay.cc | 31 + .../gdb.compile/compile-cplus-array-decay.exp | 50 + gdb/testsuite/gdb.compile/compile-cplus-inherit.cc | 58 + .../gdb.compile/compile-cplus-inherit.exp | 53 + gdb/testsuite/gdb.compile/compile-cplus-member.cc | 83 ++ gdb/testsuite/gdb.compile/compile-cplus-member.exp | 77 ++ gdb/testsuite/gdb.compile/compile-cplus-method.cc | 91 ++ gdb/testsuite/gdb.compile/compile-cplus-method.exp | 67 + gdb/testsuite/gdb.compile/compile-cplus-mod.c | 28 + .../gdb.compile/compile-cplus-namespace.cc | 52 + .../gdb.compile/compile-cplus-namespace.exp | 51 + gdb/testsuite/gdb.compile/compile-cplus-nested.cc | 58 + gdb/testsuite/gdb.compile/compile-cplus-nested.exp | 53 + gdb/testsuite/gdb.compile/compile-cplus-print.c | 32 + gdb/testsuite/gdb.compile/compile-cplus-print.exp | 81 ++ gdb/testsuite/gdb.compile/compile-cplus-virtual.cc | 54 + .../gdb.compile/compile-cplus-virtual.exp | 71 + gdb/testsuite/gdb.compile/compile-cplus.c | 241 ++++ gdb/testsuite/gdb.compile/compile-cplus.exp | 341 +++++ gdb/testsuite/lib/compile-support.exp | 227 ++++ 39 files changed, 4515 insertions(+), 30 deletions(-) create mode 100644 gdb/compile/compile-cplus-support.c create mode 100644 gdb/compile/compile-cplus-symbols.c create mode 100644 gdb/compile/compile-cplus-types.c create mode 100644 gdb/compile/compile-cplus.h create mode 100644 gdb/compile/gcc-cp-plugin.h create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-inherit.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-inherit.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-member.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-member.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-method.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-method.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-mod.c create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-namespace.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-namespace.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-nested.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-nested.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-print.c create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-print.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-virtual.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-virtual.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus.c create mode 100644 gdb/testsuite/gdb.compile/compile-cplus.exp create mode 100644 gdb/testsuite/lib/compile-support.exp diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e12c54983c..c03dbbfec4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,35 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Add compile-cplus-support.c, + compile-cplus-symbols.c, and compile-cplus-types.c. + (HFILES_NO_SRCDIR): Add gcc-cp-plugin.h. + * c-lang.c (cplus_language_defn): Set C++ compile functions. + * c-lang.h (cplus_get_compile_context, cplus_compute_program): + Declare. + * compile/compile-c-support.c: Include compile-cplus.h. + (load_libcompile): Templatize. + (get_compile_context): "New" function. + (c_get_compile_context): Use get_compile_context. + (cplus_get_compile_context): New function. + (cplus_push_user_expression, cplus_pop_user_expression) + (cplus_add_code_header, cplus_add_input, cplus_compile_program) + (cplus_compute_program): Define new structs/functions. + * compile/compile-cplus-support.c: New file. + * compile/compile-cplus-symmbols.c: New file. + * compile/compile-cplus-types.c: New file. + * compile/compile-cplus.h: New file. + * compile/compile-internal.h (debug_compile_oracle, GCC_TYPE_NONE): + Declare. + * compile/compile-object-load.c (get_out_value_type): Use + strncmp_iw when comparing symbol names. + (compile_object_load): Add mst_bss and mst_data. + * compile/compile.c (_initialize_compile): Remove + -Wno-implicit-function-declaration from `compile_args'. + * compile/gcc-cp-plugin.h: New file. + * NEWS: Mention C++ compile support and new debug options. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (collect_info::add_symbol): Make virtual. (struct symbol_searcher_collect_info): New struct. (symbol_searcher::find_all_symbols): New method. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 118c3c8062..9163e04d14 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -317,6 +317,9 @@ SUBDIR_GCC_COMPILE_SRCS = \ compile/compile-c-support.c \ compile/compile-c-symbols.c \ compile/compile-c-types.c \ + compile/compile-cplus-support.c \ + compile/compile-cplus-symbols.c \ + compile/compile-cplus-types.c \ compile/compile-loc2c.c \ compile/compile-object-load.c \ compile/compile-object-run.c @@ -1461,10 +1464,12 @@ HFILES_NO_SRCDIR = \ common/xml-utils.h \ compile/compile.h \ compile/compile-c.h \ + compile/compile-cplus.h \ compile/compile-internal.h \ compile/compile-object-load.h \ compile/compile-object-run.h \ compile/gcc-c-plugin.h \ + compile/gcc-cp-plugin.h \ config/nm-linux.h \ config/nm-nto.h \ config/djgpp/langinfo.h \ diff --git a/gdb/NEWS b/gdb/NEWS index f275031345..cfc7789a9f 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,10 @@ *** Changes since GDB 8.2 +* GDB now has experimental support for the compilation and injection of + C++ source code into the inferior. This feature requires the GCC C++ + plug-in available since GCC 7.1. + * GDB and GDBserver now support IPv6 connections. IPv6 addresses can be passed using the '[ADDRESS]:PORT' notation, or the regular 'ADDRESS:PORT' method. @@ -12,6 +16,16 @@ * New commands +set debug compile-oracle +show debug compile-oracle + Control the display of debug output about symbol requests from + the compiler plug-in. + +set debug compile-cplus-types +show debug compile-cplus-types + Control the display of debug output about C++ type conversion + in the compile feature. + frame apply [all | COUNT | -COUNT | level LEVEL...] [FLAG]... COMMAND Apply a command to some frames. FLAG arguments allow to control what output to produce and how to handle diff --git a/gdb/c-lang.c b/gdb/c-lang.c index 5ad580182c..6bae4c18ec 100644 --- a/gdb/c-lang.c +++ b/gdb/c-lang.c @@ -1017,8 +1017,8 @@ extern const struct language_defn cplus_language_defn = iterate_over_symbols, cp_search_name_hash, &cplus_varobj_ops, - NULL, - NULL, + cplus_get_compile_context, + cplus_compute_program, LANG_MAGIC }; diff --git a/gdb/c-lang.h b/gdb/c-lang.h index b7bf08992b..9719ad50aa 100644 --- a/gdb/c-lang.h +++ b/gdb/c-lang.h @@ -160,6 +160,14 @@ extern int c_textual_element_type (struct type *, char); extern compile_instance *c_get_compile_context (void); +/* Create a new instance of the C++ compiler and return it. The new + compiler is owned by the caller and must be freed using the destroy + method. This function never returns NULL, but rather throws an + exception on failure. This is suitable for use as the + la_get_compile_instance language method. */ + +extern compile_instance *cplus_get_compile_context (void); + /* This takes the user-supplied text and returns a new bit of code to compile. @@ -172,4 +180,15 @@ extern std::string c_compute_program (compile_instance *inst, const struct block *expr_block, CORE_ADDR expr_pc); +/* This takes the user-supplied text and returns a new bit of code to compile. + + This is used as the la_compute_program language method; see that + for a description of the arguments. */ + +extern std::string cplus_compute_program (compile_instance *inst, + const char *input, + struct gdbarch *gdbarch, + const struct block *expr_block, + CORE_ADDR expr_pc); + #endif /* !defined (C_LANG_H) */ diff --git a/gdb/compile/compile-c-support.c b/gdb/compile/compile-c-support.c index e8993aa5eb..4c7893cf06 100644 --- a/gdb/compile/compile-c-support.c +++ b/gdb/compile/compile-c-support.c @@ -1,4 +1,4 @@ -/* C language support for compilation. +/* C/C++ language support for compilation. Copyright (C) 2014-2018 Free Software Foundation, Inc. @@ -20,6 +20,7 @@ #include "defs.h" #include "compile-internal.h" #include "compile-c.h" +#include "compile-cplus.h" #include "compile.h" #include "gdb-dlfcn.h" #include "c-lang.h" @@ -67,25 +68,22 @@ c_get_range_decl_name (const struct dynamic_prop *prop) \f -/* Helper function for c_get_compile_context. Open the GCC front-end - shared library and return the symbol specified by the current - GCC_C_FE_CONTEXT. */ +/* Load the plug-in library FE_LIBCC and return the initialization function + FE_CONTEXT. */ -static gcc_c_fe_context_function * -load_libcc (void) +template <typename FUNCTYPE> +FUNCTYPE * +load_libcompile (const char *fe_libcc, const char *fe_context) { - gcc_c_fe_context_function *func; + FUNCTYPE *func; - /* gdb_dlopen will call error () on an error, so no need to check - value. */ - gdb_dlhandle_up handle = gdb_dlopen (STRINGIFY (GCC_C_FE_LIBCC)); - func = (gcc_c_fe_context_function *) gdb_dlsym (handle, - STRINGIFY (GCC_C_FE_CONTEXT)); + /* gdb_dlopen will call error () on an error, so no need to check + value. */ + gdb_dlhandle_up handle = gdb_dlopen (fe_libcc); + func = (FUNCTYPE *) gdb_dlsym (handle, fe_context); if (func == NULL) - error (_("could not find symbol %s in library %s"), - STRINGIFY (GCC_C_FE_CONTEXT), - STRINGIFY (GCC_C_FE_LIBCC)); + error (_("could not find symbol %s in library %s"), fe_context, fe_libcc); /* Leave the library open. */ handle.release (); @@ -93,28 +91,57 @@ load_libcc (void) } /* Return the compile instance associated with the current context. - This function calls the symbol returned from the load_libcc - function. This will provide the gcc_c_context. */ + This function calls the symbol returned from the load_libcompile + function. FE_LIBCC is the library to load. BASE_VERSION is the + base compile plug-in version we support. API_VERSION is the + API version supported. */ +template <typename INSTTYPE, typename FUNCTYPE, typename CTXTYPE, + typename BASE_VERSION_TYPE, typename API_VERSION_TYPE> compile_instance * -c_get_compile_context (void) +get_compile_context (const char *fe_libcc, const char *fe_context, + BASE_VERSION_TYPE base_version, + API_VERSION_TYPE api_version) { - static gcc_c_fe_context_function *func; - - struct gcc_c_context *context; + static FUNCTYPE *func; + static CTXTYPE *context; if (func == NULL) { - func = load_libcc (); + func = load_libcompile<FUNCTYPE> (fe_libcc, fe_context); gdb_assert (func != NULL); } - context = (*func) (GCC_FE_VERSION_0, GCC_C_FE_VERSION_0); + context = (*func) (base_version, api_version); if (context == NULL) error (_("The loaded version of GCC does not support the required version " "of the API.")); - return new compile_c_instance (context); + return new INSTTYPE (context); +} + +/* A C-language implementation of get_compile_context. */ + +compile_instance * +c_get_compile_context (void) +{ + return get_compile_context + <compile_c_instance, gcc_c_fe_context_function, gcc_c_context, + gcc_base_api_version, gcc_c_api_version> + (STRINGIFY (GCC_C_FE_LIBCC), STRINGIFY (GCC_C_FE_CONTEXT), + GCC_FE_VERSION_0, GCC_C_FE_VERSION_0); +} + +/* A C++-language implementation of get_compile_context. */ + +compile_instance * +cplus_get_compile_context (void) +{ + return get_compile_context + <compile_cplus_instance, gcc_cp_fe_context_function, gcc_cp_context, + gcc_base_api_version, gcc_cp_api_version> + (STRINGIFY (GCC_CP_FE_LIBCC), STRINGIFY (GCC_CP_FE_CONTEXT), + GCC_FE_VERSION_0, GCC_CP_FE_VERSION_0); } \f @@ -384,6 +411,113 @@ struct c_add_input } }; +/* C++-language policy to emit a push user expression pragma into + BUF. */ + +struct cplus_push_user_expression +{ + void push_user_expression (struct ui_file *buf) + { + fputs_unfiltered ("#pragma GCC push_user_expression\n", buf); + } +}; + +/* C++-language policy to emit a pop user expression pragma into BUF. */ + +struct cplus_pop_user_expression +{ + void pop_user_expression (struct ui_file *buf) + { + fputs_unfiltered ("#pragma GCC pop_user_expression\n", buf); + } +}; + +/* C++-language policy to construct a code header for a block of code. + Takes a scope TYPE argument which selects the correct header to + insert into BUF. */ + +struct cplus_add_code_header +{ + void add_code_header (enum compile_i_scope_types type, struct ui_file *buf) + { + switch (type) + { + case COMPILE_I_SIMPLE_SCOPE: + fputs_unfiltered ("void " + GCC_FE_WRAPPER_FUNCTION + " (struct " + COMPILE_I_SIMPLE_REGISTER_STRUCT_TAG + " *" + COMPILE_I_SIMPLE_REGISTER_ARG_NAME + ") {\n", + buf); + break; + + case COMPILE_I_PRINT_ADDRESS_SCOPE: + case COMPILE_I_PRINT_VALUE_SCOPE: + fputs_unfiltered ( + "#include <cstring>\n" + "#include <bits/move.h>\n" + "void " + GCC_FE_WRAPPER_FUNCTION + " (struct " + COMPILE_I_SIMPLE_REGISTER_STRUCT_TAG + " *" + COMPILE_I_SIMPLE_REGISTER_ARG_NAME + ", " + COMPILE_I_PRINT_OUT_ARG_TYPE + " " + COMPILE_I_PRINT_OUT_ARG + ") {\n", + buf); + break; + + case COMPILE_I_RAW_SCOPE: + break; + + default: + gdb_assert_not_reached (_("Unknown compiler scope reached.")); + } + } +}; + +/* C++-language policy to emit the user code snippet INPUT into BUF based on + the scope TYPE. */ + +struct cplus_add_input +{ + void add_input (enum compile_i_scope_types type, const char *input, + struct ui_file *buf) + { + switch (type) + { + case COMPILE_I_PRINT_VALUE_SCOPE: + case COMPILE_I_PRINT_ADDRESS_SCOPE: + fprintf_unfiltered + (buf, + /* "auto" strips ref- and cv- qualifiers, so we need to also strip + those from COMPILE_I_EXPR_PTR_TYPE. */ + "auto " COMPILE_I_EXPR_VAL " = %s;\n" + "typedef " + "std::add_pointer<std::remove_cv<decltype (%s)>::type>::type " + " __gdb_expr_ptr;\n" + "__gdb_expr_ptr " COMPILE_I_EXPR_PTR_TYPE ";\n" + "std::memcpy (" COMPILE_I_PRINT_OUT_ARG ", %s (" + COMPILE_I_EXPR_VAL "),\n" + "\tsizeof (*" COMPILE_I_EXPR_PTR_TYPE "));\n" + ,input, input, + (type == COMPILE_I_PRINT_ADDRESS_SCOPE + ? "__builtin_addressof" : "")); + break; + + default: + fputs_unfiltered (input, buf); + break; + } + fputs_unfiltered ("\n", buf); + } +}; + /* A host class representing a compile program. CompileInstanceType is the type of the compile_instance for the @@ -513,13 +647,18 @@ private: struct gdbarch *m_arch; }; -/* Type used for C program computations. */ +/* The types used for C and C++ program computations. */ typedef compile_program<compile_c_instance, c_push_user_expression, pop_user_expression_nop, c_add_code_header, c_add_code_footer, c_add_input> c_compile_program; +typedef compile_program<compile_cplus_instance, + cplus_push_user_expression, cplus_pop_user_expression, + cplus_add_code_header, c_add_code_footer, + cplus_add_input> cplus_compile_program; + /* The la_compute_program method for C. */ std::string @@ -534,3 +673,19 @@ c_compute_program (compile_instance *inst, return program.compute (input, expr_block, expr_pc); } + +/* The la_compute_program method for C++. */ + +std::string +cplus_compute_program (compile_instance *inst, + const char *input, + struct gdbarch *gdbarch, + const struct block *expr_block, + CORE_ADDR expr_pc) +{ + compile_cplus_instance *cplus_inst + = static_cast<compile_cplus_instance *> (inst); + cplus_compile_program program (cplus_inst, gdbarch); + + return program.compute (input, expr_block, expr_pc); +} diff --git a/gdb/compile/compile-cplus-support.c b/gdb/compile/compile-cplus-support.c new file mode 100644 index 0000000000..42fc7692c4 --- /dev/null +++ b/gdb/compile/compile-cplus-support.c @@ -0,0 +1,30 @@ +/* C++ language support for compilation. + + Copyright (C) 2015-2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include "gcc-cp-interface.h" + +void +gcc_cplus_enter_scope (void *datum, struct gcc_cp_context *gcc_context) +{ +} + +void +gcc_cplus_leave_scope (void *datum, struct gcc_cp_context *gcc_context) +{ +} diff --git a/gdb/compile/compile-cplus-symbols.c b/gdb/compile/compile-cplus-symbols.c new file mode 100644 index 0000000000..8e7be596d3 --- /dev/null +++ b/gdb/compile/compile-cplus-symbols.c @@ -0,0 +1,511 @@ +/* Convert symbols from GDB to GCC + + Copyright (C) 2014-2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + + +#include "defs.h" +#include "compile-internal.h" +#include "compile-cplus.h" +#include "gdb_assert.h" +#include "symtab.h" +#include "parser-defs.h" +#include "block.h" +#include "objfiles.h" +#include "compile.h" +#include "value.h" +#include "exceptions.h" +#include "gdbtypes.h" +#include "dwarf2loc.h" +#include "cp-support.h" +#include "gdbcmd.h" +#include "compile-c.h" + +/* See description in compile-internal.h. */ + +int debug_compile_oracle = 0; + +/* Convert a given symbol, SYM, to the compiler's representation. + INSTANCE is the compiler instance. IS_GLOBAL is true if the + symbol came from the global scope. IS_LOCAL is true if the symbol + came from a local scope. (Note that the two are not strictly + inverses because the symbol might have come from the static + scope.) */ + +static void +convert_one_symbol (compile_cplus_instance *instance, + struct block_symbol sym, bool is_global, bool is_local) +{ + /* Squash compiler warning. */ + gcc_type sym_type = 0; + const char *filename = symbol_symtab (sym.symbol)->filename; + unsigned short line = SYMBOL_LINE (sym.symbol); + + instance->error_symbol_once (sym.symbol); + + if (SYMBOL_CLASS (sym.symbol) == LOC_LABEL) + sym_type = 0; + else + sym_type = instance->convert_type (SYMBOL_TYPE (sym.symbol)); + + if (SYMBOL_DOMAIN (sym.symbol) == STRUCT_DOMAIN) + { + /* Nothing to do. */ + } + else + { + /* Squash compiler warning. */ + gcc_cp_symbol_kind_flags kind = GCC_CP_FLAG_BASE; + CORE_ADDR addr = 0; + std::string name; + gdb::unique_xmalloc_ptr<char> symbol_name; + + switch (SYMBOL_CLASS (sym.symbol)) + { + case LOC_TYPEDEF: + if (TYPE_CODE (SYMBOL_TYPE (sym.symbol)) == TYPE_CODE_TYPEDEF) + kind = GCC_CP_SYMBOL_TYPEDEF; + else if (TYPE_CODE (SYMBOL_TYPE (sym.symbol)) == TYPE_CODE_NAMESPACE) + return; + break; + + case LOC_LABEL: + kind = GCC_CP_SYMBOL_LABEL; + addr = SYMBOL_VALUE_ADDRESS (sym.symbol); + break; + + case LOC_BLOCK: + { + kind = GCC_CP_SYMBOL_FUNCTION; + addr = BLOCK_START (SYMBOL_BLOCK_VALUE (sym.symbol)); + if (is_global && TYPE_GNU_IFUNC (SYMBOL_TYPE (sym.symbol))) + addr = gnu_ifunc_resolve_addr (target_gdbarch (), addr); + } + break; + + case LOC_CONST: + if (TYPE_CODE (SYMBOL_TYPE (sym.symbol)) == TYPE_CODE_ENUM) + { + /* Already handled by convert_enum. */ + return; + } + instance->plugin ().build_constant + (sym_type, SYMBOL_NATURAL_NAME (sym.symbol), + SYMBOL_VALUE (sym.symbol), filename, line); + return; + + case LOC_CONST_BYTES: + error (_("Unsupported LOC_CONST_BYTES for symbol \"%s\"."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_UNDEF: + internal_error (__FILE__, __LINE__, _("LOC_UNDEF found for \"%s\"."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_COMMON_BLOCK: + error (_("Fortran common block is unsupported for compilation " + "evaluaton of symbol \"%s\"."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_OPTIMIZED_OUT: + error (_("Symbol \"%s\" cannot be used for compilation evaluation " + "as it is optimized out."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_COMPUTED: + if (is_local) + goto substitution; + /* Probably TLS here. */ + warning (_("Symbol \"%s\" is thread-local and currently can only " + "be referenced from the current thread in " + "compiled code."), + SYMBOL_PRINT_NAME (sym.symbol)); + /* FALLTHROUGH */ + case LOC_UNRESOLVED: + /* 'symbol_name' cannot be used here as that one is used only for + local variables from compile_dwarf_expr_to_c. + Global variables can be accessed by GCC only by their address, not + by their name. */ + { + struct value *val; + struct frame_info *frame = nullptr; + + if (symbol_read_needs_frame (sym.symbol)) + { + frame = get_selected_frame (nullptr); + if (frame == nullptr) + error (_("Symbol \"%s\" cannot be used because " + "there is no selected frame"), + SYMBOL_PRINT_NAME (sym.symbol)); + } + + val = read_var_value (sym.symbol, sym.block, frame); + if (VALUE_LVAL (val) != lval_memory) + error (_("Symbol \"%s\" cannot be used for compilation " + "evaluation as its address has not been found."), + SYMBOL_PRINT_NAME (sym.symbol)); + + kind = GCC_CP_SYMBOL_VARIABLE; + addr = value_address (val); + } + break; + + + case LOC_REGISTER: + case LOC_ARG: + case LOC_REF_ARG: + case LOC_REGPARM_ADDR: + case LOC_LOCAL: + substitution: + kind = GCC_CP_SYMBOL_VARIABLE; + symbol_name = c_symbol_substitution_name (sym.symbol); + break; + + case LOC_STATIC: + kind = GCC_CP_SYMBOL_VARIABLE; + addr = SYMBOL_VALUE_ADDRESS (sym.symbol); + break; + + case LOC_FINAL_VALUE: + default: + gdb_assert_not_reached ("Unreachable case in convert_one_symbol."); + } + + /* Don't emit local variable decls for a raw expression. */ + if (instance->scope () != COMPILE_I_RAW_SCOPE || symbol_name == nullptr) + { + compile_scope scope; + + /* For non-local symbols, create/push a new scope so that the + symbol is properly scoped to the plug-in. */ + if (!is_local) + { + scope + = instance->new_scope (SYMBOL_NATURAL_NAME (sym.symbol), + SYMBOL_TYPE (sym.symbol)); + if (scope.nested_type () != GCC_TYPE_NONE) + { + /* We found a symbol for this type that was defined inside + some other symbol, e.g., a class tyepdef defined. */ + return; + } + + instance->enter_scope (scope); + } + + /* Get the `raw' name of the symbol. */ + if (name.empty () && SYMBOL_NATURAL_NAME (sym.symbol) != nullptr) + name = decl_name (SYMBOL_NATURAL_NAME (sym.symbol)).get (); + + /* Define the decl. */ + instance->plugin ().build_decl + ("variable", name.c_str (), kind, sym_type, + symbol_name.get (), addr, filename, line); + + /* Pop scope for non-local symbols. */ + if (!is_local) + instance->leave_scope (); + } + } +} + +/* Convert a full symbol to its gcc form. CONTEXT is the compiler to + use, IDENTIFIER is the name of the symbol, SYM is the symbol + itself, and DOMAIN is the domain which was searched. */ + +static void +convert_symbol_sym (compile_cplus_instance *instance, + const char *identifier, struct block_symbol sym, + domain_enum domain) +{ + /* If we found a symbol and it is not in the static or global + scope, then we should first convert any static or global scope + symbol of the same name. This lets this unusual case work: + + int x; // Global. + int func(void) + { + int x; + // At this spot, evaluate "extern int x; x" + } + */ + + const struct block *static_block = block_static_block (sym.block); + /* STATIC_BLOCK is NULL if FOUND_BLOCK is the global block. */ + bool is_local_symbol = (sym.block != static_block && static_block != nullptr); + if (is_local_symbol) + { + struct block_symbol global_sym; + + global_sym = lookup_symbol (identifier, nullptr, domain, nullptr); + /* If the outer symbol is in the static block, we ignore it, as + it cannot be referenced. */ + if (global_sym.symbol != nullptr + && global_sym.block != block_static_block (global_sym.block)) + { + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_convert_symbol \"%s\": global symbol\n", + identifier); + convert_one_symbol (instance, global_sym, true, false); + } + } + + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_convert_symbol \"%s\": local symbol\n", + identifier); + convert_one_symbol (instance, sym, false, is_local_symbol); +} + +/* Convert a minimal symbol to its gcc form. CONTEXT is the compiler + to use and BMSYM is the minimal symbol to convert. */ + +static void +convert_symbol_bmsym (compile_cplus_instance *instance, + struct bound_minimal_symbol bmsym) +{ + struct minimal_symbol *msym = bmsym.minsym; + struct objfile *objfile = bmsym.objfile; + struct type *type; + gcc_cp_symbol_kind_flags kind; + gcc_type sym_type; + CORE_ADDR addr; + + addr = MSYMBOL_VALUE_ADDRESS (objfile, msym); + + /* Conversion copied from write_exp_msymbol. */ + switch (MSYMBOL_TYPE (msym)) + { + case mst_text: + case mst_file_text: + case mst_solib_trampoline: + type = objfile_type (objfile)->nodebug_text_symbol; + kind = GCC_CP_SYMBOL_FUNCTION; + break; + + case mst_text_gnu_ifunc: + /* nodebug_text_gnu_ifunc_symbol would cause: + function return type cannot be function */ + type = objfile_type (objfile)->nodebug_text_symbol; + kind = GCC_CP_SYMBOL_FUNCTION; + addr = gnu_ifunc_resolve_addr (target_gdbarch (), addr); + break; + + case mst_data: + case mst_file_data: + case mst_bss: + case mst_file_bss: + type = objfile_type (objfile)->nodebug_data_symbol; + kind = GCC_CP_SYMBOL_VARIABLE; + break; + + case mst_slot_got_plt: + type = objfile_type (objfile)->nodebug_got_plt_symbol; + kind = GCC_CP_SYMBOL_FUNCTION; + break; + + default: + type = objfile_type (objfile)->nodebug_unknown_symbol; + kind = GCC_CP_SYMBOL_VARIABLE; + break; + } + + sym_type = instance->convert_type (type); + instance->plugin ().push_namespace (""); + instance->plugin ().build_decl + ("minsym", MSYMBOL_NATURAL_NAME (msym), kind, sym_type, nullptr, addr, + nullptr, 0); + instance->plugin ().pop_binding_level (""); +} + +/* See compile-cplus.h. */ + +void +gcc_cplus_convert_symbol (void *datum, + struct gcc_cp_context *gcc_context, + enum gcc_cp_oracle_request request ATTRIBUTE_UNUSED, + const char *identifier) +{ + if (debug_compile_oracle) + fprintf_unfiltered (gdb_stdlog, + "got oracle request for \"%s\"\n", identifier); + + bool found = false; + compile_cplus_instance *instance = (compile_cplus_instance *) datum; + + TRY + { + /* Symbol searching is a three part process unfortunately. */ + + /* First do a "standard" lookup, converting any found symbols. + This will find variables in the current scope. */ + + struct block_symbol sym + = lookup_symbol (identifier, instance->block (), VAR_DOMAIN, nullptr); + + if (sym.symbol != nullptr) + { + found = true; + convert_symbol_sym (instance, identifier, sym, VAR_DOMAIN); + } + + /* Then use linespec.c's multi-symbol search. This should find + all non-variable symbols for which we have debug info. */ + + symbol_searcher searcher; + searcher.find_all_symbols (identifier, current_language, + ALL_DOMAIN, nullptr, nullptr); + + /* Convert any found symbols. */ + for (const auto &it : searcher.matching_symbols ()) + { + found = true; + convert_symbol_sym (instance, identifier, it, + SYMBOL_DOMAIN (it.symbol)); + } + + /* Finally, if no symbols have been found, fall back to minsyms. */ + if (!found) + { + for (const auto &it : searcher.matching_msymbols ()) + { + found = true; + convert_symbol_bmsym (instance, it); + } + } + } + CATCH (e, RETURN_MASK_ALL) + { + /* We can't allow exceptions to escape out of this callback. Safest + is to simply emit a gcc error. */ + instance->plugin ().error (e.message); + } + END_CATCH + + if (compile_debug && !found) + fprintf_unfiltered (gdb_stdlog, + "gcc_convert_symbol \"%s\": lookup_symbol failed\n", + identifier); + + if (debug_compile_oracle) + { + if (found) + fprintf_unfiltered (gdb_stdlog, "found type for %s\n", identifier); + else + { + fprintf_unfiltered (gdb_stdlog, "did not find type for %s\n", + identifier); + } + } + + return; +} + +/* See compile-cplus.h. */ + +gcc_address +gcc_cplus_symbol_address (void *datum, struct gcc_cp_context *gcc_context, + const char *identifier) +{ + compile_cplus_instance *instance = (compile_cplus_instance *) datum; + gcc_address result = 0; + int found = 0; + + if (debug_compile_oracle) + fprintf_unfiltered (gdb_stdlog, + "got oracle request for address of %s\n", identifier); + + /* We can't allow exceptions to escape out of this callback. Safest + is to simply emit a gcc error. */ + TRY + { + struct symbol *sym + = lookup_symbol (identifier, nullptr, VAR_DOMAIN, nullptr).symbol; + + if (sym != nullptr && SYMBOL_CLASS (sym) == LOC_BLOCK) + { + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_symbol_address \"%s\": full symbol\n", + identifier); + result = BLOCK_START (SYMBOL_BLOCK_VALUE (sym)); + if (TYPE_GNU_IFUNC (SYMBOL_TYPE (sym))) + result = gnu_ifunc_resolve_addr (target_gdbarch (), result); + found = 1; + } + else + { + struct bound_minimal_symbol msym; + + msym = lookup_bound_minimal_symbol (identifier); + if (msym.minsym != nullptr) + { + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_symbol_address \"%s\": minimal " + "symbol\n", + identifier); + result = BMSYMBOL_VALUE_ADDRESS (msym); + if (MSYMBOL_TYPE (msym.minsym) == mst_text_gnu_ifunc) + result = gnu_ifunc_resolve_addr (target_gdbarch (), result); + found = 1; + } + } + } + + CATCH (e, RETURN_MASK_ERROR) + { + instance->plugin ().error (e.message); + } + END_CATCH + + if (compile_debug && !found) + fprintf_unfiltered (gdb_stdlog, + "gcc_symbol_address \"%s\": failed\n", + identifier); + + if (debug_compile_oracle) + { + if (found) + fprintf_unfiltered (gdb_stdlog, "found address for %s!\n", identifier); + else + fprintf_unfiltered (gdb_stdlog, + "did not find address for %s\n", identifier); + } + + return result; +} + +\f + +void _initialize_compile_cplus_symbols (void); + +void +_initialize_compile_cplus_symbols (void) +{ + add_setshow_boolean_cmd ("compile-oracle", no_class, + &debug_compile_oracle, _("\ +Set debugging of compiler plug-in oracle requests."), _("\ +Show debugging of compiler plug-in oracle requests."), _("\ +When enabled debugging messages are printed for compiler plug-in\n\ +oracle requests."), + nullptr, + nullptr, + &setdebuglist, + &showdebuglist); +} diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c new file mode 100644 index 0000000000..3e197834fc --- /dev/null +++ b/gdb/compile/compile-cplus-types.c @@ -0,0 +1,1430 @@ +/* Convert types from GDB to GCC + + Copyright (C) 2014-2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + + +#include "defs.h" +#include "common/preprocessor.h" +#include "gdbtypes.h" +#include "compile-internal.h" +#include "compile-cplus.h" +#include "gdb_assert.h" +#include "symtab.h" +#include "source.h" +#include "cp-support.h" +#include "cp-abi.h" +#include "symtab.h" +#include "objfiles.h" +#include "block.h" +#include "gdbcmd.h" +#include "c-lang.h" +#include "compile-c.h" /* Included for c_get_range_decl_name + et al. */ +#include <algorithm> + +/* Default compile flags for C++. */ + +const char *compile_cplus_instance::m_default_cflags = "-std=gnu++11"; + +/* Flag to enable internal debugging. */ + +static int debug_compile_cplus_types = 0; + +/* Flag to enable internal scope switching debugging. */ + +static int debug_compile_cplus_scopes = 0; + +/* Forward declarations. */ + +static gcc_type compile_cplus_convert_func (compile_cplus_instance *instance, + struct type *type, + bool strip_artificial); + +/* See description in compile-cplus.h. */ + +gdb::unique_xmalloc_ptr<char> +decl_name (const char *natural) +{ + if (natural == nullptr) + return nullptr; + + char *name = cp_func_name (natural); + if (name != nullptr) + return gdb::unique_xmalloc_ptr<char> (name); + + return gdb::unique_xmalloc_ptr<char> (xstrdup (natural)); +} + +/* Get the access flag for the NUM'th field of TYPE. */ + +static enum gcc_cp_symbol_kind +get_field_access_flag (const struct type *type, int num) +{ + if (TYPE_FIELD_PROTECTED (type, num)) + return GCC_CP_ACCESS_PROTECTED; + else if (TYPE_FIELD_PRIVATE (type, num)) + return GCC_CP_ACCESS_PRIVATE; + + /* GDB assumes everything else is public. */ + return GCC_CP_ACCESS_PUBLIC; +} + +/* Get the access flag for the NUM'th method of TYPE's FNI'th + fieldlist. */ + +enum gcc_cp_symbol_kind +get_method_access_flag (const struct type *type, int fni, int num) +{ + gdb_assert (TYPE_CODE (type) == TYPE_CODE_STRUCT); + + /* If this type was not declared a class, everything is public. */ + if (!TYPE_DECLARED_CLASS (type)) + return GCC_CP_ACCESS_PUBLIC; + + /* Otherwise, read accessibility from the fn_field. */ + const struct fn_field *methods = TYPE_FN_FIELDLIST1 (type, fni); + if (TYPE_FN_FIELD_PROTECTED (methods, num)) + return GCC_CP_ACCESS_PROTECTED; + else if (TYPE_FN_FIELD_PRIVATE (methods, num)) + return GCC_CP_ACCESS_PRIVATE; + else + return GCC_CP_ACCESS_PUBLIC; +} + +/* A useful debugging function to output the scope SCOPE to stdout. */ + +static void __attribute__ ((used)) +debug_print_scope (const compile_scope &scope) +{ + for (const auto &comp: scope) + { + std::string symbol = (comp.bsymbol.symbol != nullptr + ? SYMBOL_NATURAL_NAME (comp.bsymbol.symbol) + : "<none>"); + + printf_unfiltered ("\tname = %s, symbol = %s\n", comp.name.c_str (), + symbol.c_str ()); + } +} + +/* Utility function to convert CODE into a string. */ + +static const char * +type_code_to_string (enum type_code code) +{ + const char * const s[] = + {"BISTRING (deprecated)", "UNDEF (not used)", + "PTR", "ARRAY", "STRUCT", "UNION", "ENUM", + "FLAGS", "FUNC", "INT", "FLT", "VOID", + "SET", "RANGE", "STRING", "ERROR", "METHOD", + "METHODPTR", "MEMBERPTR", "REF", "RVALUE_REF", "CHAR", "BOOL", + "COMPLEX", "TYPEDEF", "NAMESPACE", "DECFLOAT", "MODULE", + "INTERNAL_FUNCTION", "XMETHOD"}; + + return s[code + 1]; +} + +/* See description in compile-cplus.h. */ + +compile_scope +type_name_to_scope (const char *type_name, const struct block *block) +{ + compile_scope scope; + + if (type_name == nullptr) + { + /* An anonymous type. We cannot really do much here. We simply cannot + look up anonymous types easily/at all. */ + return scope; + } + + const char *p = type_name; + std::string lookup_name; + + while (*p != '\0') + { + /* Create a string token of the first component of TYPE_NAME. */ + int len = cp_find_first_component (p); + std::string s (p, len); + + /* Advance past the last token. */ + p += len; + + /* Look up the symbol and decide when to stop. */ + if (!lookup_name.empty ()) + lookup_name += "::"; + lookup_name += s; + + /* Look up the resulting name. */ + struct block_symbol bsymbol + = lookup_symbol (lookup_name.c_str (), block, VAR_DOMAIN, nullptr); + + if (bsymbol.symbol != nullptr) + { + scope_component comp = {s, bsymbol}; + + scope.push_back (comp); + + if (TYPE_CODE (SYMBOL_TYPE (bsymbol.symbol)) != TYPE_CODE_NAMESPACE) + { + /* We're done. */ + break; + } + } + + if (*p == ':') + { + ++p; + if (*p == ':') + ++p; + else + { + /* This shouldn't happen since we are not attempting to + loop over user input. This name is generated by GDB + from debug info. */ + internal_error (__FILE__, __LINE__, + _("malformed TYPE_NAME during parsing")); + } + } + } + + return scope; +} + +/* Compare two scope_components for equality. These are equal if the names + of the two components' are the same. */ + +bool +operator== (const scope_component &lhs, const scope_component &rhs) +{ + return lhs.name == rhs.name; +} + +/* Compare two scope_components for inequality. These are not equal if + the two components' names are not equal. */ + +bool +operator!= (const scope_component &lhs, const scope_component &rhs) +{ + return lhs.name != rhs.name; +} + +/* Compare two compile_scopes for equality. These are equal if they are both + contain the same number of components and each component is equal. */ + +bool +operator== (const compile_scope &lhs, const compile_scope &rhs) +{ + if (lhs.size () != rhs.size ()) + return false; + + for (int i = 0; i < lhs.size (); ++i) + { + if (lhs[i] != rhs[i]) + return false; + } + + return true; +} + +/* Compare two compile_scopes for inequality. These are inequal if they + contain unequal number of elements or if any of the components are not + the same. */ + +bool +operator!= (const compile_scope &lhs, const compile_scope &rhs) +{ + if (lhs.size () != rhs.size ()) + return true; + + for (int i = 0; i < lhs.size (); ++i) + { + if (lhs[i] != rhs[i]) + return true; + } + + return false; +} + +/* See description in compile-cplus.h. */ + +void +compile_cplus_instance::enter_scope (compile_scope &new_scope) +{ + bool must_push = m_scopes.empty () || m_scopes.back () != new_scope; + + new_scope.m_pushed = must_push; + + /* Save the new scope. */ + m_scopes.push_back (new_scope); + + if (must_push) + { + if (debug_compile_cplus_scopes) + fprintf_unfiltered (gdb_stdlog, "entering new scope %p\n", new_scope); + + /* Push the global namespace. */ + plugin ().push_namespace (""); + + /* Push all other namespaces. Note that we do not push the last + scope_component -- that's the actual type we are converting. */ + std::for_each + (new_scope.begin (), new_scope.end () - 1, + [this] (const scope_component &comp) + { + gdb_assert (TYPE_CODE (SYMBOL_TYPE (comp.bsymbol.symbol)) + == TYPE_CODE_NAMESPACE); + + const char *ns = (comp.name == CP_ANONYMOUS_NAMESPACE_STR ? nullptr + : comp.name.c_str ()); + + this->plugin ().push_namespace (ns); + }); + } + else + { + if (debug_compile_cplus_scopes) + { + fprintf_unfiltered (gdb_stdlog, "staying in current scope -- " + "scopes are identical\n"); + } + } +} + +/* See description in compile-cplus.h. */ + +void +compile_cplus_instance::leave_scope () +{ + /* Get the current scope and remove it from the internal list of + scopes. */ + compile_scope current = m_scopes.back (); + + m_scopes.pop_back (); + + if (current.m_pushed) + { + if (debug_compile_cplus_scopes) + fprintf_unfiltered (gdb_stdlog, "leaving scope %p\n", current); + + /* Pop namespaces. */ + std::for_each + (current.begin (),current.end () - 1, + [this] (const scope_component &comp) { + gdb_assert (TYPE_CODE (SYMBOL_TYPE (comp.bsymbol.symbol)) + == TYPE_CODE_NAMESPACE); + this->plugin ().pop_binding_level (comp.name.c_str ()); + }); + + /* Pop global namespace. */ + plugin ().pop_binding_level (""); + } + else + { + if (debug_compile_cplus_scopes) + fprintf_unfiltered (gdb_stdlog, + "identical scopes -- not leaving scope\n"); + } +} + +/* See description in compile-cplus.h. */ + +compile_scope +compile_cplus_instance::new_scope (const char *type_name, struct type *type) +{ + /* Break the type name into components. If TYPE was defined in some + superclass, we do not process TYPE but process the enclosing type + instead. */ + compile_scope scope = type_name_to_scope (type_name, block ()); + + if (!scope.empty ()) + { + /* Get the name of the last component, which should be the + unqualified name of the type to process. */ + scope_component &comp = scope.back (); + + if (!types_equal (type, SYMBOL_TYPE (comp.bsymbol.symbol)) + && (m_scopes.empty () + || (m_scopes.back ().back ().bsymbol.symbol + != comp.bsymbol.symbol))) + { + /* The type is defined inside another class(es). Convert that + type instead of defining this type. */ + convert_type (SYMBOL_TYPE (comp.bsymbol.symbol)); + + /* If the original type (passed in to us) is defined in a nested + class, the previous call will give us that type's gcc_type. + Upper layers are expecting to get the original type's + gcc_type! */ + get_cached_type (type, scope.m_nested_type); + return scope; + } + } + else + { + if (TYPE_NAME (type) == nullptr) + { + /* Anonymous type */ + + /* We don't have a qualified name for this to look up, but + we need a scope. We have to assume, then, that it is the same + as the current scope, if any. */ + if (!m_scopes.empty ()) + { + scope = m_scopes.back (); + scope.m_pushed = false; + } + else + scope.push_back (scope_component ()); + } + else + { + scope_component comp + = { + decl_name (TYPE_NAME (type)).release (), + lookup_symbol (TYPE_NAME (type), block (), VAR_DOMAIN, nullptr) + }; + scope.push_back (comp); + } + } + + /* There must be at least one component in the compile_scope. */ + gdb_assert (scope.size () > 0); + return scope; +} + +/* See description in compile-cplus.h. */ + +gcc_type +compile_cplus_instance::convert_reference_base + (gcc_type base, enum gcc_cp_ref_qualifiers rquals) +{ + return this->plugin ().build_reference_type (base, rquals); +} + +/* Convert a reference type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_reference (compile_cplus_instance *instance, + struct type *type) +{ + gcc_type target = instance->convert_type (TYPE_TARGET_TYPE (type)); + + enum gcc_cp_ref_qualifiers quals = GCC_CP_REF_QUAL_NONE; + switch (TYPE_CODE (type)) + { + case TYPE_CODE_REF: + quals = GCC_CP_REF_QUAL_LVALUE; + break; + case TYPE_CODE_RVALUE_REF: + quals = GCC_CP_REF_QUAL_RVALUE; + break; + default: + gdb_assert_not_reached ("unexpected type code for reference type"); + } + + return instance->convert_reference_base (target, quals); +} + +/* See description in compile-cplus.h. */ + +gcc_type +compile_cplus_instance::convert_pointer_base(gcc_type target) +{ + return plugin ().build_pointer_type (target); +} + +/* Convert a pointer type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_pointer (compile_cplus_instance *instance, + struct type *type) +{ + gcc_type target = instance->convert_type (TYPE_TARGET_TYPE (type)); + + return instance->convert_pointer_base (target); +} + +/* Convert an array type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_array (compile_cplus_instance *instance, + struct type *type) +{ + struct type *range = TYPE_INDEX_TYPE (type); + gcc_type element_type = instance->convert_type (TYPE_TARGET_TYPE (type)); + + if (TYPE_LOW_BOUND_KIND (range) != PROP_CONST) + { + const char *s = _("array type with non-constant" + " lower bound is not supported"); + + return instance->plugin ().error (s); + } + + if (TYPE_LOW_BOUND (range) != 0) + { + const char *s = _("cannot convert array type with " + "non-zero lower bound to C"); + + return instance->plugin ().error (s); + } + + if (TYPE_HIGH_BOUND_KIND (range) == PROP_LOCEXPR + || TYPE_HIGH_BOUND_KIND (range) == PROP_LOCLIST) + { + if (TYPE_VECTOR (type)) + { + const char *s = _("variably-sized vector type is not supported"); + + return instance->plugin ().error (s); + } + + std::string upper_bound + = c_get_range_decl_name (&TYPE_RANGE_DATA (range)->high); + return instance->plugin ().build_vla_array_type (element_type, + upper_bound.c_str ()); + } + else + { + LONGEST low_bound, high_bound, count; + + if (get_array_bounds (type, &low_bound, &high_bound) == 0) + count = -1; + else + { + gdb_assert (low_bound == 0); /* Ensured above. */ + count = high_bound + 1; + } + + if (TYPE_VECTOR (type)) + return instance->plugin ().build_vector_type (element_type, count); + + return instance->plugin ().build_array_type (element_type, count); + } +} + +/* Convert a typedef of TYPE. If not GCC_CP_ACCESS_NONE, NESTED_ACCESS + will define the accessibility of the typedef definition in its + containing class. */ + +static gcc_type +compile_cplus_convert_typedef (compile_cplus_instance *instance, + struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + + if (scope.nested_type () != GCC_TYPE_NONE) + return scope.nested_type (); + + gdb::unique_xmalloc_ptr<char> name = decl_name (TYPE_NAME (type)); + + /* Make sure the scope for this type has been pushed. */ + instance->enter_scope (scope); + + /* Convert the typedef's real type. */ + gcc_type typedef_type = instance->convert_type (check_typedef (type)); + + instance->plugin ().build_decl ("typedef", name.get (), + GCC_CP_SYMBOL_TYPEDEF | nested_access, + typedef_type, 0, 0, nullptr, 0); + + /* Completed this scope. */ + instance->leave_scope (); + return typedef_type; +} + +/* Convert types defined in TYPE. */ + +static void +compile_cplus_convert_type_defns (compile_cplus_instance *instance, + struct type *type) +{ + int i; + enum gcc_cp_symbol_kind accessibility; + + /* Convert typedefs. */ + for (i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i) + { + if (TYPE_TYPEDEF_FIELD_PROTECTED (type, i)) + accessibility = GCC_CP_ACCESS_PROTECTED; + else if (TYPE_TYPEDEF_FIELD_PRIVATE (type, i)) + accessibility = GCC_CP_ACCESS_PRIVATE; + else + accessibility = GCC_CP_ACCESS_PUBLIC; + instance->convert_type (TYPE_TYPEDEF_FIELD_TYPE (type, i), accessibility); + } + + /* Convert nested types. */ + for (i = 0; i < TYPE_NESTED_TYPES_COUNT (type); ++i) + { + if (TYPE_NESTED_TYPES_FIELD_PROTECTED (type, i)) + accessibility = GCC_CP_ACCESS_PROTECTED; + else if (TYPE_NESTED_TYPES_FIELD_PRIVATE (type, i)) + accessibility = GCC_CP_ACCESS_PRIVATE; + else + accessibility = GCC_CP_ACCESS_PUBLIC; + instance->convert_type (TYPE_NESTED_TYPES_FIELD_TYPE (type, i), + accessibility); + } +} + +/* Convert data members defined in TYPE, which should be struct/class/union + with gcc_type COMP_TYPE. */ + +static void +compile_cplus_convert_struct_or_union_members + (compile_cplus_instance *instance, struct type *type, gcc_type comp_type) +{ + for (int i = TYPE_N_BASECLASSES (type); i < TYPE_NFIELDS (type); ++i) + { + const char *field_name = TYPE_FIELD_NAME (type, i); + + if (TYPE_FIELD_IGNORE (type, i) + || TYPE_FIELD_ARTIFICIAL (type, i)) + continue; + + /* GDB records unnamed/anonymous fields with empty string names. */ + if (*field_name == '\0') + field_name = nullptr; + + gcc_type field_type + = instance->convert_type (TYPE_FIELD_TYPE (type, i)); + + if (field_is_static (&TYPE_FIELD (type, i))) + { + CORE_ADDR physaddr; + + switch (TYPE_FIELD_LOC_KIND (type, i)) + { + case FIELD_LOC_KIND_PHYSADDR: + { + physaddr = TYPE_FIELD_STATIC_PHYSADDR (type, i); + + instance->plugin ().build_decl + ("field physaddr", field_name, + (GCC_CP_SYMBOL_VARIABLE | get_field_access_flag (type, i)), + field_type, nullptr, physaddr, nullptr, 0); + } + break; + + case FIELD_LOC_KIND_PHYSNAME: + { + const char *physname = TYPE_FIELD_STATIC_PHYSNAME (type, i); + struct block_symbol sym + = lookup_symbol (physname, instance->block (), + VAR_DOMAIN, nullptr); + + if (sym.symbol == nullptr) + { + /* We didn't actually find the symbol. There's little + we can do but ignore this member. */ + continue; + } + const char *filename = symbol_symtab (sym.symbol)->filename; + unsigned int line = SYMBOL_LINE (sym.symbol); + + physaddr = SYMBOL_VALUE_ADDRESS (sym.symbol); + instance->plugin ().build_decl + ("field physname", field_name, + (GCC_CP_SYMBOL_VARIABLE| get_field_access_flag (type, i)), + field_type, nullptr, physaddr, filename, line); + } + break; + + default: + gdb_assert_not_reached + ("unexpected static field location kind"); + } + } + else + { + unsigned long bitsize = TYPE_FIELD_BITSIZE (type, i); + enum gcc_cp_symbol_kind field_flags = GCC_CP_SYMBOL_FIELD + | get_field_access_flag (type, i); + + if (bitsize == 0) + bitsize = 8 * TYPE_LENGTH (TYPE_FIELD_TYPE (type, i)); + + instance->plugin ().build_field + (field_name, field_type, field_flags, bitsize, + TYPE_FIELD_BITPOS (type, i)); + } + } +} + +/* Convert a method type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_method (compile_cplus_instance *instance, + struct type *parent_type, + struct type *method_type) +{ + /* Get the actual function type of the method, the corresponding class's + type and corresponding qualifier flags. */ + gcc_type func_type = compile_cplus_convert_func (instance, method_type, true); + gcc_type class_type = instance->convert_type (parent_type); + gcc_cp_qualifiers_flags quals = (enum gcc_cp_qualifiers) 0; + + if (TYPE_CONST (method_type)) + quals |= GCC_CP_QUALIFIER_CONST; + if (TYPE_VOLATILE (method_type)) + quals |= GCC_CP_QUALIFIER_VOLATILE; + if (TYPE_RESTRICT (method_type)) + quals |= GCC_CP_QUALIFIER_RESTRICT; + + /* Not yet implemented. */ + gcc_cp_ref_qualifiers_flags rquals = GCC_CP_REF_QUAL_NONE; + + return instance->plugin ().build_method_type + (class_type, func_type, quals, rquals); +} + +/* Convert a member or method pointer represented by TYPE. */ + +static gcc_type +compile_cplus_convert_memberptr (compile_cplus_instance *instance, + struct type *type) +{ + struct type *containing_class = TYPE_SELF_TYPE (type); + + if (containing_class == nullptr) + return GCC_TYPE_NONE; + + gcc_type class_type = instance->convert_type (containing_class); + gcc_type member_type + = instance->convert_type (TYPE_TARGET_TYPE (type)); + + return instance->plugin ().build_pointer_to_member_type + (class_type, member_type); +} + +/* Convert all methods defined in TYPE, which should be a class/struct/union + with gcc_type CLASS_TYPE. */ + +static void +compile_cplus_convert_struct_or_union_methods (compile_cplus_instance *instance, + struct type *type, + gcc_type class_type) +{ + for (int i = 0; i < TYPE_NFN_FIELDS (type); ++i) + { + struct fn_field *methods = TYPE_FN_FIELDLIST1 (type, i); + gdb::unique_xmalloc_ptr<char> overloaded_name + = decl_name (TYPE_FN_FIELDLIST_NAME (type, i)); + + /* Loop through the fieldlist, adding decls to the compiler's + representation of the class. */ + for (int j = 0; j < TYPE_FN_FIELDLIST_LENGTH (type, i); ++j) + { + /* Skip artificial methods. */ + if (TYPE_FN_FIELD_ARTIFICIAL (methods, j)) + continue; + + gcc_cp_symbol_kind_flags sym_kind = GCC_CP_SYMBOL_FUNCTION; + gcc_type method_type; + struct block_symbol sym + = lookup_symbol (TYPE_FN_FIELD_PHYSNAME (methods, j), + instance->block (), VAR_DOMAIN, nullptr); + + if (sym.symbol == nullptr) + { + if (TYPE_FN_FIELD_VIRTUAL_P (methods, j)) + { + /* This is beyond hacky, and is really only a workaround for + detecting pure virtual methods. */ + method_type = compile_cplus_convert_method + (instance, type, TYPE_FN_FIELD_TYPE (methods, j)); + + instance->plugin ().build_decl + ("pure virtual method", overloaded_name.get (), + (sym_kind + | get_method_access_flag (type, i, j) + | GCC_CP_FLAG_VIRTUAL_FUNCTION + | GCC_CP_FLAG_PURE_VIRTUAL_FUNCTION), + method_type, nullptr, 0, nullptr, 0); + continue; + } + + /* This can happen if we have a DW_AT_declaration DIE + for the method, but no "definition"-type DIE (with + DW_AT_specification referencing the decl DIE), i.e., + the compiler has probably optimized the method away. + + In this case, all we can hope to do is issue a warning + to the user letting him know. If the user has not actually + requested using this method, things should still work. */ + warning (_("Method %s appears to be optimized out.\n" + "All references to this method will be undefined."), + TYPE_FN_FIELD_PHYSNAME (methods, j)); + continue; + } + + const char *filename = symbol_symtab (sym.symbol)->filename; + unsigned int line = SYMBOL_LINE (sym.symbol); + CORE_ADDR address = BLOCK_START (SYMBOL_BLOCK_VALUE (sym.symbol)); + const char *kind; + + if (TYPE_FN_FIELD_STATIC_P (methods, j)) + { + kind = "static method"; + method_type = compile_cplus_convert_func + (instance, TYPE_FN_FIELD_TYPE (methods, j), true); + } + else + { + kind = "method"; + method_type = (compile_cplus_convert_method + (instance, type, TYPE_FN_FIELD_TYPE (methods, j))); + } + + if (TYPE_FN_FIELD_VIRTUAL_P (methods, j)) + sym_kind |= GCC_CP_FLAG_VIRTUAL_FUNCTION; + + instance->plugin ().build_decl + (kind, overloaded_name.get (), + sym_kind | get_method_access_flag (type, i, j), + method_type, nullptr, address, filename, line); + } + } +} + +/* Convert a struct or union type to its gcc representation. If this type + was defined in another type, NESTED_ACCESS should indicate the + accessibility of this type. */ + +static gcc_type +compile_cplus_convert_struct_or_union (compile_cplus_instance *instance, + struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + const char *filename = nullptr; + unsigned short line = 0; + + /* Get the decl name of this type. */ + gdb::unique_xmalloc_ptr<char> name = decl_name (TYPE_NAME (type)); + + /* Create a new scope for TYPE. */ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + + if (scope.nested_type () != GCC_TYPE_NONE) + { + /* The type requested was actually defined inside another type, + such as a nested class definition. Return that type. */ + return scope.nested_type (); + } + + /* Push all scopes. */ + instance->enter_scope (scope); + + /* First we create the resulting type and enter it into our hash + table. This lets recursive types work. */ + + gcc_decl resuld; + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) + { + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; + + resuld = instance->plugin ().build_decl + (what, name.get (), (GCC_CP_SYMBOL_CLASS | nested_access + | (TYPE_DECLARED_CLASS (type) + ? GCC_CP_FLAG_CLASS_NOFLAG + : GCC_CP_FLAG_CLASS_IS_STRUCT)), + 0, nullptr, 0, filename, line); + } + else + { + gdb_assert (TYPE_CODE (type) == TYPE_CODE_UNION); + resuld = instance->plugin ().build_decl + ("union", name.get (), GCC_CP_SYMBOL_UNION | nested_access, + 0, nullptr, 0, filename, line); + } + + gcc_type result; + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) + { + struct gcc_vbase_array bases; + int num_baseclasses = TYPE_N_BASECLASSES (type); + + memset (&bases, 0, sizeof (bases)); + + if (num_baseclasses > 0) + { + bases.elements = XNEWVEC (gcc_type, num_baseclasses); + bases.flags = XNEWVEC (enum gcc_cp_symbol_kind, num_baseclasses); + bases.n_elements = num_baseclasses; + for (int i = 0; i < num_baseclasses; ++i) + { + struct type *base_type = TYPE_BASECLASS (type, i); + + bases.flags[i] = GCC_CP_SYMBOL_BASECLASS + | get_field_access_flag (type, i) + | (BASETYPE_VIA_VIRTUAL (type, i) + ? GCC_CP_FLAG_BASECLASS_VIRTUAL + : GCC_CP_FLAG_BASECLASS_NOFLAG); + bases.elements[i] = instance->convert_type (base_type); + } + } + + result = instance->plugin ().start_class_type + (name.get (), resuld, &bases, filename, line); + xfree (bases.flags); + xfree (bases.elements); + } + else + { + gdb_assert (TYPE_CODE (type) == TYPE_CODE_UNION); + result = instance->plugin ().start_class_type + (name.get (), resuld, nullptr, filename, line); + } + + instance->insert_type (type, result); + + /* Add definitions. */ + compile_cplus_convert_type_defns (instance, type); + + /* Add methods. */ + compile_cplus_convert_struct_or_union_methods (instance, type, result); + + /* Add members. */ + compile_cplus_convert_struct_or_union_members (instance, type, result); + + /* All finished. */ + instance->plugin ().finish_class_type (name.get (), TYPE_LENGTH (type)); + + /* Pop all scopes. */ + instance->leave_scope (); + return result; +} + +/* Convert an enum type to its gcc representation. If this type + was defined in another type, NESTED_ACCESS should indicate the + accessibility of this type.*/ + +static gcc_type +compile_cplus_convert_enum (compile_cplus_instance *instance, struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + int scoped_enum_p = FALSE; + + /* Create a new scope for this type. */ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + + if (scope.nested_type () != GCC_TYPE_NONE) + { + /* The type requested was actually defined inside another type, + such as a nested class definition. Return that type. */ + return scope.nested_type (); + } + + gdb::unique_xmalloc_ptr<char> name = decl_name (TYPE_NAME (type)); + + /* Push all scopes. */ + instance->enter_scope (scope); + + gcc_type int_type + = instance->plugin ().get_int_type (TYPE_UNSIGNED (type), + TYPE_LENGTH (type), nullptr); + gcc_type result + = instance->plugin ().start_enum_type (name.get (), int_type, + GCC_CP_SYMBOL_ENUM | nested_access + | (scoped_enum_p + ? GCC_CP_FLAG_ENUM_SCOPED + : GCC_CP_FLAG_ENUM_NOFLAG), + nullptr, 0); + for (int i = 0; i < TYPE_NFIELDS (type); ++i) + { + gdb::unique_xmalloc_ptr<char> fname + = decl_name (TYPE_FIELD_NAME (type, i)); + + if (TYPE_FIELD_LOC_KIND (type, i) != FIELD_LOC_KIND_ENUMVAL + || fname == nullptr) + continue; + + instance->plugin ().build_enum_constant (result, fname.get (), + TYPE_FIELD_ENUMVAL (type, i)); + } + + /* Finish enum definition and pop scopes. */ + instance->plugin ().finish_enum_type (result); + instance->leave_scope (); + return result; +} + +/* Convert a function type to its gcc representation. This function does + not deal with function templates. */ + +static gcc_type +compile_cplus_convert_func (compile_cplus_instance *instance, + struct type *type, bool strip_artificial) +{ + int is_varargs = TYPE_VARARGS (type); + struct type *target_type = TYPE_TARGET_TYPE (type); + + /* Functions with no debug info have no return type. Ideally we'd + want to fallback to the type of the cast just before the + function, like GDB's built-in expression parser, but we don't + have access to that type here. For now, fallback to int, like + GDB's parser used to do. */ + if (target_type == nullptr) + { + if (TYPE_OBJFILE_OWNED (type)) + target_type = objfile_type (TYPE_OWNER (type).objfile)->builtin_int; + else + target_type = builtin_type (TYPE_OWNER (type).gdbarch)->builtin_int; + warning (_("function has unknown return type; assuming int")); + } + + /* This approach means we can't make self-referential function + types. Those are impossible in C, though. */ + gcc_type return_type = instance->convert_type (target_type); + + struct gcc_type_array array = + { TYPE_NFIELDS (type), XNEWVEC (gcc_type, TYPE_NFIELDS (type)) }; + int artificials = 0; + for (int i = 0; i < TYPE_NFIELDS (type); ++i) + { + if (strip_artificial && TYPE_FIELD_ARTIFICIAL (type, i)) + { + --array.n_elements; + ++artificials; + } + else + { + array.elements[i - artificials] + = instance->convert_type (TYPE_FIELD_TYPE (type, i)); + } + } + + /* We omit setting the argument types to `void' to be a little flexible + with some minsyms like printf (compile-cplus.exp has examples). */ + gcc_type result = instance->plugin ().build_function_type + (return_type, &array, is_varargs); + xfree (array.elements); + return result; +} + +/* Convert an integer type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_int (compile_cplus_instance *instance, struct type *type) +{ + if (TYPE_NOSIGN (type)) + { + gdb_assert (TYPE_LENGTH (type) == 1); + return instance->plugin ().get_char_type (); + } + + return instance->plugin ().get_int_type + (TYPE_UNSIGNED (type), TYPE_LENGTH (type), TYPE_NAME (type)); +} + +/* Convert a floating-point type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_float (compile_cplus_instance *instance, + struct type *type) +{ + return instance->plugin ().get_float_type + (TYPE_LENGTH (type), TYPE_NAME (type)); +} + +/* Convert the 'void' type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_void (compile_cplus_instance *instance, struct type *type) +{ + return instance->plugin ().get_void_type (); +} + +/* Convert a boolean type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_bool (compile_cplus_instance *instance, struct type *type) +{ + return instance->plugin ().get_bool_type (); +} + +/* See description in compile-cplus.h. */ + +gcc_type +compile_cplus_instance::convert_qualified_base (gcc_type base, + gcc_cp_qualifiers_flags quals) +{ + gcc_type result = base; + + if (quals != GCC_CP_REF_QUAL_NONE) + result = plugin ().build_qualified_type (base, quals); + + return result; +} + +/* See description in compile-cplus.h. */ + +static gcc_type +compile_cplus_convert_qualified (compile_cplus_instance *instance, + struct type *type) +{ + struct type *unqual = make_unqualified_type (type); + gcc_cp_qualifiers_flags quals = (enum gcc_cp_qualifiers) 0; + gcc_type unqual_converted = instance->convert_type (unqual); + + if (TYPE_CONST (type)) + quals |= GCC_CP_QUALIFIER_CONST; + if (TYPE_VOLATILE (type)) + quals |= GCC_CP_QUALIFIER_VOLATILE; + if (TYPE_RESTRICT (type)) + quals |= GCC_CP_QUALIFIER_RESTRICT; + + return instance->convert_qualified_base (unqual_converted, quals); +} + +/* Convert a complex type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_complex (compile_cplus_instance *instance, + struct type *type) +{ + gcc_type base = instance->convert_type (TYPE_TARGET_TYPE (type)); + + return instance->plugin ().build_complex_type (base); +} + +/* Convert a namespace of TYPE. */ + +static gcc_type +compile_cplus_convert_namespace (compile_cplus_instance *instance, + struct type *type) +{ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + gdb::unique_xmalloc_ptr<char> name = decl_name (TYPE_NAME (type)); + + /* Push scope. */ + instance->enter_scope (scope); + + /* Convert this namespace. */ + instance->plugin ().push_namespace (name.get ()); + instance->plugin ().pop_binding_level (name.get ()); + + /* Pop scope. */ + instance->leave_scope (); + + /* Namespaces are non-cacheable types. */ + return GCC_TYPE_NONE; +} + +/* A helper function which knows how to convert most types from their + gdb representation to the corresponding gcc form. This examines + the TYPE and dispatches to the appropriate conversion function. It + returns the gcc type. + + If the type was defined in another type, NESTED_ACCESS should indicate the + accessibility of this type. */ + +static gcc_type +convert_type_cplus_basic (compile_cplus_instance *instance, + struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + /* If we are converting a qualified type, first convert the + unqualified type and then apply the qualifiers. */ + if ((TYPE_INSTANCE_FLAGS (type) & (TYPE_INSTANCE_FLAG_CONST + | TYPE_INSTANCE_FLAG_VOLATILE + | TYPE_INSTANCE_FLAG_RESTRICT)) != 0) + return compile_cplus_convert_qualified (instance, type); + + switch (TYPE_CODE (type)) + { + case TYPE_CODE_REF: + case TYPE_CODE_RVALUE_REF: + return compile_cplus_convert_reference (instance, type); + + case TYPE_CODE_PTR: + return compile_cplus_convert_pointer (instance, type); + + case TYPE_CODE_ARRAY: + return compile_cplus_convert_array (instance, type); + + case TYPE_CODE_STRUCT: + case TYPE_CODE_UNION: + return + compile_cplus_convert_struct_or_union (instance, type, nested_access); + + case TYPE_CODE_ENUM: + return compile_cplus_convert_enum (instance, type, nested_access); + + case TYPE_CODE_FUNC: + return compile_cplus_convert_func (instance, type, false); + + case TYPE_CODE_METHOD: + return + compile_cplus_convert_method (instance, TYPE_SELF_TYPE (type), type); + + case TYPE_CODE_MEMBERPTR: + case TYPE_CODE_METHODPTR: + return compile_cplus_convert_memberptr (instance, type); + break; + + case TYPE_CODE_INT: + return compile_cplus_convert_int (instance, type); + + case TYPE_CODE_FLT: + return compile_cplus_convert_float (instance, type); + + case TYPE_CODE_VOID: + return compile_cplus_convert_void (instance, type); + + case TYPE_CODE_BOOL: + return compile_cplus_convert_bool (instance, type); + + case TYPE_CODE_COMPLEX: + return compile_cplus_convert_complex (instance, type); + + case TYPE_CODE_NAMESPACE: + return compile_cplus_convert_namespace (instance, type); + + case TYPE_CODE_TYPEDEF: + return compile_cplus_convert_typedef (instance, type, nested_access); + + default: + break; + } + + std::string s = string_printf (_("unhandled TYPE_CODE_%s"), + type_code_to_string (TYPE_CODE (type))); + + return instance->plugin ().error (s.c_str ()); +} + +gcc_type +compile_cplus_instance::convert_type (struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + /* Check if TYPE has already been converted. */ + gcc_type result; + if (get_cached_type (type, result)) + return result; + + /* It is the first time this type has been seen -- convert it + and cache it, if appropriate.. */ + result = convert_type_cplus_basic (this, type, nested_access); + if (result != GCC_TYPE_NONE) + insert_type (type, result); + return result; +} + +\f + +/* Plug-in forwards. */ + +/* C++ plug-in wrapper. */ + +/* A result printer for plug-in calls that return a gcc_type or + gcc_decl. */ + +static void +compile_cplus_debug_output_1 (gcc_type arg) +{ + fprintf_unfiltered (gdb_stdlog, "%lld", arg); +} + +static void +compile_cplus_debug_output_1 (const char *arg) +{ + if (arg == nullptr) + fputs_unfiltered ("NULL", gdb_stdlog); + else + fputs_unfiltered (arg, gdb_stdlog); +} + +static void +compile_cplus_debug_output () +{ +} + +template <typename T> +static void +compile_cplus_debug_output_1 (const T *arg) +{ +} + +template <typename T, typename... Targs> +static void +compile_cplus_debug_output (T arg, Targs... Args) +{ + compile_cplus_debug_output_1 (arg); + fputc_unfiltered (' ', gdb_stdlog); + compile_cplus_debug_output (Args...); +} + +#define FORWARD(OP,...) m_context->cp_ops->OP(m_context, ##__VA_ARGS__) +#define OUTPUT_DEBUG_RESULT(R) \ + if (debug_compile_cplus_types) \ + { \ + fputs_unfiltered (": ", gdb_stdlog); \ + compile_cplus_debug_output (R); \ + fputc_unfiltered ('\n', gdb_stdlog); \ + } \ + +#define GCC_METHOD0(R, N) \ + R gcc_cp_plugin::N () const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N)); \ + auto result = FORWARD (N); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD1(R, N, A) \ + R gcc_cp_plugin::N (A a) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a); \ + auto result = FORWARD (N, a); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD2(R, N, A, B) \ + R gcc_cp_plugin::N (A a, B b) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b); \ + auto result = FORWARD (N, a, b); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD3(R, N, A, B, C) \ + R gcc_cp_plugin::N (A a, B b, C c) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c); \ + auto result = FORWARD (N, a, b, c); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD4(R, N, A, B, C, D) \ + R gcc_cp_plugin::N (A a, B b, C c, D d) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c, d); \ + auto result = FORWARD (N, a, b, c, d); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD5(R, N, A, B, C, D, E) \ + R gcc_cp_plugin::N (A a, B b, C c, D d, E e) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c, d, e); \ + auto result = FORWARD (N, a, b, c, d, e); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD7(R, N, A, B, C, D, E, F, G) \ + R gcc_cp_plugin::N (A a, B b, C c, D d, E e, F f, G g) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c, d, e, f, g); \ + auto result = FORWARD (N, a, b, c, d, e, f, g); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } + +#include "gcc-cp-fe.def" + +#undef GCC_METHOD0 +#undef GCC_METHOD1 +#undef GCC_METHOD2 +#undef GCC_METHOD3 +#undef GCC_METHOD4 +#undef GCC_METHOD5 +#undef GCC_METHOD7 +#undef FORWARD +#undef OUTPUT_DEBUG_RESULT + +gcc_expr +gcc_cp_plugin::build_decl (const char *debug_decltype, const char *name, + enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, + const char *substitution_name, gcc_address address, + const char *filename, unsigned int line_number) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_decltype); + + return build_decl (name, sym_kind, sym_type, substitution_name, + address, filename, line_number); +} + +gcc_type +gcc_cp_plugin::start_class_type (const char *debug_name, gcc_decl typedecl, + const struct gcc_vbase_array *base_classes, + const char *filename, unsigned int line_number) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_name); + + return start_class_type (typedecl, base_classes, filename, line_number); +} + +int +gcc_cp_plugin::finish_class_type (const char *debug_name, + unsigned long size_in_bytes) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_name); + + return finish_class_type (size_in_bytes); +} + +int +gcc_cp_plugin::pop_binding_level (const char *debug_name) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_name); + + return pop_binding_level (); +} + +void _initialize_compile_cplus_types (void); + +void +_initialize_compile_cplus_types (void) +{ + add_setshow_boolean_cmd ("compile-cplus-types", no_class, + &debug_compile_cplus_types, _("\ +Set debugging of C++ compile type conversion."), _("\ +Show debugging of C++ compile type conversion."), _("\ +When enabled debugging messages are printed during C++ type conversion for\n\ +the compile commands."), + nullptr, + nullptr, + &setdebuglist, + &showdebuglist); + + add_setshow_boolean_cmd ("compile-cplus-scopes", no_class, + &debug_compile_cplus_scopes, _("\ +Set debugging of C++ compile scopes."), _("\ +Show debugging of C++ compile scopes."), _("\ +When enabled debugging messages are printed about definition scopes during\n\ +C++ type conversion for the compile commands."), + nullptr, + nullptr, + &setdebuglist, + &showdebuglist); +} diff --git a/gdb/compile/compile-cplus.h b/gdb/compile/compile-cplus.h new file mode 100644 index 0000000000..0f246af310 --- /dev/null +++ b/gdb/compile/compile-cplus.h @@ -0,0 +1,207 @@ +/* Header file for GDB compile C++ language support. + Copyright (C) 2016-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#ifndef GDB_COMPILE_CPLUS_H +#define GDB_COMPILE_CPLUS_H + +#include "common/enum-flags.h" +#include "gcc-cp-plugin.h" + +struct type; +struct block; + +/* enum-flags wrapper */ +DEF_ENUM_FLAGS_TYPE (enum gcc_cp_qualifiers, gcc_cp_qualifiers_flags); +DEF_ENUM_FLAGS_TYPE (enum gcc_cp_ref_qualifiers, gcc_cp_ref_qualifiers_flags); +DEF_ENUM_FLAGS_TYPE (enum gcc_cp_symbol_kind, gcc_cp_symbol_kind_flags); + +class compile_cplus_instance; + +/* A single component of a type's scope. Type names are broken into + "components," a series of unqualified names comprising the type name, + e.g., "namespace1", "namespace2", "myclass". */ + +struct scope_component +{ + /* The unqualified name of this scope. */ + std::string name; + + /* The block symbol for this type/scope. */ + struct block_symbol bsymbol; +}; + +/* Comparison operators for scope_components. */ + +bool operator== (const scope_component &lhs, const scope_component &rhs); +bool operator!= (const scope_component &lhs, const scope_component &rhs); + + +/* A single compiler scope used to define a type. + + A compile_scope is a list of scope_components, where all leading + scope_components are namespaces, followed by a single non-namespace + type component (the actual type we are converting). */ + +class compile_scope : private std::vector<scope_component> +{ +public: + + using std::vector<scope_component>::push_back; + using std::vector<scope_component>::pop_back; + using std::vector<scope_component>::back; + using std::vector<scope_component>::empty; + using std::vector<scope_component>::size; + using std::vector<scope_component>::begin; + using std::vector<scope_component>::end; + using std::vector<scope_component>::operator[]; + + compile_scope () + : m_nested_type (GCC_TYPE_NONE), m_pushed (false) + { + } + + /* Return the gcc_type of the type if it is a nested definition. + Returns GCC_TYPE_NONE if this type was not nested. */ + gcc_type nested_type () + { + return m_nested_type; + } + +private: + + /* compile_cplus_instance is a friend class so that it can set the + following private members when compile_scopes are created. */ + friend compile_cplus_instance; + + /* If the type was actually a nested type, this will hold that nested + type after the scope is pushed. */ + gcc_type m_nested_type; + + /* If true, this scope was pushed to the compiler and all namespaces + must be popped when leaving the scope. */ + bool m_pushed; +}; + +/* Comparison operators for compile_scopes. */ + +bool operator== (const compile_scope &lhs, const compile_scope &rhs); +bool operator!= (const compile_scope &lhs, const compile_scope &rhs); + +/* Convert TYPENAME into a vector of namespace and top-most/super + composite scopes. + + For example, for the input "Namespace::classB::classInner", the + resultant vector will contain the tokens "Namespace" and + "classB". */ + +compile_scope type_name_to_scope (const char *type_name, + const struct block *block); + +/* A callback suitable for use as the GCC C++ symbol oracle. */ + +extern gcc_cp_oracle_function gcc_cplus_convert_symbol; + +/* A callback suitable for use as the GCC C++ address oracle. */ + +extern gcc_cp_symbol_address_function gcc_cplus_symbol_address; + +/* Callbacks suitable for use as the GCC C++ enter/leave scope requests. */ + +extern gcc_cp_enter_leave_user_expr_scope_function gcc_cplus_enter_scope; +extern gcc_cp_enter_leave_user_expr_scope_function gcc_cplus_leave_scope; + +/* A subclass of compile_instance that is specific to the C++ front + end. */ + +class compile_cplus_instance : public compile_instance +{ +public: + + explicit compile_cplus_instance (struct gcc_cp_context *gcc_cp) + : compile_instance (&gcc_cp->base, m_default_cflags), + m_plugin (gcc_cp) + { + m_plugin.set_callbacks (gcc_cplus_convert_symbol, + gcc_cplus_symbol_address, + gcc_cplus_enter_scope, gcc_cplus_leave_scope, + this); + } + + /* Convert a gdb type, TYPE, to a GCC type. + + If this type was defined in another type, NESTED_ACCESS should indicate + the accessibility of this type (or GCC_CP_ACCESS_NONE if not a nested + type). GCC_CP_ACCESS_NONE is the default nested access. + + The new GCC type is returned. */ + gcc_type convert_type + (struct type *type, + enum gcc_cp_symbol_kind nested_access = GCC_CP_ACCESS_NONE); + + /* Return a handle for the GCC plug-in. */ + gcc_cp_plugin &plugin () { return m_plugin; } + + /* Factory method to create a new scope based on TYPE with name TYPE_NAME. + [TYPE_NAME could be TYPE_NAME or SYMBOL_NATURAL_NAME.] + + If TYPE is a nested or local definition, nested_type () will return + the gcc_type of the conversion. + + Otherwise, nested_type () is GCC_TYPE_NONE. */ + compile_scope new_scope (const char *type_name, struct type *type); + + /* Enter the given NEW_SCOPE. */ + void enter_scope (compile_scope &scope); + + /* Leave the current scope. */ + void leave_scope (); + + /* Add the qualifiers given by QUALS to BASE. */ + gcc_type convert_qualified_base (gcc_type base, + gcc_cp_qualifiers_flags quals); + + /* Convert TARGET into a pointer type. */ + gcc_type convert_pointer_base (gcc_type target); + + /* Convert BASE into a reference type. RQUALS describes the reference. */ + gcc_type convert_reference_base (gcc_type base, + enum gcc_cp_ref_qualifiers rquals); + +private: + + /* Default compiler flags for C++. */ + static const char *m_default_cflags; + + /* The GCC plug-in. */ + gcc_cp_plugin m_plugin; + + /* A list of scopes we are processing. */ + std::vector<compile_scope> m_scopes; +}; + +/* Return the declaration name of the symbol named NATURAL. + This returns a name with no function arguments or template parameters, + suitable for passing to the compiler plug-in. */ + +gdb::unique_xmalloc_ptr<char> decl_name (const char *natural); + +/* Get the access flag for the NUM'th method of TYPE's FNI'th + fieldlist. */ + +enum gcc_cp_symbol_kind get_method_access_flag (const struct type *type, + int fni, int num); + +#endif /* GDB_COMPILE_CPLUS_H */ diff --git a/gdb/compile/compile-internal.h b/gdb/compile/compile-internal.h index c8d2d2f427..483a0d5f7f 100644 --- a/gdb/compile/compile-internal.h +++ b/gdb/compile/compile-internal.h @@ -23,6 +23,10 @@ extern int compile_debug; +/* Flag to enable internal debugging for oracle requests. */ + +extern int debug_compile_oracle; + struct block; /* An object that maps a gdb type to a gcc type. */ @@ -164,6 +168,10 @@ protected: #define COMPILE_I_EXPR_VAL "__gdb_expr_val" #define COMPILE_I_EXPR_PTR_TYPE "__gdb_expr_ptr_type" +/* A "type" to indicate a NULL type. */ + +const gcc_type GCC_TYPE_NONE = (gcc_type) -1; + /* Call gdbarch_register_name (GDBARCH, REGNUM) and convert its result to a form suitable for the compiler source. The register names should not clash with inferior defined macros. */ diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c index a83f95dda9..873750b944 100644 --- a/gdb/compile/compile-object-load.c +++ b/gdb/compile/compile-object-load.c @@ -459,7 +459,8 @@ get_out_value_type (struct symbol *func_sym, struct objfile *objfile, if (function != NULL && (BLOCK_SUPERBLOCK (function_block) == BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK)) - && (strcmp (SYMBOL_LINKAGE_NAME (function), GCC_FE_WRAPPER_FUNCTION) + && (strcmp_iw (SYMBOL_LINKAGE_NAME (function), + GCC_FE_WRAPPER_FUNCTION) == 0)) break; } @@ -478,7 +479,7 @@ get_out_value_type (struct symbol *func_sym, struct objfile *objfile, gdb_ptr_type = check_typedef (gdb_ptr_type); if (TYPE_CODE (gdb_ptr_type) != TYPE_CODE_PTR) error (_("Type of \"%s\" is not a pointer"), COMPILE_I_EXPR_PTR_TYPE); - gdb_type_from_ptr = TYPE_TARGET_TYPE (gdb_ptr_type); + gdb_type_from_ptr = check_typedef (TYPE_TARGET_TYPE (gdb_ptr_type)); if (types_deeply_equal (gdb_type, gdb_type_from_ptr)) { @@ -741,6 +742,8 @@ compile_object_load (const compile_file_names &file_names, ? mst_unknown : MSYMBOL_TYPE (bmsym.minsym)) { case mst_text: + case mst_bss: + case mst_data: sym->value = BMSYMBOL_VALUE_ADDRESS (bmsym); if (compile_debug) fprintf_unfiltered (gdb_stdlog, diff --git a/gdb/compile/compile.c b/gdb/compile/compile.c index 31ae5970b9..efa4e8d0fa 100644 --- a/gdb/compile/compile.c +++ b/gdb/compile/compile.c @@ -995,7 +995,6 @@ String quoting is parsed like in shell, for example:\n\ " -fPIE" /* We want warnings, except for some commonly happening for GDB commands. */ " -Wall " - " -Wno-implicit-function-declaration" " -Wno-unused-but-set-variable" " -Wno-unused-variable" /* Override CU's possible -fstack-protector-strong. */ diff --git a/gdb/compile/gcc-cp-plugin.h b/gdb/compile/gcc-cp-plugin.h new file mode 100644 index 0000000000..1b72726a67 --- /dev/null +++ b/gdb/compile/gcc-cp-plugin.h @@ -0,0 +1,85 @@ +/* GCC C++ plug-in wrapper for GDB. + + Copyright (C) 2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +/* A class representing the GCC C++ plug-in. */ + +#include "gcc-cp-interface.h" + +class gcc_cp_plugin +{ +public: + + explicit gcc_cp_plugin (struct gcc_cp_context *gcc_cp) + : m_context (gcc_cp) + { + } + + /* Set the oracle callbacks to be used by the compiler plug-in. */ + void set_callbacks (gcc_cp_oracle_function *binding_oracle, + gcc_cp_symbol_address_function *address_oracle, + gcc_cp_enter_leave_user_expr_scope_function *enter_scope, + gcc_cp_enter_leave_user_expr_scope_function *leave_scope, + void *datum) + { + m_context->cp_ops->set_callbacks (m_context, binding_oracle, + address_oracle, enter_scope, leave_scope, + datum); + } + + /* Returns the interface version of the compiler plug-in. */ + int version () const { return m_context->cp_ops->cp_version; } + +#define GCC_METHOD0(R, N) R N () const; +#define GCC_METHOD1(R, N, A) R N (A) const; +#define GCC_METHOD2(R, N, A, B) R N (A, B) const; +#define GCC_METHOD3(R, N, A, B, C) R N (A, B, C) const; +#define GCC_METHOD4(R, N, A, B, C, D) R N (A, B, C, D) const; +#define GCC_METHOD5(R, N, A, B, C, D, E) R N (A, B, C, D, E) const; +#define GCC_METHOD7(R, N, A, B, C, D, E, F, G) R N (A, B, C, D, E, F, G) const; + +#include "gcc-cp-fe.def" + +#undef GCC_METHOD0 +#undef GCC_METHOD1 +#undef GCC_METHOD2 +#undef GCC_METHOD3 +#undef GCC_METHOD4 +#undef GCC_METHOD5 +#undef GCC_METHOD7 + + /* Special overloads of plug-in methods with added debugging information. */ + + gcc_expr build_decl (const char *debug_decltype, const char *name, + enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, + const char *substitution_name, gcc_address address, + const char *filename, unsigned int line_number); + + gcc_type start_class_type (const char *debug_name, gcc_decl typedecl, + const struct gcc_vbase_array *base_classes, + const char *filename, unsigned int line_number); + + int finish_class_type (const char *debug_name, unsigned long size_in_bytes); + + int pop_binding_level (const char *debug_name); + +private: + + /* The GCC C++ context. */ + struct gcc_cp_context *m_context; +}; diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index ceb4043e32..f8fcd33481 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + + * gdb.texinfo (Compiling and injecting code in GDB): Document + set/show "compile-oracle" and "compile-cplus-types" commands. + 2018-08-07 Simon Marchi <simon.marchi@ericsson.com> * gdb.texinfo (Index Files Speed Up GDB): Add section about diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index b931834400..c17c19caa2 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -18689,6 +18689,26 @@ injecting the code. The default is off. @item show debug compile Displays the current state of displaying @value{GDBN} process of compiling and injecting the code. + +@anchor{set debug compile-oracle} +@item set debug compile-oracle +@cindex compile oracle debugging info +Turns on or off display of symbol requests from the compiler plug-in +(the ``oracle''). The default is off. + +@item show debug compile-oracle +Displays the current state of displaying symbol requests made by the +compiler plug-in. + +@anchor{set debug compile-cplus-types} +@item set debug compile-cplus-types +@cindex compile C++ type conversion +Turns on or off the display of C++ type conversion debugging information. +The default is off. + +@item show debug compile-cplus-types +Displays the current state of displaying debugging information for +C++ type conversion. @end table @subsection Compilation options for the @code{compile} command diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index bd3c3bfec5..050e406349 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,28 @@ +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + + * gdb.compile/compile-cplus-anonymous.cc: New file. + * gdb.compile/compile-cplus-anonymous.exp: New file. + * gdb.compile/compile-cplus-array-decay.cc: New file. + * gdb.compile/compile-cplus-array-decay.exp: New file. + * gdb.compile/compile-cplus-inherit.cc: New file. + * gdb.compile/compile-cplus-inherit.exp: New file. + * gdb.compile/compile-cplus-member.cc: New file. + * gdb.compile/compile-cplus-member.exp: New file. + * gdb.compile/compile-cplus-method.cc: New file. + * gdb.compile/compile-cplus-method.exp: New file. + * gdb.compile/compile-cplus-mod.c: "New" file. + * gdb.compile/compile-cplus-namespace.cc: New file. + * gdb.compile/compile-cplus-namespace.exp: New file. + * gdb.compile/compile-cplus-nested.cc: New file. + * gdb.compile/compile-cplus-nested.exp: New file. + * gdb.compile/compile-cplus-print.c: "New" file. + * gdb.compile/compile-cplus-print.exp: "New" file. + * gdb.compile/compile-cplus-virtual.cc: New file. + * gdb.compile/compile-cplus-virtual.exp: New file. + * gdb.compile/compile-cplus.c: "New" file. + * gdb.compile/compile-cplus.exp: "New" file. + * lib/compile-support.exp: New file. + 2018-08-09 Andrew Burgess <andrew.burgess@embecosm.com> * gdb.base/vla-optimized-out.exp: Add new test. diff --git a/gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc new file mode 100644 index 0000000000..4c6673249e --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc @@ -0,0 +1,76 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +namespace { + static enum {ABC = 1, DEF, GHI, JKL} anon_e = GHI; + static union + { + char aa; + int bb; + float ff; + double dd; + void *pp; + } anon_u = { 'a' }; + + static struct + { + char *ptr; + int len; + struct + { + unsigned MAGIC; + }; + union + { + int ua; + char *ub; + }; + } anon_s = {"abracadabra", 11, 0xdead, 0xbeef}; + + struct A + { + A (void) : e (AA) + { + this->u.b = 0; + this->s.ptr = "hello"; + this->s.len = 5; + } + + enum {AA = 10, BB, CC, DD} e; + union + { + char a; + int b; + float f; + double d; + void *p; + } u; + struct + { + char *ptr; + int len; + } s; + }; +}; + +int +main (void) +{ + A a; + int var = 1234; + + return a.u.b + a.s.len + static_cast<int> (a.e) + + static_cast<int> (anon_e) + anon_u.bb + anon_s.len; // break here +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp new file mode 100644 index 0000000000..0aa3290557 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp @@ -0,0 +1,64 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Anonymous type conversion tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +# Reminder, "var" is an integer; all these types get converted to `int'. +CompileExpression::new "var" +CompileExpression::test "anon_e" {(3|GHI)} +CompileExpression::test "anon_u.aa" {97( 'a')?} +CompileExpression::test "a.u.b" 0 +CompileExpression::test "a.s.len" 5 +CompileExpression::test "a.e" {(10|A::AA)} +CompileExpression::test "(*a.s.ptr != 'h')" (0|false) +CompileExpression::test "A::BB" {(11|A::BB)} +CompileExpression::test "ABC" {(1|ABC)} +CompileExpression::test "DEF" {(2|DEF)} +CompileExpression::test "GHI" {(3|GHI)} +CompileExpression::test "JKL" {(4|JKL)} + +set k "compile/1234 *-*-*" +CompileExpression::test "anon_s.len" 11 -kfail $k +CompileExpression::test "anon_s.MAGIC" "57005" -kfail $k +CompileExpression::test "anon_s.ua" "48879" -kfail $k +CompileExpression::test "(*anon_s.ptr == 'a')" (1|true) -kfail $k diff --git a/gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc new file mode 100644 index 0000000000..da51a65654 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc @@ -0,0 +1,31 @@ +/* Copyright 2017-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +static const char *g_string_initializer = "hello"; + +int +main () +{ + int integers[10]; + const char *strings[10]; + + for (auto &i : integers) + i = 0; + + for (auto &i : strings) + i = g_string_initializer; + + return 0; // break here +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp new file mode 100644 index 0000000000..fb3e63fd91 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp @@ -0,0 +1,50 @@ +# Copyright 2017-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Test whether GDB's C++ compile feature is decaying arrays into pointers. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +gdb_test "compile print integers" " = \\{0, 0, 0, 0, 0, 0, 0, 0, 0, 0\\}" + +gdb_test "compile print strings" " = \\{$hex \"hello\", $hex \"hello\",\ + $hex \"hello\", $hex \"hello\", $hex \"hello\", $hex \"hello\",\ + $hex \"hello\", $hex \"hello\", $hex \"hello\", $hex \"hello\"\\}" diff --git a/gdb/testsuite/gdb.compile/compile-cplus-inherit.cc b/gdb/testsuite/gdb.compile/compile-cplus-inherit.cc new file mode 100644 index 0000000000..de81d1a182 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-inherit.cc @@ -0,0 +1,58 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +struct A +{ + A () : a_ (1) {} + int do_it (int amount) { return a_ + amount; } + + int a_; +}; + +struct B +{ + B () : b_ (2) {} + int do_it (int amount) { return b_ - amount; } + + int b_; +}; + +struct C +{ + C () : c_ (3) {} + int do_it (int amount) { return c_ * amount; } + + int c_; +}; + +struct D : public A, B, C +{ + D () : d_ (4) {} + + int d_; +}; + +int +main (void) +{ + D d; + int var = 1234; + + var = d.A::do_it (1) + + d.B::do_it (2) + + d.C::do_it (3); // break here + + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp b/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp new file mode 100644 index 0000000000..1978cb556a --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp @@ -0,0 +1,53 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Inheritance tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "d.a_" 1 +CompileExpression::test "d.b_" 2 +CompileExpression::test "d.c_" 3 +CompileExpression::test "d.d_" 4 +CompileExpression::test "d.A::do_it (1)" 2 +CompileExpression::test "d.B::do_it (1)" 1 +CompileExpression::test "d.C::do_it (1)" 3 diff --git a/gdb/testsuite/gdb.compile/compile-cplus-member.cc b/gdb/testsuite/gdb.compile/compile-cplus-member.cc new file mode 100644 index 0000000000..428e3aab56 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-member.cc @@ -0,0 +1,83 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +class A; +static int get_values (const A& a); + +enum myenum {E_A = 10, E_B, E_C, E_D, E_E}; + +namespace N { + typedef enum {NA = 20, NB, NC, ND} ANON_NE; +} + +namespace { + typedef enum {AA = 40, AB, AC, AD} ANON_E; +} + +ANON_E g_e = AC; + +class A +{ +public: + typedef int ATYPE; + + A(void) : public_ (1), protected_ (N::NB), private_ (3) {} + ATYPE public_; + static const myenum s_public_; + friend ATYPE get_values (const A&); + +protected: + N::ANON_NE protected_; + static N::ANON_NE s_protected_; + +private: + ATYPE private_; + static myenum s_private_; +}; + +const myenum A::s_public_ = E_A; +N::ANON_NE A::s_protected_ = N::NA; +myenum A::s_private_ = E_C; + +static A::ATYPE +get_values (const A& a) +{ + A::ATYPE val; + + val = a.public_ + a.private_; // 1 + 3 + if (a.protected_ == N::NB) // + 21 + val += 21; + if (a.s_public_ == E_A) // +10 + val += 10; + if (a.s_protected_ == N::NA) // +20 + val += 20; + if (a.s_private_ == E_C) // +30 + val += 30; + if (g_e == AC) // +40 + val += 40; + return val; // = 125 +} + +typedef int A::*PMI; + +int +main (void) +{ + A a; + int var = 1234; + PMI pmi = &A::public_; + + return a.*pmi + get_values (a); // break here +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-member.exp b/gdb/testsuite/gdb.compile/compile-cplus-member.exp new file mode 100644 index 0000000000..525ba43c00 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-member.exp @@ -0,0 +1,77 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Member tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "a.public_" 1 +CompileExpression::test "a.protected_" {(21|N::NB)} +CompileExpression::test "a.private_" 3 +CompileExpression::test "A::s_public_" {(10|E_A)} +CompileExpression::test "A::s_protected_" {(20|N::NA)} +CompileExpression::test "A::s_private_" {(12|E_C)} +CompileExpression::test "A::ATYPE i = 10; var = i;" 10 -explicit +CompileExpression::test "get_values (a)" 125 +CompileExpression::test "myenum me = E_B; var = me;" 11 -explicit +CompileExpression::test "A::s_protected_ = N::NB; var = A::s_protected_;" \ + 21 -explicit +CompileExpression::test "A::s_private_ = E_B; var = A::s_private_;" 11 -explicit +CompileExpression::test "N::ANON_NE ae = N::ND; var = ae;" 23 -explicit +CompileExpression::test {a.*pmi} 1 +CompileExpression::test {a.public_ = 2; var = a.*pmi; a.public_ = 1} 2 -explicit +CompileExpression::test "g_e" {(42|AC)} + +# Test some compilation failures +set failed {\r\nCompilation failed\.} +# !!keiths: This should actually really work... +gdb_test "compile code a.s_public_ = E_B" \ + ".*assignment of read-only variable 'A::s_public_'$failed" + +gdb_test "compile code get_values ()" \ + ".*too few arguments to function.*$failed" + +gdb_test "compile code ATYPE i;" \ + ".*.ATYPE. was not declared in this scope$failed" + +gdb_test "compile code N::ANON_NE nse = E_A" \ + ".*cannot convert.*$failed" diff --git a/gdb/testsuite/gdb.compile/compile-cplus-method.cc b/gdb/testsuite/gdb.compile/compile-cplus-method.cc new file mode 100644 index 0000000000..b5470e06b6 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-method.cc @@ -0,0 +1,91 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +class A; +static int get_value (const A* a); + +class A +{ +public: + typedef int ATYPE; + + A (void) : a_ (21) {} + ATYPE get_var (void) { return a_; } + ATYPE get_var (unsigned long a) { return 100; } + ATYPE get_var (ATYPE a) { return 101; } + ATYPE get_var (float a) { return 102; } + ATYPE get_var (void *a) { return 103;} + ATYPE get_var (A& lr) { return 104; } + ATYPE get_var (A const& lr) { return 105; } + + ATYPE get_var1 (int n) { return a_ << n; } + ATYPE get_var2 (int incr, unsigned n) { return (a_ + incr) << n; } + + static ATYPE get_1 (int a) { return a + 1; } + static ATYPE get_2 (int a, int b) { return a + b + 2; } + + friend ATYPE get_value (const A*); + +private: + ATYPE a_; +}; + +static A::ATYPE +get_value (A::ATYPE a) +{ + return a; +} + +static A::ATYPE +get_value (const A* a) +{ + return a->a_; +} + +static A::ATYPE +get_value (void) +{ + return 200; +} + +typedef int (A::*PMF) (A::ATYPE); + +int +main (void) +{ + A *a = new A (); + int var = 1234; + float f = 1.23; + unsigned long ul = 0xdeadbeef; + A const* ac = a; + + PMF pmf = &A::get_var; + PMF *pmf_p = &pmf; + + var -= a->get_var (); // break here + var -= a->get_var (1); + var -= a->get_var (ul); + var -= a->get_var (f); + var -= a->get_var (a); + var -= a->get_var (*a); + var -= a->get_var (*ac); + var -= a->get_var1 (1); + var -= a->get_var2 (1, 2); + var += (a->*pmf) (1); + var -= (a->**pmf_p) (1); + + return var - A::get_1 (1) + A::get_2 (1, 2) + get_value () + + get_value (get_value ()) + get_value (a); +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-method.exp b/gdb/testsuite/gdb.compile/compile-cplus-method.exp new file mode 100644 index 0000000000..3a5bb82850 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-method.exp @@ -0,0 +1,67 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Method tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "a->get_var ()" 21 +CompileExpression::test "a->get_var (static_cast<unsigned long> (1))" 100 +CompileExpression::test "a->get_var (static_cast<int> (1))" 101 +CompileExpression::test "a->get_var (static_cast<float> (1))" 102 +CompileExpression::test "a->get_var (static_cast<void *> (a))" 103 +CompileExpression::test "a->get_var (*a)" 104 +CompileExpression::test "a->get_var (*ac)" 105 +CompileExpression::test "a->get_var1 (1)" 42 +CompileExpression::test "a->get_var2 (1, 2)" 88 +CompileExpression::test "A::get_1 (1)" 2 +CompileExpression::test "A::get_2 (1, 2)" 5 +CompileExpression::test "A::get_1 (a->get_var ())" 22 +CompileExpression::test "a->get_var1 (a->get_var () - 16)" 672 +CompileExpression::test "a->get_var2 (a->get_var (), A::get_1 (2))" 336 +CompileExpression::test "get_value ()" 200 +CompileExpression::test "get_value (a)" 21 +CompileExpression::test "get_value (get_value ())" 200 +CompileExpression::test {(a->*pmf) (1)} 101 +CompileExpression::test \ + {pmf = &A::get_var1; var = (a->*pmf) (2); pmf = &A::get_var} 84 -explicit +CompileExpression::test {(a->**pmf_p) (1)} 101 diff --git a/gdb/testsuite/gdb.compile/compile-cplus-mod.c b/gdb/testsuite/gdb.compile/compile-cplus-mod.c new file mode 100644 index 0000000000..56a135ba8c --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-mod.c @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2014-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +extern "C" void +_gdb_expr (void) +{ + // Make 'globalvar' lookup working. +#pragma GCC push_user_expression + + globalvar = 3; + globalvar += 4; + +#pragma GCC pop_user_expression +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-namespace.cc b/gdb/testsuite/gdb.compile/compile-cplus-namespace.cc new file mode 100644 index 0000000000..1f8dc96cd9 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-namespace.cc @@ -0,0 +1,52 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +namespace N1 +{ + namespace N2 + { + namespace N3 + { + namespace N4 + { + static int n4static = 400; + + struct S4 + { + static int s4static; + int s4int_; + S4 (void) : s4int_ (4) {}; + ~S4 (void) { --s4static; } + + int get_var (void) { return s4int_; } + static int get_svar (void) { return s4static; } + }; + int S4::s4static = 40; + } + } + } +} + +int +main (void) +{ + using namespace N1::N2::N3::N4; + + S4 s4; + int var = 1234; + + var += s4.s4int_; /* break here */ + return S4::get_svar () - 10 * s4.get_var (); +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp b/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp new file mode 100644 index 0000000000..768a707b93 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp @@ -0,0 +1,51 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Namespace tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "N1::N2::N3::N4::n4static" 400 +CompileExpression::test "N1::N2::N3::N4::S4::s4static" 40 +CompileExpression::test "s4.s4int_" 4 +CompileExpression::test "N1::N2::N3::N4::S4::get_svar ()" 40 +CompileExpression::test "s4.get_var ()" 4 diff --git a/gdb/testsuite/gdb.compile/compile-cplus-nested.cc b/gdb/testsuite/gdb.compile/compile-cplus-nested.cc new file mode 100644 index 0000000000..5d35cf9c51 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-nested.cc @@ -0,0 +1,58 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +class A +{ +public: + A (void) : a_ (1) {} + int get (void); + +protected: + int a_; + +private: + /* It is important to not /not/ use the nested class definition in A. + This exercises a different path through the code. */ + struct Inner1 + { + int a_; + Inner1 (void) : a_ (2) {} + + struct Inner2 + { + int a_; + Inner2 (void) : a_ (3) {} + }; + }; +}; + +int +A::get (void) +{ + A::Inner1 i1; + A::Inner1::Inner2 i2; + + return i1.a_ + i2.a_; // break here +} + +int var = 1234; + +int +main (void) +{ + A a; + + return a.get (); +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-nested.exp b/gdb/testsuite/gdb.compile/compile-cplus-nested.exp new file mode 100644 index 0000000000..3b5ba20b28 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-nested.exp @@ -0,0 +1,53 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Nested type tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "i1.a_" 2 +CompileExpression::test "i2.a_" 3 +CompileExpression::test "A::Inner1 *i1p = &i1; var = i1p->a_;" 2 -explicit +CompileExpression::test "A::Inner1::Inner2 *i2p = &i2; var = i2p->a_;" 3 \ + -explicit +CompileExpression::test "A::Inner1 &r1 = i1; var = r1.a_;" 2 -explicit +CompileExpression::test "A::Inner1::Inner2 &r2 = i2; var = r2.a_;" 3 -explicit diff --git a/gdb/testsuite/gdb.compile/compile-cplus-print.c b/gdb/testsuite/gdb.compile/compile-cplus-print.c new file mode 100644 index 0000000000..9e6575da66 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-print.c @@ -0,0 +1,32 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include <stdlib.h> + +int varint = 10; +int vararray[] = { 1, 2, 3, 4, 5 }; +int *vararrayp = vararray; +struct object +{ + int field; +} varobject = { 1 }; + +int +main (void) +{ + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-print.exp b/gdb/testsuite/gdb.compile/compile-cplus-print.exp new file mode 100644 index 0000000000..b554c7ddb3 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-print.exp @@ -0,0 +1,81 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +load_lib compile-support.exp + +standard_testfile + +get_compiler_info +set options {} +if [test_compiler_info gcc*] { + lappend options additional_flags=-g3 + lappend options additional_flags=-std=gnu++11 + lappend options c++ +} + +set srcfilesoptions [list ${srcfile} ${options}] + +if { [eval build_executable_from_specs ${testfile}.exp $testfile {$options} ${srcfilesoptions}] } { + return -1 +} + +clean_restart ${testfile} + +if {[skip_compile_feature_tests]} { + untested "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_test_no_output "set language c++" \ + "Set language to C++" + +if ![runto_main] { + return -1 +} + +gdb_test "compile print varint" " = 10" +gdb_test "compile print vararray" " = \\{1, 2, 3, 4, 5\\}" +gdb_test "compile print main" " = \\{int \\(void\\)\\} 0x\[0-9a-f\]+" + +set test "compile print *vararray@3" +gdb_test_multiple $test $test { + -re " = \\{1, 2, 3\\}\r\n$gdb_prompt $" { + pass $test + } + -re "warning: .*All references to this method will be undefined\.\r\n" { + exp_continue + } + -re ": error: stray '@' in program\r\n.*\r\n$gdb_prompt $" { + kfail compile/18489 "$test" + } +} + +set test "compile print *vararrayp@3" +gdb_test_multiple $test $test { + -re " = \\{1, 2, 3\\}\r\n$gdb_prompt $" { + pass $test + } + -re "warning: .*All references to this method will be undefined\.\r\n" { + exp_continue + } + -re ": error: stray '@' in program\r\n.*\r\n$gdb_prompt $" { + kfail compile/18489 "$test" + } +} + +gdb_test "compile print/x 256" " = 0x100" +gdb_test {print $} " = 256" + +gdb_test "compile print varobject" { = {field = 1}} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-virtual.cc b/gdb/testsuite/gdb.compile/compile-cplus-virtual.cc new file mode 100644 index 0000000000..5083726303 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-virtual.cc @@ -0,0 +1,54 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +struct A +{ + virtual int doit (void) { return 1; } + virtual int doit3 (void) { return -3; } + virtual int doit2 (void) = 0; +}; + +struct B : virtual A +{ + int doit (void) { return 2; } + int doit2 (void) { return 22; } +}; + +struct C : virtual A +{ + int doit (void) { return 3; } + int doit2 (void) { return 33; } +}; + +struct D : B, C +{ + int doit (void) { return 4; } + int doit2 (void) { return 44; } +}; + +int +main (void) +{ + int var = 1234; + B b; + C c; + D d; + A *ap = &d; + + var = (b.doit () + c.doit () + d.doit () + d.doit3 () + + ap->doit () + ap->doit2 ()); // break here + + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp b/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp new file mode 100644 index 0000000000..696cc03304 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp @@ -0,0 +1,71 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Virtual method/inheritance tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "b.doit ()" 2 +CompileExpression::test "c.doit ()" 3 +CompileExpression::test "d.doit ()" 4 +CompileExpression::test "ap->doit ()" 4 +CompileExpression::test "b.doit2 ()" 22 +CompileExpression::test "c.doit2 ()" 33 +CompileExpression::test "d.doit2 ()" 44 +CompileExpression::test "ap->doit2 ()" 44 +CompileExpression::test "b.doit3 ()" -3 +CompileExpression::test "c.doit3 ()" -3 +CompileExpression::test "d.doit3 ()" -3 + +# These two tests are "disabled". They represent new/future features. +# CompileExpression::test \ + [concat "struct ABC {int doit2(void) { return 3333; }} abc;" \ + "var = abc.doit2()"] \ + 3333 -explicit +# CompileExpression::test \ + [concat "struct ABC : A {int doit2(void) { return 4444; }} abc;" \ + "var = abc.doit2()"] \ + 4444 -explicit + +# Test some error conditions +gdb_test "compile code A a;" \ + ".*cannot declare variable .a. to be of abstract type.*Compilation failed." diff --git a/gdb/testsuite/gdb.compile/compile-cplus.c b/gdb/testsuite/gdb.compile/compile-cplus.c new file mode 100644 index 0000000000..ab14514894 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus.c @@ -0,0 +1,241 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2014-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include <stdbool.h> +#include <iostream> + +#define SOME_MACRO 23 +#define ARG_MACRO(X, Y) ((X) + (Y) - 1) + + +enum enum_type { + ONE = 1, + TWO = 2 +}; + +typedef int v4 __attribute__ ((vector_size (16))); + +union union_type; + +struct struct_type { + char charfield; + unsigned char ucharfield; + short shortfield; + unsigned short ushortfield; + int intfield; + unsigned int uintfield; + unsigned int bitfield : 3; + long longfield; + unsigned long ulongfield; + enum enum_type enumfield; + float floatfield; + double doublefield; + const union union_type *ptrfield; + struct struct_type *selffield; + int arrayfield[5]; + _Complex double complexfield; + _Bool boolfield; + v4 vectorfield; +}; + +typedef int inttypedef; + +union union_type { + int intfield; + inttypedef typedeffield; +}; + +/* volatile provides some coverage of the conversion code. */ +volatile struct struct_type struct_object; + +union union_type union_object; + + +enum ulonger_enum_type { + REALLY_MINUS_1 = -1UL, +}; + +enum ulonger_enum_type ulonger; + +enum longer_enum_type { + MINUS_1 = -1, + FORCE_TO_LONG = 1L << ((8 * sizeof (long)) - 2) +}; + +enum longer_enum_type longer; + +int globalvar = 10; + +static void +func_static (int addend) +{ + globalvar += addend; +} + +void +func_global (int subtrahend) +{ + globalvar -= subtrahend; +} + +void +no_args_or_locals (void) +{ + /* no_args_or_locals breakpoint */ +} + +int *intptr; +int globalshadow = 10; +static int staticshadow = 20; +int externed = 7; + +class Base +{ + virtual int pure_virt () = 0; + public: + int return_value () {return a;} + private: + int a = 1; + int b = 2; +}; + +class Base2 +{ + virtual int non_pure () {return 84;} + public: + int return_value () {return b;} + private: + int a = 3; + int b = 4; +}; + +class Base3 +{ + public: + int return_value () {return b;} + private: + int b = 5; +}; + + +class Multiple : public Base, public Base2 +{ + int pure_virt () + { + int a = Base::return_value (); + return a + 42; + } +}; +//struct foo { foo(); virtual ~foo(); }; struct bar : virtual foo { bar(); ~bar(); }; struct baz : bar {}; bar::bar() {} bar::~bar() {} bar t; baz u; +struct VirtualOnly +{ + VirtualOnly(); + virtual ~VirtualOnly()=0; +}; + +VirtualOnly::VirtualOnly () +{ +} + +VirtualOnly::~VirtualOnly () +{ +} + +struct VirtualBase : virtual VirtualOnly +{ + int z = 22; + VirtualBase (void); + ~VirtualBase (void); +}; + +struct VirtualBase2 : VirtualBase {}; + +VirtualBase::VirtualBase (void) +{ + z = 24; +} + +VirtualBase::~VirtualBase (void) +{ + z = 22; +} + +class Foo +{ + int var; + static const int public_static_var = 12; + + private: + int private_var = 0; + int private_method (void); + + public: + int public_var = 0; + int public_method (void); + void set_private_var (int); +}; + +void Foo::set_private_var (int i) +{ + private_var = i; +} + +int Foo::private_method (void) +{ + return private_var; +} + +int Foo::public_method (void) +{ + return public_var; +} + +int +main (void) +{ + int localvar = 50; + int shadowed = 51; + int bound = 3; + int unresolved = 10; + int globalshadow = 100; + int staticshadow = 200; + int externed = 9; + int f = 0; + int var = 0; + Foo foovar; + Multiple *multivar = new Multiple; + VirtualBase vbase; + VirtualBase2 vbase2; + static int static_local = 77000; + + foovar.public_var = 42; + foovar.set_private_var (42); + multivar->Base2::return_value(); + { + int another_local = 7; + int shadowed = 52; + extern int unresolved; + extern int externed; + + int vla[bound]; + + func_static (0); /* break-here */ + no_args_or_locals (); + } + + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus.exp b/gdb/testsuite/gdb.compile/compile-cplus.exp new file mode 100644 index 0000000000..cb8d9cbdfd --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus.exp @@ -0,0 +1,341 @@ +# Copyright 2014-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +load_lib compile-support.exp + +standard_testfile .c compile-shlib.c compile-constvar.S compile-nodebug.c + +get_compiler_info +set options {} +if [test_compiler_info gcc*] { + lappend options additional_flags=-g3 + lappend options additional_flags=-std=gnu++11 + lappend options c++ +} + +if { ![istarget x86_64-*-* ] || ![is_lp64_target] } { + verbose "Skipping x86_64 LOC_CONST test." + set srcfile3 "" +} + +set srcfilesoptions [list ${srcfile} ${options}] +if { $srcfile3 != "" } { + lappend srcfilesoptions $srcfile3 ${options} +} +lappend srcfilesoptions $srcfile4 "nodebug c++" +if { [eval build_executable_from_specs ${testfile}.exp $testfile {$options} ${srcfilesoptions}] } { + return -1 +} + +clean_restart ${testfile} + +# +# FIXME: Right now, for C++ we just duplicate the C tests, but force +# the language to C++ +# +gdb_test_no_output "set language c++" \ + "Set language to C++" + +if ![runto_main] { + return -1 +} + +if {[skip_compile_feature_tests]} { + untested "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +# +# Test delimiter for code, and arguments. +# + + +gdb_test_no_output "compile code globalvar = SOME_MACRO;" \ + "set variable from macro" +gdb_test "p globalvar" " = 23" "expect 23" + +gdb_test_no_output "compile code globalvar = ARG_MACRO(0, 0);" \ + "set variable from function-like macro" +gdb_test "p globalvar" " = -1" "expect -1" + +gdb_test_no_output "compile code globalvar = 42;" "set variable" +gdb_test "p globalvar" " = 42" "expect 42" + +gdb_test_no_output "compile code globalvar *= 2;" "modify variable" +gdb_test "p globalvar" " = 84" "expect 84" + +gdb_test_no_output "compile file -r ${srcdir}/${subdir}/${testfile}-mod.c" \ + "use external source file" +gdb_test "p globalvar" " = 7" "expect 7" + +gdb_test_no_output "compile code func_static (2);" "call static function" +gdb_test "p globalvar" " = 9" "expect 9" +gdb_test_no_output "compile code func_global (1);" "call global function" +gdb_test "p globalvar" " = 8" "expect 8" + +gdb_test_no_output \ + "compile code globalvar = (sizeof (ulonger) == sizeof (long))" \ + "compute size of ulonger" +gdb_test "p globalvar" " = 1" "check size of ulonger" +gdb_test_no_output \ + "compile code globalvar = (sizeof (longer) == sizeof (long))" \ + "compute size of longer" +gdb_test "p globalvar" " = 1" "check size of longer" +gdb_test_no_output "compile code globalvar = MINUS_1" +gdb_test "p globalvar" " = -1" "check MINUS_1" + +gdb_test_no_output "compile code globalvar = static_local" +gdb_test "p globalvar" " = 77000" "check static_local" + +gdb_test_no_output \ + "compile code static int staticvar = 5; intptr = &staticvar" \ + "do not keep jit in memory" +gdb_test "p *intptr" "Cannot access memory at address 0x\[0-9a-f\]+" \ + "expect 5" + +gdb_test "compile code func_doesnotexist ();" "error: \'func_doesnotexist\' was not declared in this scope.*" + +gdb_test "compile code *(volatile int *) 0 = 0;" \ + "The program being debugged was signaled while in a function called from GDB\\.\r\nGDB remains in the frame where the signal was received\\.\r\n.*" \ + "compile code segfault first" +gdb_test "bt" \ + "\r\n#0 \[^\r\n\]* in _gdb_expr \[^\r\n\]*\r\n#1 <function called from gdb>\r\n.*" + +set test "p/x \$pc" +set infcall_pc 0 +gdb_test_multiple $test $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + set infcall_pc $expect_out(1,string) + pass $test + } +} + +gdb_test "info sym $infcall_pc" "\r\n_gdb_expr.*" "info sym found" +gdb_test "return" "\r\n#0 main .*" "return" \ + "Make _gdb_expr\\(__gdb_regs\\*\\) return now\\? \\(y or n\\) " "y" +gdb_test "info sym $infcall_pc" "\r\nNo symbol matches .*" "info sym not found" + +gdb_test_no_output "set unwindonsignal on" +gdb_test "compile code *(volatile int *) 0 = 0;" \ + "The program being debugged was signaled while in a function called from GDB\\.\r\nGDB has restored the context to what it was before the call\\.\r\n.*" \ + "compile code segfault second" + +gdb_breakpoint [gdb_get_line_number "break-here"] +gdb_continue_to_breakpoint "break-here" ".* break-here .*" + +# C++ Specific tests. +## Public methods and members + +gdb_test "print foovar.public_var" "42" \ + "Test compile code foovar.public_var = 42 setting." +gdb_test_no_output "compile code foovar.public_var = 43;" \ + "set foobar.public_var to 43" +gdb_test "print foovar.public_var" "43" \ + "Test compile code foovar.public_var = 43 setting." +gdb_test "print foovar.public_method ()" "43" \ + "Test compile code foovar.public_method = 43 setting." + +## Private methods and members +gdb_test_no_output "compile code foovar.set_private_var (84);" \ + "Call class function to set private_var" +gdb_test "print foovar.private_var" "84" \ + "Test compile code foovar.set_private_var = 84 setting." +gdb_test_no_output "compile code foovar.private_var = 85" \ + "Directly set a private member in GDB compile5" +gdb_test "print foovar.private_var" "85" \ + "Test compile code foovar.set_private_var = 85 setting." + +## Simple inheritance +CompileExpression::new "var" +CompileExpression::test "class Baz: public Foo {public: int z = 12;}; Baz bazvar; bazvar.z = 24; var = bazvar.z" 24 -explicit +## Multiple inheritance +CompileExpression::test "class MI: public Base, public Base2 {int pure_virt () {return 42;}}; MI MIVar; var = MIVar.pure_virt();" 42 -explicit +CompileExpression::test "class MI: public Base, public Base2 {int pure_virt () {return Base::return_value() + 42;}}; MI MIVar; var = MIVar.pure_virt();" 43 -explicit +CompileExpression::test "class Base3 {public: int z = 99;}; class MI: public Base, public Base3 {int pure_virt () {return Base3::z + 42;}}; MI MIVar; var = MIVar.pure_virt();" 141 -explicit + +gdb_test "p localvar" " = 50" "expect localvar 50" + +gdb_test_no_output "compile code localvar = 12;" "set localvar" +gdb_test "p localvar" " = 12" "expect 12" + +gdb_test_no_output "compile code localvar *= 2;" "modify localvar" +gdb_test "p localvar" " = 24" "expect 24" + +gdb_test_no_output "compile code localvar = shadowed" \ + "test shadowing" +gdb_test "p localvar" " = 52" "expect 52" + +gdb_test_no_output "compile code localvar = externed" +gdb_test "p localvar" " = 7" "test extern in inner scope" + +gdb_test_no_output "compile code vla\[2\] = 7" +gdb_test "p vla\[2\]" " = 7" +gdb_test_no_output \ + "compile code localvar = (sizeof (vla) == bound * sizeof (vla\[0\]))" +gdb_test "p localvar" " = 1" + +# +# Test setting fields and also many different types. +# + +gdb_test_no_output "compile code struct_object.selffield = (struct_type*)&struct_object" +gdb_test "print struct_object.selffield == &struct_object" " = true" + +gdb_test_no_output "compile code struct_object.charfield = 1" +gdb_test "print struct_object.charfield" " = 1 '\\\\001'" +gdb_test_no_output "compile code struct_object.ucharfield = 1" +gdb_test "print struct_object.ucharfield" " = 1 '\\\\001'" + +foreach {field value} { + shortfield -5 + ushortfield 5 + intfield -7 + uintfield 7 + bitfield 2 + longfield -9 + ulongfield 9 + enumfield ONE + floatfield 1 + doublefield 2 +} { + gdb_test_no_output "compile code struct_object.$field = $value" + gdb_test "print struct_object.$field" " = $value" +} + +gdb_test_no_output "compile code struct_object.arrayfield\[2\] = 7" +gdb_test "print struct_object.arrayfield" \ + " = \\{0, 0, 7, 0, 0\\}" + +gdb_test_no_output "compile code struct_object.complexfield = 7 + 5i" +gdb_test "print struct_object.complexfield" " = 7 \\+ 5 \\* I" + +gdb_test_no_output "compile code struct_object.boolfield = 1" +gdb_test "print struct_object.boolfield" " = true" + +gdb_test_no_output "compile code struct_object.vectorfield\[2\] = 7" +gdb_test "print struct_object.vectorfield" \ + " = \\{0, 0, 7, 0\\}" + +gdb_test_no_output "compile code union_object.typedeffield = 7" +gdb_test "print union_object.typedeffield" " = 7" +gdb_test "print union_object.intfield" " = 7" + + +# LOC_UNRESOLVED tests. + +gdb_test "print unresolved" " = 20" +gdb_test "compile code globalvar = unresolved;" +gdb_test "print globalvar" " = 20" "print unresolved value" + +# Test shadowing with global and static variables. + +gdb_test_no_output "compile code globalshadow += 1;" +gdb_test "print globalshadow" " = 101" +gdb_test_no_output "compile code extern int globalshadow; globalshadow += 5;" +gdb_test "print 'compile-cplus.c'::globalshadow" " = 15" +gdb_test "print globalshadow" " = 101" "print globalshadow second time" +gdb_test_no_output "compile code staticshadow += 2;" +gdb_test "print staticshadow" " = 202" +# "extern int staticshadow;" cannot access static variable. + +# Raw code cannot refer to locals. +# As it references global variable we need the #pragma. +# For #pragma we need multiline input. +gdb_test_multiple "compile code -r" "compile code -r multiline 1" { -re "\r\n>$" {} } +gdb_test_multiple "void _gdb_expr(void) {" "compile code -r multiline 2" { -re "\r\n>$" {} } +gdb_test_multiple "#pragma GCC push_user_expression" "compile code -r multiline 3" { -re "\r\n>$" {} } +gdb_test_multiple " globalshadow = 77000;" "compile code -r multiline 4" { -re "\r\n>$" {} } +gdb_test_multiple "#pragma GCC pop_user_expression" "compile code -r multiline 5" { -re "\r\n>$" {} } +gdb_test_multiple "}" "compile code -r multiline 6" { -re "\r\n>$" {} } +gdb_test_no_output "end" "compile code -r multiline 7" +gdb_test "print 'compile-cplus.c'::globalshadow" " = 77000" \ + "check globalshadow with -r" + +# Test GOT vs. resolving jit function pointers. + +gdb_test_no_output "compile -raw -- extern \"C\" void abort(); int func(){return 21;} void _gdb_expr(){int (*funcp)()=func; if (funcp()!=21) abort();}" \ + "pointer to jit function" + +# +# Test the case where the registers structure would not normally have +# any fields. +# + +gdb_breakpoint [gdb_get_line_number "no_args_or_locals breakpoint"] +gdb_continue_to_breakpoint "no_args_or_locals" + +gdb_test_no_output "compile code globalvar = 77;" "set variable to 77" +gdb_test "p globalvar" " = 77" "expect 77" + + +# Test reference to minimal_symbol, not (full) symbol. + +gdb_test_no_output "compile code globalvar = func_nodebug (75);" \ + "call func_nodebug" +gdb_test "p globalvar" " = -75" "expect -75" +gdb_test_no_output \ + "compile code int (*funcp) (int) = (int(*)(int))func_nodebug; globalvar = funcp (76);" \ + "call func_nodebug indirectly" +gdb_test "p globalvar" " = -76" "expect -76" + + +# Test compiled module memory protection. + +gdb_test_no_output "set debug compile on" +gdb_test "compile code static const int readonly = 1; *(int *) &readonly = 2;" \ + "The program being debugged was signaled while in a function called from GDB\\.\r\nGDB has restored the context to what it was before the call\\.\r\n.*" +gdb_test_no_output "set debug compile off" + + +# +# Some simple coverage tests. +# + +gdb_test "show debug compile" "Compile debugging is .*" +gdb_test "show compile-args" \ + "Compile command command-line arguments are .*" +gdb_test "compile code -z" "Unknown argument.*" + +gdb_test "set lang rust" \ + "Warning: the current language does not match this frame." +gdb_test "compile code globalvar" "No compiler support for language rust\." +gdb_test_no_output "set lang auto" + +gdb_test_no_output "compile code union union_type newdecl_u" +gdb_test_no_output "compile code struct struct_type newdecl_s" +gdb_test_no_output "compile code inttypedef newdecl_i" + +gdb_test "compile file" \ + "You must provide a filename for this command.*" \ + "Test compile file without a filename" +gdb_test "compile file -r" \ + "You must provide a filename with the raw option set.*" \ + "Test compile file and raw option without a filename" +gdb_test "compile file -z" \ + "Unknown argument.*" \ + "Test compile file with unknown argument" + + +# LOC_CONST tests. + +if { $srcfile3 != "" } { + gdb_test "p constvar" " = 3" + gdb_test "info addr constvar" {Symbol "constvar" is constant\.} + + gdb_test "compile code globalvar = constvar;" + gdb_test "print globalvar" " = 3" "print constvar value" +} else { + untested "print constvar value" +} diff --git a/gdb/testsuite/lib/compile-support.exp b/gdb/testsuite/lib/compile-support.exp new file mode 100644 index 0000000000..b784c3549b --- /dev/null +++ b/gdb/testsuite/lib/compile-support.exp @@ -0,0 +1,227 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Generic/oft used support routines for testing GDB's compile feature. + +# Return 1 if we should skip tests of the "compile" feature. +# This must be invoked after the inferior has been started. + +proc skip_compile_feature_tests {} { + global gdb_prompt + + set result 0 + gdb_test_multiple "compile code -- ;" "check for working compile command" { + "Could not load libcc1.*\r\n$gdb_prompt $" { + set result 1 + } + -re "Command not supported on this host\\..*\r\n$gdb_prompt $" { + set result 1 + } + -re "\r\n$gdb_prompt $" { + } + } + return $result +} + +# This namespace provides some convenience functions for running +# "compile code" and "compile print" tests. +# +# Exported functions are defined inline below. +# +# General usage: +# +# Start a new session, noting that the variable "var" will be used for +# "compile code" expressions. This variable /must/ exist in the stopped +# location. +# +# CompileExpression::new "var" +# +# Test the implicit expression "foo;" with result/value 3. +# CompileExpression::test "foo" 3 +# ---> Runs the following tests (name of tests ignored for illustration) +# gdb_test_no_output "compile code var = foo" +# gdb_test "p var" "= 3" +# gdb_test "compile print foo;" "= 3" +# +# Test the explicit expression "a = function (3); var = a;" with the result 21. +# CompileExpression::test "a = function (3); var = a;" 21 -explicit +# ---> Runs the following tests (name of tests ignored for illustration) +# gdb_test_no_output "compile code a = function (3); var = a;" +# gdb_test "p var" "= 21" +# +# Additional option flags may be passed to test to control the behavior +# of the test harness: +# +# Pass -explicit to specify that the test uses an explicit expression, +# one which sets the value of the variable (see above). Only the code test +# will be run. +# +# Pass -value and/or -print to indicate that the value and/or print steps +# will optionally fail. Specify "xfail" or "kfail" to indicate how +# particular step will fail. These may be followed by any accepted DejaGNU +# parameters such as architecture and bug#. [See examples below.] +# +# To specify that the compile (and consequently print and value tests) is +# expected to kfail/xfail, use -kfail or -xfail with any appropriate +# DejaGNU parameters. Both options override -print and -value. +# [-xfail is given precedence over -kfail should both be given.] +# +# -value is used when a "code" test is run, specifying that the "compile +# code" and "print VAR" steps will fail in the prescribed manner. +# [If the print step generates a PASS, the test is considered invalidly +# written. VAR's value should /always/ be invalidated before a test is +# run.] +# +# -print is used to specify that an expression will fail in the prescribed +# manner when "print" test is executed. +# +# Pass "-name NAME" to set an optional test name. If not specified, +# the harness will use test names such as "compile code EXPR" and +# "result of compile code EXPR". +# +# Pass "-noprint" or "-nocode" to suppress print or code tests, respectively, +# This is useful when the expression being tested modifies the object +# being tested, e.g., "a++". +# +# These options must be passed LAST to CompileExpression::test. +# +# Examples: +# +# Both "code" and "print" tests are expected to xfail: +# CompileExpression add_imp "foo" 3 -compile {xfail *-*-*} -print {xfail *-*-*} +# +# The "print $VARIABLE" portion of the "code" test is expected to kfail +# (the actual "compile code" GDB command will succeed), but the "print" +# test should pass: +# CompileExpression add_imp "foo" 3 -value {kfail *-*-* gdb/1234} + +namespace eval ::CompileExpression { + + # The variable name to check testing results. This variable + # must be in scope when tests are run. + variable varName_ {} + + # Start a new expression list. VARNAME is the name of the variable + # that will be printed to check if the result of the test was + # successful. + proc new {varname} { + variable varName_ + + set varName_ $varname + } + + # Test an expression. + # + # See the preamble for a list of valid optional arguments. + # + # Implicit expressions will be sent to GDB in the form + # "$varName = $EXP". "p $varName" will be used to decide the pass + # or fail status of the test. + # + # Explicit expressions will be sent to GDB as-is and tested using only + # "compile code". The expression should set the value of the variable + # $varName, which is then printed to determine whether the test passed + # or failed. + # + # Unlike explicit expressions, implicit expressions are tested with both + # "compile print" and "compile code". + + proc test {exp result args} { + parse_args {{value {"" ""}} {print {"" ""}} {name ""} + {noprint} {nocode} {explicit} {xfail {"" ""}} {kfail {"" ""}}} + + if {[lindex $xfail 0] != ""} { + set l "xfail $xfail" + } elseif {[lindex $kfail 0] != ""} { + set l "kfail $kfail" + } else { + set l "" + set compile {"" ""} + } + if {$l != ""} { + set compile $l + set print $l + set value $l + } + + if {!$nocode} { + do_test_ code $exp $result $explicit $name \ + [list $compile $value $print] + } + if {!$noprint} { + do_test_ print $exp $result $explicit $name \ + [list $compile $value $print] + } + } + + # Run a compile test for CMD ("print" or "code"). + + proc do_test_ {cmd exp result is_explicit tst fail_list} { + variable varName_ + + if {![string match $cmd "code"] + && ![string match $cmd "print"]} { + error "invalid command, $cmd; should be \"print\" or \"compile\"" + } + + # Get expected result of test. Will be "" if test is + # expected to PASS. + lassign $fail_list fail_compile fail_value fail_print + + # Set a test name if one hasn't been provided. + if {$tst == ""} { + set tst "compile $cmd $exp" + } + + if {[string match $cmd "print"]} { + if {!$is_explicit} { + eval setup_failures_ $fail_print + gdb_test "compile print $exp" $result $tst + } + } else { + if {$is_explicit} { + set command "compile code $exp" + } else { + set command "compile code $varName_ = $exp" + } + eval setup_failures_ $fail_compile + gdb_test_no_output $command $tst + eval setup_failures_ $fail_value + gdb_test "p $varName_" "= $result" "result of $tst" + } + } + + # A convenience proc used to set up xfail and kfail tests. + # HOW is either xfail or kfail (case is ignored). ARGS is any + # optional architecture, bug number, or other string to pass to + # respective DejaGNU setup_$how routines. + + proc setup_failures_ {how args} { + switch -nocase $how { + xfail { + eval setup_xfail $args + } + + kfail { + eval setup_kfail $args + } + + default { + # Do nothing. Either the test is expected to PASS + # or we have an unhandled failure mode. + } + } + } +} -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-10 23:32 ` [PATCH 9/9] C++ compile support Keith Seitz @ 2018-08-11 7:22 ` Eli Zaretskii 2018-08-17 17:51 ` Keith Seitz 2018-08-12 0:17 ` Tom Tromey 2021-03-24 1:04 ` Simon Marchi 2 siblings, 1 reply; 45+ messages in thread From: Eli Zaretskii @ 2018-08-11 7:22 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches > From: Keith Seitz <keiths@redhat.com> > Date: Fri, 10 Aug 2018 16:25:34 -0700 > > This initial support has several glaring omissions: > - No template support at all > I have follow-on patches for this, but they add much complexity > to this "basic" support. Consequently, they will be submitted separately. > - Cannot print functions > The code template needs tweaking, and I simply haven't gotten to it yet. > - So-called "special function" support is not included > Using constructors, destructors, operators, etc will not work. I have > follow-on patches for that, but they require some work because of the > recent churn in symbol searching. > - There are several test suite references to "compile/1234" bugs. > I will file bugs and update the test suite's bug references before pushing > these patches. Shouldn't these omissions be mentioned somewhere? Like in NEWS? > +* GDB now has experimental support for the compilation and injection of > + C++ source code into the inferior. This feature requires the GCC C++ > + plug-in available since GCC 7.1. The last sentence basically means "only on ELF platforms", right? So IMO this limitation should be stated explicitly, lest people get excited, and then get disappointed. > +set debug compile-oracle > +show debug compile-oracle > + Control the display of debug output about symbol requests from > + the compiler plug-in. > + > +set debug compile-cplus-types > +show debug compile-cplus-types > + Control the display of debug output about C++ type conversion > + in the compile feature. I suggest to mention that these commands are only available/have effect if the C++ compilation is supported. > +@anchor{set debug compile-oracle} > +@item set debug compile-oracle > +@cindex compile oracle debugging info > +Turns on or off display of symbol requests from the compiler plug-in > +(the ``oracle''). The default is off. @dfn{oracle} should render better. In any case, why do we call this "the oracle"? In the computing context, "oracle" has connotations that we don't necessarily want to encourage, I think. Why not something like "set debug symbol-requests"? > +Turns on or off the display of C++ type conversion debugging information. Please use C@t{++} for C++ in the text, it renders better in the printed manual. OK for the documentation parts, with those nits fixed. Thanks. ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-11 7:22 ` Eli Zaretskii @ 2018-08-17 17:51 ` Keith Seitz 2018-08-17 18:57 ` Eli Zaretskii 0 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-17 17:51 UTC (permalink / raw) To: Eli Zaretskii; +Cc: gdb-patches On 08/11/2018 12:22 AM, Eli Zaretskii wrote: >> From: Keith Seitz <keiths@redhat.com> >> Date: Fri, 10 Aug 2018 16:25:34 -0700 >> >> This initial support has several glaring omissions: >> - No template support at all >> I have follow-on patches for this, but they add much complexity >> to this "basic" support. Consequently, they will be submitted separately. >> - Cannot print functions >> The code template needs tweaking, and I simply haven't gotten to it yet. >> - So-called "special function" support is not included >> Using constructors, destructors, operators, etc will not work. I have >> follow-on patches for that, but they require some work because of the >> recent churn in symbol searching. >> - There are several test suite references to "compile/1234" bugs. >> I will file bugs and update the test suite's bug references before pushing >> these patches. > > Shouldn't these omissions be mentioned somewhere? Like in NEWS? To be honest, I was hesitant to even mention this in NEWS at all (yet). The code is *very* beta and incomplete (as you can see). That's why the "experimental" moniker. Nonetheless, assuming we want to mention it, I've changed the entry to: * GDB now has experimental support for the compilation and injection of C++ source code into the inferior. This beta release does not include support for several language features, such as templates, constructors, and operators. > >> +* GDB now has experimental support for the compilation and injection of >> + C++ source code into the inferior. This feature requires the GCC C++ >> + plug-in available since GCC 7.1. > > The last sentence basically means "only on ELF platforms", right? So > IMO this limitation should be stated explicitly, lest people get > excited, and then get disappointed. I'm not sure how to answer this. That seems like enumerating all the dependencies of every dependency GDB has (bfd, libiberty, bison, etc). The feature (like the C compile feature already included) requires the compiler plug-in. Whatever that plug-in supports is what GDB supports. Would you like me to include something like: "Currently tested on x86_64 GNU/Linux." That tells readers what is known to work without suggesting all possible permutations of host/OS that might work [but are untested AFAIK]. >> +set debug compile-oracle >> +show debug compile-oracle >> + Control the display of debug output about symbol requests from >> + the compiler plug-in. >> + >> +set debug compile-cplus-types >> +show debug compile-cplus-types >> + Control the display of debug output about C++ type conversion >> + in the compile feature. > > I suggest to mention that these commands are only available/have > effect if the C++ compilation is supported. Maybe this is better/clearer? set debug compile-cplus-types show debug compile-cplus-types Control the display of debug output about type conversion in the C++ compile feature. Commands have no effect while compiling for other languages. >> +@anchor{set debug compile-oracle} >> +@item set debug compile-oracle >> +@cindex compile oracle debugging info >> +Turns on or off display of symbol requests from the compiler plug-in >> +(the ``oracle''). The default is off. > > @dfn{oracle} should render better. In any case, why do we call this > "the oracle"? In the computing context, "oracle" has connotations > that we don't necessarily want to encourage, I think. Why not > something like "set debug symbol-requests"? This symbol resolver design is called the "oracle" internally (see also references to this name in the Wiki page describing the compile project, https://sourceware.org/gdb/wiki/GCCCompileAndExecute ). Nonetheless, on second thought, it seems almost nonsensical to have a special debug flag just for this. So I've removed the option and just added the "oracle" debug output when the "normal" compile debug flag is set. WDYT? >> +Turns on or off the display of C++ type conversion debugging information. > > Please use C@t{++} for C++ in the text, it renders better in the > printed manual. Done. Would you like me to repost this patch? Keith ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-17 17:51 ` Keith Seitz @ 2018-08-17 18:57 ` Eli Zaretskii 2018-08-20 17:02 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Eli Zaretskii @ 2018-08-17 18:57 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches > Cc: gdb-patches@sourceware.org > From: Keith Seitz <keiths@redhat.com> > Date: Fri, 17 Aug 2018 10:50:53 -0700 > > * GDB now has experimental support for the compilation and injection of > C++ source code into the inferior. This beta release does not include > support for several language features, such as templates, constructors, > and operators. This is fine, thanks. > >> +* GDB now has experimental support for the compilation and injection of > >> + C++ source code into the inferior. This feature requires the GCC C++ > >> + plug-in available since GCC 7.1. > > > > The last sentence basically means "only on ELF platforms", right? So > > IMO this limitation should be stated explicitly, lest people get > > excited, and then get disappointed. > > I'm not sure how to answer this. That seems like enumerating all the dependencies > of every dependency GDB has (bfd, libiberty, bison, etc). The feature (like the > C compile feature already included) requires the compiler plug-in. Whatever that > plug-in supports is what GDB supports. It is okay to say that this is supported only on platforms where libcc1.so and the 'compile' command are available. My problem was with not qualifying this at all. > Would you like me to include something like: "Currently tested on x86_64 > GNU/Linux." Using "currently" is generally not advisable, as the meaning of that word changes with time. > >> +set debug compile-oracle > >> +show debug compile-oracle > >> + Control the display of debug output about symbol requests from > >> + the compiler plug-in. > >> + > >> +set debug compile-cplus-types > >> +show debug compile-cplus-types > >> + Control the display of debug output about C++ type conversion > >> + in the compile feature. > > > > I suggest to mention that these commands are only available/have > > effect if the C++ compilation is supported. > > Maybe this is better/clearer? > > set debug compile-cplus-types > show debug compile-cplus-types > Control the display of debug output about type conversion in the > C++ compile feature. Commands have no effect while compiling for > other languages. Yes, better. > Nonetheless, on second thought, it seems almost nonsensical to have a > special debug flag just for this. So I've removed the option and just > added the "oracle" debug output when the "normal" compile debug flag > is set. WDYT? OK. > Would you like me to repost this patch? That won't be needed, thanks. ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-17 18:57 ` Eli Zaretskii @ 2018-08-20 17:02 ` Keith Seitz 0 siblings, 0 replies; 45+ messages in thread From: Keith Seitz @ 2018-08-20 17:02 UTC (permalink / raw) To: gdb-patches On 08/17/2018 11:57 AM, Eli Zaretskii wrote: >> I'm not sure how to answer this. That seems like enumerating all the dependencies >> of every dependency GDB has (bfd, libiberty, bison, etc). The feature (like the >> C compile feature already included) requires the compiler plug-in. Whatever that >> plug-in supports is what GDB supports. > > It is okay to say that this is supported only on platforms where > libcc1.so and the 'compile' command are available. My problem was > with not qualifying this at all. Gotcha. I've "copied" the announcement text from the original (C) compile submission talking about compiler requirement: This feature requires GCC 7.1 or higher built with libcp1.so (the C++ plug-in). >> Would you like me to include something like: "Currently tested on x86_64 >> GNU/Linux." > > Using "currently" is generally not advisable, as the meaning of that > word changes with time. Indeed! I've removed this text in favor of the above requirement statement. >> Would you like me to repost this patch? > > That won't be needed, thanks. Thank you for your comments/suggestions! Keith ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-10 23:32 ` [PATCH 9/9] C++ compile support Keith Seitz 2018-08-11 7:22 ` Eli Zaretskii @ 2018-08-12 0:17 ` Tom Tromey 2018-08-17 18:26 ` Keith Seitz 2021-03-24 1:04 ` Simon Marchi 2 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-12 0:17 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch adds *basic* support for C++ to the compile feature. It does Keith> most simple type conversions, including everything that C compile does and Keith> your basic "with-classes" type of C++. Thanks for doing this. This is very good. Keith> +extern compile_instance *cplus_get_compile_context (void); I think we stopped using (void) now. Keith> +typedef compile_program<compile_cplus_instance, Keith> + cplus_push_user_expression, cplus_pop_user_expression, Keith> + cplus_add_code_header, c_add_code_footer, Keith> + cplus_add_input> cplus_compile_program; Keith> + Haha, this seemed like overkill to me, but I see it's already this way, and it doesn't really matter I think. Keith> diff --git a/gdb/compile/compile-cplus-support.c b/gdb/compile/compile-cplus-support.c Keith> new file mode 100644 Keith> index 0000000000..42fc7692c4 [...] Keith> +void Keith> +gcc_cplus_enter_scope (void *datum, struct gcc_cp_context *gcc_context) Keith> +{ Keith> +} Keith> + Keith> +void Keith> +gcc_cplus_leave_scope (void *datum, struct gcc_cp_context *gcc_context) Keith> +{ Keith> +} Is this something that gets expanded in later patches? If not, I'd suggest just making these private static methods on compile_cplus_instance, to avoid needing a new file. On the other hand, if this is expanded in the future, then it is totally fine like this. Keith> +/* Convert a given symbol, SYM, to the compiler's representation. Keith> + INSTANCE is the compiler instance. IS_GLOBAL is true if the Keith> + symbol came from the global scope. IS_LOCAL is true if the symbol Keith> + came from a local scope. (Note that the two are not strictly Keith> + inverses because the symbol might have come from the static Keith> + scope.) */ Keith> + Keith> +static void Keith> +convert_one_symbol (compile_cplus_instance *instance, Keith> + struct block_symbol sym, bool is_global, bool is_local) I think back in the day, I'd hoped that there would be more code sharing between the C and C++ compile paths. But maybe this wasn't possible? I didn't do a deep comparison or anything. And it's fine if they have to be separate. Keith> +void _initialize_compile_cplus_symbols (void); I think this declaration isn't needed any more. Keith> +/* See description in compile-cplus.h. */ Keith> + Keith> +gdb::unique_xmalloc_ptr<char> Keith> +decl_name (const char *natural) This should return a std::string. See below. Keith> + std::string symbol = (comp.bsymbol.symbol != nullptr Keith> + ? SYMBOL_NATURAL_NAME (comp.bsymbol.symbol) Keith> + : "<none>"); This could just be a const char * to avoid an allocation. Keith> +/* Utility function to convert CODE into a string. */ Keith> + Keith> +static const char * Keith> +type_code_to_string (enum type_code code) Keith> +{ Keith> + const char * const s[] = Keith> + {"BISTRING (deprecated)", "UNDEF (not used)", Keith> + "PTR", "ARRAY", "STRUCT", "UNION", "ENUM", Keith> + "FLAGS", "FUNC", "INT", "FLT", "VOID", Keith> + "SET", "RANGE", "STRING", "ERROR", "METHOD", Keith> + "METHODPTR", "MEMBERPTR", "REF", "RVALUE_REF", "CHAR", "BOOL", Keith> + "COMPLEX", "TYPEDEF", "NAMESPACE", "DECFLOAT", "MODULE", Keith> + "INTERNAL_FUNCTION", "XMETHOD"}; Keith> + Keith> + return s[code + 1]; This could get out of sync with gdbtypes.h. So I'd suggest either (1) taking the simple route and printing this as an integer; or (2) moving the enum to a .defs file and auto-generating the strings from it, to avoid any possibility of problems. In case 2, type_code_to_string could move to gdbtypes.c. Keith> + scope_component comp Keith> + = { Keith> + decl_name (TYPE_NAME (type)).release (), Keith> + lookup_symbol (TYPE_NAME (type), block (), VAR_DOMAIN, nullptr) scope_component::name is a std::string, so I think this decl_name call will leak memory; which is why decl_name should return a std::string itself. Keith> +/* Return the declaration name of the symbol named NATURAL. Keith> + This returns a name with no function arguments or template parameters, Keith> + suitable for passing to the compiler plug-in. */ Keith> + Keith> +gdb::unique_xmalloc_ptr<char> decl_name (const char *natural); This seems like a fairly generic name for something that is maybe specific to the C++ compile code. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-12 0:17 ` Tom Tromey @ 2018-08-17 18:26 ` Keith Seitz 2018-08-28 17:52 ` Tom Tromey 0 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-17 18:26 UTC (permalink / raw) To: Tom Tromey; +Cc: gdb-patches On 08/11/2018 05:16 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: > Keith> +extern compile_instance *cplus_get_compile_context (void); > > I think we stopped using (void) now. Indeed. I've audited the code and removed these. > Keith> +typedef compile_program<compile_cplus_instance, > Keith> + cplus_push_user_expression, cplus_pop_user_expression, > Keith> + cplus_add_code_header, c_add_code_footer, > Keith> + cplus_add_input> cplus_compile_program; > Keith> + > > Haha, this seemed like overkill to me, but I see it's already this way, > and it doesn't really matter I think. Yeah, it is overkill. I debated whether to include this or not, and in the end, I think I simply forgot about it. O:-) > Keith> diff --git a/gdb/compile/compile-cplus-support.c b/gdb/compile/compile-cplus-support.c > Keith> new file mode 100644 > Keith> index 0000000000..42fc7692c4 > [...] > Keith> +void > Keith> +gcc_cplus_enter_scope (void *datum, struct gcc_cp_context *gcc_context) > Keith> +{ > Keith> +} > Keith> + > Keith> +void > Keith> +gcc_cplus_leave_scope (void *datum, struct gcc_cp_context *gcc_context) > Keith> +{ > Keith> +} > > Is this something that gets expanded in later patches? Unfortunately, no it is not something that is expanded in later patches. It *should* be, but I haven't gotten to it yet. :-( > If not, I'd suggest just making these private static methods on > compile_cplus_instance, to avoid needing a new file. This just makes more sense than having another file which contains only these two functions. I've made that change. > Keith> +/* Convert a given symbol, SYM, to the compiler's representation. > Keith> + INSTANCE is the compiler instance. IS_GLOBAL is true if the > Keith> + symbol came from the global scope. IS_LOCAL is true if the symbol > Keith> + came from a local scope. (Note that the two are not strictly > Keith> + inverses because the symbol might have come from the static > Keith> + scope.) */ > Keith> + > Keith> +static void > Keith> +convert_one_symbol (compile_cplus_instance *instance, > Keith> + struct block_symbol sym, bool is_global, bool is_local) > > I think back in the day, I'd hoped that there would be more code sharing > between the C and C++ compile paths. But maybe this wasn't possible? I > didn't do a deep comparison or anything. And it's fine if they have to > be separate. I hear you. To be honest, when I got onto the project, the entirety of the existing compile files were copied to C++ equivalents. If I'm brutally honest, I haven't investigated this at all. [Or even thought it was going to be possible. Not to say that it isn't possible. Just that I didn't think it would be.] > Keith> +void _initialize_compile_cplus_symbols (void); > > I think this declaration isn't needed any more. Yup. Removed all such offenses. > Keith> +/* See description in compile-cplus.h. */ > Keith> + > Keith> +gdb::unique_xmalloc_ptr<char> > Keith> +decl_name (const char *natural) > > This should return a std::string. See below. Actually, that turns out not to be so easy because of the difference between "" and NULL in the compiler plug-in API. We lose this distinction if we switch to std::string. [more below] > Keith> + std::string symbol = (comp.bsymbol.symbol != nullptr > Keith> + ? SYMBOL_NATURAL_NAME (comp.bsymbol.symbol) > Keith> + : "<none>"); > > This could just be a const char * to avoid an allocation. That's an almost comical error! Fixed. > Keith> +/* Utility function to convert CODE into a string. */ > Keith> + > Keith> +static const char * > Keith> +type_code_to_string (enum type_code code) > Keith> +{ > Keith> + const char * const s[] = > Keith> + {"BISTRING (deprecated)", "UNDEF (not used)", > Keith> + "PTR", "ARRAY", "STRUCT", "UNION", "ENUM", > Keith> + "FLAGS", "FUNC", "INT", "FLT", "VOID", > Keith> + "SET", "RANGE", "STRING", "ERROR", "METHOD", > Keith> + "METHODPTR", "MEMBERPTR", "REF", "RVALUE_REF", "CHAR", "BOOL", > Keith> + "COMPLEX", "TYPEDEF", "NAMESPACE", "DECFLOAT", "MODULE", > Keith> + "INTERNAL_FUNCTION", "XMETHOD"}; > Keith> + > Keith> + return s[code + 1]; > > This could get out of sync with gdbtypes.h. So I'd suggest either (1) > taking the simple route and printing this as an integer; or (2) moving > the enum to a .defs file and auto-generating the strings from it, to > avoid any possibility of problems. In case 2, type_code_to_string could > move to gdbtypes.c. For now, I've gone the simple route. This is done in several other places already (IIRC). I'd rather submit a separate patch that propagates this to_string everywhere. > Keith> + scope_component comp > Keith> + = { > Keith> + decl_name (TYPE_NAME (type)).release (), > Keith> + lookup_symbol (TYPE_NAME (type), block (), VAR_DOMAIN, nullptr) > > scope_component::name is a std::string, so I think this decl_name call > will leak memory; which is why decl_name should return a std::string > itself. Good catch. For now, I've changed this to .get() the result of the unique_ptr. It's a copy, but I don't consider any of this time-critical. [To be clear, that's because I'm focused on making it work right now.] > Keith> +/* Return the declaration name of the symbol named NATURAL. > Keith> + This returns a name with no function arguments or template parameters, > Keith> + suitable for passing to the compiler plug-in. */ > Keith> + > Keith> +gdb::unique_xmalloc_ptr<char> decl_name (const char *natural); > > This seems like a fairly generic name for something that is maybe > specific to the C++ compile code. Indeed. I've moved it to a static function of compile_cplus_instance. While double-double-double-double-...-checking everything, I also noticed the "bug" that you approved yesterday (gdb_test_no_output in gdb.compile/compile.exp). That was hiding a simple bug causing double-definition of some symbols. I've corrected that bug here and KFAILed any remaining failing tests. [I thought I had already KFAILed these, but I missed compile-cplus.exp and compile-cplus-print.exp.] I do apologize for that. The complete list of changes in this revision: a) removed "(void)" everywhere b) removed compile-cplus-support.c and moved functions to private static members of compile_cplus_instance c) removed _initialize_XYZ decls d) moved decl_name to static member of compile_cplus_instance e) used get instead of release in new_scope f) KFAIL remaining compile-cplus.exp/compile-cplus-print.exp tests and fixed a bug uncovered by missing "_no_output" buglet g) std::string --> const char * to avoid allocation h) removed type_code_to_string Keith Subject: [PATCH] C++ compile support This patch adds *basic* support for C++ to the compile feature. It does most simple type conversions, including everything that C compile does and your basic "with-classes" type of C++. I've written a new compile-support.exp support file which adds a new test facility for automating and simplifying "compile print" vs "compile code" testing. See testsuite/lib/compile-support.exp and CompileExpression for more on that. The tests use this facility extensively. This initial support has several glaring omissions: - No template support at all I have follow-on patches for this, but they add much complexity to this "basic" support. Consequently, they will be submitted separately. - Cannot print functions The code template needs tweaking, and I simply haven't gotten to it yet. - So-called "special function" support is not included Using constructors, destructors, operators, etc will not work. I have follow-on patches for that, but they require some work because of the recent churn in symbol searching. - There are several test suite references to "compile/1234" bugs. I will file bugs and update the test suite's bug references before pushing these patches. The test suite started as a copy of the original C-language support, but I have written tests to exercise the basic functionality of the plug-in. I've added a new option for outputting debug messages for C++ type-conversion ("debug compile-cplus-types"). gdb/ChangeLog: * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Add compile-cplus-symbols.c and compile-cplus-types.c. (HFILES_NO_SRCDIR): Add gcc-cp-plugin.h. * c-lang.c (cplus_language_defn): Set C++ compile functions. * c-lang.h (cplus_get_compile_context, cplus_compute_program): Declare. * compile/compile-c-support.c: Include compile-cplus.h. (load_libcompile): Templatize. (get_compile_context): "New" function. (c_get_compile_context): Use get_compile_context. (cplus_get_compile_context): New function. (cplus_push_user_expression, cplus_pop_user_expression) (cplus_add_code_header, cplus_add_input, cplus_compile_program) (cplus_compute_program): Define new structs/functions. * compile/compile-cplus-symmbols.c: New file. * compile/compile-cplus-types.c: New file. * compile/compile-cplus.h: New file. * compile/compile-internal.h (debug_compile_oracle, GCC_TYPE_NONE): Declare. * compile/compile-object-load.c (get_out_value_type): Use strncmp_iw when comparing symbol names. (compile_object_load): Add mst_bss and mst_data. * compile/compile.c (_initialize_compile): Remove -Wno-implicit-function-declaration from `compile_args'. * compile/gcc-cp-plugin.h: New file. * NEWS: Mention C++ compile support and new debug options. gdb/testsuite/ChangeLog: * gdb.compile/compile-cplus-anonymous.cc: New file. * gdb.compile/compile-cplus-anonymous.exp: New file. * gdb.compile/compile-cplus-array-decay.cc: New file. * gdb.compile/compile-cplus-array-decay.exp: New file. * gdb.compile/compile-cplus-inherit.cc: New file. * gdb.compile/compile-cplus-inherit.exp: New file. * gdb.compile/compile-cplus-member.cc: New file. * gdb.compile/compile-cplus-member.exp: New file. * gdb.compile/compile-cplus-method.cc: New file. * gdb.compile/compile-cplus-method.exp: New file. * gdb.compile/compile-cplus-mod.c: "New" file. * gdb.compile/compile-cplus-namespace.cc: New file. * gdb.compile/compile-cplus-namespace.exp: New file. * gdb.compile/compile-cplus-nested.cc: New file. * gdb.compile/compile-cplus-nested.exp: New file. * gdb.compile/compile-cplus-print.c: "New" file. * gdb.compile/compile-cplus-print.exp: "New" file. * gdb.compile/compile-cplus-virtual.cc: New file. * gdb.compile/compile-cplus-virtual.exp: New file. * gdb.compile/compile-cplus.c: "New" file. * gdb.compile/compile-cplus.exp: "New" file. * lib/compile-support.exp: New file. doc/ChangeLog: * gdb.texinfo (Compiling and injecting code in GDB): Document set/show "compile-oracle" and "compile-cplus-types" commands. --- gdb/ChangeLog | 29 + gdb/Makefile.in | 4 + gdb/NEWS | 14 + gdb/c-lang.c | 4 +- gdb/c-lang.h | 19 + gdb/compile/compile-c-support.c | 205 ++- gdb/compile/compile-cplus-symbols.c | 493 +++++++ gdb/compile/compile-cplus-types.c | 1427 ++++++++++++++++++++ gdb/compile/compile-cplus.h | 205 +++ gdb/compile/compile-internal.h | 4 + gdb/compile/compile-object-load.c | 7 +- gdb/compile/compile.c | 1 - gdb/compile/gcc-cp-plugin.h | 85 ++ gdb/doc/ChangeLog | 5 + gdb/doc/gdb.texinfo | 10 + gdb/testsuite/ChangeLog | 25 + .../gdb.compile/compile-cplus-anonymous.cc | 76 ++ .../gdb.compile/compile-cplus-anonymous.exp | 64 + .../gdb.compile/compile-cplus-array-decay.cc | 31 + .../gdb.compile/compile-cplus-array-decay.exp | 50 + gdb/testsuite/gdb.compile/compile-cplus-inherit.cc | 58 + .../gdb.compile/compile-cplus-inherit.exp | 53 + gdb/testsuite/gdb.compile/compile-cplus-member.cc | 83 ++ gdb/testsuite/gdb.compile/compile-cplus-member.exp | 76 ++ gdb/testsuite/gdb.compile/compile-cplus-method.cc | 91 ++ gdb/testsuite/gdb.compile/compile-cplus-method.exp | 67 + gdb/testsuite/gdb.compile/compile-cplus-mod.c | 28 + .../gdb.compile/compile-cplus-namespace.cc | 52 + .../gdb.compile/compile-cplus-namespace.exp | 51 + gdb/testsuite/gdb.compile/compile-cplus-nested.cc | 58 + gdb/testsuite/gdb.compile/compile-cplus-nested.exp | 53 + gdb/testsuite/gdb.compile/compile-cplus-print.c | 32 + gdb/testsuite/gdb.compile/compile-cplus-print.exp | 79 ++ gdb/testsuite/gdb.compile/compile-cplus-virtual.cc | 54 + .../gdb.compile/compile-cplus-virtual.exp | 71 + gdb/testsuite/gdb.compile/compile-cplus.c | 241 ++++ gdb/testsuite/gdb.compile/compile-cplus.exp | 347 +++++ gdb/testsuite/lib/compile-support.exp | 227 ++++ 38 files changed, 4449 insertions(+), 30 deletions(-) create mode 100644 gdb/compile/compile-cplus-symbols.c create mode 100644 gdb/compile/compile-cplus-types.c create mode 100644 gdb/compile/compile-cplus.h create mode 100644 gdb/compile/gcc-cp-plugin.h create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-inherit.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-inherit.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-member.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-member.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-method.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-method.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-mod.c create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-namespace.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-namespace.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-nested.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-nested.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-print.c create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-print.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-virtual.cc create mode 100644 gdb/testsuite/gdb.compile/compile-cplus-virtual.exp create mode 100644 gdb/testsuite/gdb.compile/compile-cplus.c create mode 100644 gdb/testsuite/gdb.compile/compile-cplus.exp create mode 100644 gdb/testsuite/lib/compile-support.exp diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0a7720cf17..35bf9dfdc9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,34 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Add compile-cplus-symbols.c + and compile-cplus-types.c. + (HFILES_NO_SRCDIR): Add gcc-cp-plugin.h. + * c-lang.c (cplus_language_defn): Set C++ compile functions. + * c-lang.h (cplus_get_compile_context, cplus_compute_program): + Declare. + * compile/compile-c-support.c: Include compile-cplus.h. + (load_libcompile): Templatize. + (get_compile_context): "New" function. + (c_get_compile_context): Use get_compile_context. + (cplus_get_compile_context): New function. + (cplus_push_user_expression, cplus_pop_user_expression) + (cplus_add_code_header, cplus_add_input, cplus_compile_program) + (cplus_compute_program): Define new structs/functions. + * compile/compile-cplus-symmbols.c: New file. + * compile/compile-cplus-types.c: New file. + * compile/compile-cplus.h: New file. + * compile/compile-internal.h (debug_compile_oracle, GCC_TYPE_NONE): + Declare. + * compile/compile-object-load.c (get_out_value_type): Use + strncmp_iw when comparing symbol names. + (compile_object_load): Add mst_bss and mst_data. + * compile/compile.c (_initialize_compile): Remove + -Wno-implicit-function-declaration from `compile_args'. + * compile/gcc-cp-plugin.h: New file. + * NEWS: Mention C++ compile support and new debug options. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (collect_info::add_symbol): Make virtual. (struct symbol_searcher_collect_info): New struct. (symbol_searcher::find_all_symbols): New method. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 118c3c8062..14a9b45eeb 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -317,6 +317,8 @@ SUBDIR_GCC_COMPILE_SRCS = \ compile/compile-c-support.c \ compile/compile-c-symbols.c \ compile/compile-c-types.c \ + compile/compile-cplus-symbols.c \ + compile/compile-cplus-types.c \ compile/compile-loc2c.c \ compile/compile-object-load.c \ compile/compile-object-run.c @@ -1461,10 +1463,12 @@ HFILES_NO_SRCDIR = \ common/xml-utils.h \ compile/compile.h \ compile/compile-c.h \ + compile/compile-cplus.h \ compile/compile-internal.h \ compile/compile-object-load.h \ compile/compile-object-run.h \ compile/gcc-c-plugin.h \ + compile/gcc-cp-plugin.h \ config/nm-linux.h \ config/nm-nto.h \ config/djgpp/langinfo.h \ diff --git a/gdb/NEWS b/gdb/NEWS index f275031345..10855cdc6a 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,14 @@ *** Changes since GDB 8.2 +* GDB now has experimental support for the compilation and injection of + C++ source code into the inferior. This beta release does not include + support for several language features, such as templates, constructors, + and operators. + + This feature requires the GCC C++ plug-in available since GCC 7.1. + Currently tested on x86_64 GNU/Linux. + * GDB and GDBserver now support IPv6 connections. IPv6 addresses can be passed using the '[ADDRESS]:PORT' notation, or the regular 'ADDRESS:PORT' method. @@ -12,6 +20,12 @@ * New commands +set debug compile-cplus-types +show debug compile-cplus-types + Control the display of debug output about type conversion in the + C++ compile feature. Commands have no effect while compiliong + for other languages. + frame apply [all | COUNT | -COUNT | level LEVEL...] [FLAG]... COMMAND Apply a command to some frames. FLAG arguments allow to control what output to produce and how to handle diff --git a/gdb/c-lang.c b/gdb/c-lang.c index 5ad580182c..6bae4c18ec 100644 --- a/gdb/c-lang.c +++ b/gdb/c-lang.c @@ -1017,8 +1017,8 @@ extern const struct language_defn cplus_language_defn = iterate_over_symbols, cp_search_name_hash, &cplus_varobj_ops, - NULL, - NULL, + cplus_get_compile_context, + cplus_compute_program, LANG_MAGIC }; diff --git a/gdb/c-lang.h b/gdb/c-lang.h index b7bf08992b..ae17abd20f 100644 --- a/gdb/c-lang.h +++ b/gdb/c-lang.h @@ -160,6 +160,14 @@ extern int c_textual_element_type (struct type *, char); extern compile_instance *c_get_compile_context (void); +/* Create a new instance of the C++ compiler and return it. The new + compiler is owned by the caller and must be freed using the destroy + method. This function never returns NULL, but rather throws an + exception on failure. This is suitable for use as the + la_get_compile_instance language method. */ + +extern compile_instance *cplus_get_compile_context (); + /* This takes the user-supplied text and returns a new bit of code to compile. @@ -172,4 +180,15 @@ extern std::string c_compute_program (compile_instance *inst, const struct block *expr_block, CORE_ADDR expr_pc); +/* This takes the user-supplied text and returns a new bit of code to compile. + + This is used as the la_compute_program language method; see that + for a description of the arguments. */ + +extern std::string cplus_compute_program (compile_instance *inst, + const char *input, + struct gdbarch *gdbarch, + const struct block *expr_block, + CORE_ADDR expr_pc); + #endif /* !defined (C_LANG_H) */ diff --git a/gdb/compile/compile-c-support.c b/gdb/compile/compile-c-support.c index e8993aa5eb..5c700bbac2 100644 --- a/gdb/compile/compile-c-support.c +++ b/gdb/compile/compile-c-support.c @@ -1,4 +1,4 @@ -/* C language support for compilation. +/* C/C++ language support for compilation. Copyright (C) 2014-2018 Free Software Foundation, Inc. @@ -20,6 +20,7 @@ #include "defs.h" #include "compile-internal.h" #include "compile-c.h" +#include "compile-cplus.h" #include "compile.h" #include "gdb-dlfcn.h" #include "c-lang.h" @@ -67,25 +68,22 @@ c_get_range_decl_name (const struct dynamic_prop *prop) \f -/* Helper function for c_get_compile_context. Open the GCC front-end - shared library and return the symbol specified by the current - GCC_C_FE_CONTEXT. */ +/* Load the plug-in library FE_LIBCC and return the initialization function + FE_CONTEXT. */ -static gcc_c_fe_context_function * -load_libcc (void) +template <typename FUNCTYPE> +FUNCTYPE * +load_libcompile (const char *fe_libcc, const char *fe_context) { - gcc_c_fe_context_function *func; + FUNCTYPE *func; - /* gdb_dlopen will call error () on an error, so no need to check - value. */ - gdb_dlhandle_up handle = gdb_dlopen (STRINGIFY (GCC_C_FE_LIBCC)); - func = (gcc_c_fe_context_function *) gdb_dlsym (handle, - STRINGIFY (GCC_C_FE_CONTEXT)); + /* gdb_dlopen will call error () on an error, so no need to check + value. */ + gdb_dlhandle_up handle = gdb_dlopen (fe_libcc); + func = (FUNCTYPE *) gdb_dlsym (handle, fe_context); if (func == NULL) - error (_("could not find symbol %s in library %s"), - STRINGIFY (GCC_C_FE_CONTEXT), - STRINGIFY (GCC_C_FE_LIBCC)); + error (_("could not find symbol %s in library %s"), fe_context, fe_libcc); /* Leave the library open. */ handle.release (); @@ -93,28 +91,57 @@ load_libcc (void) } /* Return the compile instance associated with the current context. - This function calls the symbol returned from the load_libcc - function. This will provide the gcc_c_context. */ + This function calls the symbol returned from the load_libcompile + function. FE_LIBCC is the library to load. BASE_VERSION is the + base compile plug-in version we support. API_VERSION is the + API version supported. */ +template <typename INSTTYPE, typename FUNCTYPE, typename CTXTYPE, + typename BASE_VERSION_TYPE, typename API_VERSION_TYPE> compile_instance * -c_get_compile_context (void) +get_compile_context (const char *fe_libcc, const char *fe_context, + BASE_VERSION_TYPE base_version, + API_VERSION_TYPE api_version) { - static gcc_c_fe_context_function *func; - - struct gcc_c_context *context; + static FUNCTYPE *func; + static CTXTYPE *context; if (func == NULL) { - func = load_libcc (); + func = load_libcompile<FUNCTYPE> (fe_libcc, fe_context); gdb_assert (func != NULL); } - context = (*func) (GCC_FE_VERSION_0, GCC_C_FE_VERSION_0); + context = (*func) (base_version, api_version); if (context == NULL) error (_("The loaded version of GCC does not support the required version " "of the API.")); - return new compile_c_instance (context); + return new INSTTYPE (context); +} + +/* A C-language implementation of get_compile_context. */ + +compile_instance * +c_get_compile_context () +{ + return get_compile_context + <compile_c_instance, gcc_c_fe_context_function, gcc_c_context, + gcc_base_api_version, gcc_c_api_version> + (STRINGIFY (GCC_C_FE_LIBCC), STRINGIFY (GCC_C_FE_CONTEXT), + GCC_FE_VERSION_0, GCC_C_FE_VERSION_0); +} + +/* A C++-language implementation of get_compile_context. */ + +compile_instance * +cplus_get_compile_context () +{ + return get_compile_context + <compile_cplus_instance, gcc_cp_fe_context_function, gcc_cp_context, + gcc_base_api_version, gcc_cp_api_version> + (STRINGIFY (GCC_CP_FE_LIBCC), STRINGIFY (GCC_CP_FE_CONTEXT), + GCC_FE_VERSION_0, GCC_CP_FE_VERSION_0); } \f @@ -384,6 +411,113 @@ struct c_add_input } }; +/* C++-language policy to emit a push user expression pragma into + BUF. */ + +struct cplus_push_user_expression +{ + void push_user_expression (struct ui_file *buf) + { + fputs_unfiltered ("#pragma GCC push_user_expression\n", buf); + } +}; + +/* C++-language policy to emit a pop user expression pragma into BUF. */ + +struct cplus_pop_user_expression +{ + void pop_user_expression (struct ui_file *buf) + { + fputs_unfiltered ("#pragma GCC pop_user_expression\n", buf); + } +}; + +/* C++-language policy to construct a code header for a block of code. + Takes a scope TYPE argument which selects the correct header to + insert into BUF. */ + +struct cplus_add_code_header +{ + void add_code_header (enum compile_i_scope_types type, struct ui_file *buf) + { + switch (type) + { + case COMPILE_I_SIMPLE_SCOPE: + fputs_unfiltered ("void " + GCC_FE_WRAPPER_FUNCTION + " (struct " + COMPILE_I_SIMPLE_REGISTER_STRUCT_TAG + " *" + COMPILE_I_SIMPLE_REGISTER_ARG_NAME + ") {\n", + buf); + break; + + case COMPILE_I_PRINT_ADDRESS_SCOPE: + case COMPILE_I_PRINT_VALUE_SCOPE: + fputs_unfiltered ( + "#include <cstring>\n" + "#include <bits/move.h>\n" + "void " + GCC_FE_WRAPPER_FUNCTION + " (struct " + COMPILE_I_SIMPLE_REGISTER_STRUCT_TAG + " *" + COMPILE_I_SIMPLE_REGISTER_ARG_NAME + ", " + COMPILE_I_PRINT_OUT_ARG_TYPE + " " + COMPILE_I_PRINT_OUT_ARG + ") {\n", + buf); + break; + + case COMPILE_I_RAW_SCOPE: + break; + + default: + gdb_assert_not_reached (_("Unknown compiler scope reached.")); + } + } +}; + +/* C++-language policy to emit the user code snippet INPUT into BUF based on + the scope TYPE. */ + +struct cplus_add_input +{ + void add_input (enum compile_i_scope_types type, const char *input, + struct ui_file *buf) + { + switch (type) + { + case COMPILE_I_PRINT_VALUE_SCOPE: + case COMPILE_I_PRINT_ADDRESS_SCOPE: + fprintf_unfiltered + (buf, + /* "auto" strips ref- and cv- qualifiers, so we need to also strip + those from COMPILE_I_EXPR_PTR_TYPE. */ + "auto " COMPILE_I_EXPR_VAL " = %s;\n" + "typedef " + "std::add_pointer<std::remove_cv<decltype (%s)>::type>::type " + " __gdb_expr_ptr;\n" + "__gdb_expr_ptr " COMPILE_I_EXPR_PTR_TYPE ";\n" + "std::memcpy (" COMPILE_I_PRINT_OUT_ARG ", %s (" + COMPILE_I_EXPR_VAL "),\n" + "\tsizeof (*" COMPILE_I_EXPR_PTR_TYPE "));\n" + ,input, input, + (type == COMPILE_I_PRINT_ADDRESS_SCOPE + ? "__builtin_addressof" : "")); + break; + + default: + fputs_unfiltered (input, buf); + break; + } + fputs_unfiltered ("\n", buf); + } +}; + /* A host class representing a compile program. CompileInstanceType is the type of the compile_instance for the @@ -513,13 +647,18 @@ private: struct gdbarch *m_arch; }; -/* Type used for C program computations. */ +/* The types used for C and C++ program computations. */ typedef compile_program<compile_c_instance, c_push_user_expression, pop_user_expression_nop, c_add_code_header, c_add_code_footer, c_add_input> c_compile_program; +typedef compile_program<compile_cplus_instance, + cplus_push_user_expression, cplus_pop_user_expression, + cplus_add_code_header, c_add_code_footer, + cplus_add_input> cplus_compile_program; + /* The la_compute_program method for C. */ std::string @@ -534,3 +673,19 @@ c_compute_program (compile_instance *inst, return program.compute (input, expr_block, expr_pc); } + +/* The la_compute_program method for C++. */ + +std::string +cplus_compute_program (compile_instance *inst, + const char *input, + struct gdbarch *gdbarch, + const struct block *expr_block, + CORE_ADDR expr_pc) +{ + compile_cplus_instance *cplus_inst + = static_cast<compile_cplus_instance *> (inst); + cplus_compile_program program (cplus_inst, gdbarch); + + return program.compute (input, expr_block, expr_pc); +} diff --git a/gdb/compile/compile-cplus-symbols.c b/gdb/compile/compile-cplus-symbols.c new file mode 100644 index 0000000000..0f849fe365 --- /dev/null +++ b/gdb/compile/compile-cplus-symbols.c @@ -0,0 +1,493 @@ +/* Convert symbols from GDB to GCC + + Copyright (C) 2014-2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + + +#include "defs.h" +#include "compile-internal.h" +#include "compile-cplus.h" +#include "gdb_assert.h" +#include "symtab.h" +#include "parser-defs.h" +#include "block.h" +#include "objfiles.h" +#include "compile.h" +#include "value.h" +#include "exceptions.h" +#include "gdbtypes.h" +#include "dwarf2loc.h" +#include "cp-support.h" +#include "gdbcmd.h" +#include "compile-c.h" + +/* Convert a given symbol, SYM, to the compiler's representation. + INSTANCE is the compiler instance. IS_GLOBAL is true if the + symbol came from the global scope. IS_LOCAL is true if the symbol + came from a local scope. (Note that the two are not strictly + inverses because the symbol might have come from the static + scope.) */ + +static void +convert_one_symbol (compile_cplus_instance *instance, + struct block_symbol sym, bool is_global, bool is_local) +{ + /* Squash compiler warning. */ + gcc_type sym_type = 0; + const char *filename = symbol_symtab (sym.symbol)->filename; + unsigned short line = SYMBOL_LINE (sym.symbol); + + instance->error_symbol_once (sym.symbol); + + if (SYMBOL_CLASS (sym.symbol) == LOC_LABEL) + sym_type = 0; + else + sym_type = instance->convert_type (SYMBOL_TYPE (sym.symbol)); + + if (SYMBOL_DOMAIN (sym.symbol) == STRUCT_DOMAIN) + { + /* Nothing to do. */ + } + else + { + /* Squash compiler warning. */ + gcc_cp_symbol_kind_flags kind = GCC_CP_FLAG_BASE; + CORE_ADDR addr = 0; + std::string name; + gdb::unique_xmalloc_ptr<char> symbol_name; + + switch (SYMBOL_CLASS (sym.symbol)) + { + case LOC_TYPEDEF: + if (TYPE_CODE (SYMBOL_TYPE (sym.symbol)) == TYPE_CODE_TYPEDEF) + kind = GCC_CP_SYMBOL_TYPEDEF; + else if (TYPE_CODE (SYMBOL_TYPE (sym.symbol)) == TYPE_CODE_NAMESPACE) + return; + break; + + case LOC_LABEL: + kind = GCC_CP_SYMBOL_LABEL; + addr = SYMBOL_VALUE_ADDRESS (sym.symbol); + break; + + case LOC_BLOCK: + { + kind = GCC_CP_SYMBOL_FUNCTION; + addr = BLOCK_START (SYMBOL_BLOCK_VALUE (sym.symbol)); + if (is_global && TYPE_GNU_IFUNC (SYMBOL_TYPE (sym.symbol))) + addr = gnu_ifunc_resolve_addr (target_gdbarch (), addr); + } + break; + + case LOC_CONST: + if (TYPE_CODE (SYMBOL_TYPE (sym.symbol)) == TYPE_CODE_ENUM) + { + /* Already handled by convert_enum. */ + return; + } + instance->plugin ().build_constant + (sym_type, SYMBOL_NATURAL_NAME (sym.symbol), + SYMBOL_VALUE (sym.symbol), filename, line); + return; + + case LOC_CONST_BYTES: + error (_("Unsupported LOC_CONST_BYTES for symbol \"%s\"."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_UNDEF: + internal_error (__FILE__, __LINE__, _("LOC_UNDEF found for \"%s\"."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_COMMON_BLOCK: + error (_("Fortran common block is unsupported for compilation " + "evaluaton of symbol \"%s\"."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_OPTIMIZED_OUT: + error (_("Symbol \"%s\" cannot be used for compilation evaluation " + "as it is optimized out."), + SYMBOL_PRINT_NAME (sym.symbol)); + + case LOC_COMPUTED: + if (is_local) + goto substitution; + /* Probably TLS here. */ + warning (_("Symbol \"%s\" is thread-local and currently can only " + "be referenced from the current thread in " + "compiled code."), + SYMBOL_PRINT_NAME (sym.symbol)); + /* FALLTHROUGH */ + case LOC_UNRESOLVED: + /* 'symbol_name' cannot be used here as that one is used only for + local variables from compile_dwarf_expr_to_c. + Global variables can be accessed by GCC only by their address, not + by their name. */ + { + struct value *val; + struct frame_info *frame = nullptr; + + if (symbol_read_needs_frame (sym.symbol)) + { + frame = get_selected_frame (nullptr); + if (frame == nullptr) + error (_("Symbol \"%s\" cannot be used because " + "there is no selected frame"), + SYMBOL_PRINT_NAME (sym.symbol)); + } + + val = read_var_value (sym.symbol, sym.block, frame); + if (VALUE_LVAL (val) != lval_memory) + error (_("Symbol \"%s\" cannot be used for compilation " + "evaluation as its address has not been found."), + SYMBOL_PRINT_NAME (sym.symbol)); + + kind = GCC_CP_SYMBOL_VARIABLE; + addr = value_address (val); + } + break; + + + case LOC_REGISTER: + case LOC_ARG: + case LOC_REF_ARG: + case LOC_REGPARM_ADDR: + case LOC_LOCAL: + substitution: + kind = GCC_CP_SYMBOL_VARIABLE; + symbol_name = c_symbol_substitution_name (sym.symbol); + break; + + case LOC_STATIC: + kind = GCC_CP_SYMBOL_VARIABLE; + addr = SYMBOL_VALUE_ADDRESS (sym.symbol); + break; + + case LOC_FINAL_VALUE: + default: + gdb_assert_not_reached ("Unreachable case in convert_one_symbol."); + } + + /* Don't emit local variable decls for a raw expression. */ + if (instance->scope () != COMPILE_I_RAW_SCOPE || symbol_name == nullptr) + { + compile_scope scope; + + /* For non-local symbols, create/push a new scope so that the + symbol is properly scoped to the plug-in. */ + if (!is_local) + { + scope + = instance->new_scope (SYMBOL_NATURAL_NAME (sym.symbol), + SYMBOL_TYPE (sym.symbol)); + if (scope.nested_type () != GCC_TYPE_NONE) + { + /* We found a symbol for this type that was defined inside + some other symbol, e.g., a class tyepdef defined. */ + return; + } + + instance->enter_scope (scope); + } + + /* Get the `raw' name of the symbol. */ + if (name.empty () && SYMBOL_NATURAL_NAME (sym.symbol) != nullptr) + name = compile_cplus_instance::decl_name + (SYMBOL_NATURAL_NAME (sym.symbol)).get (); + + /* Define the decl. */ + instance->plugin ().build_decl + ("variable", name.c_str (), kind, sym_type, + symbol_name.get (), addr, filename, line); + + /* Pop scope for non-local symbols. */ + if (!is_local) + instance->leave_scope (); + } + } +} + +/* Convert a full symbol to its gcc form. CONTEXT is the compiler to + use, IDENTIFIER is the name of the symbol, SYM is the symbol + itself, and DOMAIN is the domain which was searched. */ + +static void +convert_symbol_sym (compile_cplus_instance *instance, + const char *identifier, struct block_symbol sym, + domain_enum domain) +{ + /* If we found a symbol and it is not in the static or global + scope, then we should first convert any static or global scope + symbol of the same name. This lets this unusual case work: + + int x; // Global. + int func(void) + { + int x; + // At this spot, evaluate "extern int x; x" + } + */ + + const struct block *static_block = block_static_block (sym.block); + /* STATIC_BLOCK is NULL if FOUND_BLOCK is the global block. */ + bool is_local_symbol = (sym.block != static_block && static_block != nullptr); + if (is_local_symbol) + { + struct block_symbol global_sym; + + global_sym = lookup_symbol (identifier, nullptr, domain, nullptr); + /* If the outer symbol is in the static block, we ignore it, as + it cannot be referenced. */ + if (global_sym.symbol != nullptr + && global_sym.block != block_static_block (global_sym.block)) + { + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_convert_symbol \"%s\": global symbol\n", + identifier); + convert_one_symbol (instance, global_sym, true, false); + } + } + + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_convert_symbol \"%s\": local symbol\n", + identifier); + convert_one_symbol (instance, sym, false, is_local_symbol); +} + +/* Convert a minimal symbol to its gcc form. CONTEXT is the compiler + to use and BMSYM is the minimal symbol to convert. */ + +static void +convert_symbol_bmsym (compile_cplus_instance *instance, + struct bound_minimal_symbol bmsym) +{ + struct minimal_symbol *msym = bmsym.minsym; + struct objfile *objfile = bmsym.objfile; + struct type *type; + gcc_cp_symbol_kind_flags kind; + gcc_type sym_type; + CORE_ADDR addr; + + addr = MSYMBOL_VALUE_ADDRESS (objfile, msym); + + /* Conversion copied from write_exp_msymbol. */ + switch (MSYMBOL_TYPE (msym)) + { + case mst_text: + case mst_file_text: + case mst_solib_trampoline: + type = objfile_type (objfile)->nodebug_text_symbol; + kind = GCC_CP_SYMBOL_FUNCTION; + break; + + case mst_text_gnu_ifunc: + /* nodebug_text_gnu_ifunc_symbol would cause: + function return type cannot be function */ + type = objfile_type (objfile)->nodebug_text_symbol; + kind = GCC_CP_SYMBOL_FUNCTION; + addr = gnu_ifunc_resolve_addr (target_gdbarch (), addr); + break; + + case mst_data: + case mst_file_data: + case mst_bss: + case mst_file_bss: + type = objfile_type (objfile)->nodebug_data_symbol; + kind = GCC_CP_SYMBOL_VARIABLE; + break; + + case mst_slot_got_plt: + type = objfile_type (objfile)->nodebug_got_plt_symbol; + kind = GCC_CP_SYMBOL_FUNCTION; + break; + + default: + type = objfile_type (objfile)->nodebug_unknown_symbol; + kind = GCC_CP_SYMBOL_VARIABLE; + break; + } + + sym_type = instance->convert_type (type); + instance->plugin ().push_namespace (""); + instance->plugin ().build_decl + ("minsym", MSYMBOL_NATURAL_NAME (msym), kind, sym_type, nullptr, addr, + nullptr, 0); + instance->plugin ().pop_binding_level (""); +} + +/* See compile-cplus.h. */ + +void +gcc_cplus_convert_symbol (void *datum, + struct gcc_cp_context *gcc_context, + enum gcc_cp_oracle_request request ATTRIBUTE_UNUSED, + const char *identifier) +{ + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "got oracle request for \"%s\"\n", identifier); + + bool found = false; + compile_cplus_instance *instance = (compile_cplus_instance *) datum; + + TRY + { + /* Symbol searching is a three part process unfortunately. */ + + /* First do a "standard" lookup, converting any found symbols. + This will find variables in the current scope. */ + + struct block_symbol sym + = lookup_symbol (identifier, instance->block (), VAR_DOMAIN, nullptr); + + if (sym.symbol != nullptr) + { + found = true; + convert_symbol_sym (instance, identifier, sym, VAR_DOMAIN); + } + + /* Then use linespec.c's multi-symbol search. This should find + all non-variable symbols for which we have debug info. */ + + symbol_searcher searcher; + searcher.find_all_symbols (identifier, current_language, + ALL_DOMAIN, nullptr, nullptr); + + /* Convert any found symbols. */ + for (const auto &it : searcher.matching_symbols ()) + { + /* Don't convert the symbol found above, if any, twice! */ + if (it.symbol != sym.symbol) + { + found = true; + convert_symbol_sym (instance, identifier, it, + SYMBOL_DOMAIN (it.symbol)); + } + } + + /* Finally, if no symbols have been found, fall back to minsyms. */ + if (!found) + { + for (const auto &it : searcher.matching_msymbols ()) + { + found = true; + convert_symbol_bmsym (instance, it); + } + } + } + CATCH (e, RETURN_MASK_ALL) + { + /* We can't allow exceptions to escape out of this callback. Safest + is to simply emit a gcc error. */ + instance->plugin ().error (e.message); + } + END_CATCH + + if (compile_debug && !found) + fprintf_unfiltered (gdb_stdlog, + "gcc_convert_symbol \"%s\": lookup_symbol failed\n", + identifier); + + if (compile_debug) + { + if (found) + fprintf_unfiltered (gdb_stdlog, "found type for %s\n", identifier); + else + { + fprintf_unfiltered (gdb_stdlog, "did not find type for %s\n", + identifier); + } + } + + return; +} + +/* See compile-cplus.h. */ + +gcc_address +gcc_cplus_symbol_address (void *datum, struct gcc_cp_context *gcc_context, + const char *identifier) +{ + compile_cplus_instance *instance = (compile_cplus_instance *) datum; + gcc_address result = 0; + int found = 0; + + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "got oracle request for address of %s\n", identifier); + + /* We can't allow exceptions to escape out of this callback. Safest + is to simply emit a gcc error. */ + TRY + { + struct symbol *sym + = lookup_symbol (identifier, nullptr, VAR_DOMAIN, nullptr).symbol; + + if (sym != nullptr && SYMBOL_CLASS (sym) == LOC_BLOCK) + { + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_symbol_address \"%s\": full symbol\n", + identifier); + result = BLOCK_START (SYMBOL_BLOCK_VALUE (sym)); + if (TYPE_GNU_IFUNC (SYMBOL_TYPE (sym))) + result = gnu_ifunc_resolve_addr (target_gdbarch (), result); + found = 1; + } + else + { + struct bound_minimal_symbol msym; + + msym = lookup_bound_minimal_symbol (identifier); + if (msym.minsym != nullptr) + { + if (compile_debug) + fprintf_unfiltered (gdb_stdlog, + "gcc_symbol_address \"%s\": minimal " + "symbol\n", + identifier); + result = BMSYMBOL_VALUE_ADDRESS (msym); + if (MSYMBOL_TYPE (msym.minsym) == mst_text_gnu_ifunc) + result = gnu_ifunc_resolve_addr (target_gdbarch (), result); + found = 1; + } + } + } + + CATCH (e, RETURN_MASK_ERROR) + { + instance->plugin ().error (e.message); + } + END_CATCH + + if (compile_debug && !found) + fprintf_unfiltered (gdb_stdlog, + "gcc_symbol_address \"%s\": failed\n", + identifier); + + if (compile_debug) + { + if (found) + fprintf_unfiltered (gdb_stdlog, "found address for %s!\n", identifier); + else + fprintf_unfiltered (gdb_stdlog, + "did not find address for %s\n", identifier); + } + + return result; +} diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c new file mode 100644 index 0000000000..9425fc6ac7 --- /dev/null +++ b/gdb/compile/compile-cplus-types.c @@ -0,0 +1,1427 @@ +/* Convert types from GDB to GCC + + Copyright (C) 2014-2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + + +#include "defs.h" +#include "common/preprocessor.h" +#include "gdbtypes.h" +#include "compile-internal.h" +#include "compile-cplus.h" +#include "gdb_assert.h" +#include "symtab.h" +#include "source.h" +#include "cp-support.h" +#include "cp-abi.h" +#include "symtab.h" +#include "objfiles.h" +#include "block.h" +#include "gdbcmd.h" +#include "c-lang.h" +#include "compile-c.h" /* Included for c_get_range_decl_name + et al. */ +#include <algorithm> + +/* Default compile flags for C++. */ + +const char *compile_cplus_instance::m_default_cflags = "-std=gnu++11"; + +/* Flag to enable internal debugging. */ + +static int debug_compile_cplus_types = 0; + +/* Flag to enable internal scope switching debugging. */ + +static int debug_compile_cplus_scopes = 0; + +/* Forward declarations. */ + +static gcc_type compile_cplus_convert_func (compile_cplus_instance *instance, + struct type *type, + bool strip_artificial); + +/* See description in compile-cplus.h. */ + +gdb::unique_xmalloc_ptr<char> +compile_cplus_instance::decl_name (const char *natural) +{ + if (natural == nullptr) + return nullptr; + + char *name = cp_func_name (natural); + if (name != nullptr) + return gdb::unique_xmalloc_ptr<char> (name); + + return gdb::unique_xmalloc_ptr<char> (xstrdup (natural)); +} + +/* Get the access flag for the NUM'th field of TYPE. */ + +static enum gcc_cp_symbol_kind +get_field_access_flag (const struct type *type, int num) +{ + if (TYPE_FIELD_PROTECTED (type, num)) + return GCC_CP_ACCESS_PROTECTED; + else if (TYPE_FIELD_PRIVATE (type, num)) + return GCC_CP_ACCESS_PRIVATE; + + /* GDB assumes everything else is public. */ + return GCC_CP_ACCESS_PUBLIC; +} + +/* Get the access flag for the NUM'th method of TYPE's FNI'th + fieldlist. */ + +enum gcc_cp_symbol_kind +get_method_access_flag (const struct type *type, int fni, int num) +{ + gdb_assert (TYPE_CODE (type) == TYPE_CODE_STRUCT); + + /* If this type was not declared a class, everything is public. */ + if (!TYPE_DECLARED_CLASS (type)) + return GCC_CP_ACCESS_PUBLIC; + + /* Otherwise, read accessibility from the fn_field. */ + const struct fn_field *methods = TYPE_FN_FIELDLIST1 (type, fni); + if (TYPE_FN_FIELD_PROTECTED (methods, num)) + return GCC_CP_ACCESS_PROTECTED; + else if (TYPE_FN_FIELD_PRIVATE (methods, num)) + return GCC_CP_ACCESS_PRIVATE; + else + return GCC_CP_ACCESS_PUBLIC; +} + +/* A useful debugging function to output the scope SCOPE to stdout. */ + +static void __attribute__ ((used)) +debug_print_scope (const compile_scope &scope) +{ + for (const auto &comp: scope) + { + const char *symbol = (comp.bsymbol.symbol != nullptr + ? SYMBOL_NATURAL_NAME (comp.bsymbol.symbol) + : "<none>"); + + printf_unfiltered ("\tname = %s, symbol = %s\n", comp.name.c_str (), + symbol); + } +} + +/* See description in compile-cplus.h. */ + +compile_scope +type_name_to_scope (const char *type_name, const struct block *block) +{ + compile_scope scope; + + if (type_name == nullptr) + { + /* An anonymous type. We cannot really do much here. We simply cannot + look up anonymous types easily/at all. */ + return scope; + } + + const char *p = type_name; + std::string lookup_name; + + while (*p != '\0') + { + /* Create a string token of the first component of TYPE_NAME. */ + int len = cp_find_first_component (p); + std::string s (p, len); + + /* Advance past the last token. */ + p += len; + + /* Look up the symbol and decide when to stop. */ + if (!lookup_name.empty ()) + lookup_name += "::"; + lookup_name += s; + + /* Look up the resulting name. */ + struct block_symbol bsymbol + = lookup_symbol (lookup_name.c_str (), block, VAR_DOMAIN, nullptr); + + if (bsymbol.symbol != nullptr) + { + scope_component comp = {s, bsymbol}; + + scope.push_back (comp); + + if (TYPE_CODE (SYMBOL_TYPE (bsymbol.symbol)) != TYPE_CODE_NAMESPACE) + { + /* We're done. */ + break; + } + } + + if (*p == ':') + { + ++p; + if (*p == ':') + ++p; + else + { + /* This shouldn't happen since we are not attempting to + loop over user input. This name is generated by GDB + from debug info. */ + internal_error (__FILE__, __LINE__, + _("malformed TYPE_NAME during parsing")); + } + } + } + + return scope; +} + +/* Compare two scope_components for equality. These are equal if the names + of the two components' are the same. */ + +bool +operator== (const scope_component &lhs, const scope_component &rhs) +{ + return lhs.name == rhs.name; +} + +/* Compare two scope_components for inequality. These are not equal if + the two components' names are not equal. */ + +bool +operator!= (const scope_component &lhs, const scope_component &rhs) +{ + return lhs.name != rhs.name; +} + +/* Compare two compile_scopes for equality. These are equal if they are both + contain the same number of components and each component is equal. */ + +bool +operator== (const compile_scope &lhs, const compile_scope &rhs) +{ + if (lhs.size () != rhs.size ()) + return false; + + for (int i = 0; i < lhs.size (); ++i) + { + if (lhs[i] != rhs[i]) + return false; + } + + return true; +} + +/* Compare two compile_scopes for inequality. These are inequal if they + contain unequal number of elements or if any of the components are not + the same. */ + +bool +operator!= (const compile_scope &lhs, const compile_scope &rhs) +{ + if (lhs.size () != rhs.size ()) + return true; + + for (int i = 0; i < lhs.size (); ++i) + { + if (lhs[i] != rhs[i]) + return true; + } + + return false; +} + +/* See description in compile-cplus.h. */ + +void +compile_cplus_instance::enter_scope (compile_scope &new_scope) +{ + bool must_push = m_scopes.empty () || m_scopes.back () != new_scope; + + new_scope.m_pushed = must_push; + + /* Save the new scope. */ + m_scopes.push_back (new_scope); + + if (must_push) + { + if (debug_compile_cplus_scopes) + fprintf_unfiltered (gdb_stdlog, "entering new scope %p\n", new_scope); + + /* Push the global namespace. */ + plugin ().push_namespace (""); + + /* Push all other namespaces. Note that we do not push the last + scope_component -- that's the actual type we are converting. */ + std::for_each + (new_scope.begin (), new_scope.end () - 1, + [this] (const scope_component &comp) + { + gdb_assert (TYPE_CODE (SYMBOL_TYPE (comp.bsymbol.symbol)) + == TYPE_CODE_NAMESPACE); + + const char *ns = (comp.name == CP_ANONYMOUS_NAMESPACE_STR ? nullptr + : comp.name.c_str ()); + + this->plugin ().push_namespace (ns); + }); + } + else + { + if (debug_compile_cplus_scopes) + { + fprintf_unfiltered (gdb_stdlog, "staying in current scope -- " + "scopes are identical\n"); + } + } +} + +/* See description in compile-cplus.h. */ + +void +compile_cplus_instance::leave_scope () +{ + /* Get the current scope and remove it from the internal list of + scopes. */ + compile_scope current = m_scopes.back (); + + m_scopes.pop_back (); + + if (current.m_pushed) + { + if (debug_compile_cplus_scopes) + fprintf_unfiltered (gdb_stdlog, "leaving scope %p\n", current); + + /* Pop namespaces. */ + std::for_each + (current.begin (),current.end () - 1, + [this] (const scope_component &comp) { + gdb_assert (TYPE_CODE (SYMBOL_TYPE (comp.bsymbol.symbol)) + == TYPE_CODE_NAMESPACE); + this->plugin ().pop_binding_level (comp.name.c_str ()); + }); + + /* Pop global namespace. */ + plugin ().pop_binding_level (""); + } + else + { + if (debug_compile_cplus_scopes) + fprintf_unfiltered (gdb_stdlog, + "identical scopes -- not leaving scope\n"); + } +} + +/* See description in compile-cplus.h. */ + +compile_scope +compile_cplus_instance::new_scope (const char *type_name, struct type *type) +{ + /* Break the type name into components. If TYPE was defined in some + superclass, we do not process TYPE but process the enclosing type + instead. */ + compile_scope scope = type_name_to_scope (type_name, block ()); + + if (!scope.empty ()) + { + /* Get the name of the last component, which should be the + unqualified name of the type to process. */ + scope_component &comp = scope.back (); + + if (!types_equal (type, SYMBOL_TYPE (comp.bsymbol.symbol)) + && (m_scopes.empty () + || (m_scopes.back ().back ().bsymbol.symbol + != comp.bsymbol.symbol))) + { + /* The type is defined inside another class(es). Convert that + type instead of defining this type. */ + convert_type (SYMBOL_TYPE (comp.bsymbol.symbol)); + + /* If the original type (passed in to us) is defined in a nested + class, the previous call will give us that type's gcc_type. + Upper layers are expecting to get the original type's + gcc_type! */ + get_cached_type (type, scope.m_nested_type); + return scope; + } + } + else + { + if (TYPE_NAME (type) == nullptr) + { + /* Anonymous type */ + + /* We don't have a qualified name for this to look up, but + we need a scope. We have to assume, then, that it is the same + as the current scope, if any. */ + if (!m_scopes.empty ()) + { + scope = m_scopes.back (); + scope.m_pushed = false; + } + else + scope.push_back (scope_component ()); + } + else + { + scope_component comp + = { + decl_name (TYPE_NAME (type)).get (), + lookup_symbol (TYPE_NAME (type), block (), VAR_DOMAIN, nullptr) + }; + scope.push_back (comp); + } + } + + /* There must be at least one component in the compile_scope. */ + gdb_assert (scope.size () > 0); + return scope; +} + +/* See description in compile-cplus.h. */ + +gcc_type +compile_cplus_instance::convert_reference_base + (gcc_type base, enum gcc_cp_ref_qualifiers rquals) +{ + return this->plugin ().build_reference_type (base, rquals); +} + +/* Convert a reference type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_reference (compile_cplus_instance *instance, + struct type *type) +{ + gcc_type target = instance->convert_type (TYPE_TARGET_TYPE (type)); + + enum gcc_cp_ref_qualifiers quals = GCC_CP_REF_QUAL_NONE; + switch (TYPE_CODE (type)) + { + case TYPE_CODE_REF: + quals = GCC_CP_REF_QUAL_LVALUE; + break; + case TYPE_CODE_RVALUE_REF: + quals = GCC_CP_REF_QUAL_RVALUE; + break; + default: + gdb_assert_not_reached ("unexpected type code for reference type"); + } + + return instance->convert_reference_base (target, quals); +} + +/* See description in compile-cplus.h. */ + +gcc_type +compile_cplus_instance::convert_pointer_base(gcc_type target) +{ + return plugin ().build_pointer_type (target); +} + +/* Convert a pointer type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_pointer (compile_cplus_instance *instance, + struct type *type) +{ + gcc_type target = instance->convert_type (TYPE_TARGET_TYPE (type)); + + return instance->convert_pointer_base (target); +} + +/* Convert an array type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_array (compile_cplus_instance *instance, + struct type *type) +{ + struct type *range = TYPE_INDEX_TYPE (type); + gcc_type element_type = instance->convert_type (TYPE_TARGET_TYPE (type)); + + if (TYPE_LOW_BOUND_KIND (range) != PROP_CONST) + { + const char *s = _("array type with non-constant" + " lower bound is not supported"); + + return instance->plugin ().error (s); + } + + if (TYPE_LOW_BOUND (range) != 0) + { + const char *s = _("cannot convert array type with " + "non-zero lower bound to C"); + + return instance->plugin ().error (s); + } + + if (TYPE_HIGH_BOUND_KIND (range) == PROP_LOCEXPR + || TYPE_HIGH_BOUND_KIND (range) == PROP_LOCLIST) + { + if (TYPE_VECTOR (type)) + { + const char *s = _("variably-sized vector type is not supported"); + + return instance->plugin ().error (s); + } + + std::string upper_bound + = c_get_range_decl_name (&TYPE_RANGE_DATA (range)->high); + return instance->plugin ().build_vla_array_type (element_type, + upper_bound.c_str ()); + } + else + { + LONGEST low_bound, high_bound, count; + + if (get_array_bounds (type, &low_bound, &high_bound) == 0) + count = -1; + else + { + gdb_assert (low_bound == 0); /* Ensured above. */ + count = high_bound + 1; + } + + if (TYPE_VECTOR (type)) + return instance->plugin ().build_vector_type (element_type, count); + + return instance->plugin ().build_array_type (element_type, count); + } +} + +/* Convert a typedef of TYPE. If not GCC_CP_ACCESS_NONE, NESTED_ACCESS + will define the accessibility of the typedef definition in its + containing class. */ + +static gcc_type +compile_cplus_convert_typedef (compile_cplus_instance *instance, + struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + + if (scope.nested_type () != GCC_TYPE_NONE) + return scope.nested_type (); + + gdb::unique_xmalloc_ptr<char> name + = compile_cplus_instance::decl_name (TYPE_NAME (type)); + + /* Make sure the scope for this type has been pushed. */ + instance->enter_scope (scope); + + /* Convert the typedef's real type. */ + gcc_type typedef_type = instance->convert_type (check_typedef (type)); + + instance->plugin ().build_decl ("typedef", name.get (), + GCC_CP_SYMBOL_TYPEDEF | nested_access, + typedef_type, 0, 0, nullptr, 0); + + /* Completed this scope. */ + instance->leave_scope (); + return typedef_type; +} + +/* Convert types defined in TYPE. */ + +static void +compile_cplus_convert_type_defns (compile_cplus_instance *instance, + struct type *type) +{ + int i; + enum gcc_cp_symbol_kind accessibility; + + /* Convert typedefs. */ + for (i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i) + { + if (TYPE_TYPEDEF_FIELD_PROTECTED (type, i)) + accessibility = GCC_CP_ACCESS_PROTECTED; + else if (TYPE_TYPEDEF_FIELD_PRIVATE (type, i)) + accessibility = GCC_CP_ACCESS_PRIVATE; + else + accessibility = GCC_CP_ACCESS_PUBLIC; + instance->convert_type (TYPE_TYPEDEF_FIELD_TYPE (type, i), accessibility); + } + + /* Convert nested types. */ + for (i = 0; i < TYPE_NESTED_TYPES_COUNT (type); ++i) + { + if (TYPE_NESTED_TYPES_FIELD_PROTECTED (type, i)) + accessibility = GCC_CP_ACCESS_PROTECTED; + else if (TYPE_NESTED_TYPES_FIELD_PRIVATE (type, i)) + accessibility = GCC_CP_ACCESS_PRIVATE; + else + accessibility = GCC_CP_ACCESS_PUBLIC; + instance->convert_type (TYPE_NESTED_TYPES_FIELD_TYPE (type, i), + accessibility); + } +} + +/* Convert data members defined in TYPE, which should be struct/class/union + with gcc_type COMP_TYPE. */ + +static void +compile_cplus_convert_struct_or_union_members + (compile_cplus_instance *instance, struct type *type, gcc_type comp_type) +{ + for (int i = TYPE_N_BASECLASSES (type); i < TYPE_NFIELDS (type); ++i) + { + const char *field_name = TYPE_FIELD_NAME (type, i); + + if (TYPE_FIELD_IGNORE (type, i) + || TYPE_FIELD_ARTIFICIAL (type, i)) + continue; + + /* GDB records unnamed/anonymous fields with empty string names. */ + if (*field_name == '\0') + field_name = nullptr; + + gcc_type field_type + = instance->convert_type (TYPE_FIELD_TYPE (type, i)); + + if (field_is_static (&TYPE_FIELD (type, i))) + { + CORE_ADDR physaddr; + + switch (TYPE_FIELD_LOC_KIND (type, i)) + { + case FIELD_LOC_KIND_PHYSADDR: + { + physaddr = TYPE_FIELD_STATIC_PHYSADDR (type, i); + + instance->plugin ().build_decl + ("field physaddr", field_name, + (GCC_CP_SYMBOL_VARIABLE | get_field_access_flag (type, i)), + field_type, nullptr, physaddr, nullptr, 0); + } + break; + + case FIELD_LOC_KIND_PHYSNAME: + { + const char *physname = TYPE_FIELD_STATIC_PHYSNAME (type, i); + struct block_symbol sym + = lookup_symbol (physname, instance->block (), + VAR_DOMAIN, nullptr); + + if (sym.symbol == nullptr) + { + /* We didn't actually find the symbol. There's little + we can do but ignore this member. */ + continue; + } + const char *filename = symbol_symtab (sym.symbol)->filename; + unsigned int line = SYMBOL_LINE (sym.symbol); + + physaddr = SYMBOL_VALUE_ADDRESS (sym.symbol); + instance->plugin ().build_decl + ("field physname", field_name, + (GCC_CP_SYMBOL_VARIABLE| get_field_access_flag (type, i)), + field_type, nullptr, physaddr, filename, line); + } + break; + + default: + gdb_assert_not_reached + ("unexpected static field location kind"); + } + } + else + { + unsigned long bitsize = TYPE_FIELD_BITSIZE (type, i); + enum gcc_cp_symbol_kind field_flags = GCC_CP_SYMBOL_FIELD + | get_field_access_flag (type, i); + + if (bitsize == 0) + bitsize = 8 * TYPE_LENGTH (TYPE_FIELD_TYPE (type, i)); + + instance->plugin ().build_field + (field_name, field_type, field_flags, bitsize, + TYPE_FIELD_BITPOS (type, i)); + } + } +} + +/* Convert a method type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_method (compile_cplus_instance *instance, + struct type *parent_type, + struct type *method_type) +{ + /* Get the actual function type of the method, the corresponding class's + type and corresponding qualifier flags. */ + gcc_type func_type = compile_cplus_convert_func (instance, method_type, true); + gcc_type class_type = instance->convert_type (parent_type); + gcc_cp_qualifiers_flags quals = (enum gcc_cp_qualifiers) 0; + + if (TYPE_CONST (method_type)) + quals |= GCC_CP_QUALIFIER_CONST; + if (TYPE_VOLATILE (method_type)) + quals |= GCC_CP_QUALIFIER_VOLATILE; + if (TYPE_RESTRICT (method_type)) + quals |= GCC_CP_QUALIFIER_RESTRICT; + + /* Not yet implemented. */ + gcc_cp_ref_qualifiers_flags rquals = GCC_CP_REF_QUAL_NONE; + + return instance->plugin ().build_method_type + (class_type, func_type, quals, rquals); +} + +/* Convert a member or method pointer represented by TYPE. */ + +static gcc_type +compile_cplus_convert_memberptr (compile_cplus_instance *instance, + struct type *type) +{ + struct type *containing_class = TYPE_SELF_TYPE (type); + + if (containing_class == nullptr) + return GCC_TYPE_NONE; + + gcc_type class_type = instance->convert_type (containing_class); + gcc_type member_type + = instance->convert_type (TYPE_TARGET_TYPE (type)); + + return instance->plugin ().build_pointer_to_member_type + (class_type, member_type); +} + +/* Convert all methods defined in TYPE, which should be a class/struct/union + with gcc_type CLASS_TYPE. */ + +static void +compile_cplus_convert_struct_or_union_methods (compile_cplus_instance *instance, + struct type *type, + gcc_type class_type) +{ + for (int i = 0; i < TYPE_NFN_FIELDS (type); ++i) + { + struct fn_field *methods = TYPE_FN_FIELDLIST1 (type, i); + gdb::unique_xmalloc_ptr<char> overloaded_name + = compile_cplus_instance::decl_name (TYPE_FN_FIELDLIST_NAME (type, i)); + + /* Loop through the fieldlist, adding decls to the compiler's + representation of the class. */ + for (int j = 0; j < TYPE_FN_FIELDLIST_LENGTH (type, i); ++j) + { + /* Skip artificial methods. */ + if (TYPE_FN_FIELD_ARTIFICIAL (methods, j)) + continue; + + gcc_cp_symbol_kind_flags sym_kind = GCC_CP_SYMBOL_FUNCTION; + gcc_type method_type; + struct block_symbol sym + = lookup_symbol (TYPE_FN_FIELD_PHYSNAME (methods, j), + instance->block (), VAR_DOMAIN, nullptr); + + if (sym.symbol == nullptr) + { + if (TYPE_FN_FIELD_VIRTUAL_P (methods, j)) + { + /* This is beyond hacky, and is really only a workaround for + detecting pure virtual methods. */ + method_type = compile_cplus_convert_method + (instance, type, TYPE_FN_FIELD_TYPE (methods, j)); + + instance->plugin ().build_decl + ("pure virtual method", overloaded_name.get (), + (sym_kind + | get_method_access_flag (type, i, j) + | GCC_CP_FLAG_VIRTUAL_FUNCTION + | GCC_CP_FLAG_PURE_VIRTUAL_FUNCTION), + method_type, nullptr, 0, nullptr, 0); + continue; + } + + /* This can happen if we have a DW_AT_declaration DIE + for the method, but no "definition"-type DIE (with + DW_AT_specification referencing the decl DIE), i.e., + the compiler has probably optimized the method away. + + In this case, all we can hope to do is issue a warning + to the user letting him know. If the user has not actually + requested using this method, things should still work. */ + warning (_("Method %s appears to be optimized out.\n" + "All references to this method will be undefined."), + TYPE_FN_FIELD_PHYSNAME (methods, j)); + continue; + } + + const char *filename = symbol_symtab (sym.symbol)->filename; + unsigned int line = SYMBOL_LINE (sym.symbol); + CORE_ADDR address = BLOCK_START (SYMBOL_BLOCK_VALUE (sym.symbol)); + const char *kind; + + if (TYPE_FN_FIELD_STATIC_P (methods, j)) + { + kind = "static method"; + method_type = compile_cplus_convert_func + (instance, TYPE_FN_FIELD_TYPE (methods, j), true); + } + else + { + kind = "method"; + method_type = (compile_cplus_convert_method + (instance, type, TYPE_FN_FIELD_TYPE (methods, j))); + } + + if (TYPE_FN_FIELD_VIRTUAL_P (methods, j)) + sym_kind |= GCC_CP_FLAG_VIRTUAL_FUNCTION; + + instance->plugin ().build_decl + (kind, overloaded_name.get (), + sym_kind | get_method_access_flag (type, i, j), + method_type, nullptr, address, filename, line); + } + } +} + +/* Convert a struct or union type to its gcc representation. If this type + was defined in another type, NESTED_ACCESS should indicate the + accessibility of this type. */ + +static gcc_type +compile_cplus_convert_struct_or_union (compile_cplus_instance *instance, + struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + const char *filename = nullptr; + unsigned short line = 0; + + /* Get the decl name of this type. */ + gdb::unique_xmalloc_ptr<char> name + = compile_cplus_instance::decl_name (TYPE_NAME (type)); + + /* Create a new scope for TYPE. */ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + + if (scope.nested_type () != GCC_TYPE_NONE) + { + /* The type requested was actually defined inside another type, + such as a nested class definition. Return that type. */ + return scope.nested_type (); + } + + /* Push all scopes. */ + instance->enter_scope (scope); + + /* First we create the resulting type and enter it into our hash + table. This lets recursive types work. */ + + gcc_decl resuld; + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) + { + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; + + resuld = instance->plugin ().build_decl + (what, name.get (), (GCC_CP_SYMBOL_CLASS | nested_access + | (TYPE_DECLARED_CLASS (type) + ? GCC_CP_FLAG_CLASS_NOFLAG + : GCC_CP_FLAG_CLASS_IS_STRUCT)), + 0, nullptr, 0, filename, line); + } + else + { + gdb_assert (TYPE_CODE (type) == TYPE_CODE_UNION); + resuld = instance->plugin ().build_decl + ("union", name.get (), GCC_CP_SYMBOL_UNION | nested_access, + 0, nullptr, 0, filename, line); + } + + gcc_type result; + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) + { + struct gcc_vbase_array bases; + int num_baseclasses = TYPE_N_BASECLASSES (type); + + memset (&bases, 0, sizeof (bases)); + + if (num_baseclasses > 0) + { + bases.elements = XNEWVEC (gcc_type, num_baseclasses); + bases.flags = XNEWVEC (enum gcc_cp_symbol_kind, num_baseclasses); + bases.n_elements = num_baseclasses; + for (int i = 0; i < num_baseclasses; ++i) + { + struct type *base_type = TYPE_BASECLASS (type, i); + + bases.flags[i] = GCC_CP_SYMBOL_BASECLASS + | get_field_access_flag (type, i) + | (BASETYPE_VIA_VIRTUAL (type, i) + ? GCC_CP_FLAG_BASECLASS_VIRTUAL + : GCC_CP_FLAG_BASECLASS_NOFLAG); + bases.elements[i] = instance->convert_type (base_type); + } + } + + result = instance->plugin ().start_class_type + (name.get (), resuld, &bases, filename, line); + xfree (bases.flags); + xfree (bases.elements); + } + else + { + gdb_assert (TYPE_CODE (type) == TYPE_CODE_UNION); + result = instance->plugin ().start_class_type + (name.get (), resuld, nullptr, filename, line); + } + + instance->insert_type (type, result); + + /* Add definitions. */ + compile_cplus_convert_type_defns (instance, type); + + /* Add methods. */ + compile_cplus_convert_struct_or_union_methods (instance, type, result); + + /* Add members. */ + compile_cplus_convert_struct_or_union_members (instance, type, result); + + /* All finished. */ + instance->plugin ().finish_class_type (name.get (), TYPE_LENGTH (type)); + + /* Pop all scopes. */ + instance->leave_scope (); + return result; +} + +/* Convert an enum type to its gcc representation. If this type + was defined in another type, NESTED_ACCESS should indicate the + accessibility of this type.*/ + +static gcc_type +compile_cplus_convert_enum (compile_cplus_instance *instance, struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + int scoped_enum_p = FALSE; + + /* Create a new scope for this type. */ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + + if (scope.nested_type () != GCC_TYPE_NONE) + { + /* The type requested was actually defined inside another type, + such as a nested class definition. Return that type. */ + return scope.nested_type (); + } + + gdb::unique_xmalloc_ptr<char> name + = compile_cplus_instance::decl_name (TYPE_NAME (type)); + + /* Push all scopes. */ + instance->enter_scope (scope); + + gcc_type int_type + = instance->plugin ().get_int_type (TYPE_UNSIGNED (type), + TYPE_LENGTH (type), nullptr); + gcc_type result + = instance->plugin ().start_enum_type (name.get (), int_type, + GCC_CP_SYMBOL_ENUM | nested_access + | (scoped_enum_p + ? GCC_CP_FLAG_ENUM_SCOPED + : GCC_CP_FLAG_ENUM_NOFLAG), + nullptr, 0); + for (int i = 0; i < TYPE_NFIELDS (type); ++i) + { + gdb::unique_xmalloc_ptr<char> fname + = compile_cplus_instance::decl_name (TYPE_FIELD_NAME (type, i)); + + if (TYPE_FIELD_LOC_KIND (type, i) != FIELD_LOC_KIND_ENUMVAL + || fname == nullptr) + continue; + + instance->plugin ().build_enum_constant (result, fname.get (), + TYPE_FIELD_ENUMVAL (type, i)); + } + + /* Finish enum definition and pop scopes. */ + instance->plugin ().finish_enum_type (result); + instance->leave_scope (); + return result; +} + +/* Convert a function type to its gcc representation. This function does + not deal with function templates. */ + +static gcc_type +compile_cplus_convert_func (compile_cplus_instance *instance, + struct type *type, bool strip_artificial) +{ + int is_varargs = TYPE_VARARGS (type); + struct type *target_type = TYPE_TARGET_TYPE (type); + + /* Functions with no debug info have no return type. Ideally we'd + want to fallback to the type of the cast just before the + function, like GDB's built-in expression parser, but we don't + have access to that type here. For now, fallback to int, like + GDB's parser used to do. */ + if (target_type == nullptr) + { + if (TYPE_OBJFILE_OWNED (type)) + target_type = objfile_type (TYPE_OWNER (type).objfile)->builtin_int; + else + target_type = builtin_type (TYPE_OWNER (type).gdbarch)->builtin_int; + warning (_("function has unknown return type; assuming int")); + } + + /* This approach means we can't make self-referential function + types. Those are impossible in C, though. */ + gcc_type return_type = instance->convert_type (target_type); + + struct gcc_type_array array = + { TYPE_NFIELDS (type), XNEWVEC (gcc_type, TYPE_NFIELDS (type)) }; + int artificials = 0; + for (int i = 0; i < TYPE_NFIELDS (type); ++i) + { + if (strip_artificial && TYPE_FIELD_ARTIFICIAL (type, i)) + { + --array.n_elements; + ++artificials; + } + else + { + array.elements[i - artificials] + = instance->convert_type (TYPE_FIELD_TYPE (type, i)); + } + } + + /* We omit setting the argument types to `void' to be a little flexible + with some minsyms like printf (compile-cplus.exp has examples). */ + gcc_type result = instance->plugin ().build_function_type + (return_type, &array, is_varargs); + xfree (array.elements); + return result; +} + +/* Convert an integer type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_int (compile_cplus_instance *instance, struct type *type) +{ + if (TYPE_NOSIGN (type)) + { + gdb_assert (TYPE_LENGTH (type) == 1); + return instance->plugin ().get_char_type (); + } + + return instance->plugin ().get_int_type + (TYPE_UNSIGNED (type), TYPE_LENGTH (type), TYPE_NAME (type)); +} + +/* Convert a floating-point type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_float (compile_cplus_instance *instance, + struct type *type) +{ + return instance->plugin ().get_float_type + (TYPE_LENGTH (type), TYPE_NAME (type)); +} + +/* Convert the 'void' type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_void (compile_cplus_instance *instance, struct type *type) +{ + return instance->plugin ().get_void_type (); +} + +/* Convert a boolean type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_bool (compile_cplus_instance *instance, struct type *type) +{ + return instance->plugin ().get_bool_type (); +} + +/* See description in compile-cplus.h. */ + +gcc_type +compile_cplus_instance::convert_qualified_base (gcc_type base, + gcc_cp_qualifiers_flags quals) +{ + gcc_type result = base; + + if (quals != GCC_CP_REF_QUAL_NONE) + result = plugin ().build_qualified_type (base, quals); + + return result; +} + +/* See description in compile-cplus.h. */ + +static gcc_type +compile_cplus_convert_qualified (compile_cplus_instance *instance, + struct type *type) +{ + struct type *unqual = make_unqualified_type (type); + gcc_cp_qualifiers_flags quals = (enum gcc_cp_qualifiers) 0; + gcc_type unqual_converted = instance->convert_type (unqual); + + if (TYPE_CONST (type)) + quals |= GCC_CP_QUALIFIER_CONST; + if (TYPE_VOLATILE (type)) + quals |= GCC_CP_QUALIFIER_VOLATILE; + if (TYPE_RESTRICT (type)) + quals |= GCC_CP_QUALIFIER_RESTRICT; + + return instance->convert_qualified_base (unqual_converted, quals); +} + +/* Convert a complex type to its gcc representation. */ + +static gcc_type +compile_cplus_convert_complex (compile_cplus_instance *instance, + struct type *type) +{ + gcc_type base = instance->convert_type (TYPE_TARGET_TYPE (type)); + + return instance->plugin ().build_complex_type (base); +} + +/* Convert a namespace of TYPE. */ + +static gcc_type +compile_cplus_convert_namespace (compile_cplus_instance *instance, + struct type *type) +{ + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); + gdb::unique_xmalloc_ptr<char> name + = compile_cplus_instance::decl_name (TYPE_NAME (type)); + + /* Push scope. */ + instance->enter_scope (scope); + + /* Convert this namespace. */ + instance->plugin ().push_namespace (name.get ()); + instance->plugin ().pop_binding_level (name.get ()); + + /* Pop scope. */ + instance->leave_scope (); + + /* Namespaces are non-cacheable types. */ + return GCC_TYPE_NONE; +} + +/* A helper function which knows how to convert most types from their + gdb representation to the corresponding gcc form. This examines + the TYPE and dispatches to the appropriate conversion function. It + returns the gcc type. + + If the type was defined in another type, NESTED_ACCESS should indicate the + accessibility of this type. */ + +static gcc_type +convert_type_cplus_basic (compile_cplus_instance *instance, + struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + /* If we are converting a qualified type, first convert the + unqualified type and then apply the qualifiers. */ + if ((TYPE_INSTANCE_FLAGS (type) & (TYPE_INSTANCE_FLAG_CONST + | TYPE_INSTANCE_FLAG_VOLATILE + | TYPE_INSTANCE_FLAG_RESTRICT)) != 0) + return compile_cplus_convert_qualified (instance, type); + + switch (TYPE_CODE (type)) + { + case TYPE_CODE_REF: + case TYPE_CODE_RVALUE_REF: + return compile_cplus_convert_reference (instance, type); + + case TYPE_CODE_PTR: + return compile_cplus_convert_pointer (instance, type); + + case TYPE_CODE_ARRAY: + return compile_cplus_convert_array (instance, type); + + case TYPE_CODE_STRUCT: + case TYPE_CODE_UNION: + return + compile_cplus_convert_struct_or_union (instance, type, nested_access); + + case TYPE_CODE_ENUM: + return compile_cplus_convert_enum (instance, type, nested_access); + + case TYPE_CODE_FUNC: + return compile_cplus_convert_func (instance, type, false); + + case TYPE_CODE_METHOD: + return + compile_cplus_convert_method (instance, TYPE_SELF_TYPE (type), type); + + case TYPE_CODE_MEMBERPTR: + case TYPE_CODE_METHODPTR: + return compile_cplus_convert_memberptr (instance, type); + break; + + case TYPE_CODE_INT: + return compile_cplus_convert_int (instance, type); + + case TYPE_CODE_FLT: + return compile_cplus_convert_float (instance, type); + + case TYPE_CODE_VOID: + return compile_cplus_convert_void (instance, type); + + case TYPE_CODE_BOOL: + return compile_cplus_convert_bool (instance, type); + + case TYPE_CODE_COMPLEX: + return compile_cplus_convert_complex (instance, type); + + case TYPE_CODE_NAMESPACE: + return compile_cplus_convert_namespace (instance, type); + + case TYPE_CODE_TYPEDEF: + return compile_cplus_convert_typedef (instance, type, nested_access); + + default: + break; + } + + std::string s = string_printf (_("unhandled TYPE_CODE %d"), + TYPE_CODE (type)); + + return instance->plugin ().error (s.c_str ()); +} + +gcc_type +compile_cplus_instance::convert_type (struct type *type, + enum gcc_cp_symbol_kind nested_access) +{ + /* Check if TYPE has already been converted. */ + gcc_type result; + if (get_cached_type (type, result)) + return result; + + /* It is the first time this type has been seen -- convert it + and cache it, if appropriate.. */ + result = convert_type_cplus_basic (this, type, nested_access); + if (result != GCC_TYPE_NONE) + insert_type (type, result); + return result; +} + +void +compile_cplus_instance::gcc_cplus_enter_scope + (void *datum, struct gcc_cp_context *gcc_context) +{ +} + +void +compile_cplus_instance::gcc_cplus_leave_scope + (void *datum, struct gcc_cp_context *gcc_context) +{ +} + +\f + +/* Plug-in forwards. */ + +/* C++ plug-in wrapper. */ + +/* A result printer for plug-in calls that return a gcc_type or + gcc_decl. */ + +static void +compile_cplus_debug_output_1 (gcc_type arg) +{ + fprintf_unfiltered (gdb_stdlog, "%lld", arg); +} + +static void +compile_cplus_debug_output_1 (const char *arg) +{ + if (arg == nullptr) + fputs_unfiltered ("NULL", gdb_stdlog); + else + fputs_unfiltered (arg, gdb_stdlog); +} + +static void +compile_cplus_debug_output () +{ +} + +template <typename T> +static void +compile_cplus_debug_output_1 (const T *arg) +{ +} + +template <typename T, typename... Targs> +static void +compile_cplus_debug_output (T arg, Targs... Args) +{ + compile_cplus_debug_output_1 (arg); + fputc_unfiltered (' ', gdb_stdlog); + compile_cplus_debug_output (Args...); +} + +#define FORWARD(OP,...) m_context->cp_ops->OP(m_context, ##__VA_ARGS__) +#define OUTPUT_DEBUG_RESULT(R) \ + if (debug_compile_cplus_types) \ + { \ + fputs_unfiltered (": ", gdb_stdlog); \ + compile_cplus_debug_output (R); \ + fputc_unfiltered ('\n', gdb_stdlog); \ + } \ + +#define GCC_METHOD0(R, N) \ + R gcc_cp_plugin::N () const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N)); \ + auto result = FORWARD (N); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD1(R, N, A) \ + R gcc_cp_plugin::N (A a) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a); \ + auto result = FORWARD (N, a); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD2(R, N, A, B) \ + R gcc_cp_plugin::N (A a, B b) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b); \ + auto result = FORWARD (N, a, b); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD3(R, N, A, B, C) \ + R gcc_cp_plugin::N (A a, B b, C c) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c); \ + auto result = FORWARD (N, a, b, c); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD4(R, N, A, B, C, D) \ + R gcc_cp_plugin::N (A a, B b, C c, D d) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c, d); \ + auto result = FORWARD (N, a, b, c, d); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD5(R, N, A, B, C, D, E) \ + R gcc_cp_plugin::N (A a, B b, C c, D d, E e) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c, d, e); \ + auto result = FORWARD (N, a, b, c, d, e); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } +#define GCC_METHOD7(R, N, A, B, C, D, E, F, G) \ + R gcc_cp_plugin::N (A a, B b, C c, D d, E e, F f, G g) const \ + { \ + if (debug_compile_cplus_types) \ + compile_cplus_debug_output (STRINGIFY (N), a, b, c, d, e, f, g); \ + auto result = FORWARD (N, a, b, c, d, e, f, g); \ + OUTPUT_DEBUG_RESULT (result); \ + return result; \ + } + +#include "gcc-cp-fe.def" + +#undef GCC_METHOD0 +#undef GCC_METHOD1 +#undef GCC_METHOD2 +#undef GCC_METHOD3 +#undef GCC_METHOD4 +#undef GCC_METHOD5 +#undef GCC_METHOD7 +#undef FORWARD +#undef OUTPUT_DEBUG_RESULT + +gcc_expr +gcc_cp_plugin::build_decl (const char *debug_decltype, const char *name, + enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, + const char *substitution_name, gcc_address address, + const char *filename, unsigned int line_number) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_decltype); + + return build_decl (name, sym_kind, sym_type, substitution_name, + address, filename, line_number); +} + +gcc_type +gcc_cp_plugin::start_class_type (const char *debug_name, gcc_decl typedecl, + const struct gcc_vbase_array *base_classes, + const char *filename, unsigned int line_number) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_name); + + return start_class_type (typedecl, base_classes, filename, line_number); +} + +int +gcc_cp_plugin::finish_class_type (const char *debug_name, + unsigned long size_in_bytes) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_name); + + return finish_class_type (size_in_bytes); +} + +int +gcc_cp_plugin::pop_binding_level (const char *debug_name) +{ + if (debug_compile_cplus_types) + fprintf_unfiltered (gdb_stdlog, "<%s> ", debug_name); + + return pop_binding_level (); +} + +void +_initialize_compile_cplus_types () +{ + add_setshow_boolean_cmd ("compile-cplus-types", no_class, + &debug_compile_cplus_types, _("\ +Set debugging of C++ compile type conversion."), _("\ +Show debugging of C++ compile type conversion."), _("\ +When enabled debugging messages are printed during C++ type conversion for\n\ +the compile commands."), + nullptr, + nullptr, + &setdebuglist, + &showdebuglist); + + add_setshow_boolean_cmd ("compile-cplus-scopes", no_class, + &debug_compile_cplus_scopes, _("\ +Set debugging of C++ compile scopes."), _("\ +Show debugging of C++ compile scopes."), _("\ +When enabled debugging messages are printed about definition scopes during\n\ +C++ type conversion for the compile commands."), + nullptr, + nullptr, + &setdebuglist, + &showdebuglist); +} diff --git a/gdb/compile/compile-cplus.h b/gdb/compile/compile-cplus.h new file mode 100644 index 0000000000..7baa57da84 --- /dev/null +++ b/gdb/compile/compile-cplus.h @@ -0,0 +1,205 @@ +/* Header file for GDB compile C++ language support. + Copyright (C) 2016-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#ifndef GDB_COMPILE_CPLUS_H +#define GDB_COMPILE_CPLUS_H + +#include "common/enum-flags.h" +#include "gcc-cp-plugin.h" + +struct type; +struct block; + +/* enum-flags wrapper */ +DEF_ENUM_FLAGS_TYPE (enum gcc_cp_qualifiers, gcc_cp_qualifiers_flags); +DEF_ENUM_FLAGS_TYPE (enum gcc_cp_ref_qualifiers, gcc_cp_ref_qualifiers_flags); +DEF_ENUM_FLAGS_TYPE (enum gcc_cp_symbol_kind, gcc_cp_symbol_kind_flags); + +class compile_cplus_instance; + +/* A single component of a type's scope. Type names are broken into + "components," a series of unqualified names comprising the type name, + e.g., "namespace1", "namespace2", "myclass". */ + +struct scope_component +{ + /* The unqualified name of this scope. */ + std::string name; + + /* The block symbol for this type/scope. */ + struct block_symbol bsymbol; +}; + +/* Comparison operators for scope_components. */ + +bool operator== (const scope_component &lhs, const scope_component &rhs); +bool operator!= (const scope_component &lhs, const scope_component &rhs); + + +/* A single compiler scope used to define a type. + + A compile_scope is a list of scope_components, where all leading + scope_components are namespaces, followed by a single non-namespace + type component (the actual type we are converting). */ + +class compile_scope : private std::vector<scope_component> +{ +public: + + using std::vector<scope_component>::push_back; + using std::vector<scope_component>::pop_back; + using std::vector<scope_component>::back; + using std::vector<scope_component>::empty; + using std::vector<scope_component>::size; + using std::vector<scope_component>::begin; + using std::vector<scope_component>::end; + using std::vector<scope_component>::operator[]; + + compile_scope () + : m_nested_type (GCC_TYPE_NONE), m_pushed (false) + { + } + + /* Return the gcc_type of the type if it is a nested definition. + Returns GCC_TYPE_NONE if this type was not nested. */ + gcc_type nested_type () + { + return m_nested_type; + } + +private: + + /* compile_cplus_instance is a friend class so that it can set the + following private members when compile_scopes are created. */ + friend compile_cplus_instance; + + /* If the type was actually a nested type, this will hold that nested + type after the scope is pushed. */ + gcc_type m_nested_type; + + /* If true, this scope was pushed to the compiler and all namespaces + must be popped when leaving the scope. */ + bool m_pushed; +}; + +/* Comparison operators for compile_scopes. */ + +bool operator== (const compile_scope &lhs, const compile_scope &rhs); +bool operator!= (const compile_scope &lhs, const compile_scope &rhs); + +/* Convert TYPENAME into a vector of namespace and top-most/super + composite scopes. + + For example, for the input "Namespace::classB::classInner", the + resultant vector will contain the tokens "Namespace" and + "classB". */ + +compile_scope type_name_to_scope (const char *type_name, + const struct block *block); + +/* A callback suitable for use as the GCC C++ symbol oracle. */ + +extern gcc_cp_oracle_function gcc_cplus_convert_symbol; + +/* A callback suitable for use as the GCC C++ address oracle. */ + +extern gcc_cp_symbol_address_function gcc_cplus_symbol_address; + +/* A subclass of compile_instance that is specific to the C++ front + end. */ + +class compile_cplus_instance : public compile_instance +{ +public: + + explicit compile_cplus_instance (struct gcc_cp_context *gcc_cp) + : compile_instance (&gcc_cp->base, m_default_cflags), + m_plugin (gcc_cp) + { + m_plugin.set_callbacks (gcc_cplus_convert_symbol, + gcc_cplus_symbol_address, + gcc_cplus_enter_scope, gcc_cplus_leave_scope, + this); + } + + /* Convert a gdb type, TYPE, to a GCC type. + + If this type was defined in another type, NESTED_ACCESS should indicate + the accessibility of this type (or GCC_CP_ACCESS_NONE if not a nested + type). GCC_CP_ACCESS_NONE is the default nested access. + + The new GCC type is returned. */ + gcc_type convert_type + (struct type *type, + enum gcc_cp_symbol_kind nested_access = GCC_CP_ACCESS_NONE); + + /* Return a handle for the GCC plug-in. */ + gcc_cp_plugin &plugin () { return m_plugin; } + + /* Factory method to create a new scope based on TYPE with name TYPE_NAME. + [TYPE_NAME could be TYPE_NAME or SYMBOL_NATURAL_NAME.] + + If TYPE is a nested or local definition, nested_type () will return + the gcc_type of the conversion. + + Otherwise, nested_type () is GCC_TYPE_NONE. */ + compile_scope new_scope (const char *type_name, struct type *type); + + /* Enter the given NEW_SCOPE. */ + void enter_scope (compile_scope &scope); + + /* Leave the current scope. */ + void leave_scope (); + + /* Add the qualifiers given by QUALS to BASE. */ + gcc_type convert_qualified_base (gcc_type base, + gcc_cp_qualifiers_flags quals); + + /* Convert TARGET into a pointer type. */ + gcc_type convert_pointer_base (gcc_type target); + + /* Convert BASE into a reference type. RQUALS describes the reference. */ + gcc_type convert_reference_base (gcc_type base, + enum gcc_cp_ref_qualifiers rquals); + + /* Return the declaration name of the symbol named NATURAL. + This returns a name with no function arguments or template parameters, + suitable for passing to the compiler plug-in. */ + static gdb::unique_xmalloc_ptr<char> decl_name (const char *natural); + +private: + + /* Callbacks suitable for use as the GCC C++ enter/leave scope requests. */ + static gcc_cp_enter_leave_user_expr_scope_function gcc_cplus_enter_scope; + static gcc_cp_enter_leave_user_expr_scope_function gcc_cplus_leave_scope; + + /* Default compiler flags for C++. */ + static const char *m_default_cflags; + + /* The GCC plug-in. */ + gcc_cp_plugin m_plugin; + + /* A list of scopes we are processing. */ + std::vector<compile_scope> m_scopes; +}; + +/* Get the access flag for the NUM'th method of TYPE's FNI'th + fieldlist. */ + +enum gcc_cp_symbol_kind get_method_access_flag (const struct type *type, + int fni, int num); + +#endif /* GDB_COMPILE_CPLUS_H */ diff --git a/gdb/compile/compile-internal.h b/gdb/compile/compile-internal.h index c8d2d2f427..a6e7330ae8 100644 --- a/gdb/compile/compile-internal.h +++ b/gdb/compile/compile-internal.h @@ -164,6 +164,10 @@ protected: #define COMPILE_I_EXPR_VAL "__gdb_expr_val" #define COMPILE_I_EXPR_PTR_TYPE "__gdb_expr_ptr_type" +/* A "type" to indicate a NULL type. */ + +const gcc_type GCC_TYPE_NONE = (gcc_type) -1; + /* Call gdbarch_register_name (GDBARCH, REGNUM) and convert its result to a form suitable for the compiler source. The register names should not clash with inferior defined macros. */ diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c index a83f95dda9..873750b944 100644 --- a/gdb/compile/compile-object-load.c +++ b/gdb/compile/compile-object-load.c @@ -459,7 +459,8 @@ get_out_value_type (struct symbol *func_sym, struct objfile *objfile, if (function != NULL && (BLOCK_SUPERBLOCK (function_block) == BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK)) - && (strcmp (SYMBOL_LINKAGE_NAME (function), GCC_FE_WRAPPER_FUNCTION) + && (strcmp_iw (SYMBOL_LINKAGE_NAME (function), + GCC_FE_WRAPPER_FUNCTION) == 0)) break; } @@ -478,7 +479,7 @@ get_out_value_type (struct symbol *func_sym, struct objfile *objfile, gdb_ptr_type = check_typedef (gdb_ptr_type); if (TYPE_CODE (gdb_ptr_type) != TYPE_CODE_PTR) error (_("Type of \"%s\" is not a pointer"), COMPILE_I_EXPR_PTR_TYPE); - gdb_type_from_ptr = TYPE_TARGET_TYPE (gdb_ptr_type); + gdb_type_from_ptr = check_typedef (TYPE_TARGET_TYPE (gdb_ptr_type)); if (types_deeply_equal (gdb_type, gdb_type_from_ptr)) { @@ -741,6 +742,8 @@ compile_object_load (const compile_file_names &file_names, ? mst_unknown : MSYMBOL_TYPE (bmsym.minsym)) { case mst_text: + case mst_bss: + case mst_data: sym->value = BMSYMBOL_VALUE_ADDRESS (bmsym); if (compile_debug) fprintf_unfiltered (gdb_stdlog, diff --git a/gdb/compile/compile.c b/gdb/compile/compile.c index 31ae5970b9..efa4e8d0fa 100644 --- a/gdb/compile/compile.c +++ b/gdb/compile/compile.c @@ -995,7 +995,6 @@ String quoting is parsed like in shell, for example:\n\ " -fPIE" /* We want warnings, except for some commonly happening for GDB commands. */ " -Wall " - " -Wno-implicit-function-declaration" " -Wno-unused-but-set-variable" " -Wno-unused-variable" /* Override CU's possible -fstack-protector-strong. */ diff --git a/gdb/compile/gcc-cp-plugin.h b/gdb/compile/gcc-cp-plugin.h new file mode 100644 index 0000000000..1b72726a67 --- /dev/null +++ b/gdb/compile/gcc-cp-plugin.h @@ -0,0 +1,85 @@ +/* GCC C++ plug-in wrapper for GDB. + + Copyright (C) 2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +/* A class representing the GCC C++ plug-in. */ + +#include "gcc-cp-interface.h" + +class gcc_cp_plugin +{ +public: + + explicit gcc_cp_plugin (struct gcc_cp_context *gcc_cp) + : m_context (gcc_cp) + { + } + + /* Set the oracle callbacks to be used by the compiler plug-in. */ + void set_callbacks (gcc_cp_oracle_function *binding_oracle, + gcc_cp_symbol_address_function *address_oracle, + gcc_cp_enter_leave_user_expr_scope_function *enter_scope, + gcc_cp_enter_leave_user_expr_scope_function *leave_scope, + void *datum) + { + m_context->cp_ops->set_callbacks (m_context, binding_oracle, + address_oracle, enter_scope, leave_scope, + datum); + } + + /* Returns the interface version of the compiler plug-in. */ + int version () const { return m_context->cp_ops->cp_version; } + +#define GCC_METHOD0(R, N) R N () const; +#define GCC_METHOD1(R, N, A) R N (A) const; +#define GCC_METHOD2(R, N, A, B) R N (A, B) const; +#define GCC_METHOD3(R, N, A, B, C) R N (A, B, C) const; +#define GCC_METHOD4(R, N, A, B, C, D) R N (A, B, C, D) const; +#define GCC_METHOD5(R, N, A, B, C, D, E) R N (A, B, C, D, E) const; +#define GCC_METHOD7(R, N, A, B, C, D, E, F, G) R N (A, B, C, D, E, F, G) const; + +#include "gcc-cp-fe.def" + +#undef GCC_METHOD0 +#undef GCC_METHOD1 +#undef GCC_METHOD2 +#undef GCC_METHOD3 +#undef GCC_METHOD4 +#undef GCC_METHOD5 +#undef GCC_METHOD7 + + /* Special overloads of plug-in methods with added debugging information. */ + + gcc_expr build_decl (const char *debug_decltype, const char *name, + enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, + const char *substitution_name, gcc_address address, + const char *filename, unsigned int line_number); + + gcc_type start_class_type (const char *debug_name, gcc_decl typedecl, + const struct gcc_vbase_array *base_classes, + const char *filename, unsigned int line_number); + + int finish_class_type (const char *debug_name, unsigned long size_in_bytes); + + int pop_binding_level (const char *debug_name); + +private: + + /* The GCC C++ context. */ + struct gcc_cp_context *m_context; +}; diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index ceb4043e32..f8fcd33481 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + + * gdb.texinfo (Compiling and injecting code in GDB): Document + set/show "compile-oracle" and "compile-cplus-types" commands. + 2018-08-07 Simon Marchi <simon.marchi@ericsson.com> * gdb.texinfo (Index Files Speed Up GDB): Add section about diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index b931834400..f83e06058b 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -18689,6 +18689,16 @@ injecting the code. The default is off. @item show debug compile Displays the current state of displaying @value{GDBN} process of compiling and injecting the code. + +@anchor{set debug compile-cplus-types} +@item set debug compile-cplus-types +@cindex compile C@t{++} type conversion +Turns on or off the display of C@t{++} type conversion debugging information. +The default is off. + +@item show debug compile-cplus-types +Displays the current state of displaying debugging information for +C@t{++} type conversion. @end table @subsection Compilation options for the @code{compile} command diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index bd3c3bfec5..050e406349 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,28 @@ +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + + * gdb.compile/compile-cplus-anonymous.cc: New file. + * gdb.compile/compile-cplus-anonymous.exp: New file. + * gdb.compile/compile-cplus-array-decay.cc: New file. + * gdb.compile/compile-cplus-array-decay.exp: New file. + * gdb.compile/compile-cplus-inherit.cc: New file. + * gdb.compile/compile-cplus-inherit.exp: New file. + * gdb.compile/compile-cplus-member.cc: New file. + * gdb.compile/compile-cplus-member.exp: New file. + * gdb.compile/compile-cplus-method.cc: New file. + * gdb.compile/compile-cplus-method.exp: New file. + * gdb.compile/compile-cplus-mod.c: "New" file. + * gdb.compile/compile-cplus-namespace.cc: New file. + * gdb.compile/compile-cplus-namespace.exp: New file. + * gdb.compile/compile-cplus-nested.cc: New file. + * gdb.compile/compile-cplus-nested.exp: New file. + * gdb.compile/compile-cplus-print.c: "New" file. + * gdb.compile/compile-cplus-print.exp: "New" file. + * gdb.compile/compile-cplus-virtual.cc: New file. + * gdb.compile/compile-cplus-virtual.exp: New file. + * gdb.compile/compile-cplus.c: "New" file. + * gdb.compile/compile-cplus.exp: "New" file. + * lib/compile-support.exp: New file. + 2018-08-09 Andrew Burgess <andrew.burgess@embecosm.com> * gdb.base/vla-optimized-out.exp: Add new test. diff --git a/gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc new file mode 100644 index 0000000000..95c4430e51 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.cc @@ -0,0 +1,76 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +namespace { + static enum {ABC = 1, DEF, GHI, JKL} anon_e = GHI; + static union + { + char aa; + int bb; + float ff; + double dd; + void *pp; + } anon_u = { 'a' }; + + static struct + { + char *ptr; + int len; + struct + { + unsigned MAGIC; + }; + union + { + int ua; + char *ub; + }; + } anon_s = {"abracadabra", 11, 0xdead, 0xbeef}; + + struct A + { + A () : e (AA) + { + this->u.b = 0; + this->s.ptr = "hello"; + this->s.len = 5; + } + + enum {AA = 10, BB, CC, DD} e; + union + { + char a; + int b; + float f; + double d; + void *p; + } u; + struct + { + char *ptr; + int len; + } s; + }; +}; + +int +main () +{ + A a; + int var = 1234; + + return a.u.b + a.s.len + static_cast<int> (a.e) + + static_cast<int> (anon_e) + anon_u.bb + anon_s.len; // break here +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp new file mode 100644 index 0000000000..0aa3290557 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-anonymous.exp @@ -0,0 +1,64 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Anonymous type conversion tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +# Reminder, "var" is an integer; all these types get converted to `int'. +CompileExpression::new "var" +CompileExpression::test "anon_e" {(3|GHI)} +CompileExpression::test "anon_u.aa" {97( 'a')?} +CompileExpression::test "a.u.b" 0 +CompileExpression::test "a.s.len" 5 +CompileExpression::test "a.e" {(10|A::AA)} +CompileExpression::test "(*a.s.ptr != 'h')" (0|false) +CompileExpression::test "A::BB" {(11|A::BB)} +CompileExpression::test "ABC" {(1|ABC)} +CompileExpression::test "DEF" {(2|DEF)} +CompileExpression::test "GHI" {(3|GHI)} +CompileExpression::test "JKL" {(4|JKL)} + +set k "compile/1234 *-*-*" +CompileExpression::test "anon_s.len" 11 -kfail $k +CompileExpression::test "anon_s.MAGIC" "57005" -kfail $k +CompileExpression::test "anon_s.ua" "48879" -kfail $k +CompileExpression::test "(*anon_s.ptr == 'a')" (1|true) -kfail $k diff --git a/gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc new file mode 100644 index 0000000000..da51a65654 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.cc @@ -0,0 +1,31 @@ +/* Copyright 2017-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +static const char *g_string_initializer = "hello"; + +int +main () +{ + int integers[10]; + const char *strings[10]; + + for (auto &i : integers) + i = 0; + + for (auto &i : strings) + i = g_string_initializer; + + return 0; // break here +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp new file mode 100644 index 0000000000..fb3e63fd91 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-array-decay.exp @@ -0,0 +1,50 @@ +# Copyright 2017-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Test whether GDB's C++ compile feature is decaying arrays into pointers. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +gdb_test "compile print integers" " = \\{0, 0, 0, 0, 0, 0, 0, 0, 0, 0\\}" + +gdb_test "compile print strings" " = \\{$hex \"hello\", $hex \"hello\",\ + $hex \"hello\", $hex \"hello\", $hex \"hello\", $hex \"hello\",\ + $hex \"hello\", $hex \"hello\", $hex \"hello\", $hex \"hello\"\\}" diff --git a/gdb/testsuite/gdb.compile/compile-cplus-inherit.cc b/gdb/testsuite/gdb.compile/compile-cplus-inherit.cc new file mode 100644 index 0000000000..1d93f9cf01 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-inherit.cc @@ -0,0 +1,58 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +struct A +{ + A () : a_ (1) {} + int do_it (int amount) { return a_ + amount; } + + int a_; +}; + +struct B +{ + B () : b_ (2) {} + int do_it (int amount) { return b_ - amount; } + + int b_; +}; + +struct C +{ + C () : c_ (3) {} + int do_it (int amount) { return c_ * amount; } + + int c_; +}; + +struct D : public A, B, C +{ + D () : d_ (4) {} + + int d_; +}; + +int +main () +{ + D d; + int var = 1234; + + var = d.A::do_it (1) + + d.B::do_it (2) + + d.C::do_it (3); // break here + + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp b/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp new file mode 100644 index 0000000000..1978cb556a --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-inherit.exp @@ -0,0 +1,53 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Inheritance tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "d.a_" 1 +CompileExpression::test "d.b_" 2 +CompileExpression::test "d.c_" 3 +CompileExpression::test "d.d_" 4 +CompileExpression::test "d.A::do_it (1)" 2 +CompileExpression::test "d.B::do_it (1)" 1 +CompileExpression::test "d.C::do_it (1)" 3 diff --git a/gdb/testsuite/gdb.compile/compile-cplus-member.cc b/gdb/testsuite/gdb.compile/compile-cplus-member.cc new file mode 100644 index 0000000000..d742318f68 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-member.cc @@ -0,0 +1,83 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +class A; +static int get_values (const A& a); + +enum myenum {E_A = 10, E_B, E_C, E_D, E_E}; + +namespace N { + typedef enum {NA = 20, NB, NC, ND} ANON_NE; +} + +namespace { + typedef enum {AA = 40, AB, AC, AD} ANON_E; +} + +ANON_E g_e = AC; + +class A +{ +public: + typedef int ATYPE; + + A () : public_ (1), protected_ (N::NB), private_ (3) {} + ATYPE public_; + static const myenum s_public_; + friend ATYPE get_values (const A&); + +protected: + N::ANON_NE protected_; + static N::ANON_NE s_protected_; + +private: + ATYPE private_; + static myenum s_private_; +}; + +const myenum A::s_public_ = E_A; +N::ANON_NE A::s_protected_ = N::NA; +myenum A::s_private_ = E_C; + +static A::ATYPE +get_values (const A& a) +{ + A::ATYPE val; + + val = a.public_ + a.private_; // 1 + 3 + if (a.protected_ == N::NB) // + 21 + val += 21; + if (a.s_public_ == E_A) // +10 + val += 10; + if (a.s_protected_ == N::NA) // +20 + val += 20; + if (a.s_private_ == E_C) // +30 + val += 30; + if (g_e == AC) // +40 + val += 40; + return val; // = 125 +} + +typedef int A::*PMI; + +int +main () +{ + A a; + int var = 1234; + PMI pmi = &A::public_; + + return a.*pmi + get_values (a); // break here +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-member.exp b/gdb/testsuite/gdb.compile/compile-cplus-member.exp new file mode 100644 index 0000000000..f6255df399 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-member.exp @@ -0,0 +1,76 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Member tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "a.public_" 1 +CompileExpression::test "a.protected_" {(21|N::NB)} +CompileExpression::test "a.private_" 3 +CompileExpression::test "A::s_public_" {(10|E_A)} +CompileExpression::test "A::s_protected_" {(20|N::NA)} +CompileExpression::test "A::s_private_" {(12|E_C)} +CompileExpression::test "A::ATYPE i = 10; var = i;" 10 -explicit +CompileExpression::test "get_values (a)" 125 +CompileExpression::test "myenum me = E_B; var = me;" 11 -explicit +CompileExpression::test "A::s_protected_ = N::NB; var = A::s_protected_;" \ + 21 -explicit +CompileExpression::test "A::s_private_ = E_B; var = A::s_private_;" 11 -explicit +CompileExpression::test "N::ANON_NE ae = N::ND; var = ae;" 23 -explicit +CompileExpression::test {a.*pmi} 1 +CompileExpression::test {a.public_ = 2; var = a.*pmi; a.public_ = 1} 2 -explicit +CompileExpression::test "g_e" {(42|AC)} + +# Test some compilation failures +set failed {\r\nCompilation failed\.} +gdb_test "compile code a.s_public_ = E_B" \ + ".*assignment of read-only variable 'A::s_public_'$failed" + +gdb_test "compile code get_values ()" \ + ".*too few arguments to function.*$failed" + +gdb_test "compile code ATYPE i;" \ + ".*.ATYPE. was not declared in this scope$failed" + +gdb_test "compile code N::ANON_NE nse = E_A" \ + ".*cannot convert.*$failed" diff --git a/gdb/testsuite/gdb.compile/compile-cplus-method.cc b/gdb/testsuite/gdb.compile/compile-cplus-method.cc new file mode 100644 index 0000000000..39934935ea --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-method.cc @@ -0,0 +1,91 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +class A; +static int get_value (const A* a); + +class A +{ +public: + typedef int ATYPE; + + A () : a_ (21) {} + ATYPE get_var () { return a_; } + ATYPE get_var (unsigned long a) { return 100; } + ATYPE get_var (ATYPE a) { return 101; } + ATYPE get_var (float a) { return 102; } + ATYPE get_var (void *a) { return 103;} + ATYPE get_var (A& lr) { return 104; } + ATYPE get_var (A const& lr) { return 105; } + + ATYPE get_var1 (int n) { return a_ << n; } + ATYPE get_var2 (int incr, unsigned n) { return (a_ + incr) << n; } + + static ATYPE get_1 (int a) { return a + 1; } + static ATYPE get_2 (int a, int b) { return a + b + 2; } + + friend ATYPE get_value (const A*); + +private: + ATYPE a_; +}; + +static A::ATYPE +get_value (A::ATYPE a) +{ + return a; +} + +static A::ATYPE +get_value (const A* a) +{ + return a->a_; +} + +static A::ATYPE +get_value () +{ + return 200; +} + +typedef int (A::*PMF) (A::ATYPE); + +int +main () +{ + A *a = new A (); + int var = 1234; + float f = 1.23; + unsigned long ul = 0xdeadbeef; + A const* ac = a; + + PMF pmf = &A::get_var; + PMF *pmf_p = &pmf; + + var -= a->get_var (); // break here + var -= a->get_var (1); + var -= a->get_var (ul); + var -= a->get_var (f); + var -= a->get_var (a); + var -= a->get_var (*a); + var -= a->get_var (*ac); + var -= a->get_var1 (1); + var -= a->get_var2 (1, 2); + var += (a->*pmf) (1); + var -= (a->**pmf_p) (1); + + return var - A::get_1 (1) + A::get_2 (1, 2) + get_value () + + get_value (get_value ()) + get_value (a); +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-method.exp b/gdb/testsuite/gdb.compile/compile-cplus-method.exp new file mode 100644 index 0000000000..3a5bb82850 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-method.exp @@ -0,0 +1,67 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Method tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "a->get_var ()" 21 +CompileExpression::test "a->get_var (static_cast<unsigned long> (1))" 100 +CompileExpression::test "a->get_var (static_cast<int> (1))" 101 +CompileExpression::test "a->get_var (static_cast<float> (1))" 102 +CompileExpression::test "a->get_var (static_cast<void *> (a))" 103 +CompileExpression::test "a->get_var (*a)" 104 +CompileExpression::test "a->get_var (*ac)" 105 +CompileExpression::test "a->get_var1 (1)" 42 +CompileExpression::test "a->get_var2 (1, 2)" 88 +CompileExpression::test "A::get_1 (1)" 2 +CompileExpression::test "A::get_2 (1, 2)" 5 +CompileExpression::test "A::get_1 (a->get_var ())" 22 +CompileExpression::test "a->get_var1 (a->get_var () - 16)" 672 +CompileExpression::test "a->get_var2 (a->get_var (), A::get_1 (2))" 336 +CompileExpression::test "get_value ()" 200 +CompileExpression::test "get_value (a)" 21 +CompileExpression::test "get_value (get_value ())" 200 +CompileExpression::test {(a->*pmf) (1)} 101 +CompileExpression::test \ + {pmf = &A::get_var1; var = (a->*pmf) (2); pmf = &A::get_var} 84 -explicit +CompileExpression::test {(a->**pmf_p) (1)} 101 diff --git a/gdb/testsuite/gdb.compile/compile-cplus-mod.c b/gdb/testsuite/gdb.compile/compile-cplus-mod.c new file mode 100644 index 0000000000..617f2cb730 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-mod.c @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2014-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +extern "C" void +_gdb_expr () +{ + // Make 'globalvar' lookup working. +#pragma GCC push_user_expression + + globalvar = 3; + globalvar += 4; + +#pragma GCC pop_user_expression +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-namespace.cc b/gdb/testsuite/gdb.compile/compile-cplus-namespace.cc new file mode 100644 index 0000000000..c64077a8a1 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-namespace.cc @@ -0,0 +1,52 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +namespace N1 +{ + namespace N2 + { + namespace N3 + { + namespace N4 + { + static int n4static = 400; + + struct S4 + { + static int s4static; + int s4int_; + S4 () : s4int_ (4) {}; + ~S4 () { --s4static; } + + int get_var () { return s4int_; } + static int get_svar () { return s4static; } + }; + int S4::s4static = 40; + } + } + } +} + +int +main () +{ + using namespace N1::N2::N3::N4; + + S4 s4; + int var = 1234; + + var += s4.s4int_; /* break here */ + return S4::get_svar () - 10 * s4.get_var (); +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp b/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp new file mode 100644 index 0000000000..768a707b93 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp @@ -0,0 +1,51 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Namespace tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "N1::N2::N3::N4::n4static" 400 +CompileExpression::test "N1::N2::N3::N4::S4::s4static" 40 +CompileExpression::test "s4.s4int_" 4 +CompileExpression::test "N1::N2::N3::N4::S4::get_svar ()" 40 +CompileExpression::test "s4.get_var ()" 4 diff --git a/gdb/testsuite/gdb.compile/compile-cplus-nested.cc b/gdb/testsuite/gdb.compile/compile-cplus-nested.cc new file mode 100644 index 0000000000..60b79cc852 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-nested.cc @@ -0,0 +1,58 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +class A +{ +public: + A () : a_ (1) {} + int get (); + +protected: + int a_; + +private: + /* It is important to not /not/ use the nested class definition in A. + This exercises a different path through the code. */ + struct Inner1 + { + int a_; + Inner1 () : a_ (2) {} + + struct Inner2 + { + int a_; + Inner2 () : a_ (3) {} + }; + }; +}; + +int +A::get () +{ + A::Inner1 i1; + A::Inner1::Inner2 i2; + + return i1.a_ + i2.a_; // break here +} + +int var = 1234; + +int +main () +{ + A a; + + return a.get (); +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-nested.exp b/gdb/testsuite/gdb.compile/compile-cplus-nested.exp new file mode 100644 index 0000000000..3b5ba20b28 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-nested.exp @@ -0,0 +1,53 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Nested type tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "i1.a_" 2 +CompileExpression::test "i2.a_" 3 +CompileExpression::test "A::Inner1 *i1p = &i1; var = i1p->a_;" 2 -explicit +CompileExpression::test "A::Inner1::Inner2 *i2p = &i2; var = i2p->a_;" 3 \ + -explicit +CompileExpression::test "A::Inner1 &r1 = i1; var = r1.a_;" 2 -explicit +CompileExpression::test "A::Inner1::Inner2 &r2 = i2; var = r2.a_;" 3 -explicit diff --git a/gdb/testsuite/gdb.compile/compile-cplus-print.c b/gdb/testsuite/gdb.compile/compile-cplus-print.c new file mode 100644 index 0000000000..a1f8d049ff --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-print.c @@ -0,0 +1,32 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include <stdlib.h> + +int varint = 10; +int vararray[] = { 1, 2, 3, 4, 5 }; +int *vararrayp = vararray; +struct object +{ + int field; +} varobject = { 1 }; + +int +main () +{ + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-print.exp b/gdb/testsuite/gdb.compile/compile-cplus-print.exp new file mode 100644 index 0000000000..f9de0e1c05 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-print.exp @@ -0,0 +1,79 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +load_lib compile-support.exp + +standard_testfile + +get_compiler_info +set options {} +if [test_compiler_info gcc*] { + lappend options additional_flags=-g3 + lappend options additional_flags=-std=gnu++11 + lappend options c++ +} + +set srcfilesoptions [list ${srcfile} ${options}] + +if { [eval build_executable_from_specs ${testfile}.exp $testfile {$options} ${srcfilesoptions}] } { + return -1 +} + +clean_restart ${testfile} + +if {[skip_compile_feature_tests]} { + untested "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_test_no_output "set language c++" \ + "Set language to C++" + +if ![runto_main] { + return -1 +} + +gdb_test "compile print varint" " = 10" +gdb_test "compile print vararray" " = \\{1, 2, 3, 4, 5\\}" + +setup_kfail compile/1234 *-*-* +gdb_test "compile print main" " = \\{int \\(void\\)\\} 0x\[0-9a-f\]+" + +setup_kfail compile/124 *-*-* +set test "compile print *vararray@3" +gdb_test_multiple $test $test { + -re " = \\{1, 2, 3\\}\r\n$gdb_prompt $" { + pass $test + } + -re "warning: .*All references to this method will be undefined\.\r\n" { + exp_continue + } +} + +setup_kfail compile/1234 *-*-* +set test "compile print *vararrayp@3" +gdb_test_multiple $test $test { + -re " = \\{1, 2, 3\\}\r\n$gdb_prompt $" { + pass $test + } + -re "warning: .*All references to this method will be undefined\.\r\n" { + exp_continue + } +} + +gdb_test "compile print/x 256" " = 0x100" +gdb_test {print $} " = 256" + +gdb_test "compile print varobject" { = {field = 1}} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-virtual.cc b/gdb/testsuite/gdb.compile/compile-cplus-virtual.cc new file mode 100644 index 0000000000..f3317a3572 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-virtual.cc @@ -0,0 +1,54 @@ +/* Copyright 2015-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +struct A +{ + virtual int doit () { return 1; } + virtual int doit3 () { return -3; } + virtual int doit2 () = 0; +}; + +struct B : virtual A +{ + int doit () { return 2; } + int doit2 () { return 22; } +}; + +struct C : virtual A +{ + int doit () { return 3; } + int doit2 () { return 33; } +}; + +struct D : B, C +{ + int doit () { return 4; } + int doit2 () { return 44; } +}; + +int +main () +{ + int var = 1234; + B b; + C c; + D d; + A *ap = &d; + + var = (b.doit () + c.doit () + d.doit () + d.doit3 () + + ap->doit () + ap->doit2 ()); // break here + + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp b/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp new file mode 100644 index 0000000000..3a3e7b9673 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus-virtual.exp @@ -0,0 +1,71 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Virtual method/inheritance tests for GDB's C++ compile feature. + +load_lib compile-support.exp + +standard_testfile .cc + +if {[skip_cplus_tests]} { + untested "skipping C++ tests" + return +} + +if {[prepare_for_testing $testfile $testfile $srcfile \ + {debug nowarnings c++}]} { + return -1 +} + +if {![runto_main]} { + untested "could not run to main" + return -1 +} + +if {[skip_compile_feature_tests]} { + untested \ + "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +gdb_breakpoint [gdb_get_line_number "break here" $srcfile] +gdb_continue_to_breakpoint "testing location" + +CompileExpression::new "var" +CompileExpression::test "b.doit ()" 2 +CompileExpression::test "c.doit ()" 3 +CompileExpression::test "d.doit ()" 4 +CompileExpression::test "ap->doit ()" 4 +CompileExpression::test "b.doit2 ()" 22 +CompileExpression::test "c.doit2 ()" 33 +CompileExpression::test "d.doit2 ()" 44 +CompileExpression::test "ap->doit2 ()" 44 +CompileExpression::test "b.doit3 ()" -3 +CompileExpression::test "c.doit3 ()" -3 +CompileExpression::test "d.doit3 ()" -3 + +# These two tests are "disabled". They represent new/future features. +# CompileExpression::test \ + [concat "struct ABC {int doit2() { return 3333; }} abc;" \ + "var = abc.doit2()"] \ + 3333 -explicit +# CompileExpression::test \ + [concat "struct ABC : A {int doit2() { return 4444; }} abc;" \ + "var = abc.doit2()"] \ + 4444 -explicit + +# Test some error conditions +gdb_test "compile code A a;" \ + ".*cannot declare variable .a. to be of abstract type.*Compilation failed." diff --git a/gdb/testsuite/gdb.compile/compile-cplus.c b/gdb/testsuite/gdb.compile/compile-cplus.c new file mode 100644 index 0000000000..558f1b6930 --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus.c @@ -0,0 +1,241 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2014-2018 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include <stdbool.h> +#include <iostream> + +#define SOME_MACRO 23 +#define ARG_MACRO(X, Y) ((X) + (Y) - 1) + + +enum enum_type { + ONE = 1, + TWO = 2 +}; + +typedef int v4 __attribute__ ((vector_size (16))); + +union union_type; + +struct struct_type { + char charfield; + unsigned char ucharfield; + short shortfield; + unsigned short ushortfield; + int intfield; + unsigned int uintfield; + unsigned int bitfield : 3; + long longfield; + unsigned long ulongfield; + enum enum_type enumfield; + float floatfield; + double doublefield; + const union union_type *ptrfield; + struct struct_type *selffield; + int arrayfield[5]; + _Complex double complexfield; + _Bool boolfield; + v4 vectorfield; +}; + +typedef int inttypedef; + +union union_type { + int intfield; + inttypedef typedeffield; +}; + +/* volatile provides some coverage of the conversion code. */ +volatile struct struct_type struct_object; + +union union_type union_object; + + +enum ulonger_enum_type { + REALLY_MINUS_1 = -1UL, +}; + +enum ulonger_enum_type ulonger; + +enum longer_enum_type { + MINUS_1 = -1, + FORCE_TO_LONG = 1L << ((8 * sizeof (long)) - 2) +}; + +enum longer_enum_type longer; + +int globalvar = 10; + +static void +func_static (int addend) +{ + globalvar += addend; +} + +void +func_global (int subtrahend) +{ + globalvar -= subtrahend; +} + +void +no_args_or_locals () +{ + /* no_args_or_locals breakpoint */ +} + +int *intptr; +int globalshadow = 10; +static int staticshadow = 20; +int externed = 7; + +class Base +{ + virtual int pure_virt () = 0; + public: + int return_value () {return a;} + private: + int a = 1; + int b = 2; +}; + +class Base2 +{ + virtual int non_pure () {return 84;} + public: + int return_value () {return b;} + private: + int a = 3; + int b = 4; +}; + +class Base3 +{ + public: + int return_value () {return b;} + private: + int b = 5; +}; + + +class Multiple : public Base, public Base2 +{ + int pure_virt () + { + int a = Base::return_value (); + return a + 42; + } +}; +//struct foo { foo(); virtual ~foo(); }; struct bar : virtual foo { bar(); ~bar(); }; struct baz : bar {}; bar::bar() {} bar::~bar() {} bar t; baz u; +struct VirtualOnly +{ + VirtualOnly(); + virtual ~VirtualOnly()=0; +}; + +VirtualOnly::VirtualOnly () +{ +} + +VirtualOnly::~VirtualOnly () +{ +} + +struct VirtualBase : virtual VirtualOnly +{ + int z = 22; + VirtualBase (); + ~VirtualBase (); +}; + +struct VirtualBase2 : VirtualBase {}; + +VirtualBase::VirtualBase () +{ + z = 24; +} + +VirtualBase::~VirtualBase () +{ + z = 22; +} + +class Foo +{ + int var; + static const int public_static_var = 12; + + private: + int private_var = 0; + int private_method (); + + public: + int public_var = 0; + int public_method (); + void set_private_var (int); +}; + +void Foo::set_private_var (int i) +{ + private_var = i; +} + +int Foo::private_method () +{ + return private_var; +} + +int Foo::public_method () +{ + return public_var; +} + +int +main () +{ + int localvar = 50; + int shadowed = 51; + int bound = 3; + int unresolved = 10; + int globalshadow = 100; + int staticshadow = 200; + int externed = 9; + int f = 0; + int var = 0; + Foo foovar; + Multiple *multivar = new Multiple; + VirtualBase vbase; + VirtualBase2 vbase2; + static int static_local = 77000; + + foovar.public_var = 42; + foovar.set_private_var (42); + multivar->Base2::return_value(); + { + int another_local = 7; + int shadowed = 52; + extern int unresolved; + extern int externed; + + int vla[bound]; + + func_static (0); /* break-here */ + no_args_or_locals (); + } + + return 0; +} diff --git a/gdb/testsuite/gdb.compile/compile-cplus.exp b/gdb/testsuite/gdb.compile/compile-cplus.exp new file mode 100644 index 0000000000..2e770c0a1e --- /dev/null +++ b/gdb/testsuite/gdb.compile/compile-cplus.exp @@ -0,0 +1,347 @@ +# Copyright 2014-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +load_lib compile-support.exp + +standard_testfile .c compile-shlib.c compile-constvar.S compile-nodebug.c + +get_compiler_info +set options {} +if [test_compiler_info gcc*] { + lappend options additional_flags=-g3 + lappend options additional_flags=-std=gnu++11 + lappend options c++ +} + +if { ![istarget x86_64-*-* ] || ![is_lp64_target] } { + verbose "Skipping x86_64 LOC_CONST test." + set srcfile3 "" +} + +set srcfilesoptions [list ${srcfile} ${options}] +if { $srcfile3 != "" } { + lappend srcfilesoptions $srcfile3 ${options} +} +lappend srcfilesoptions $srcfile4 "nodebug c++" +if { [eval build_executable_from_specs ${testfile}.exp $testfile {$options} ${srcfilesoptions}] } { + return -1 +} + +clean_restart ${testfile} + +# +# FIXME: Right now, for C++ we just duplicate the C tests, but force +# the language to C++ +# +gdb_test_no_output "set language c++" \ + "Set language to C++" + +if ![runto_main] { + return -1 +} + +if {[skip_compile_feature_tests]} { + untested "compile command not supported (could not find libcc1 shared library?)" + return -1 +} + +# +# Test delimiter for code, and arguments. +# + + +gdb_test_no_output "compile code globalvar = SOME_MACRO;" \ + "set variable from macro" +gdb_test "p globalvar" " = 23" "expect 23" + +gdb_test_no_output "compile code globalvar = ARG_MACRO(0, 0);" \ + "set variable from function-like macro" +gdb_test "p globalvar" " = -1" "expect -1" + +gdb_test_no_output "compile code globalvar = 42;" "set variable" +gdb_test "p globalvar" " = 42" "expect 42" + +gdb_test_no_output "compile code globalvar *= 2;" "modify variable" +gdb_test "p globalvar" " = 84" "expect 84" + +gdb_test_no_output "compile file -r ${srcdir}/${subdir}/${testfile}-mod.c" \ + "use external source file" +gdb_test "p globalvar" " = 7" "expect 7" + +gdb_test_no_output "compile code func_static (2);" "call static function" +gdb_test "p globalvar" " = 9" "expect 9" +gdb_test_no_output "compile code func_global (1);" "call global function" +gdb_test "p globalvar" " = 8" "expect 8" + +gdb_test_no_output \ + "compile code globalvar = (sizeof (ulonger) == sizeof (long))" \ + "compute size of ulonger" +gdb_test "p globalvar" " = 1" "check size of ulonger" +gdb_test_no_output \ + "compile code globalvar = (sizeof (longer) == sizeof (long))" \ + "compute size of longer" +gdb_test "p globalvar" " = 1" "check size of longer" +gdb_test_no_output "compile code globalvar = MINUS_1" +gdb_test "p globalvar" " = -1" "check MINUS_1" + +gdb_test_no_output "compile code globalvar = static_local" +gdb_test "p globalvar" " = 77000" "check static_local" + +gdb_test_no_output \ + "compile code static int staticvar = 5; intptr = &staticvar" \ + "do not keep jit in memory" +gdb_test "p *intptr" "Cannot access memory at address 0x\[0-9a-f\]+" \ + "expect 5" + +gdb_test "compile code func_doesnotexist ();" "error: \'func_doesnotexist\' was not declared in this scope.*" + +gdb_test "compile code *(volatile int *) 0 = 0;" \ + "The program being debugged was signaled while in a function called from GDB\\.\r\nGDB remains in the frame where the signal was received\\.\r\n.*" \ + "compile code segfault first" +gdb_test "bt" \ + "\r\n#0 \[^\r\n\]* in _gdb_expr \[^\r\n\]*\r\n#1 <function called from gdb>\r\n.*" + +set test "p/x \$pc" +set infcall_pc 0 +gdb_test_multiple $test $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + set infcall_pc $expect_out(1,string) + pass $test + } +} + +gdb_test "info sym $infcall_pc" "\r\n_gdb_expr.*" "info sym found" +gdb_test "return" "\r\n#0 main .*" "return" \ + "Make _gdb_expr\\(__gdb_regs\\*\\) return now\\? \\(y or n\\) " "y" +gdb_test "info sym $infcall_pc" "\r\nNo symbol matches .*" "info sym not found" + +gdb_test_no_output "set unwindonsignal on" +gdb_test "compile code *(volatile int *) 0 = 0;" \ + "The program being debugged was signaled while in a function called from GDB\\.\r\nGDB has restored the context to what it was before the call\\.\r\n.*" \ + "compile code segfault second" + +gdb_breakpoint [gdb_get_line_number "break-here"] +gdb_continue_to_breakpoint "break-here" ".* break-here .*" + +# C++ Specific tests. +## Public methods and members + +gdb_test "print foovar.public_var" "42" \ + "Test compile code foovar.public_var = 42 setting." +gdb_test_no_output "compile code foovar.public_var = 43;" \ + "set foobar.public_var to 43" +gdb_test "print foovar.public_var" "43" \ + "Test compile code foovar.public_var = 43 setting." +gdb_test "print foovar.public_method ()" "43" \ + "Test compile code foovar.public_method = 43 setting." + +## Private methods and members +gdb_test_no_output "compile code foovar.set_private_var (84);" \ + "Call class function to set private_var" +gdb_test "print foovar.private_var" "84" \ + "Test compile code foovar.set_private_var = 84 setting." +gdb_test_no_output "compile code foovar.private_var = 85" \ + "Directly set a private member in GDB compile5" +gdb_test "print foovar.private_var" "85" \ + "Test compile code foovar.set_private_var = 85 setting." + +## Simple inheritance +CompileExpression::new "var" +CompileExpression::test "class Baz: public Foo {public: int z = 12;}; Baz bazvar; bazvar.z = 24; var = bazvar.z" 24 -explicit +## Multiple inheritance +CompileExpression::test "class MI: public Base, public Base2 {int pure_virt () {return 42;}}; MI MIVar; var = MIVar.pure_virt();" 42 -explicit +CompileExpression::test "class MI: public Base, public Base2 {int pure_virt () {return Base::return_value() + 42;}}; MI MIVar; var = MIVar.pure_virt();" 43 -explicit +CompileExpression::test "class Base3 {public: int z = 99;}; class MI: public Base, public Base3 {int pure_virt () {return Base3::z + 42;}}; MI MIVar; var = MIVar.pure_virt();" 141 -explicit + +gdb_test "p localvar" " = 50" "expect localvar 50" + +gdb_test_no_output "compile code localvar = 12;" "set localvar" +gdb_test "p localvar" " = 12" "expect 12" + +gdb_test_no_output "compile code localvar *= 2;" "modify localvar" +gdb_test "p localvar" " = 24" "expect 24" + +gdb_test_no_output "compile code localvar = shadowed" \ + "test shadowing" +gdb_test "p localvar" " = 52" "expect 52" + +gdb_test_no_output "compile code localvar = externed" +gdb_test "p localvar" " = 7" "test extern in inner scope" + +gdb_test_no_output "compile code vla\[2\] = 7" +gdb_test "p vla\[2\]" " = 7" +gdb_test_no_output \ + "compile code localvar = (sizeof (vla) == bound * sizeof (vla\[0\]))" +gdb_test "p localvar" " = 1" + +# +# Test setting fields and also many different types. +# + +gdb_test_no_output "compile code struct_object.selffield = (struct_type*)&struct_object" +gdb_test "print struct_object.selffield == &struct_object" " = true" + +gdb_test_no_output "compile code struct_object.charfield = 1" +gdb_test "print struct_object.charfield" " = 1 '\\\\001'" +gdb_test_no_output "compile code struct_object.ucharfield = 1" +gdb_test "print struct_object.ucharfield" " = 1 '\\\\001'" + +foreach {field value} { + shortfield -5 + ushortfield 5 + intfield -7 + uintfield 7 + bitfield 2 + longfield -9 + ulongfield 9 + enumfield ONE + floatfield 1 + doublefield 2 +} { + gdb_test_no_output "compile code struct_object.$field = $value" + gdb_test "print struct_object.$field" " = $value" +} + +gdb_test_no_output "compile code struct_object.arrayfield\[2\] = 7" +gdb_test "print struct_object.arrayfield" \ + " = \\{0, 0, 7, 0, 0\\}" + +gdb_test_no_output "compile code struct_object.complexfield = 7 + 5i" +gdb_test "print struct_object.complexfield" " = 7 \\+ 5 \\* I" + +gdb_test_no_output "compile code struct_object.boolfield = 1" +gdb_test "print struct_object.boolfield" " = true" + +gdb_test_no_output "compile code struct_object.vectorfield\[2\] = 7" +gdb_test "print struct_object.vectorfield" \ + " = \\{0, 0, 7, 0\\}" + +gdb_test_no_output "compile code union_object.typedeffield = 7" +gdb_test "print union_object.typedeffield" " = 7" +gdb_test "print union_object.intfield" " = 7" + + +# LOC_UNRESOLVED tests. + +gdb_test "print unresolved" " = 20" +gdb_test "compile code globalvar = unresolved;" +gdb_test "print globalvar" " = 20" "print unresolved value" + +# Test shadowing with global and static variables. + +gdb_test_no_output "compile code globalshadow += 1;" +gdb_test "print globalshadow" " = 101" +gdb_test_no_output "compile code extern int globalshadow; globalshadow += 5;" +gdb_test "print 'compile-cplus.c'::globalshadow" " = 15" +gdb_test "print globalshadow" " = 101" "print globalshadow second time" +gdb_test_no_output "compile code staticshadow += 2;" +gdb_test "print staticshadow" " = 202" +# "extern int staticshadow;" cannot access static variable. + +# Raw code cannot refer to locals. +# As it references global variable we need the #pragma. +# For #pragma we need multiline input. +gdb_test_multiple "compile code -r" "compile code -r multiline 1" { -re "\r\n>$" {} } +gdb_test_multiple "void _gdb_expr(void) {" "compile code -r multiline 2" { -re "\r\n>$" {} } +gdb_test_multiple "#pragma GCC push_user_expression" "compile code -r multiline 3" { -re "\r\n>$" {} } +gdb_test_multiple " globalshadow = 77000;" "compile code -r multiline 4" { -re "\r\n>$" {} } +gdb_test_multiple "#pragma GCC pop_user_expression" "compile code -r multiline 5" { -re "\r\n>$" {} } +gdb_test_multiple "}" "compile code -r multiline 6" { -re "\r\n>$" {} } +gdb_test_no_output "end" "compile code -r multiline 7" +gdb_test "print 'compile-cplus.c'::globalshadow" " = 77000" \ + "check globalshadow with -r" + +# Test GOT vs. resolving jit function pointers. + +gdb_test_no_output "compile -raw -- extern \"C\" void abort(); int func(){return 21;} void _gdb_expr(){int (*funcp)()=func; if (funcp()!=21) abort();}" \ + "pointer to jit function" + +# +# Test the case where the registers structure would not normally have +# any fields. +# + +gdb_breakpoint [gdb_get_line_number "no_args_or_locals breakpoint"] +gdb_continue_to_breakpoint "no_args_or_locals" + +gdb_test_no_output "compile code globalvar = 77;" "set variable to 77" +gdb_test "p globalvar" " = 77" "expect 77" + + +# Test reference to minimal_symbol, not (full) symbol. + +setup_kfail compile/1234 *-*-* +gdb_test_no_output "compile code globalvar = func_nodebug (75);" \ + "call func_nodebug" + +setup_kfail compile/1234 *-*-* +gdb_test "p globalvar" " = -75" "expect -75" + +setup_kfail compile/1234 *-*-* +gdb_test_no_output \ + "compile code int (*funcp) (int) = (int(*)(int))func_nodebug; globalvar = funcp (76);" \ + "call func_nodebug indirectly" +setup_kfail compile/1234 *-*-* +gdb_test "p globalvar" " = -76" "expect -76" + + +# Test compiled module memory protection. + +gdb_test_no_output "set debug compile on" +gdb_test "compile code static const int readonly = 1; *(int *) &readonly = 2;" \ + "The program being debugged was signaled while in a function called from GDB\\.\r\nGDB has restored the context to what it was before the call\\.\r\n.*" +gdb_test_no_output "set debug compile off" + + +# +# Some simple coverage tests. +# + +gdb_test "show debug compile" "Compile debugging is .*" +gdb_test "show compile-args" \ + "Compile command command-line arguments are .*" +gdb_test "compile code -z" "Unknown argument.*" + +gdb_test "set lang rust" \ + "Warning: the current language does not match this frame." +gdb_test "compile code globalvar" "No compiler support for language rust\." +gdb_test_no_output "set lang auto" + +gdb_test_no_output "compile code union union_type newdecl_u" +gdb_test_no_output "compile code struct struct_type newdecl_s" +gdb_test_no_output "compile code inttypedef newdecl_i" + +gdb_test "compile file" \ + "You must provide a filename for this command.*" \ + "Test compile file without a filename" +gdb_test "compile file -r" \ + "You must provide a filename with the raw option set.*" \ + "Test compile file and raw option without a filename" +gdb_test "compile file -z" \ + "Unknown argument.*" \ + "Test compile file with unknown argument" + + +# LOC_CONST tests. + +if { $srcfile3 != "" } { + gdb_test "p constvar" " = 3" + gdb_test "info addr constvar" {Symbol "constvar" is constant\.} + + gdb_test_no_output "compile code globalvar = constvar;" + gdb_test "print globalvar" " = 3" "print constvar value" +} else { + untested "print constvar value" +} diff --git a/gdb/testsuite/lib/compile-support.exp b/gdb/testsuite/lib/compile-support.exp new file mode 100644 index 0000000000..b784c3549b --- /dev/null +++ b/gdb/testsuite/lib/compile-support.exp @@ -0,0 +1,227 @@ +# Copyright 2015-2018 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Generic/oft used support routines for testing GDB's compile feature. + +# Return 1 if we should skip tests of the "compile" feature. +# This must be invoked after the inferior has been started. + +proc skip_compile_feature_tests {} { + global gdb_prompt + + set result 0 + gdb_test_multiple "compile code -- ;" "check for working compile command" { + "Could not load libcc1.*\r\n$gdb_prompt $" { + set result 1 + } + -re "Command not supported on this host\\..*\r\n$gdb_prompt $" { + set result 1 + } + -re "\r\n$gdb_prompt $" { + } + } + return $result +} + +# This namespace provides some convenience functions for running +# "compile code" and "compile print" tests. +# +# Exported functions are defined inline below. +# +# General usage: +# +# Start a new session, noting that the variable "var" will be used for +# "compile code" expressions. This variable /must/ exist in the stopped +# location. +# +# CompileExpression::new "var" +# +# Test the implicit expression "foo;" with result/value 3. +# CompileExpression::test "foo" 3 +# ---> Runs the following tests (name of tests ignored for illustration) +# gdb_test_no_output "compile code var = foo" +# gdb_test "p var" "= 3" +# gdb_test "compile print foo;" "= 3" +# +# Test the explicit expression "a = function (3); var = a;" with the result 21. +# CompileExpression::test "a = function (3); var = a;" 21 -explicit +# ---> Runs the following tests (name of tests ignored for illustration) +# gdb_test_no_output "compile code a = function (3); var = a;" +# gdb_test "p var" "= 21" +# +# Additional option flags may be passed to test to control the behavior +# of the test harness: +# +# Pass -explicit to specify that the test uses an explicit expression, +# one which sets the value of the variable (see above). Only the code test +# will be run. +# +# Pass -value and/or -print to indicate that the value and/or print steps +# will optionally fail. Specify "xfail" or "kfail" to indicate how +# particular step will fail. These may be followed by any accepted DejaGNU +# parameters such as architecture and bug#. [See examples below.] +# +# To specify that the compile (and consequently print and value tests) is +# expected to kfail/xfail, use -kfail or -xfail with any appropriate +# DejaGNU parameters. Both options override -print and -value. +# [-xfail is given precedence over -kfail should both be given.] +# +# -value is used when a "code" test is run, specifying that the "compile +# code" and "print VAR" steps will fail in the prescribed manner. +# [If the print step generates a PASS, the test is considered invalidly +# written. VAR's value should /always/ be invalidated before a test is +# run.] +# +# -print is used to specify that an expression will fail in the prescribed +# manner when "print" test is executed. +# +# Pass "-name NAME" to set an optional test name. If not specified, +# the harness will use test names such as "compile code EXPR" and +# "result of compile code EXPR". +# +# Pass "-noprint" or "-nocode" to suppress print or code tests, respectively, +# This is useful when the expression being tested modifies the object +# being tested, e.g., "a++". +# +# These options must be passed LAST to CompileExpression::test. +# +# Examples: +# +# Both "code" and "print" tests are expected to xfail: +# CompileExpression add_imp "foo" 3 -compile {xfail *-*-*} -print {xfail *-*-*} +# +# The "print $VARIABLE" portion of the "code" test is expected to kfail +# (the actual "compile code" GDB command will succeed), but the "print" +# test should pass: +# CompileExpression add_imp "foo" 3 -value {kfail *-*-* gdb/1234} + +namespace eval ::CompileExpression { + + # The variable name to check testing results. This variable + # must be in scope when tests are run. + variable varName_ {} + + # Start a new expression list. VARNAME is the name of the variable + # that will be printed to check if the result of the test was + # successful. + proc new {varname} { + variable varName_ + + set varName_ $varname + } + + # Test an expression. + # + # See the preamble for a list of valid optional arguments. + # + # Implicit expressions will be sent to GDB in the form + # "$varName = $EXP". "p $varName" will be used to decide the pass + # or fail status of the test. + # + # Explicit expressions will be sent to GDB as-is and tested using only + # "compile code". The expression should set the value of the variable + # $varName, which is then printed to determine whether the test passed + # or failed. + # + # Unlike explicit expressions, implicit expressions are tested with both + # "compile print" and "compile code". + + proc test {exp result args} { + parse_args {{value {"" ""}} {print {"" ""}} {name ""} + {noprint} {nocode} {explicit} {xfail {"" ""}} {kfail {"" ""}}} + + if {[lindex $xfail 0] != ""} { + set l "xfail $xfail" + } elseif {[lindex $kfail 0] != ""} { + set l "kfail $kfail" + } else { + set l "" + set compile {"" ""} + } + if {$l != ""} { + set compile $l + set print $l + set value $l + } + + if {!$nocode} { + do_test_ code $exp $result $explicit $name \ + [list $compile $value $print] + } + if {!$noprint} { + do_test_ print $exp $result $explicit $name \ + [list $compile $value $print] + } + } + + # Run a compile test for CMD ("print" or "code"). + + proc do_test_ {cmd exp result is_explicit tst fail_list} { + variable varName_ + + if {![string match $cmd "code"] + && ![string match $cmd "print"]} { + error "invalid command, $cmd; should be \"print\" or \"compile\"" + } + + # Get expected result of test. Will be "" if test is + # expected to PASS. + lassign $fail_list fail_compile fail_value fail_print + + # Set a test name if one hasn't been provided. + if {$tst == ""} { + set tst "compile $cmd $exp" + } + + if {[string match $cmd "print"]} { + if {!$is_explicit} { + eval setup_failures_ $fail_print + gdb_test "compile print $exp" $result $tst + } + } else { + if {$is_explicit} { + set command "compile code $exp" + } else { + set command "compile code $varName_ = $exp" + } + eval setup_failures_ $fail_compile + gdb_test_no_output $command $tst + eval setup_failures_ $fail_value + gdb_test "p $varName_" "= $result" "result of $tst" + } + } + + # A convenience proc used to set up xfail and kfail tests. + # HOW is either xfail or kfail (case is ignored). ARGS is any + # optional architecture, bug number, or other string to pass to + # respective DejaGNU setup_$how routines. + + proc setup_failures_ {how args} { + switch -nocase $how { + xfail { + eval setup_xfail $args + } + + kfail { + eval setup_kfail $args + } + + default { + # Do nothing. Either the test is expected to PASS + # or we have an unhandled failure mode. + } + } + } +} -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-17 18:26 ` Keith Seitz @ 2018-08-28 17:52 ` Tom Tromey 2018-08-29 22:32 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-28 17:52 UTC (permalink / raw) To: Keith Seitz; +Cc: Tom Tromey, gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> The complete list of changes in this revision: Keith> a) removed "(void)" everywhere Keith> b) removed compile-cplus-support.c and moved functions to Keith> private static members of compile_cplus_instance Keith> c) removed _initialize_XYZ decls Keith> d) moved decl_name to static member of compile_cplus_instance Keith> e) used get instead of release in new_scope Keith> f) KFAIL remaining compile-cplus.exp/compile-cplus-print.exp tests Keith> and fixed a bug uncovered by missing "_no_output" buglet Keith> g) std::string --> const char * to avoid allocation Keith> h) removed type_code_to_string Thank you for updating this. This looks good to me. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-28 17:52 ` Tom Tromey @ 2018-08-29 22:32 ` Keith Seitz 0 siblings, 0 replies; 45+ messages in thread From: Keith Seitz @ 2018-08-29 22:32 UTC (permalink / raw) To: gdb-patches On 08/28/2018 10:51 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: > > Keith> The complete list of changes in this revision: > Keith> a) removed "(void)" everywhere > Keith> b) removed compile-cplus-support.c and moved functions to > Keith> private static members of compile_cplus_instance > Keith> c) removed _initialize_XYZ decls > Keith> d) moved decl_name to static member of compile_cplus_instance > Keith> e) used get instead of release in new_scope > Keith> f) KFAIL remaining compile-cplus.exp/compile-cplus-print.exp tests > Keith> and fixed a bug uncovered by missing "_no_output" buglet > Keith> g) std::string --> const char * to avoid allocation > Keith> h) removed type_code_to_string > > Thank you for updating this. This looks good to me. With that, then, I've rebased this series and pushed it. [I also filed bugs for the KFAILs added in the tests. All kfail tests updated with new bug numbers.] Thank you, Tom! Keith ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2018-08-10 23:32 ` [PATCH 9/9] C++ compile support Keith Seitz 2018-08-11 7:22 ` Eli Zaretskii 2018-08-12 0:17 ` Tom Tromey @ 2021-03-24 1:04 ` Simon Marchi 2021-03-24 14:51 ` Keith Seitz 2021-04-01 18:03 ` Tom Tromey 2 siblings, 2 replies; 45+ messages in thread From: Simon Marchi @ 2021-03-24 1:04 UTC (permalink / raw) To: Keith Seitz, gdb-patches Hi Keith, I am from the past... On 2018-08-10 7:25 p.m., Keith Seitz wrote: > +/* Convert a struct or union type to its gcc representation. If this type > + was defined in another type, NESTED_ACCESS should indicate the > + accessibility of this type. */ > + > +static gcc_type > +compile_cplus_convert_struct_or_union (compile_cplus_instance *instance, > + struct type *type, > + enum gcc_cp_symbol_kind nested_access) > +{ > + const char *filename = nullptr; > + unsigned short line = 0; > + > + /* Get the decl name of this type. */ > + gdb::unique_xmalloc_ptr<char> name = decl_name (TYPE_NAME (type)); > + > + /* Create a new scope for TYPE. */ > + compile_scope scope = instance->new_scope (TYPE_NAME (type), type); > + > + if (scope.nested_type () != GCC_TYPE_NONE) > + { > + /* The type requested was actually defined inside another type, > + such as a nested class definition. Return that type. */ > + return scope.nested_type (); > + } > + > + /* Push all scopes. */ > + instance->enter_scope (scope); > + > + /* First we create the resulting type and enter it into our hash > + table. This lets recursive types work. */ > + > + gcc_decl resuld; > + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) > + { > + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; I don't know if this matters, but the condition above looks reversed, can you confirm? Simon ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2021-03-24 1:04 ` Simon Marchi @ 2021-03-24 14:51 ` Keith Seitz 2021-03-24 15:06 ` Simon Marchi 2021-04-01 18:03 ` Tom Tromey 1 sibling, 1 reply; 45+ messages in thread From: Keith Seitz @ 2021-03-24 14:51 UTC (permalink / raw) To: Simon Marchi, gdb-patches On 3/23/21 6:04 PM, Simon Marchi wrote: > Hi Keith, > > I am from the past... Hahaha... That's okay; I feel like I am living in the past! > On 2018-08-10 7:25 p.m., Keith Seitz wrote: >> + gcc_decl resuld; >> + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) >> + { >> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; > > I don't know if this matters, but the condition above looks reversed, > can you confirm? Wowser. Good catch! While it should *of course* be corrected, the first parameter there is essentially for debugging, so it is not critical that this be propagated everywhere: gcc_expr build_decl (const char *debug_decltype, const char *name, enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, const char *substitution_name, gcc_address address, const char *filename, unsigned int line_number); Let me know if you want me to clean up my boo-boo or whether you've patch-in-hand to push already. Keith ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2021-03-24 14:51 ` Keith Seitz @ 2021-03-24 15:06 ` Simon Marchi 2021-03-24 20:49 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Simon Marchi @ 2021-03-24 15:06 UTC (permalink / raw) To: Keith Seitz, gdb-patches On 2021-03-24 10:51 a.m., Keith Seitz wrote: > On 3/23/21 6:04 PM, Simon Marchi wrote: >> Hi Keith, >> >> I am from the past... > > Hahaha... That's okay; I feel like I am living in the past! > >> On 2018-08-10 7:25 p.m., Keith Seitz wrote: >>> + gcc_decl resuld; >>> + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) >>> + { >>> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; >> >> I don't know if this matters, but the condition above looks reversed, >> can you confirm? > > Wowser. Good catch! > > While it should *of course* be corrected, the first parameter there is > essentially for debugging, so it is not critical that this be propagated > everywhere: Ok, that's what I thought. > > gcc_expr build_decl (const char *debug_decltype, const char *name, > enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, > const char *substitution_name, gcc_address address, > const char *filename, unsigned int line_number); > > Let me know if you want me to clean up my boo-boo or whether you've > patch-in-hand to push already. > > Keith I'd be fine if you pushed a trivial patch. Thanks! Simon ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2021-03-24 15:06 ` Simon Marchi @ 2021-03-24 20:49 ` Keith Seitz 0 siblings, 0 replies; 45+ messages in thread From: Keith Seitz @ 2021-03-24 20:49 UTC (permalink / raw) To: Simon Marchi, gdb-patches On 3/24/21 8:06 AM, Simon Marchi wrote: > > I'd be fine if you pushed a trivial patch. Thanks! I've pushed as an obvious commit. Thank you for discovering this and allowing me to fix it. Keith ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2021-03-24 1:04 ` Simon Marchi 2021-03-24 14:51 ` Keith Seitz @ 2021-04-01 18:03 ` Tom Tromey 2021-04-01 18:07 ` Luis Machado 2021-04-01 19:36 ` Keith Seitz 1 sibling, 2 replies; 45+ messages in thread From: Tom Tromey @ 2021-04-01 18:03 UTC (permalink / raw) To: Simon Marchi via Gdb-patches >> + { >> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; Simon> I don't know if this matters, but the condition above looks reversed, Simon> can you confirm? FWIW, last time I tried, at least one of the c++ compile tests causes a gcc crash, then lots of timeouts. Are these working for anyone? Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2021-04-01 18:03 ` Tom Tromey @ 2021-04-01 18:07 ` Luis Machado 2021-04-01 19:36 ` Keith Seitz 1 sibling, 0 replies; 45+ messages in thread From: Luis Machado @ 2021-04-01 18:07 UTC (permalink / raw) To: Tom Tromey, Simon Marchi via Gdb-patches On 4/1/21 3:03 PM, Tom Tromey wrote: >>> + { >>> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; > > Simon> I don't know if this matters, but the condition above looks reversed, > Simon> can you confirm? > > FWIW, last time I tried, at least one of the c++ compile tests causes a > gcc crash, then lots of timeouts. Are these working for anyone? > > Tom > They "work" with some PASSes, but there are a lot of FAIL's for aarch64-linux/armhf-linux. ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 9/9] C++ compile support 2021-04-01 18:03 ` Tom Tromey 2021-04-01 18:07 ` Luis Machado @ 2021-04-01 19:36 ` Keith Seitz 1 sibling, 0 replies; 45+ messages in thread From: Keith Seitz @ 2021-04-01 19:36 UTC (permalink / raw) To: gdb-patches On 4/1/21 11:03 AM, Tom Tromey wrote: >>> + { >>> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; > > Simon> I don't know if this matters, but the condition above looks reversed, > Simon> can you confirm? > > FWIW, last time I tried, at least one of the c++ compile tests causes a > gcc crash, then lots of timeouts. Are these working for anyone? Sadly there's a lot of bitrot "here." The last time I took a good look at this ($long time ago), there was a bug that was preventing much of this from working, but it was entirely on GDB's side (https://sourceware.org/bugzilla/show_bug.cgi?id=23749 *). Keith * I have not recently assessed if this is still a problem. ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz ` (6 preceding siblings ...) 2018-08-10 23:32 ` [PATCH 9/9] C++ compile support Keith Seitz @ 2018-08-10 23:32 ` Keith Seitz 2018-08-11 15:01 ` Tom Tromey 2018-08-10 23:34 ` [PATCH 8/9] Add new search_symbols_multiple API Keith Seitz 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:32 UTC (permalink / raw) To: gdb-patches This patch converts linespec.c's linespec.label_symbols member from a VEC to a std::vector. gdb/ChangeLog: * linespec.c (struct linespec) <minimal_symbols>: Change type to std::vector. Update all users. (struct collect_info) <minimal_symbols>: Likewise. (find_method, find_function_symbols, find_linespec_symbols): Change `minsyms' parameter to std::vector. Update all callers. --- gdb/ChangeLog | 8 +++++ gdb/linespec.c | 104 +++++++++++++++++++++++---------------------------------- 2 files changed, 49 insertions(+), 63 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b3f5a5d039..f762196cbc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <minimal_symbols>: Change type to + std::vector. Update all users. + (struct collect_info) <minimal_symbols>: Likewise. + (find_method, find_function_symbols, find_linespec_symbols): Change + `minsyms' parameter to std::vector. Update all callers. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <label_symbols>: Change type to std::vector. Update all users. (find_label_symbols_in_block): Change `result' parameter to diff --git a/gdb/linespec.c b/gdb/linespec.c index 4e7f9b08b0..bc20001df9 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -116,7 +116,7 @@ struct linespec /* A list of matching function symbols and minimal symbols. Both lists may be NULL (or empty) if no matching symbols were found. */ std::vector<symbol *> *function_symbols; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> *minimal_symbols; /* A structure of matching label symbols and the corresponding function symbol in which the label was found. Both may be NULL @@ -202,7 +202,7 @@ struct collect_info struct { std::vector<symbol *> *symbols; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> *minimal_symbols; } result; /* Possibly add a symbol to the results. */ @@ -362,7 +362,7 @@ static void find_linespec_symbols (struct linespec_state *self, const char *name, symbol_name_match_type name_match_type, std::vector<symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms); + std::vector<bound_minimal_symbol> *minsyms); static struct line_offset linespec_parse_variable (struct linespec_state *self, @@ -1768,7 +1768,7 @@ linespec_parse_basic (linespec_parser *parser) linespec_token token; std::vector<symbol *> symbols; std::vector<symbol *> *labels; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> minimal_symbols; /* Get the next token. */ token = linespec_lexer_lex_one (parser); @@ -1871,11 +1871,13 @@ linespec_parse_basic (linespec_parser *parser) PARSER_EXPLICIT (parser)->func_name_match_type, &symbols, &minimal_symbols); - if (!symbols.empty () || minimal_symbols != NULL) + if (!symbols.empty () || !minimal_symbols.empty ()) { PARSER_RESULT (parser)->function_symbols = new std::vector<symbol *> (std::move (symbols)); - PARSER_RESULT (parser)->minimal_symbols = minimal_symbols; + PARSER_RESULT (parser)->minimal_symbols + = new std::vector<bound_minimal_symbol> + (std::move (minimal_symbols)); PARSER_EXPLICIT (parser)->function_name = name.release (); } else @@ -2280,20 +2282,16 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) const CORE_ADDR addr = BLOCK_START (SYMBOL_BLOCK_VALUE (sym)); - bound_minimal_symbol_d *elem; - for (int m = 0; - VEC_iterate (bound_minimal_symbol_d, ls->minimal_symbols, - m, elem); - ++m) + for (const auto &elem : *ls->minimal_symbols) { - if (MSYMBOL_TYPE (elem->minsym) == mst_text_gnu_ifunc - || MSYMBOL_TYPE (elem->minsym) == mst_data_gnu_ifunc) + if (MSYMBOL_TYPE (elem.minsym) == mst_text_gnu_ifunc + || MSYMBOL_TYPE (elem.minsym) == mst_data_gnu_ifunc) { - CORE_ADDR msym_addr = BMSYMBOL_VALUE_ADDRESS (*elem); - if (MSYMBOL_TYPE (elem->minsym) == mst_data_gnu_ifunc) + CORE_ADDR msym_addr = BMSYMBOL_VALUE_ADDRESS (elem); + if (MSYMBOL_TYPE (elem.minsym) == mst_data_gnu_ifunc) { struct gdbarch *gdbarch - = get_objfile_arch (elem->objfile); + = get_objfile_arch (elem.objfile); msym_addr = (gdbarch_convert_from_func_ptr_addr (gdbarch, @@ -2324,20 +2322,14 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) if (ls->minimal_symbols != NULL) { /* Sort minimal symbols by program space, too */ - qsort (VEC_address (bound_minimal_symbol_d, ls->minimal_symbols), - VEC_length (bound_minimal_symbol_d, ls->minimal_symbols), - sizeof (bound_minimal_symbol_d), compare_msymbols); + qsort (ls->minimal_symbols->data (), ls->minimal_symbols->size (), + sizeof (bound_minimal_symbol), compare_msymbols); - bound_minimal_symbol_d *elem; - - for (int i = 0; - VEC_iterate (bound_minimal_symbol_d, ls->minimal_symbols, - i, elem); - ++i) + for (const auto &elem : *ls->minimal_symbols) { - program_space *pspace = elem->objfile->pspace; + program_space *pspace = elem.objfile->pspace; set_current_program_space (pspace); - minsym_found (state, elem->objfile, elem->minsym, &sals); + minsym_found (state, elem.objfile, elem.minsym, &sals); } } } @@ -2386,7 +2378,7 @@ convert_explicit_location_to_linespec (struct linespec_state *self, { std::vector<symbol *> symbols; std::vector<symbol *> *labels; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> minimal_symbols; result->explicit_loc.func_name_match_type = fname_match_type; @@ -2416,14 +2408,15 @@ convert_explicit_location_to_linespec (struct linespec_state *self, function_name, fname_match_type, &symbols, &minimal_symbols); - if (symbols.empty () && minimal_symbols == NULL) + if (symbols.empty () && minimal_symbols.empty ()) symbol_not_found_error (function_name, result->explicit_loc.source_filename); result->explicit_loc.function_name = xstrdup (function_name); result->function_symbols = new std::vector<symbol *> (std::move (symbols)); - result->minimal_symbols = minimal_symbols; + result->minimal_symbols + = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); } if (label_name != NULL) @@ -2773,10 +2766,7 @@ linespec_parser_delete (void *arg) delete PARSER_RESULT (parser)->file_symtabs; delete PARSER_RESULT (parser)->function_symbols; - - if (PARSER_RESULT (parser)->minimal_symbols != NULL) - VEC_free (bound_minimal_symbol_d, PARSER_RESULT (parser)->minimal_symbols); - + delete PARSER_RESULT (parser)->minimal_symbols; delete PARSER_RESULT (parser)->labels.label_symbols; delete PARSER_RESULT (parser)->labels.function_symbols; @@ -3036,7 +3026,7 @@ linespec_complete (completion_tracker &tracker, const char *text, const char *func_name = PARSER_EXPLICIT (&parser)->function_name; std::vector<symbol *> function_symbols; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> minimal_symbols; find_linespec_symbols (PARSER_STATE (&parser), PARSER_RESULT (&parser)->file_symtabs, func_name, match_type, @@ -3044,7 +3034,8 @@ linespec_complete (completion_tracker &tracker, const char *text, PARSER_RESULT (&parser)->function_symbols = new std::vector<symbol *> (std::move (function_symbols)); - PARSER_RESULT (&parser)->minimal_symbols = minimal_symbols; + PARSER_RESULT (&parser)->minimal_symbols + = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); complete_label (tracker, &parser, parser.completion_word); } @@ -3444,7 +3435,8 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) std::vector<symbol *> symbols; info.result.symbols = &symbols; - info.result.minimal_symbols = NULL; + std::vector<bound_minimal_symbol> minimal_symbols; + info.result.minimal_symbols = &minimal_symbols; new_argptr = find_imps (arg, &symbol_names); if (symbol_names.empty ()) @@ -3454,8 +3446,7 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) FUNCTIONS_DOMAIN); std::vector<symtab_and_line> values; - if (!symbols.empty () - || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) + if (!symbols.empty () || !minimal_symbols.empty ()) { char *saved_arg; @@ -3465,7 +3456,8 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) ls->explicit_loc.function_name = xstrdup (saved_arg); ls->function_symbols = new std::vector<symbol *> (std::move (symbols)); - ls->minimal_symbols = info.result.minimal_symbols; + ls->minimal_symbols + = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); values = convert_linespec_to_sals (self, ls); if (self->canonical) @@ -3705,7 +3697,7 @@ static void find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, VEC (symbolp) *sym_classes, std::vector<symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms) + std::vector<bound_minimal_symbol> *minsyms) { struct symbol *sym; int ix; @@ -3724,7 +3716,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, info.state = self; info.file_symtabs = file_symtabs; info.result.symbols = symbols; - info.result.minimal_symbols = NULL; + info.result.minimal_symbols = minsyms; /* Iterate over all the types, looking for the names of existing methods matching METHOD_NAME. If we cannot find a direct method in a @@ -3774,12 +3766,8 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, } } - if (!symbols->empty () - || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) - { - *minsyms = info.result.minimal_symbols; - return; - } + if (!symbols->empty () || !minsyms->empty ()) + return; /* Throw an NOT_FOUND_ERROR. This will be caught by the caller and other attempts to locate the symbol will be made. */ @@ -3910,14 +3898,14 @@ find_function_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, std::vector<symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms) + std::vector<bound_minimal_symbol> *minsyms) { struct collect_info info; std::vector<const char *> symbol_names; info.state = state; info.result.symbols = symbols; - info.result.minimal_symbols = NULL; + info.result.minimal_symbols = minsyms; info.file_symtabs = file_symtabs; /* Try NAME as an Objective-C selector. */ @@ -3928,14 +3916,6 @@ find_function_symbols (struct linespec_state *state, else add_matching_symbols_to_info (name, name_match_type, FUNCTIONS_DOMAIN, &info, state->search_pspace); - - if (VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) - { - VEC_free (bound_minimal_symbol_d, info.result.minimal_symbols); - *minsyms = NULL; - } - else - *minsyms = info.result.minimal_symbols; } /* Find all symbols named NAME in FILE_SYMTABS, returning debug symbols @@ -3947,7 +3927,7 @@ find_linespec_symbols (struct linespec_state *state, const char *lookup_name, symbol_name_match_type name_match_type, std::vector <symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms) + std::vector<bound_minimal_symbol> *minsyms) { std::string canon = cp_canonicalize_string_no_typedefs (lookup_name); if (!canon.empty ()) @@ -3968,8 +3948,7 @@ find_linespec_symbols (struct linespec_state *state, /* If we were unable to locate a symbol of the same name, try dividing the name into class and method names and searching the class and its baseclasses. */ - if (symbols->empty () - && VEC_empty (bound_minimal_symbol_d, *minsyms)) + if (symbols->empty () && minsyms->empty ()) { std::string klass, method; const char *last, *p, *scope_op; @@ -4444,8 +4423,7 @@ search_minsyms_for_name (struct collect_info *info, if (classify_mtype (MSYMBOL_TYPE (item.minsym)) != classification) break; - VEC_safe_push (bound_minimal_symbol_d, - info->result.minimal_symbols, &item); + info->result.minimal_symbols->push_back (item); } } } -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures 2018-08-10 23:32 ` [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures Keith Seitz @ 2018-08-11 15:01 ` Tom Tromey 2018-08-17 18:00 ` Keith Seitz 0 siblings, 1 reply; 45+ messages in thread From: Tom Tromey @ 2018-08-11 15:01 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch converts linespec.c's linespec.label_symbols member from a Keith> VEC to a std::vector. Keith> gdb/ChangeLog: Keith> * linespec.c (struct linespec) <minimal_symbols>: Change type to Keith> std::vector. Update all users. Keith> (struct collect_info) <minimal_symbols>: Likewise. Keith> (find_method, find_function_symbols, find_linespec_symbols): Change Keith> `minsyms' parameter to std::vector. Update all callers. Thank you. Keith> + qsort (ls->minimal_symbols->data (), ls->minimal_symbols->size (), Keith> + sizeof (bound_minimal_symbol), compare_msymbols); I think this should be changed to use std::sort. If I'm reading correctly, this is the only caller of compare_msymbols, so this transform shouldn't be too hard to do. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures 2018-08-11 15:01 ` Tom Tromey @ 2018-08-17 18:00 ` Keith Seitz 2018-08-28 17:44 ` Tom Tromey 0 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-17 18:00 UTC (permalink / raw) To: Tom Tromey; +Cc: gdb-patches On 08/11/2018 08:00 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: > > Keith> This patch converts linespec.c's linespec.label_symbols member from a > Keith> VEC to a std::vector. > > Keith> gdb/ChangeLog: > > Keith> * linespec.c (struct linespec) <minimal_symbols>: Change type to > Keith> std::vector. Update all users. > Keith> (struct collect_info) <minimal_symbols>: Likewise. > Keith> (find_method, find_function_symbols, find_linespec_symbols): Change > Keith> `minsyms' parameter to std::vector. Update all callers. > > Thank you. > > Keith> + qsort (ls->minimal_symbols->data (), ls->minimal_symbols->size (), > Keith> + sizeof (bound_minimal_symbol), compare_msymbols); > > I think this should be changed to use std::sort. > If I'm reading correctly, this is the only caller of compare_msymbols, > so this transform shouldn't be too hard to do. Done. New patch below. [This is the only change in this revision.] Keith Subject: [PATCH] Change `minimal_symbols' to std::vector in linespec.c structures This patch converts linespec.c's linespec.label_symbols member from a VEC to a std::vector. gdb/ChangeLog: * linespec.c (struct linespec) <minimal_symbols>: Change type to std::vector. Update all users. (convert_linespec_to_sals): Use std::sort to sort minimal symbols. (struct collect_info) <minimal_symbols>: Likewise. (compare_msymbols): Return bool. Change parameters to const bound_minimal_symbol references. (find_method, find_function_symbols, find_linespec_symbols): Change `minsyms' parameter to std::vector. Update all callers. --- gdb/ChangeLog | 11 +++++ gdb/linespec.c | 134 +++++++++++++++++++++++---------------------------------- 2 files changed, 65 insertions(+), 80 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 38c588e2c0..a94e1cdd68 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,16 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <minimal_symbols>: Change type to + std::vector. Update all users. + (convert_linespec_to_sals): Use std::sort to sort minimal symbols. + (struct collect_info) <minimal_symbols>: Likewise. + (compare_msymbols): Return bool. Change parameters to const + bound_minimal_symbol references. + (find_method, find_function_symbols, find_linespec_symbols): Change + `minsyms' parameter to std::vector. Update all callers. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <label_symbols>: Change type to std::vector. Update all users. (find_label_symbols_in_block): Change `result' parameter to diff --git a/gdb/linespec.c b/gdb/linespec.c index 9c156f910d..e7e19cab67 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -116,7 +116,7 @@ struct linespec /* A list of matching function symbols and minimal symbols. Both lists may be NULL (or empty) if no matching symbols were found. */ std::vector<symbol *> *function_symbols; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> *minimal_symbols; /* A structure of matching label symbols and the corresponding function symbol in which the label was found. Both may be NULL @@ -202,7 +202,7 @@ struct collect_info struct { std::vector<symbol *> *symbols; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> *minimal_symbols; } result; /* Possibly add a symbol to the results. */ @@ -362,7 +362,7 @@ static void find_linespec_symbols (struct linespec_state *self, const char *name, symbol_name_match_type name_match_type, std::vector<symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms); + std::vector<bound_minimal_symbol> *minsyms); static struct line_offset linespec_parse_variable (struct linespec_state *self, @@ -404,7 +404,8 @@ static int compare_symbols (const void *a, const void *b); static bool std_compare_symbols (const struct symbol *a, const struct symbol *b); -static int compare_msymbols (const void *a, const void *b); +static bool compare_msymbols (const bound_minimal_symbol &a, + const bound_minimal_symbol &b); /* Permitted quote characters for the parser. This is different from the completer's quote characters to allow backward compatibility with the @@ -1770,7 +1771,7 @@ linespec_parse_basic (linespec_parser *parser) linespec_token token; std::vector<symbol *> symbols; std::vector<symbol *> *labels; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> minimal_symbols; /* Get the next token. */ token = linespec_lexer_lex_one (parser); @@ -1873,11 +1874,13 @@ linespec_parse_basic (linespec_parser *parser) PARSER_EXPLICIT (parser)->func_name_match_type, &symbols, &minimal_symbols); - if (!symbols.empty () || minimal_symbols != NULL) + if (!symbols.empty () || !minimal_symbols.empty ()) { PARSER_RESULT (parser)->function_symbols = new std::vector<symbol *> (std::move (symbols)); - PARSER_RESULT (parser)->minimal_symbols = minimal_symbols; + PARSER_RESULT (parser)->minimal_symbols + = new std::vector<bound_minimal_symbol> + (std::move (minimal_symbols)); PARSER_EXPLICIT (parser)->function_name = name.release (); } else @@ -2283,20 +2286,16 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) const CORE_ADDR addr = BLOCK_START (SYMBOL_BLOCK_VALUE (sym)); - bound_minimal_symbol_d *elem; - for (int m = 0; - VEC_iterate (bound_minimal_symbol_d, ls->minimal_symbols, - m, elem); - ++m) + for (const auto &elem : *ls->minimal_symbols) { - if (MSYMBOL_TYPE (elem->minsym) == mst_text_gnu_ifunc - || MSYMBOL_TYPE (elem->minsym) == mst_data_gnu_ifunc) + if (MSYMBOL_TYPE (elem.minsym) == mst_text_gnu_ifunc + || MSYMBOL_TYPE (elem.minsym) == mst_data_gnu_ifunc) { - CORE_ADDR msym_addr = BMSYMBOL_VALUE_ADDRESS (*elem); - if (MSYMBOL_TYPE (elem->minsym) == mst_data_gnu_ifunc) + CORE_ADDR msym_addr = BMSYMBOL_VALUE_ADDRESS (elem); + if (MSYMBOL_TYPE (elem.minsym) == mst_data_gnu_ifunc) { struct gdbarch *gdbarch - = get_objfile_arch (elem->objfile); + = get_objfile_arch (elem.objfile); msym_addr = (gdbarch_convert_from_func_ptr_addr (gdbarch, @@ -2327,20 +2326,15 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) if (ls->minimal_symbols != NULL) { /* Sort minimal symbols by program space, too */ - qsort (VEC_address (bound_minimal_symbol_d, ls->minimal_symbols), - VEC_length (bound_minimal_symbol_d, ls->minimal_symbols), - sizeof (bound_minimal_symbol_d), compare_msymbols); + std::sort (ls->minimal_symbols->begin (), + ls->minimal_symbols->end (), + compare_msymbols); - bound_minimal_symbol_d *elem; - - for (int i = 0; - VEC_iterate (bound_minimal_symbol_d, ls->minimal_symbols, - i, elem); - ++i) + for (const auto &elem : *ls->minimal_symbols) { - program_space *pspace = elem->objfile->pspace; + program_space *pspace = elem.objfile->pspace; set_current_program_space (pspace); - minsym_found (state, elem->objfile, elem->minsym, &sals); + minsym_found (state, elem.objfile, elem.minsym, &sals); } } } @@ -2389,7 +2383,7 @@ convert_explicit_location_to_linespec (struct linespec_state *self, { std::vector<symbol *> symbols; std::vector<symbol *> *labels; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> minimal_symbols; result->explicit_loc.func_name_match_type = fname_match_type; @@ -2420,14 +2414,15 @@ convert_explicit_location_to_linespec (struct linespec_state *self, function_name, fname_match_type, &symbols, &minimal_symbols); - if (symbols.empty () && minimal_symbols == NULL) + if (symbols.empty () && minimal_symbols.empty ()) symbol_not_found_error (function_name, result->explicit_loc.source_filename); result->explicit_loc.function_name = xstrdup (function_name); result->function_symbols = new std::vector<symbol *> (std::move (symbols)); - result->minimal_symbols = minimal_symbols; + result->minimal_symbols + = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); } if (label_name != NULL) @@ -2778,10 +2773,7 @@ linespec_parser_delete (void *arg) delete PARSER_RESULT (parser)->file_symtabs; delete PARSER_RESULT (parser)->function_symbols; - - if (PARSER_RESULT (parser)->minimal_symbols != NULL) - VEC_free (bound_minimal_symbol_d, PARSER_RESULT (parser)->minimal_symbols); - + delete PARSER_RESULT (parser)->minimal_symbols; delete PARSER_RESULT (parser)->labels.label_symbols; delete PARSER_RESULT (parser)->labels.function_symbols; @@ -3041,7 +3033,7 @@ linespec_complete (completion_tracker &tracker, const char *text, const char *func_name = PARSER_EXPLICIT (&parser)->function_name; std::vector<symbol *> function_symbols; - VEC (bound_minimal_symbol_d) *minimal_symbols; + std::vector<bound_minimal_symbol> minimal_symbols; find_linespec_symbols (PARSER_STATE (&parser), PARSER_RESULT (&parser)->file_symtabs, func_name, match_type, @@ -3049,7 +3041,8 @@ linespec_complete (completion_tracker &tracker, const char *text, PARSER_RESULT (&parser)->function_symbols = new std::vector<symbol *> (std::move (function_symbols)); - PARSER_RESULT (&parser)->minimal_symbols = minimal_symbols; + PARSER_RESULT (&parser)->minimal_symbols + = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); complete_label (tracker, &parser, parser.completion_word); } @@ -3449,7 +3442,8 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) std::vector<symbol *> symbols; info.result.symbols = &symbols; - info.result.minimal_symbols = NULL; + std::vector<bound_minimal_symbol> minimal_symbols; + info.result.minimal_symbols = &minimal_symbols; new_argptr = find_imps (arg, &symbol_names); if (symbol_names.empty ()) @@ -3459,8 +3453,7 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) FUNCTIONS_DOMAIN); std::vector<symtab_and_line> values; - if (!symbols.empty () - || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) + if (!symbols.empty () || !minimal_symbols.empty ()) { char *saved_arg; @@ -3470,7 +3463,8 @@ decode_objc (struct linespec_state *self, linespec_p ls, const char *arg) ls->explicit_loc.function_name = xstrdup (saved_arg); ls->function_symbols = new std::vector<symbol *> (std::move (symbols)); - ls->minimal_symbols = info.result.minimal_symbols; + ls->minimal_symbols + = new std::vector<bound_minimal_symbol> (std::move (minimal_symbols)); values = convert_linespec_to_sals (self, ls); if (self->canonical) @@ -3662,32 +3656,26 @@ compare_symbols (const void *a, const void *b) /* Like compare_symbols but for minimal symbols. */ -static int -compare_msymbols (const void *a, const void *b) +static bool +compare_msymbols (const bound_minimal_symbol &a, const bound_minimal_symbol &b) { - const struct bound_minimal_symbol *sa - = (const struct bound_minimal_symbol *) a; - const struct bound_minimal_symbol *sb - = (const struct bound_minimal_symbol *) b; uintptr_t uia, uib; - uia = (uintptr_t) sa->objfile->pspace; - uib = (uintptr_t) sa->objfile->pspace; + uia = (uintptr_t) a.objfile->pspace; + uib = (uintptr_t) a.objfile->pspace; if (uia < uib) - return -1; + return true; if (uia > uib) - return 1; + return false; - uia = (uintptr_t) sa->minsym; - uib = (uintptr_t) sb->minsym; + uia = (uintptr_t) a.minsym; + uib = (uintptr_t) b.minsym; if (uia < uib) - return -1; - if (uia > uib) - return 1; + return true; - return 0; + return false; } /* Look for all the matching instances of each symbol in NAMES. Only @@ -3736,7 +3724,7 @@ static void find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, const char *class_name, const char *method_name, VEC (symbolp) *sym_classes, std::vector<symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms) + std::vector<bound_minimal_symbol> *minsyms) { struct symbol *sym; int ix; @@ -3755,7 +3743,7 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, info.state = self; info.file_symtabs = file_symtabs; info.result.symbols = symbols; - info.result.minimal_symbols = NULL; + info.result.minimal_symbols = minsyms; /* Iterate over all the types, looking for the names of existing methods matching METHOD_NAME. If we cannot find a direct method in a @@ -3805,12 +3793,8 @@ find_method (struct linespec_state *self, std::vector<symtab *> *file_symtabs, } } - if (!symbols->empty () - || !VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) - { - *minsyms = info.result.minimal_symbols; - return; - } + if (!symbols->empty () || !minsyms->empty ()) + return; /* Throw an NOT_FOUND_ERROR. This will be caught by the caller and other attempts to locate the symbol will be made. */ @@ -3938,14 +3922,14 @@ find_function_symbols (struct linespec_state *state, std::vector<symtab *> *file_symtabs, const char *name, symbol_name_match_type name_match_type, std::vector<symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms) + std::vector<bound_minimal_symbol> *minsyms) { struct collect_info info; std::vector<const char *> symbol_names; info.state = state; info.result.symbols = symbols; - info.result.minimal_symbols = NULL; + info.result.minimal_symbols = minsyms; info.file_symtabs = file_symtabs; /* Try NAME as an Objective-C selector. */ @@ -3956,14 +3940,6 @@ find_function_symbols (struct linespec_state *state, else add_matching_symbols_to_info (name, name_match_type, FUNCTIONS_DOMAIN, &info, state->search_pspace); - - if (VEC_empty (bound_minimal_symbol_d, info.result.minimal_symbols)) - { - VEC_free (bound_minimal_symbol_d, info.result.minimal_symbols); - *minsyms = NULL; - } - else - *minsyms = info.result.minimal_symbols; } /* Find all symbols named NAME in FILE_SYMTABS, returning debug symbols @@ -3975,7 +3951,7 @@ find_linespec_symbols (struct linespec_state *state, const char *lookup_name, symbol_name_match_type name_match_type, std::vector <symbol *> *symbols, - VEC (bound_minimal_symbol_d) **minsyms) + std::vector<bound_minimal_symbol> *minsyms) { std::string canon = cp_canonicalize_string_no_typedefs (lookup_name); if (!canon.empty ()) @@ -3996,8 +3972,7 @@ find_linespec_symbols (struct linespec_state *state, /* If we were unable to locate a symbol of the same name, try dividing the name into class and method names and searching the class and its baseclasses. */ - if (symbols->empty () - && VEC_empty (bound_minimal_symbol_d, *minsyms)) + if (symbols->empty () && minsyms->empty ()) { std::string klass, method; const char *last, *p, *scope_op; @@ -4472,8 +4447,7 @@ search_minsyms_for_name (struct collect_info *info, if (classify_mtype (MSYMBOL_TYPE (item.minsym)) != classification) break; - VEC_safe_push (bound_minimal_symbol_d, - info->result.minimal_symbols, &item); + info->result.minimal_symbols->push_back (item); } } } -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures 2018-08-17 18:00 ` Keith Seitz @ 2018-08-28 17:44 ` Tom Tromey 0 siblings, 0 replies; 45+ messages in thread From: Tom Tromey @ 2018-08-28 17:44 UTC (permalink / raw) To: Keith Seitz; +Cc: Tom Tromey, gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: >> I think this should be changed to use std::sort. >> If I'm reading correctly, this is the only caller of compare_msymbols, >> so this transform shouldn't be too hard to do. Keith> Done. New patch below. [This is the only change in this revision.] Thanks, this is ok. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH 8/9] Add new search_symbols_multiple API 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz ` (7 preceding siblings ...) 2018-08-10 23:32 ` [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures Keith Seitz @ 2018-08-10 23:34 ` Keith Seitz 2018-08-11 20:49 ` Tom Tromey 8 siblings, 1 reply; 45+ messages in thread From: Keith Seitz @ 2018-08-10 23:34 UTC (permalink / raw) To: gdb-patches This patch adds a new symbol searching API based on linespec.c's parser implementation. This allows users to find "all* matching symbols instead of the first found match (a la lookup_symbol). gdb/ChangeLog: * linespec.c (collect_info::add_symbol): Make virtual. (struct symbol_searcher_collect_info): New struct. (symbol_searcher::find_all_symbols): New method. * symtab.h (class symbol_searcher): New class. --- gdb/ChangeLog | 7 +++++++ gdb/linespec.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++- gdb/symtab.h | 43 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 96 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6fc1ce5262..e12c54983c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (collect_info::add_symbol): Make virtual. + (struct symbol_searcher_collect_info): New struct. + (symbol_searcher::find_all_symbols): New method. + * symtab.h (class symbol_searcher): New class. + +YYYY-MM-DD Keith Seitz <keiths@redhat.com> + * linespec.c (struct linespec) <function_symbols, label_symbols>: Change to vector of block_symbol. Update all users. (struct collect_info) <symbols>: Likewise. diff --git a/gdb/linespec.c b/gdb/linespec.c index ef4556d8ea..73825f2cc7 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -199,7 +199,7 @@ struct collect_info } result; /* Possibly add a symbol to the results. */ - bool add_symbol (block_symbol *bsym); + virtual bool add_symbol (block_symbol *bsym); }; bool @@ -214,6 +214,21 @@ collect_info::add_symbol (block_symbol *bsym) return true; } +/* Custom collect_info for symbol_searcher. */ + +struct symbol_searcher_collect_info + : collect_info +{ + bool add_symbol (block_symbol *bsym) override + { + /* Add everything. */ + this->result.symbols->push_back (*bsym); + + /* Continue iterating. */ + return true; + } +}; + /* Token types */ enum ls_token_type @@ -3885,6 +3900,36 @@ symtabs_from_filename (const char *filename, return result; } +/* See symtab.h. */ + +void +symbol_searcher::find_all_symbols (const std::string &name, + const struct language_defn *language, + enum search_domain search_domain, + std::vector<symtab *> *search_symtabs, + struct program_space *search_pspace) +{ + symbol_searcher_collect_info info; + struct linespec_state state; + + memset (&state, 0, sizeof (state)); + state.language = language; + info.state = &state; + + info.result.symbols = &m_symbols; + info.result.minimal_symbols = &m_minimal_symbols; + std::vector<symtab *> all_symtabs; + if (search_symtabs == nullptr) + { + all_symtabs.push_back (nullptr); + search_symtabs = &all_symtabs; + } + info.file_symtabs = search_symtabs; + + add_matching_symbols_to_info (name.c_str (), symbol_name_match_type::WILD, + search_domain, &info, search_pspace); +} + /* Look up a function symbol named NAME in symtabs FILE_SYMTABS. Matching debug symbols are returned in SYMBOLS. Matching minimal symbols are returned in MINSYMS. */ diff --git a/gdb/symtab.h b/gdb/symtab.h index da498cdb95..fe0962c7eb 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -2134,4 +2134,47 @@ void completion_list_add_name (completion_tracker &tracker, const lookup_name_info &lookup_name, const char *text, const char *word); +/* A simple symbol searching class. */ + +class symbol_searcher +{ +public: + /* Returns the symbols found for the search. */ + const std::vector<block_symbol> & + matching_symbols () const + { + return m_symbols; + } + + /* Returns the minimal symbols found for the search. */ + const std::vector<bound_minimal_symbol> & + matching_msymbols () const + { + return m_minimal_symbols; + } + + /* Search for all symbols named NAME in LANGUAGE with DOMAIN, restricting + search to FILE_SYMTABS and SEARCH_PSPACE, both of which may be NULL + to search all symtabs and program spaces. */ + void find_all_symbols (const std::string &name, + const struct language_defn *language, + enum search_domain search_domain, + std::vector<symtab *> *search_symtabs, + struct program_space *search_pspace); + + /* Reset this object to perform another search. */ + void reset () + { + m_symbols.clear (); + m_minimal_symbols.clear (); + } + +private: + /* Matching debug symbols. */ + std::vector<block_symbol> m_symbols; + + /* Matching non-debug symbols. */ + std::vector<bound_minimal_symbol> m_minimal_symbols; +}; + #endif /* !defined(SYMTAB_H) */ -- 2.13.6 ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 8/9] Add new search_symbols_multiple API 2018-08-10 23:34 ` [PATCH 8/9] Add new search_symbols_multiple API Keith Seitz @ 2018-08-11 20:49 ` Tom Tromey 0 siblings, 0 replies; 45+ messages in thread From: Tom Tromey @ 2018-08-11 20:49 UTC (permalink / raw) To: Keith Seitz; +Cc: gdb-patches >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes: Keith> This patch adds a new symbol searching API based on linespec.c's parser Keith> implementation. This allows users to find "all* matching symbols instead Keith> of the first found match (a la lookup_symbol). Keith> gdb/ChangeLog: Keith> * linespec.c (collect_info::add_symbol): Make virtual. Keith> (struct symbol_searcher_collect_info): New struct. Keith> (symbol_searcher::find_all_symbols): New method. Keith> * symtab.h (class symbol_searcher): New class. This is ok. Thanks. Tom ^ permalink raw reply [flat|nested] 45+ messages in thread
end of thread, other threads:[~2021-04-01 19:36 UTC | newest] Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz 2018-08-10 23:25 ` [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures Keith Seitz 2018-08-11 14:50 ` Tom Tromey 2018-08-10 23:25 ` [PATCH 1/9] Change `file_symtabs' to std::vector Keith Seitz 2018-08-11 14:47 ` Tom Tromey 2018-08-17 17:56 ` Keith Seitz 2018-08-28 17:30 ` Tom Tromey 2018-08-10 23:25 ` [PATCH 2/9] Change `function_symbols' " Keith Seitz 2018-08-11 14:49 ` Tom Tromey 2018-08-17 17:59 ` Keith Seitz 2018-08-28 17:43 ` Tom Tromey 2018-08-10 23:31 ` [PATCH 7/9] Use block_symbol_d in linespec APIs Keith Seitz 2018-08-11 15:05 ` Tom Tromey 2018-08-17 18:04 ` Keith Seitz 2018-08-10 23:31 ` [PATCH 6/9] Remove VEC definitions from linespec.c Keith Seitz 2018-08-11 15:03 ` Tom Tromey 2018-08-10 23:32 ` [PATCH 5/9] Change decode_compound_collector to use std::vector Keith Seitz 2018-08-11 15:02 ` Tom Tromey 2018-08-17 18:04 ` Keith Seitz 2018-08-20 1:20 ` Simon Marchi 2018-08-20 13:28 ` Tom Tromey 2018-08-20 14:03 ` Simon Marchi 2018-08-28 17:46 ` Tom Tromey 2018-08-10 23:32 ` [PATCH 9/9] C++ compile support Keith Seitz 2018-08-11 7:22 ` Eli Zaretskii 2018-08-17 17:51 ` Keith Seitz 2018-08-17 18:57 ` Eli Zaretskii 2018-08-20 17:02 ` Keith Seitz 2018-08-12 0:17 ` Tom Tromey 2018-08-17 18:26 ` Keith Seitz 2018-08-28 17:52 ` Tom Tromey 2018-08-29 22:32 ` Keith Seitz 2021-03-24 1:04 ` Simon Marchi 2021-03-24 14:51 ` Keith Seitz 2021-03-24 15:06 ` Simon Marchi 2021-03-24 20:49 ` Keith Seitz 2021-04-01 18:03 ` Tom Tromey 2021-04-01 18:07 ` Luis Machado 2021-04-01 19:36 ` Keith Seitz 2018-08-10 23:32 ` [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures Keith Seitz 2018-08-11 15:01 ` Tom Tromey 2018-08-17 18:00 ` Keith Seitz 2018-08-28 17:44 ` Tom Tromey 2018-08-10 23:34 ` [PATCH 8/9] Add new search_symbols_multiple API Keith Seitz 2018-08-11 20:49 ` Tom Tromey
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).