Re: Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Friday, June 29 2018, Joel Brobecker wrote:

>> That must be me, so I will take a look now. I think it's because
>> I didn't build with --enable-targets=all.
>
> Attached is the patch I just pushed to master.
>
> gdb/ChangeLog:
>
>         * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
>         parameter in call to amd64_target_description.
>         * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
>         * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
>         (amd64fbsd_init_abi): Likewise.
>         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
>         * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
>         * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
>         * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
>
> The change to amd64-fbsd-nat.c was done "blind" (no access to system),
> but is reasonably straightforward. The changes to the -tdep.c files
> were verify by rebuilding GDB on x86_64-linux when configured with
> --enable-targets=all.

Hey Joel,

I'm still seeing a breakage here on x86-64 Fedora GNU/Linux, when
building gdbserver:

  ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c: In function ‘const target_desc* amd64_linux_read_description(uint64_t, bool)’:
  ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:121:67: error: too few arguments to function ‘target_desc* amd64_create_target_description(uint64_t, bool, bool, bool)’
         *tdesc = amd64_create_target_description (xcr0, is_x32, true);
                                                                     ^
  In file included from ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:26:0:
  ../../../binutils-gdb/gdb/gdbserver/../arch/amd64.h:21:14: note: declared here
   target_desc *amd64_create_target_description (uint64_t xcr0, bool is_x32,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Does the patch below make sense?  It fixes the breakage for me.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 2fd2d90a49..743d465d81 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2018-06-29  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	* linux-x86-tdesc.c (amd64_linux_read_description): Add missing
+	parameter in call to 'amd64_create_target_description'.
+
 2018-06-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* x86-tdesc.h: Remove executable permission flag.
diff --git a/gdb/gdbserver/linux-x86-tdesc.c b/gdb/gdbserver/linux-x86-tdesc.c
index 358659b295..7a45953dc9 100644
--- a/gdb/gdbserver/linux-x86-tdesc.c
+++ b/gdb/gdbserver/linux-x86-tdesc.c
@@ -118,7 +118,7 @@ amd64_linux_read_description (uint64_t xcr0, bool is_x32)
 
   if (*tdesc == NULL)
     {
-      *tdesc = amd64_create_target_description (xcr0, is_x32, true);
+      *tdesc = amd64_create_target_description (xcr0, is_x32, true, false);
 
       init_target_desc (*tdesc, amd64_expedite_regs);
     }