From: Tom Tromey <tom@tromey.com>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
Simon Marchi <simark@simark.ca>, Tom Tromey <tom@tromey.com>,
Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA 1/2] Make line tables independent of progspace
Date: Thu, 26 Apr 2018 21:30:00 -0000 [thread overview]
Message-ID: <87vacd64h8.fsf@tromey.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1803291900570.2163@tp.orcam.me.uk> (Maciej W. Rozycki's message of "Thu, 29 Mar 2018 19:20:03 +0100")
>>>>> "Maciej" == Maciej W Rozycki <macro@mips.com> writes:
>> Since adjust_dwarf2_line used to be passed the relocated address, Tom included a
>> "hack" where he relocates the address, passes it through gdbarch_adjust_dwarf2_line,
>> and unrelocates it:
[...]
Maciej> Yeah, I guess it's all right, the difference will ever be either 1 or 0.
Maciej> I would pass it through MIPS16 and/or microMIPS regression testing to be
Maciej> sure. We have the Good Friday public holiday tomorrow here in the UK and
Maciej> then Easter Monday, so I won't be able to schedule a test run until
Maciej> sometime next week though.
Did you do this?
Either way, my understanding of this thread was that I needn't change
anything about adjust_dwarf2_line yet, and that I can go forward with
the line table patches. So, I am going to send a new version.
If that's in error please let me know.
Tom
next prev parent reply other threads:[~2018-04-26 21:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 17:18 [RFA 0/2] " Tom Tromey
2018-03-21 17:18 ` [RFA 2/2] Constify the line table Tom Tromey
2018-03-21 17:18 ` [RFA 1/2] Make line tables independent of progspace Tom Tromey
2018-03-24 3:40 ` Simon Marchi
2018-03-27 4:16 ` Tom Tromey
2018-03-27 4:53 ` Tom Tromey
2018-03-27 20:22 ` Simon Marchi
2018-03-28 4:53 ` Tom Tromey
2018-03-28 12:30 ` Simon Marchi
2018-03-28 3:34 ` Simon Marchi
2018-03-28 5:02 ` Tom Tromey
2018-03-28 12:32 ` Simon Marchi
2018-03-28 19:33 ` Maciej W. Rozycki
2018-03-29 15:04 ` Simon Marchi
2018-03-29 21:07 ` Maciej W. Rozycki
2018-04-26 21:30 ` Tom Tromey [this message]
2018-05-03 23:17 ` Maciej W. Rozycki
2018-05-14 23:54 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vacd64h8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@mips.com \
--cc=qiyaoltc@gmail.com \
--cc=simark@simark.ca \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).