From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11381 invoked by alias); 26 Apr 2018 21:30:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11358 invoked by uid 89); 26 Apr 2018 21:30:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*ca, Hx-languages-length:940, sk:adjust_, holiday X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Apr 2018 21:29:58 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 35284607D for ; Thu, 26 Apr 2018 16:29:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BoSjfqcWx5CKDBoSjfOHzB; Thu, 26 Apr 2018 16:29:57 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:59452 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fBoSi-002O12-RP; Thu, 26 Apr 2018 16:29:56 -0500 From: Tom Tromey To: "Maciej W. Rozycki" Cc: Simon Marchi , Simon Marchi , Tom Tromey , Yao Qi , Subject: Re: [RFA 1/2] Make line tables independent of progspace References: <20180321171809.13115-1-tom@tromey.com> <20180321171809.13115-2-tom@tromey.com> <87zi2uw3uc.fsf@tromey.com> <87vadiw24a.fsf@tromey.com> <4ca333ee-44da-d086-e3c2-cd65b46a46c1@ericsson.com> Date: Thu, 26 Apr 2018 21:30:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Thu, 29 Mar 2018 19:20:03 +0100") Message-ID: <87vacd64h8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fBoSi-002O12-RP X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:59452 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00545.txt.bz2 >>>>> "Maciej" == Maciej W Rozycki writes: >> Since adjust_dwarf2_line used to be passed the relocated address, Tom included a >> "hack" where he relocates the address, passes it through gdbarch_adjust_dwarf2_line, >> and unrelocates it: [...] Maciej> Yeah, I guess it's all right, the difference will ever be either 1 or 0. Maciej> I would pass it through MIPS16 and/or microMIPS regression testing to be Maciej> sure. We have the Good Friday public holiday tomorrow here in the UK and Maciej> then Easter Monday, so I won't be able to schedule a test run until Maciej> sometime next week though. Did you do this? Either way, my understanding of this thread was that I needn't change anything about adjust_dwarf2_line yet, and that I can go forward with the line table patches. So, I am going to send a new version. If that's in error please let me know. Tom