From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] Remove cleanups from gdb_readline_wrapper
Date: Sun, 25 Mar 2018 16:19:00 -0000 [thread overview]
Message-ID: <87vadkb00x.fsf@tromey.com> (raw)
In-Reply-To: <afb5d004-17dc-e0d6-d96c-607c165116bc@redhat.com> (Pedro Alves's message of "Sat, 24 Mar 2018 11:19:06 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I think we can move these to the ctor too, and then all the fields
Pedro> of the structure can be made private. Something like the patch
Pedro> below. (Tested on x86-64 GNU/Linux.)
Seems like a good idea to me.
Pedro> While at it, since we're touching most of the structure, we might as
Pedro> well reindent it to have open { at column 0. (Not done below to keep
Pedro> the patch readable.)
I added this and did the reindentation.
Also I removed the "explicit" from the constructor.
Tom
next prev parent reply other threads:[~2018-03-25 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 3:38 [RFA 0/2] two simple cleanup removals Tom Tromey
2018-03-23 3:38 ` [RFA 1/2] Remove cleanups from gdb_readline_wrapper Tom Tromey
2018-03-24 11:19 ` Pedro Alves
2018-03-25 16:19 ` Tom Tromey [this message]
2018-03-23 3:38 ` [RFA 2/2] Remove cleanups from prompt_for_continue Tom Tromey
2018-03-24 11:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vadkb00x.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).