From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85513 invoked by alias); 16 Oct 2017 23:00:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85500 invoked by uid 89); 16 Oct 2017 23:00:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 23:00:42 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 0437814053C for ; Mon, 16 Oct 2017 17:00:41 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id NP0d1w02E2f2jeq01P0gse; Mon, 16 Oct 2017 17:00:40 -0600 X-Authority-Analysis: v=2.2 cv=H76r+6Qi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=20KFwNOVAAAA:8 a=ChfjkYM5XqWKqa3wK2oA:9 Received: from 184-96-33-178.hlrn.qwest.net ([184.96.33.178]:48336 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e4ENB-0040hT-LL; Mon, 16 Oct 2017 17:00:37 -0600 From: Tom Tromey To: Pedro Alves Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 4/6] Simple cleanup removals in remote.c References: <20171016030427.21349-1-tom@tromey.com> <20171016030427.21349-5-tom@tromey.com> <07804bc3-a6c5-2c0f-5730-5dd12fccafbe@ericsson.com> <87fuaipzgg.fsf@tromey.com> <97a40149-a30f-b2af-4441-6945b1d29cf1@redhat.com> Date: Mon, 16 Oct 2017 23:00:00 -0000 In-Reply-To: <97a40149-a30f-b2af-4441-6945b1d29cf1@redhat.com> (Pedro Alves's message of "Mon, 16 Oct 2017 23:34:59 +0100") Message-ID: <87vajesnor.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1e4ENB-0040hT-LL X-Source-Sender: 184-96-33-178.hlrn.qwest.net (bapiya) [184.96.33.178]:48336 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00487.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This suggests to me that we're missing a string_printf variant Pedro> that appends to a preexisting string: Pedro> void string_appendf (std::string &dest, const char* fmt, ...); Pedro> See (untested) patch below. Seems like a good idea FWIW. Tom