From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55377 invoked by alias); 14 Oct 2016 21:22:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55337 invoked by uid 89); 14 Oct 2016 21:22:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:898, reader X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 14 Oct 2016 21:22:38 +0000 Received: (qmail 1543 invoked by uid 0); 14 Oct 2016 21:22:37 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy8.mail.unifiedlayer.com with SMTP; 14 Oct 2016 21:22:37 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id vZNZ1t00q2f2jeq01ZNcAD; Fri, 14 Oct 2016 15:22:36 -0600 X-Authority-Analysis: v=2.1 cv=IecUBwaa c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=8F6gY-xophSSON0-M9YA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:35738 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bv9w1-0006IR-L8; Fri, 14 Oct 2016 15:22:33 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 06/17] Record minimal symbols directly in reader. References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-7-git-send-email-tom@tromey.com> Date: Fri, 14 Oct 2016 21:22:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 13 Oct 2016 23:33:55 +0100") Message-ID: <87vawulj6w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bv9w1-0006IR-L8 X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:35738 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00462.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> +minimal_symbol_reader::record_full (const char *name, int name_len, >> + int copy_name, Pedro> Can you make this bool while at it? I've added a follow-up patch for this. >> + SECTION - the symbol's section >> + appropriate obj_section for the minimal symbol. This can be NULL. Pedro> Hmm, preexisting, but, this parameter's type is actually int. Pedro> Not sure that comment makes sense as is. I fixed this. >> + OBJFILE - the objfile associated with the minimal symbol. */ Pedro> ENOSUCHPARAMETER. .. and this >> + >> + struct minimal_symbol *record_full (const char *name, >> + int name_len, >> + int copy_name, Pedro> Use "bool" for copy_name ? .. and this and the other related things in the follow-up. Also I've fixed the other callers of record_full. Tom