From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23472 invoked by alias); 29 Jan 2015 15:58:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23456 invoked by uid 89); 29 Jan 2015 15:58:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 29 Jan 2015 15:58:15 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 29 Jan 2015 15:58:11 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 29 Jan 2015 15:58:10 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3A52617D805D for ; Thu, 29 Jan 2015 15:58:15 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0TFw9Cr60621048 for ; Thu, 29 Jan 2015 15:58:09 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0TAs1QE010766 for ; Thu, 29 Jan 2015 05:54:01 -0500 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-115.boeblingen.de.ibm.com [9.152.212.115]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t0TAs0FC010734; Thu, 29 Jan 2015 05:54:00 -0500 From: Andreas Arnez To: gdb-patches@sourceware.org Cc: Pedro Alves , Mark Kettenis , Joel Brobecker Subject: [PING] [PATCH 0/3] Fix for PR 17808 and some related changes Date: Thu, 29 Jan 2015 16:28:00 -0000 Message-ID: <87vbjp60kw.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15012915-0041-0000-0000-000003151070 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00760.txt.bz2 Ping: https://sourceware.org/ml/gdb-patches/2015-01/msg00424.html Pedro commented already, as shown below. Mark has not replied so far. Note that the PR is on the TODO list for 7.9. In my opinion at least patch 1 should go in 7.9; it's fairly harmless and should fix the PR. Patch 2 fixes a similar problem, but there might be a test gap, because I currently don't have access to appropriate test hardware (with AVX and AVX-512). And with patch 3 there's a slight chance of introducing bogus warnings when reading core files. Thus I'd suggest to push all three patches upstream, but only patch 1 into 7.9. OK? On Fri, Jan 23 2015, Pedro Alves wrote: > On 01/15/2015 03:21 PM, Andreas Arnez wrote: >> As seen in PR 17808, a test case with a forged (invalid) core file can >> crash GDB with an assertion failure when a register section has the >> wrong size. This patch series is about improving GDB's behavior in >> such cases: Patch 1 fixes the reported problem for i386 as well as for >> other targets; patch 2 avoids out-of-bounds accesses when an x86 >> ".reg-xstate" section is too short, and patch 3 adds a warning when a >> core file register section is larger than expected. >> >> This is based on the "lazy approach" suggested here: >> >> https://sourceware.org/ml/gdb-patches/2015-01/msg00229.html >> >> OK to apply? > > This looks good to me. Mark, any comments? > > Thanks, > Pedro Alves