From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7257 invoked by alias); 16 May 2014 20:17:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7236 invoked by uid 89); 16 May 2014 20:17:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 May 2014 20:17:31 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4GKHSIw024791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 May 2014 16:17:28 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4GKHRNj024234 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 16 May 2014 16:17:28 -0400 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH] PR mi/15806: Fix quoting of async events References: <1398568091-21253-1-git-send-email-simon.marchi@ericsson.com> <878uq17mrq.fsf@fleche.redhat.com> <537651BA.3020001@ericsson.com> <87ha4p60qg.fsf@fleche.redhat.com> <53766D85.3070402@ericsson.com> Date: Fri, 16 May 2014 20:17:00 -0000 In-Reply-To: <53766D85.3070402@ericsson.com> (Simon Marchi's message of "Fri, 16 May 2014 15:56:53 -0400") Message-ID: <87vbt532co.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00313.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> As you suggested, quoter == -1 could have a special meaning to modify Simon> the behavior of printchar. However, I think we are mixing two things Simon> that are not related. Why should the fact that I want to escape the " Simon> character influence whether I want to escape \ ? And vice-versa. I think it's just the normal quoting protocol. It's odd to quote one character but not also quote the quoting character. Simon> They seem quite independent to me. And if there are independent, Simon> it could mean we need two separate parameters, one saying if we Simon> want to escape a quoting character and another saying if we want Simon> to escape the backslashes. WDYT? Another option is to pass '\\' as QUOTER from remote.c. It occurs to me now that the patch should probably update the comment before printchar to document the special meaning of QUOTER==0. Tom