From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2448B384AB64 for ; Wed, 8 May 2024 14:26:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2448B384AB64 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2448B384AB64 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715178417; cv=none; b=ll/WDMGm1WiDdoh6925hWqJiPF3N39DKTkCI1bPD3jvooNF660K4c6gXQZ/l0MzRmvernUp2MvA13rJ4BG+AaEGStd8bU3XGzV/edUQZZ0zB8SeXUnqySR9F8pwqG8gxOJnP3AKMkAjniDkR2Wy9OmyG8VheuqDt8JJvFYnH3ls= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715178417; c=relaxed/simple; bh=uO+Y8fCvO//bZ+tjBneE+/geBZi1Njf2qYPD9LSen2g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Gg0Me2d2d9RSIzu32Rrepi3MlXdCILBALA5z/m77SuZR926ofVNQHl1eLfWUv8IgYAhgaQRATUlQo9qPibBIRR+j2ybLDvXLcivjZBGxhlV2NktCwrBt4UqMVvQx9bFpBhD5zoGPjHqBQQOqIm8gBct4r8pUMZIj3YQBf0z4b1o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715178415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tsAY8b6hp9Azq2WzmM1SVwSSJblfDHniwSLZD/v1058=; b=HAVdOiZWP0kNCQuJJr1N+PzXYqnkvpTXa4NIOTFrxtLCrmYzENRT7mF15VmuBV+2G7PhaS aiEur1rI1x6fAL5w51SPugExA1lMGQPvIAYNeORPTTUqcbD9R3x1cbq7qfjGv10KZhmQrF Xsr9bRA1ffOgYvXTXDofJ7b3uOY86rs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-yzBTRQG_NgeUx0kQg7pd4Q-1; Wed, 08 May 2024 10:26:54 -0400 X-MC-Unique: yzBTRQG_NgeUx0kQg7pd4Q-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-418a673c191so18566845e9.0 for ; Wed, 08 May 2024 07:26:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715178413; x=1715783213; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tsAY8b6hp9Azq2WzmM1SVwSSJblfDHniwSLZD/v1058=; b=tWMZXhMvIkLQwiO9Zaf/1BNlBEb2juFcqGnPsHaKB3TcL8l+QPyw5rt4WnzXnFe9mW SF03zacLnJzubnglx5zeC6k6YMiZCDM1TS6uooVesA2LLcglaA8u77tlEU3Nd3OBHF/j 5+8J/MKFbtw8NhIKJz18mtcQnNIJLF3e20z8q8NZtY9ixX19mM06iecwuip6nsKDX+o4 SYVExfOn5XRTE+z4g6AMRsLdlldFLz1n6fyqR6X9FtT2sCwZVpJfXimwYmnqIlZCv72p wMie+fzYr7YihzbfXMVXClPlrQhLbs/bgbm76vLukBAiz2V3zFe1ok6xjDgjJ2bcq5aQ f8Ew== X-Forwarded-Encrypted: i=1; AJvYcCVv9s207Pp7X77tuPY/OqjnKbyh9lY8qGq9O6JkvvUEkpnPRLnFVmqZ8jm+uejKAWjceZAgQhAh35kmuHhz09v3EPMe6yODIMiSUQ== X-Gm-Message-State: AOJu0YxzggVHztyzNlO+F4UkyAT70iaV2OBmMyLfxiNQB6eU7l+ijTbh pXtHnLsukcsTzLEAU/vwMsB6KubbBFhzgFdzLmNrBUFG7DvEPXgYMUSlIT5QurUwwd/h4zslXGU Wz4ZFUcGUWqO7tAve+S/khvaTT7JXHBdyXE5i9UaOxuz1qKPHhuSrprEWm6E= X-Received: by 2002:a05:6000:cc4:b0:34e:7096:8b92 with SMTP id ffacd0b85a97d-34fca42f43dmr1808532f8f.37.1715178412968; Wed, 08 May 2024 07:26:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnbvG5C0RyAZW2qyUIL2uzyFr/uOA4OMnMjgVzlPlpuIJwAlAsUyS2g7uB1ouikLsDW0u9OA== X-Received: by 2002:a05:6000:cc4:b0:34e:7096:8b92 with SMTP id ffacd0b85a97d-34fca42f43dmr1808510f8f.37.1715178412424; Wed, 08 May 2024 07:26:52 -0700 (PDT) Received: from localhost ([31.111.84.240]) by smtp.gmail.com with ESMTPSA id r13-20020a5d694d000000b0034c926ef66csm15416542wrw.51.2024.05.08.07.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 07:26:51 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , Klaus Gerlicher , simon.marchi@efficios.com Cc: Simon.Marchi@amd.com, gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: reject inserting breakpoints between functions In-Reply-To: References: <20220408200536.235329-1-simon.marchi@efficios.com> <6630b03f.050a0220.6a68d.6289SMTPIN_ADDED_BROKEN@mx.google.com> <87ttjhoocc.fsf@redhat.com> Date: Wed, 08 May 2024 15:26:50 +0100 Message-ID: <87wmo4s7kl.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi writes: > On 2024-05-01 05:47, Andrew Burgess wrote: >> Klaus Gerlicher writes: >> >>> Hi Simon, >>> >>> I verified that your patch addresses many of the issues we would also >>> like to solve in this area. >>> >>> It appears this has not published yet and it seems to be more than 2 >>> years old. >>> >>> Could you please tell me if there are any plans to commit this? >> >> Given I reviewed this once upon a time, I still had my review branch >> kicking around. >> >> I rebased onto something close to HEAD of master. I addressed the minor >> nits I pointed out in my review. I'd be happy to see this merged once >> my full regression run (still on going) has completed. >> >> I think I'd like Simon to give a +1 before I pushed this though. >> >> Thanks, >> Andrew > > Thanks for reminding me about this, it clearly fell through the cracks. > And thanks Andrew for following up on it. What you posted looks good to > me. We discussed it internally, Pedro suggested to maybe wait after the > GDB 15 branch is created before pushing this one, to give it more > testing time in master before it reaches a release. Fine with me. Feel free to pick this back up yourself if it's still of interest to you. I'll add it to my "todo" pile and revisit in a month or so if I don't see any activity. Thanks, Andrew