From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id EBE19385842B for ; Wed, 20 Mar 2024 20:32:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBE19385842B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBE19385842B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710966788; cv=none; b=SjByIEQ2ghODGzhhI+N/2xcmgnU5Buc5i9pH0xKTHOHQSsdqtrXJXH9CXw6Zms/sZ/ZMEPA0nOPZRYYI+/5atwut5/1JyfT5H92vgsf5/8+PMrBDq+i1nzWbNvHngIZgB96SkqlA3nDVM2tMBhEwYikYo4Rm59x6v2teagfAcuU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710966788; c=relaxed/simple; bh=ZcHlh70pMrvF55Qj1jQFT4JzxWl7azsO97gfJJ/WT34=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LPqF0UTtZyzhWUc9bPI98lfqdfg3BSig3iSOSAUmSl3XO1Yqw9fdABBiIuqiMpdM+j1+Xsfooqy7A9jJ4NSSnCLrMN5TWd70zsg6r1nn2gfuHsN8RQGNDecO2lthuOCynkVZWfXPvj+rG6nUTBc/vBvVMZEtHWIQBhwlFXLhSSU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-366c49ee863so1191835ab.1 for ; Wed, 20 Mar 2024 13:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1710966777; x=1711571577; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=YmClEE1diAYW52fnD7nYMz0uatkGAohW/pqiktUBCFQ=; b=Au4BA6G0gCOBiic3LLjDolIUUF4Z9N61kHc/+0Nca/4u2AUFFMYz0tvBSQyxZeS1LI OeeXhoWwIOTWCgPwJH7vXzdJoTrNqyqR/dJ64ieBq3FKt/pthF0L09ow+VosDqQuvFoO WYM6jejwb8L11PjOzu2XF4Su0Kth6QbJvDc0Dyw+ZKwPOqHkyuotQIQ7nGsfT+E6Lm/p s11ZG1zYW83UJIQiam2SXsaFHzLQdM3+1bS9wovrIqW37ZQ8WeuOfDOvRqaugZuoha+O 59zo9Lct6H8E8/sO7Sol0Xlvh/dQyeOWYWk5bKilh5W7WlVaQwovbDi3qaf2nFMBIY3k ZLSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710966777; x=1711571577; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YmClEE1diAYW52fnD7nYMz0uatkGAohW/pqiktUBCFQ=; b=X5KGSFjTWHhx83hnwVzRguWiP+q9MIqftZ0Ogx+t6man9ZHPVRRPDhTHBSpmKmolY9 aUt2BCT/WCJXGU+41fjTSL881eVwTJgfNdlHYisAflnMoCY0yMJPqTnkDOClwsc9hqYn tV8iEFulSXZ4vVbSReYb5SGimgIoZaaLnOgbZ09WvtPpZecrpNPU0D727Z//XZk1WC2P xMXX8cRFXTBrbDKEiCJwQHbyNTxCwydUGlYBXJ/wQQ9Ve6jSy9gsWSlH2on7KDIAQzq3 Pjet/wGj+85/I5DHzlwAcV4xCWsHI4rMy3r+yK2orEGY6NMzvSJEYxTgzee9lQzsGLmr zD/A== X-Forwarded-Encrypted: i=1; AJvYcCW2wrhY7OgMWOPLl+I92WiIGPJmlegd3QpObAoBrmowJLW64Endq3dnX1lilFdYNMaq84vetS9+qVu0OSwAY6FOIo+NgnG1XR09zA== X-Gm-Message-State: AOJu0YyQgbVmmxm4U/ATnRyGzMNuCfJqgKRaENhpogg1Ko2X0RMUqcax 0OfE8IkhhOus11OR8abDhQcJBj0uMi+Tr1xp/9M3PkCfm04frhmgjJhpWcxPeTpOyb9kEUep/n8 = X-Google-Smtp-Source: AGHT+IFq79h3UQb49XxIEA/CamowHceu2o7zz2MGHicoX+PQhcKVA7GYs+aLcCaIx4h2Ctdh6ZY7iA== X-Received: by 2002:a05:6602:21cc:b0:7cf:2782:241c with SMTP id c12-20020a05660221cc00b007cf2782241cmr800377ioc.16.1710966777099; Wed, 20 Mar 2024 13:32:57 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id c32-20020a029623000000b00474f03236fasm3914944jai.85.2024.03.20.13.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 13:32:56 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 8/9] Suppress some "undefined" warnings from flake8 References: <20240319-more-flake8-v1-0-893549dbed75@adacore.com> <20240319-more-flake8-v1-8-893549dbed75@adacore.com> <871q84fxy8.fsf@tromey.com> X-Attribution: Tom Date: Wed, 20 Mar 2024 14:32:56 -0600 In-Reply-To: <871q84fxy8.fsf@tromey.com> (Tom Tromey's message of "Wed, 20 Mar 2024 14:30:23 -0600") Message-ID: <87wmpwej9j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> Yeah. I'll send v2 with this fixed. Well, I did some branch shenanigans and b4 is unhappy, so here's the updated version of just this one patch. Tom commit 19d1ac05202ade4d4129bbad0e277f67bfdb1aaf Author: Tom Tromey Date: Tue Mar 19 11:08:34 2024 -0600 Suppress some "undefined" warnings from flake8 flake8 warns about some identifiers in __init__.py, because it does not realize these come from the star-imported _gdb module. This patch suppresses these warnings. diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py index 2ff1f95c8fd..611d725af58 100644 --- a/gdb/python/lib/gdb/__init__.py +++ b/gdb/python/lib/gdb/__init__.py @@ -26,6 +26,8 @@ if sys.version_info >= (3, 4): else: from imp import reload +import _gdb + # Note that two indicators are needed here to silence flake8. from _gdb import * # noqa: F401,F403 @@ -56,15 +58,14 @@ class _GdbFile(object): self.write(line) def flush(self): - flush(stream=self.stream) + _gdb.flush(stream=self.stream) def write(self, s): - write(s, stream=self.stream) - + _gdb.write(s, stream=self.stream) -sys.stdout = _GdbFile(STDOUT) -sys.stderr = _GdbFile(STDERR) +sys.stdout = _GdbFile(_gdb.STDOUT) +sys.stderr = _GdbFile(_gdb.STDERR) # Default prompt hook does nothing. prompt_hook = None @@ -185,7 +186,7 @@ def GdbSetPythonDirectory(dir): def current_progspace(): "Return the current Progspace." - return selected_inferior().progspace + return _gdb.selected_inferior().progspace def objfiles(): @@ -222,14 +223,14 @@ def set_parameter(name, value): value = "on" else: value = "off" - execute("set " + name + " " + str(value), to_string=True) + _gdb.execute("set " + name + " " + str(value), to_string=True) @contextmanager def with_parameter(name, value): """Temporarily set the GDB parameter NAME to VALUE. Note that this is a context manager.""" - old_value = parameter(name) + old_value = _gdb.parameter(name) set_parameter(name, value) try: # Nothing that useful to return.