From: Tom Tromey <tom@tromey.com>
To: Ciaran Woodward <ciaranwoodward@xmos.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com, Aditya.Kamath1@ibm.com
Subject: Re: [PATCH] Remove use of scoped_restore_tmpl from scoped_restore_warning_hook
Date: Tue, 06 Feb 2024 11:37:20 -0700 [thread overview]
Message-ID: <87wmrhcucf.fsf@tromey.com> (raw)
In-Reply-To: <20240206182213.23712-1-ciaranwoodward@xmos.com> (Ciaran Woodward's message of "Tue, 6 Feb 2024 18:22:13 +0000")
>>>>> "Ciaran" == Ciaran Woodward <ciaranwoodward@xmos.com> writes:
Ciaran> By manually implementing the save/restore behaviour, rather
Ciaran> than using the helper template, this warning is fixed.
Thank you.
Ciaran> + warning_hook_handler m_save;
Ciaran> + bool m_moved = false;
Can we just delete the move constructor?
Tom
next prev parent reply other threads:[~2024-02-06 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 18:22 Ciaran Woodward
2024-02-06 18:37 ` Tom Tromey [this message]
2024-02-07 11:18 ` Ciaran Woodward
2024-02-07 11:17 ` [PATCH v2] " Ciaran Woodward
2024-02-07 15:44 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmrhcucf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=ciaranwoodward@xmos.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).