From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 8B9843858D3C for ; Fri, 22 Dec 2023 16:10:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B9843858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B9843858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703261421; cv=none; b=JFaFThIoDuxvHX68ob8VmIe+NdpXciypqmkPCn1o4kWBildghD1DMPCyABTExBHvKSC6CKEOU/WaR/zzwVwV4Ef2ogqbAyT4/fVoEVHjYfsBvPNTelioIkWqTanzlE72LLn5RX2La+77/6ZUCym/pl0c1YSskxe32mYNuP+XssA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703261421; c=relaxed/simple; bh=hK7n/mKZtuCmkutH3FFKgUiWabyS8ZlHfyP2Oa94mVU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=k0iExoyS336O5uSgt5Z7hj36RJTMA1Yyy8SwkNhpGS0BOhQsOt1IhTNXmDC57O27bIonjriD9XE69xFANbT8lshYF/ZTNmikeMe4gyF5cCBnL0F+ZDIrzniN7tt8jg4mzV78hihUanJv2Y19LCHv68pjVoOE4fnDCAOWhj2Vvh4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id Gcn5rR0Ga6nOZGi6Orb3Iy; Fri, 22 Dec 2023 16:10:20 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Gi6NrVTJRRGmSGi6NrPz3f; Fri, 22 Dec 2023 16:10:20 +0000 X-Authority-Analysis: v=2.4 cv=efcuwpIH c=1 sm=1 tr=0 ts=6585b4ec a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=QyXUC8HyAAAA:8 a=3kamDm0_Um0XuKDuZFUA:9 a=ZXulRonScM0A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gH508GNwxHpKVKODxlgm4KmnxfMUfluxbAGvLQp7jQA=; b=qoPwi/a9a0AqtdC9wSFU3ayf0s u7znqb5fbFUiFnZM50fMUXNsYEZZcD+WnhX2X+OUMESroyMQGklbjHx/dWjQ627SvZUIdgEtRLlPJ aPNPt9w9Vzy4GD0Xxlv8BluJS; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:51076 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rGi6N-002v18-1F; Fri, 22 Dec 2023 09:10:19 -0700 From: Tom Tromey To: Eduard Sargsyan Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/1] gdb: fix assert after register write failure References: <20231219151448.23519-1-eduard.sargsyan@intel.com> <20231219151448.23519-2-eduard.sargsyan@intel.com> X-Attribution: Tom Date: Fri, 22 Dec 2023 09:10:18 -0700 In-Reply-To: <20231219151448.23519-2-eduard.sargsyan@intel.com> (Eduard Sargsyan's message of "Tue, 19 Dec 2023 15:14:48 +0000") Message-ID: <87wmt61amt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rGi6N-002v18-1F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:51076 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfP1AG2bQrx/YTPad9lS13G8Kf7LaLiPjxXUyBs6lnM9o5G8MTuR1Yel2eMjrYA4Yzgs7Iw0D9KpubUMe0hGnJ8DogEpEkYkk1itrrSzoQC86upL/Dp3D YkzV1nKeMaHQkpmqYG+7oWje1+aSN7KrftLuT37yWEzma6zuRdRlkT6qNn8vJZNyDUNbOFWOjX6fB9Q6f2tuFHOKEAnmZsOMdJE= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Eduard Sargsyan writes: > GDB tries to invalidate register cache if write to register fails. In case > when write was requested to be done for a remote inferior and connection with > remote is dead (so write request will fail) GDB cleans register caches and as > result setting register status fails with segmentation fault, because internal > pointers are not valid anymore and the unique_ptr with register status is > null. > This change adds check if register status cache is still valid before trying to > modify (set status to UNKNOWN). Could you say how to reproduce this? If it's an existing test case, then that's fine; but I am wondering if it needs a new test. Tom