From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Improve debug output support in gdbserver
Date: Fri, 17 Nov 2023 07:43:56 -0700 [thread overview]
Message-ID: <87wmugjv83.fsf@tromey.com> (raw)
In-Reply-To: <cover.1699379375.git.aburgess@redhat.com> (Andrew Burgess's message of "Tue, 7 Nov 2023 18:03:20 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> QUESTION: How would folk feel if I was super aggressive and removed
Andrew> these older flags? In theory these flags are only used for debugging
Andrew> gdbserver itself, but who knows, right?
I think it would be completely fine. I think it would be a bad idea for
us to promise that debug flags won't change, and the current approach in
gdbserver isn't really all that great.
Andrew> And on the monitor command side, we now support:
Andrew> (gdb) monitor set debug COMPONENT 1
Andrew> (gdb) monitor set debug COMPONENT 0
Andrew> to enable and disable debug for COMPONENT. Where COMPONENT is again,
Andrew> 'threads', 'remote', and 'event-loop'. Again, I've retained:
Andrew> (gdb) set debug 1
Andrew> (gdb) set debug 0
Andrew> which is equivalent to 'set debug threads 1' or 'set debug threads 0'.
Andrew> And I've also retained the legacy:
Andrew> (gdb) set remote-debug 1
Andrew> (gdb) set remote-debug 0
Andrew> (gdb) set event-loop-debug 1
Andrew> (gdb) set event-loop-debug 0
Andrew> QUESTION: As with the command line, how would people feel if I ripped
Andrew> out all of the legacy support and required folks to move to the newer
Andrew> command set?
I think this would also be fine.
Tom
next prev parent reply other threads:[~2023-11-17 14:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 18:03 Andrew Burgess
2023-11-07 18:03 ` [PATCH 1/3] gdbserver: cleanup monitor_show_help Andrew Burgess
2023-11-22 15:21 ` Andrew Burgess
2023-11-07 18:03 ` [PATCH 2/3] gdbserver: allow the --debug command line option to take a value Andrew Burgess
2023-11-07 19:41 ` Eli Zaretskii
2023-11-30 18:31 ` Andrew Burgess
2023-11-30 19:20 ` Eli Zaretskii
2023-12-04 15:57 ` Andrew Burgess
2023-12-04 16:21 ` Eli Zaretskii
2023-12-05 10:17 ` Andrew Burgess
2023-12-05 13:06 ` Eli Zaretskii
2023-11-07 18:03 ` [PATCH 3/3] gdbserver: allow for general 'monitor set debug COMPONENT VALUE' use Andrew Burgess
2023-11-17 14:43 ` Tom Tromey [this message]
2023-11-17 14:55 ` [PATCH 0/3] Improve debug output support in gdbserver Tom Tromey
2023-11-30 18:44 ` [PATCHv2 " Andrew Burgess
2023-11-30 18:44 ` [PATCHv2 1/3] gdb: fix GDB_DEBUG and GDBSERVER_DEBUG Makefile variables Andrew Burgess
2023-11-30 18:44 ` [PATCHv2 2/3] gdbserver: allow the --debug command line option to take a value Andrew Burgess
2023-11-30 18:44 ` [PATCHv2 3/3] gdbserver: allow for general 'monitor set debug COMPONENT VALUE' use Andrew Burgess
2023-11-30 19:30 ` Eli Zaretskii
2023-12-01 18:02 ` [PATCHv2 0/3] Improve debug output support in gdbserver Tom Tromey
2023-12-08 18:03 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmugjv83.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).