From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C7C013858291 for ; Mon, 13 Nov 2023 16:05:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7C013858291 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7C013858291 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699891506; cv=none; b=Y8zbb3WFapFbTA8xuknXNi5WF6lpbm+mXCJ7EkMJqYBW6N39upZxAKHbUSDQXjMphKscWdiRa+dZBzxGODMrUzm+LbrlP4pA3pPcwYaMx9fFcq45gLK55j/7qnDqj2ND/rddo1+CyH8tV8JVH0zIMPXt3NNXCqQ39PWsVwDWO64= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699891506; c=relaxed/simple; bh=3KVdRITjeZLW1i+A4OKeznaZPHLyCHL3GeKDkqTSlgo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XiMESbOU4IpI7M7Zd+ftK+enEUK8dE3FT7Mb7WkcTARwCT3efOJNJx/6CwmSJxIU6i/PZw3uJKX16qej1OMl9rUikTvyc01IbZmpoBCQyCgDcQPZ1Udy2jvgaqIHj9HOzh8pleqb7VOXWG5NG03anQztK1udEPb9fwWqHRBEDV8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699891501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xw3mgLiaWPT7oG9eaqQEN/sDISJzI5w4jxRLmZ4hFzU=; b=K17A7KHCqt3VeM9ZUmchqk8Hat18PY6uIpoyrrJ9SqpOl/Jislu7wjzMqf56ft8v7QZy0n GOBDlFePMFTH9J8m7dpMHXn98UB/Tn8Lh5VmXYRKART6Sh69hwS6qqPPme2lJWEVlY13/M jZCFxy2VLYxWrDrsNIiiBrjHH5TybNA= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-DRfg6pktNqelamSvBV_olA-1; Mon, 13 Nov 2023 11:05:00 -0500 X-MC-Unique: DRfg6pktNqelamSvBV_olA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c50234741eso38061481fa.1 for ; Mon, 13 Nov 2023 08:05:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699891498; x=1700496298; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xw3mgLiaWPT7oG9eaqQEN/sDISJzI5w4jxRLmZ4hFzU=; b=ZPab46E7uXEx1wf84ufogd3WIiO2lapLy3qKo3u2BMTjGZ2TIZoG6Qx5oE0Yh0u5LX Xei9oNw2C3LBKx7bc7At4FLR0TLbxQnbWIw4z4OC60ewkVUgHtMhp3Ozjd0Ye27UkQNx XlO5LFPbwGq8qTrX2eJpwVvjeiIhD3VF/+AB9Y+juaI1oQnQ8yAEXrlbFt5++Lh/qmAz ylEORHmK4LfoZR04UJGyNDVy6ihpXTJeKoPV7kFEikQk04q0atS2Tmaqrc08Q2lDoe4d 1SN/Me3el+ZL5Pb3N5Vkv1Ev/QU3150pFL6wijNNqgCWKRetE2L6imIQ0bY/J3VoFlWp gq9g== X-Gm-Message-State: AOJu0YysrSWFebjhElYhTb7MzOu3cYpo1obyYKsptK2qV9mUd3HFFGKX u98s2Id72iaPl3Hed4wubE+8kvZjHtlg9I0kmEq4OHRRK6b62ZHlZopK562LNATGF00LmztdqjG GXBhTenBwQdzhLu54lF0cGkZp1Hb1Dg== X-Received: by 2002:a2e:7c08:0:b0:2c6:eaf3:8065 with SMTP id x8-20020a2e7c08000000b002c6eaf38065mr5133209ljc.26.1699891498690; Mon, 13 Nov 2023 08:04:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6Cu0veIwb8sEyb6gtrRpxubHONofKi0zwbSfjLcmDC4ONqdzuN9NdUACy3OVgs1PZdWxM+w== X-Received: by 2002:a2e:7c08:0:b0:2c6:eaf3:8065 with SMTP id x8-20020a2e7c08000000b002c6eaf38065mr5133178ljc.26.1699891498298; Mon, 13 Nov 2023 08:04:58 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id l37-20020a05600c1d2500b004030e8ff964sm14518809wms.34.2023.11.13.08.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 08:04:57 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCHv2 0/5] New Python hook for missing debug information In-Reply-To: <878r72sijc.fsf@tromey.com> References: <878r72sijc.fsf@tromey.com> Date: Mon, 13 Nov 2023 16:04:56 +0000 Message-ID: <87wmulr653.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> This series adds a new Python hook to GDB, this hook allows a user to > Andrew> register a handler object which will be called whenever GDB fails to > Andrew> locate any debug information for an objfile it is loading. These > Andrew> handler objects can (potentially) perform host or project specific > Andrew> actions to help GDB locate the missing debug information. > > Do you have some specific scenario in mind for this? I'm wondering when > this would be useful, and when Objfile.add_separate_debug_file wouldn't > be sufficient. Fedora and RHEL GDB has, for many years now, carried a local patch that will suggest to the user a suitable RPM to install should GDB encounter some missing debug information. To some degree, maybe even mostly, this functionality has been replaced by debuginfod, but there are still some situations where we're finding this useful. So, I'm trying to replace the RH local (C++ patch) with a Python extension. For RPM suggestion, Python only really need to be notified when GDB encounters some missing debug info, and initially I did implement this as a new event. But when I looked at it, I didn't think this added much complexity to core GDB, and given we don't really like to change the Python API, I figure I might as well go with the fuller featured choice. > > Anyway the patches all seem fine to me. > Approved-By: Tom Tromey Thanks, Andrew