From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id A15F53858039 for ; Thu, 5 Oct 2023 16:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A15F53858039 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTP id oGLVq6uRWaLCxoRK9qcKCH; Thu, 05 Oct 2023 16:35:41 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id oRK8qMSzK5v9VoRK8qlvdN; Thu, 05 Oct 2023 16:35:40 +0000 X-Authority-Analysis: v=2.4 cv=QNp7+yHL c=1 sm=1 tr=0 ts=651ee5dc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=mswZTMVMtGXz81FW6ykA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aGu/B0jREIVDSpzK22+kQJXT+OrOUih0wDP7ugqg1R8=; b=pqLKVXR+UMA3Gtj+EXmYuFZy49 LiS3LUP3zCH+520y0G34Z2THLBgQUuyTFSQi/75uo7WSsRmbGmVe4ErSuNTWV4lHPs5h46hRV6HZ1 p7czEyTNXq/XZ4JpUowf3Dn3N; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:50412 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qoRK7-0023ZR-2E; Thu, 05 Oct 2023 10:35:39 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH 6/8] gdb: add all_objfiles_removed observer References: <20231004022305.298534-1-simon.marchi@polymtl.ca> <20231004022305.298534-7-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 05 Oct 2023 10:35:38 -0600 In-Reply-To: <20231004022305.298534-7-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 3 Oct 2023 22:20:21 -0400") Message-ID: <87wmw1vxgl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qoRK7-0023ZR-2E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:50412 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEyM/hWbTgSIDdm65G+tS3nNc9t6nm6TRleWR3w2rrapmWu1YrB0lv+IS+IOOU1z2CHPXqgx3LqX5xNCgzZeK7KAWcU2P3vW2x8DOylljTbvJxYmt5Om 1ayyUyTUcuLh4ZXfrycCokX9LdRXhtLRSkbWhCDP9Da5uEyvwNrJDdOAVRP/8onmuBLVh24FV8A29ay6sFsTsIwyAn5dNeCfvrI= X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> On the notify side, I found only one call site to change from Simon> new_objfile to all_objfiles_removed, in clear_symtab_users. It is not Simon> entirely clear to me that this is entirely correct. clear_symtab_users Simon> appears to be called in spots that don't remove all objfiles Simon> (functions finish_new_objfile, remove_symbol_file_command, reread_symbols, Simon> do_module_cleanups). But I think that this patch at least makes the Simon> current code clearer. FWIW there are a couple of bugs open about clear_symtab_users: https://sourceware.org/bugzilla/show_bug.cgi?id=17938 https://sourceware.org/bugzilla/show_bug.cgi?id=17857 Tom