From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta37.uswest2.a.cloudfilter.net (omta37.uswest2.a.cloudfilter.net [35.89.44.36]) by sourceware.org (Postfix) with ESMTPS id 948AE3858D33 for ; Wed, 16 Aug 2023 18:23:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 948AE3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTP id WIWCquBYiQFHRWLAzqDE41; Wed, 16 Aug 2023 18:23:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id WLAyqjwlGi8uRWLAyqOylz; Wed, 16 Aug 2023 18:23:24 +0000 X-Authority-Analysis: v=2.4 cv=JOsoDuGb c=1 sm=1 tr=0 ts=64dd141c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ouEwkPb2Nk+O7x3oDwQC55Q63YzvvbwwK0scTLWtoYo=; b=HCcShnMAzOn+R9REQv4jWnH83f Vp9FHF5gi91LHjIhPEFm+c909uE8bJ9CthDXlP4HkaQz+779iYwzxo4uehCCFdxf75yyyGPBpyANO cWA+96Y4XgM7hqvt0QUlfUvp3; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:36772 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qWLAx-002Yig-2g; Wed, 16 Aug 2023 12:23:23 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 6/7] [gdb/build] Return reference in target_read_auxv References: <20230815181309.8595-1-tdevries@suse.de> <20230815181309.8595-7-tdevries@suse.de> X-Attribution: Tom Date: Wed, 16 Aug 2023 12:23:23 -0600 In-Reply-To: <20230815181309.8595-7-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Tue, 15 Aug 2023 20:13:08 +0200") Message-ID: <87wmxuyhgk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qWLAx-002Yig-2g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:36772 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFpb7AKHVPqefzrkbGK7+j0ahLtAqNTmSa75F/aMrLH0+54SX0LKAp1Z3HGjIt957hGSbg6LUuoHUlOWuimAmPp3H7xgkhv7LTif/phW0U/uZICuP2yN 602AHMIKYKfoKt8zlZRAKA1oUBrA5gSW4a8wEcO9OHdIUvg92zzTDhbqQDNhWlGVrIvnFmYK3LQH3C+0cItfjcsyVFvYFR7DvrA= X-Spam-Status: No, score=-3018.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> In target_read_auxv we return a copy of an object: Tom> ... Tom> gdb::optional Tom> target_read_auxv () Tom> { Tom> ... Tom> return info->data; Tom> } Tom> ... Tom> Return a reference instead, saving a copy. I suspect it ought to return a const reference instead. Tom