From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Su1r=DO=gentoo.org=sam@sourceware.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	by sourceware.org (Postfix) with ESMTP id DC31C3858D20
	for <gdb-patches@sourceware.org>; Fri, 28 Jul 2023 15:38:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC31C3858D20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
References: <20230728123332.2521239-1-tromey@adacore.com>
User-agent: mu4e 1.10.4; emacs 29.1
From: Sam James <sam@gentoo.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Set PYTHONMALLOC in the test suite
Date: Fri, 28 Jul 2023 16:37:20 +0100
Organization: Gentoo
In-reply-to: <20230728123332.2521239-1-tromey@adacore.com>
Message-ID: <87wmyk2gij.fsf@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>


Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

> Setting PYTHONMALLOC helped me locate an earlier bug.  It seems to me
> that there aren't big downsides to always setting this during testing,
> and it might help find other bugs in the future.

This looks like a good idea. I was a bit disappointed that Python's
Valgrind integration didn't work for you in that bug, because it's
_supposed_ to detect when running under Valgrind and defer to its
malloc instead of its own, but I guess its own debug malloc is
different.

Anyway, yeah, the only downside is speed and that's not
a problem for tests, especially given they're small.