From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>,
Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCHv2] gdb/python: add mechanism to manage Python initialization functions
Date: Fri, 05 May 2023 18:27:46 +0100 [thread overview]
Message-ID: <87wn1m7kod.fsf@redhat.com> (raw)
In-Reply-To: <87fs8y4jiu.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> I saw this today and realized I'd forgotten to reply to it. It wasn't
> intentional.
>
> Andrew> I'm not a huge fan of our existing make-init-c system. I think, now
> Andrew> we've moved to C++ there are "in-lanaguage" ways we could achieve the
> Andrew> same result without having to generate code. Though I'm have no plans
> Andrew> to try and change the existing _initialize_* mechanism.
>
> Seems fair. I was worried about the static initialization problems
> we've hit before, but I see you have fixed those. And actually your
> patch makes me want to do the same for unit tests, so we can move the
> gdbsupport unit tests into gdbsupport/ where (IMO) they belong.
>
> Andrew> If you don't like this any more than my first attempt then I'll finish
> Andrew> off the make-init-c patch, but I thought I'd post this first and see
> Andrew> what you thought.
>
> This looks good to me.
>
> Reviewed-By: Tom Tromey <tom@tromey.com>
Thanks for getting back to this. I've gone ahead and pushed this now.
>
> Andrew> -int
> Andrew> +static int CPYCHECKER_NEGATIVE_RESULT_SETS_EXCEPTION
> Andrew> gdbpy_initialize_arch (void)
>
> Not a problem you need to address, but I'm not sure we can even run the
> Python checker any more, now that gdb is using C++ (and things like
> gdbpy_ref<>).
I wondered about this too, but wasn't sure how to check.
Would be nice to clean these up one day if they are no longer useful.
Thanks,
Andrew
next prev parent reply other threads:[~2023-05-05 17:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 16:53 [PATCH 0/3] New mechanism to initialise Python components in GDB Andrew Burgess
2022-10-02 16:53 ` [PATCH 1/3] gdb/python: break dependencies between gdbpy_initialize_* functions Andrew Burgess
2022-10-14 17:06 ` Tom Tromey
2022-10-20 15:58 ` Andrew Burgess
2022-10-02 16:53 ` [PATCH 2/3] gdb/python: break more " Andrew Burgess
2022-10-14 17:06 ` Tom Tromey
2022-10-20 15:59 ` Andrew Burgess
2022-10-02 16:53 ` [PATCH 3/3] gdb/python: add gdbpy_register_subsystem mechanism Andrew Burgess
2022-10-14 17:20 ` Tom Tromey
2022-10-21 13:17 ` [PATCHv2] gdb/python: add mechanism to manage Python initialization functions Andrew Burgess
2023-04-17 15:26 ` Tom Tromey
2023-05-05 17:27 ` Andrew Burgess [this message]
2023-05-05 20:07 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn1m7kod.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).