From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy5-pub.mail.unifiedlayer.com (qproxy5-pub.mail.unifiedlayer.com [69.89.21.30]) by sourceware.org (Postfix) with ESMTPS id 225B33858C31 for ; Wed, 3 May 2023 14:50:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 225B33858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by qproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 4ED0B8023403 for ; Wed, 3 May 2023 14:50:43 +0000 (UTC) Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id BFBE01003FCF6 for ; Wed, 3 May 2023 14:50:08 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id uDo0p59bClj3AuDo0poHYz; Wed, 03 May 2023 14:50:08 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=XsY/hXJ9 c=1 sm=1 tr=0 ts=645274a0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=n9Nvxce8AAAA:8 a=zstS-IiYAAAA:8 a=yENim94D2L3tfLbRbOAA:9 a=V4tbcg9hxeXQX3VEsxKP:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JcN8qDkDIoi2T1uJgWS6BH6SyyXqeKr7w6ytEM5JUxA=; b=mUmHN+DfROCdruIYK9NfHP2sej Sr0H5DnD0c5rD589eE2p/UtN+G72moLQN0H6RrBSeEmaVHEFIMHZpmQ0G3jJ0N8mSKBIFU25nPfAH UdpVzHh0EqD2Q+itbeG84eUdh; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:48608 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1puDo0-004Dpt-Hn; Wed, 03 May 2023 08:50:08 -0600 From: Tom Tromey To: Mark Wielaard Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Pass const frame_info_ptr reference for skip_[language_]trampoline References: <20230502183444.1445634-1-mark@klomp.org> X-Attribution: Tom Date: Wed, 03 May 2023 08:50:07 -0600 In-Reply-To: <20230502183444.1445634-1-mark@klomp.org> (Mark Wielaard's message of "Tue, 2 May 2023 20:34:44 +0200") Message-ID: <87wn1ptqow.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1puDo0-004Dpt-Hn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:48608 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Mark" == Mark Wielaard writes: Mark> It isn't clear why only in this one place g++ sees the issue (probably Mark> because it can inlined enough code in this specific case). s/inlined/inline/ Could you add a "Bug:" trailer with a link to the bugzilla entry? Anyway, other than that nit, this looks ok to me. It's a little unfortunate we don't know why exactly this particular spot warns, but on the other hand, the fix is harmless (actually an improvement) and we've worked around plenty of compiler oddities before. Reviewed-By: Tom Tromey Tom