From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 0963A3858D20 for ; Fri, 14 Apr 2023 13:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0963A3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 2EE1610042F93 for ; Fri, 14 Apr 2023 13:44:45 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id nJjJpqM77b9i8nJjJpxeVU; Fri, 14 Apr 2023 13:44:45 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Wd7J12tX c=1 sm=1 tr=0 ts=643958cd a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=nhJqM-8l0KKo5MKOIHkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u7b1mxHPKaeen/tjIjEQZh8R4LLn59M25+ZkkjYckt0=; b=ls1hVN2Z7H4j44g2ijPApw1sw4 OrxX9X4fKiGA6BVv9OJohO+qXCrQ51ef5m/OtZECImphbXEBAAUg8oUdBLPbezPvXZwG+XiVndSLx 1eo87SUU1xPJV2fDEtVTWx07C; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:43896 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pnJjI-000Cgf-NA; Fri, 14 Apr 2023 07:44:44 -0600 From: Tom Tromey To: Carl Love via Gdb-patches Cc: Tom Tromey , Carl Love , Ulrich Weigand , Kevin Buettner Subject: Re: [PATCH ver 2] PowerPC: fix _Float128 type output string References: <184c0edcf067acccdf71d4dcdd66447bb5d93d4c.camel@us.ibm.com> <1b5d214a6208c422963e58c27c98f81af9601628.camel@us.ibm.com> <87fs936f1o.fsf@tromey.com> <33972784460b21164a6581664f647c4edc03c1f9.camel@us.ibm.com> X-Attribution: Tom Date: Fri, 14 Apr 2023 07:44:43 -0600 In-Reply-To: <33972784460b21164a6581664f647c4edc03c1f9.camel@us.ibm.com> (Carl Love via Gdb-patches's message of "Thu, 13 Apr 2023 09:13:02 -0700") Message-ID: <87wn2e4lys.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pnJjI-000Cgf-NA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:43896 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Carl" == Carl Love via Gdb-patches writes: >> However, doesn't copy_type also copy the TYPE_FLOATFORMAT field? >> So where would this get reset? Carl> the GCC-generated dwarf info including the hack provides Carl> the following two type records: Carl> 1) name: _Float128 Carl> type: base floating-point type (TYPE_CODE_FLT) Carl> size: 16 Carl> format: floatformats_ieee_quad Carl> and Carl> 2) name: "long double" Carl> type: typedef (TYPE_CODE_TYPEDEF) Carl> target-type: _Float128 (i.e. type 1) above) Carl> What the patch does is to keep 1) as-is, and replace 2) by Carl> 2') name: "long double" Carl> type: base floating-point type (TYPE_CODE_FLT) Carl> size: 16 Carl> format: floatformats_ieee_quad Carl> where the name is taken from 2), and the rest of the Carl> record is taken from 1). Sorry for going in circles on this, but I still don't really get it. >From what I can see, the difference between (2) and (2') is just that one is a typedef and one is not. Where does this matter? Tom