From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 6FAFF3858289 for ; Wed, 8 Mar 2023 15:15:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FAFF3858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x134.google.com with SMTP id t1so6740451iln.8 for ; Wed, 08 Mar 2023 07:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678288507; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/WKgplr777Ubzn/RNk/QVXdjwiV4qjxomFdGbyuAj1w=; b=PYjlJq6SRHoX3rzRTsv5TgNhX1roulrcTldzaCvmutXOLonqEOXA+UPCYmy7P0kTj2 Wsgc3itouabWYv0kV9jYD7abrSOpK43YlQCvSBHGec9j5q7eAFAnLzKiE9cLtk3olNR8 lkVza9T/9XrNTWmzNMXlUWhzNf7Y5IcMIjE4LoZQYL6w0cUflB+DnSPc+eIH4T5cq3mC sECigxAn+L/aKwreog28cKBhTE0PJcSXY3Ckt3yRRPALE5852dcphpQIg9HrumTS4W/K VhN3hWtEUplKKFfdAfPflJ9ay4d9iHcdhO+eikdnFda1376H8RVCRgyU2ML4T5/KYdeX gUAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678288507; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/WKgplr777Ubzn/RNk/QVXdjwiV4qjxomFdGbyuAj1w=; b=yT1/nUGhgOhsV70BUXq+nDndWIxZsmVrhYbYVKQSyGGVwjL7uwopUZLeFkWoSy9SSm d+jkDN0pafAgD2ZO6IMmEkkp2cqa/Cy5S/CMKpxHzrYhh+Jgbit2wMR7x94PfDkKrGra nStW7als8EWtpy/vuJM8HbjZqLsRX7oq08JcerjMZpn7IqTb6o9Rp1Q6tow5T8jgGCTD tHpJvGBVbQSiSweRdVw4vH/P5rYJ+U9/bkHTWvxCVsFlB9fLzmb9qt6Y8UnfoTPVOQDn RHcxpKNolajCLtqrjynTHliJwbFExwixvAaBcS0LAWelgWPg74Z/m32CCxZ/iD0w0UwH sp/g== X-Gm-Message-State: AO0yUKUq0GdjJ1G0DNQVgO8gtqDDaszwSlRZQnACcha34qbAZj7esE85 Cu4frMEXB1MIo7MslLJjVBZZ2w== X-Google-Smtp-Source: AK7set/3gAe4romWmvZk0RWa13fGrbvyNmZyy/l/Gbh2osFQJxD+iXovU2UnEEirG63OI2PB98KgmA== X-Received: by 2002:a05:6e02:170c:b0:315:8e29:a0ad with SMTP id u12-20020a056e02170c00b003158e29a0admr413920ill.11.1678288507713; Wed, 08 Mar 2023 07:15:07 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id e17-20020a02a511000000b003c4eb5cb22csm4911187jam.134.2023.03.08.07.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 07:15:07 -0800 (PST) From: Tom Tromey To: Ulrich Weigand Cc: "gdb-patches@sourceware.org" , "tromey@adacore.com" , "will_schmidt@vnet.ibm.com" , "tdevries@suse.de" , "cel@us.ibm.com" Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp References: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com> <87cz5ks7zw.fsf@tromey.com> X-Attribution: Tom Date: Wed, 08 Mar 2023 08:15:06 -0700 In-Reply-To: (Ulrich Weigand's message of "Wed, 8 Mar 2023 13:48:25 +0000") Message-ID: <87wn3rnukl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ulrich> This looks good to me. The only (cosmetic) nit might be that if Ulrich> the function is installed for both 32-bit and 64-bit tdeps, Ulrich> convention seems to be that the function should be called ppc_... Ulrich> then, not ppc64_... Yep, I'll fix that in the real patch. I think I'll do it internally first so I can run it through the test suite, then send to gdb-patches. thanks, Tom