From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id D1156385840F for ; Fri, 24 Feb 2023 14:11:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1156385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id A5FB51004A820 for ; Fri, 24 Feb 2023 14:11:04 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VYmupoeg41ikhVYmupxYpd; Fri, 24 Feb 2023 14:11:04 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=De7SFthW c=1 sm=1 tr=0 ts=63f8c578 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=VGRipVkFMEYNsdS6xhsA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q1Pf7vzswl/BEMiTXzVTh2pgYZFLsB9QgvD6cLfprJ4=; b=XMMaH8X5bhzOaHUFLncONWd6z8 zV6w1Z6khp5yCaRJDVf+1IrqF3SOW3IJMIMv/sHwxMQdE0UpSMlk5pEikLzoXcClb5TbmS0Dxf5IM pRkCuQZZrYeUHJihSTeAtaUP6; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:52974 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVYmu-001fRe-6Z; Fri, 24 Feb 2023 07:11:04 -0700 From: Tom Tromey To: "Willgerodt, Felix via Gdb-patches" Cc: Tom Tromey , "Willgerodt, Felix" Subject: Re: [PATCH 1/1] gdb, fortran: Fix quad floating-point type for ifort compiler. References: <20230214110049.649769-1-felix.willgerodt@intel.com> <87bklwuvno.fsf@tromey.com> <87ttzmrhuz.fsf@tromey.com> X-Attribution: Tom Date: Fri, 24 Feb 2023 07:11:01 -0700 In-Reply-To: (Felix via Gdb-patches Willgerodt's message of "Mon, 20 Feb 2023 09:17:47 +0000") Message-ID: <87wn47i26i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pVYmu-001fRe-6Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:52974 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > When examining memory for this Fortran test, I see 128-bit values in > binary128 format, so I assume that this is just a software/compiler feature. > There is also decimal128 support in e.g. gcc. I tried it only briefly, > we don't end up in i386_floatformat_for_type for those types, but > GDB prints them just fine. I assume as they are marked as > DW_ATE_decimal_float instead of DW_ATE_float, but I didn't look into > it in detail. > I am not aware of any other float types that exist with this length. I wonder, then, if this patch would work? This way we would not have to curate a list of names. Tom diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 476d17f1efd..57e50ffdd73 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -8277,20 +8277,8 @@ static const struct floatformat ** i386_floatformat_for_type (struct gdbarch *gdbarch, const char *name, int len) { - if (len == 128 && name) - if (strcmp (name, "__float128") == 0 - || strcmp (name, "_Float128") == 0 - || strcmp (name, "complex _Float128") == 0 - || strcmp (name, "complex(kind=16)") == 0 - || strcmp (name, "COMPLEX(16)") == 0 - || strcmp (name, "complex*32") == 0 - || strcmp (name, "COMPLEX*32") == 0 - || strcmp (name, "quad complex") == 0 - || strcmp (name, "real(kind=16)") == 0 - || strcmp (name, "real*16") == 0 - || strcmp (name, "REAL*16") == 0 - || strcmp (name, "REAL(16)") == 0) - return floatformats_ieee_quad; + if (len == 128) + return floatformats_ieee_quad; return default_floatformat_for_type (gdbarch, name, len); }