From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 8C8503858C31 for ; Thu, 26 Jan 2023 18:34:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C8503858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 0C97B10048196 for ; Thu, 26 Jan 2023 18:34:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id L74gp5tIzPhg5L74gpla1o; Thu, 26 Jan 2023 18:34:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=fsEZ2H0f c=1 sm=1 tr=0 ts=63d2c7a6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=T_Alst9gAAAA:8 a=G97JyME3Yp66cKjqfOoA:9 a=DvZ5ixILWSEuw56YIEpp:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4+H4LcVvBI5wPMIFWPxzuyovwiqJZovP7RPXNnfAavQ=; b=FbPtJm4o1Og5rLCMUqoItstas4 cSjV35a7PQocU652y1d/7OacM2DClG6NPdO6u9bbyss3pcrRpIXgO50Oe8zO0J/FOmtj0Wz9aRszg r+0187OydfFDYlMTsySayxBUK; Received: from 75-166-146-144.hlrn.qwest.net ([75.166.146.144]:44608 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pL74e-004LMk-MB; Thu, 26 Jan 2023 11:34:13 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 12/27] Use clean_restart in gdb.trace References: <20230125224614.1006886-1-tom@tromey.com> <20230125224614.1006886-13-tom@tromey.com> <2912783e-3846-cc5a-9225-3ed08a96f18f@palves.net> X-Attribution: Tom Date: Thu, 26 Jan 2023 11:34:12 -0700 In-Reply-To: <2912783e-3846-cc5a-9225-3ed08a96f18f@palves.net> (Pedro Alves's message of "Thu, 26 Jan 2023 17:34:48 +0000") Message-ID: <87wn59qh5n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.144 X-Source-L: No X-Exim-ID: 1pL74e-004LMk-MB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-144.hlrn.qwest.net (murgatroyd) [75.166.146.144]:44608 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: >> - gdb_exit >> - gdb_start >> - gdb_reinitialize_dir $srcdir/$subdir >> - gdb_file_cmd $binfile >> + clean_restart $binfile Pedro> Note this one is not 100% equivalent, because this was using Pedro> gdb_file_cmd instead of gdb_load for a reason Ugh, I saw that clean_restart calls gdb_load, but gdb_load is really simple -- it just calls gdb_file_cmd! But... now I see the board files redefine gdb_load. It would be nice to get rid of the redefinitions and monkey-patching that is done in the test suite. IMO this leads to a lot of hidden gotchas. Maybe one idea would be to have a list (or namespace or something) of override-able procs, and require each board to provide them all... and then have a default "native" board. This way at least the default implementations wouldn't be living in gdb.exp to confuse me. I'll dig through and fix up these bits. Tom