From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 8265F3858CDA for ; Mon, 9 Jan 2023 15:49:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8265F3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12e.google.com with SMTP id h26so5006416ila.11 for ; Mon, 09 Jan 2023 07:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=iiXG/8tJeYJAJVEAScZDecZPAYiJ0hJbTv4oYQARwdk=; b=MbIaNhY7msKuN9VAFy2YOYeUf1Ldf3AfxwkQZFVVMyfLQij63k1tjnzzDZohFCqjSD Edq1MVVo0EYr2LjPGwDyNPF53qV3pn0movVMHRsJvaZPIv/U7LkbzOhMb4mBHT3hE9wF 9LA2mvx1xUn0Tk/r5rV8IH1SlIW6g4c2fmKwiLH5DqBomOOM138JosSDlvuAtkSgxuOI 18iRNUy+yrtQSOST3a00DS5mgTiRt+6A9VcZ0yjaYXya2Ctt8BeTRQKh68fLJsYEgGfd WcxfpLw9aApQsCR+GAkFYPwkFUyHaLpmMcIJ3GHjjkVRE/a1ww0TkjApGFFrYiHxLzYe kgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iiXG/8tJeYJAJVEAScZDecZPAYiJ0hJbTv4oYQARwdk=; b=GItY6ZfnL/MSOagLqmTHSf+tOkaSXaUzO5aDpPecSjCWIn5AI+PZ1+sNk0wZN15WIB /xv2jCsh7N2tpKeEiHVlNWe6E+YE/TkuGlJj8Boq4YXBQPhneAxNYYrW9ImhAIsCKARj xoZI/QQKJwoTMXCPIT6AFTiPGDXq7qy6wcEisTtZVEPuklMFCvA1R1ywOM+n0aX0g0Tb yhg9FF0+tMK9wgWZdzyNz7SLL/yoNPaoTcFwBegZO0K7OQjB5RWF7ff3GU/RDYcVDFte FR71NO/yRyR91L2LCFbx1iGZYB8ecieW4F+RJclPuP++0wsTQTEbPgCmzV04NPjFy5dW swWA== X-Gm-Message-State: AFqh2krLLI9R0J3hByJQNHll6sGT0t32xzvfp0J7owJ+fV8h4LFD2NHj EXviQ/57Kueizw73BPbvdcEFAdK729b0LiZh X-Google-Smtp-Source: AMrXdXvwF1h3hfgpAm6Y6dsU5FWLS5itWZAEuzg8Xkk1nNRcDkN2jq3cT12ncBU6+V8lc14JaZUCjQ== X-Received: by 2002:a05:6e02:d94:b0:30d:9349:65b1 with SMTP id i20-20020a056e020d9400b0030d934965b1mr8577997ilj.29.1673279385474; Mon, 09 Jan 2023 07:49:45 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id l13-20020a026a0d000000b00389fb6c2ca5sm2851713jac.98.2023.01.09.07.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:49:44 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Implement some agent expressions for Ada References: <20230104164452.1154744-1-tromey@adacore.com> <20230104164452.1154744-2-tromey@adacore.com> <2e2d19cc-bf4e-4ac7-902f-4ad0a7348e5f@simark.ca> X-Attribution: Tom Date: Mon, 09 Jan 2023 08:49:44 -0700 In-Reply-To: <2e2d19cc-bf4e-4ac7-902f-4ad0a7348e5f@simark.ca> (Simon Marchi's message of "Fri, 6 Jan 2023 16:38:05 -0500") Message-ID: <87wn5vaesn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> + std::get<0> (m_storage)->generate_ax (exp, ax, value, cast_type); >> + >> + struct type *type = value->type; >> + if (ada_is_aligner_type (type)) >> + error (_("Aligner types cannot be handled in agent expressions")); >> + else if (find_base_type (type) != nullptr) >> + error (_("Dynamic types cannot be handled in agent expressions")); Simon> Is it on purpose that you do these checks after calling generate_ax? It's intentional, because it is the type of the wrapped value that is being checked. Tom