From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 5B6A03857C51 for ; Fri, 18 Nov 2022 15:38:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B6A03857C51 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 963D610042404 for ; Fri, 18 Nov 2022 15:37:53 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id w3RBoZpl6hil5w3RBos8c6; Fri, 18 Nov 2022 15:37:53 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Qo6bYX+d c=1 sm=1 tr=0 ts=6377a6d1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=BJVTU551QcbFskoy2GsA:9 a=66zSKFQpzMcA:10:demote_shortener_domain_2 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=guTGlBNcImYZCOo7r2UD5S5URUw00GqsJ1CX6DsinFE=; b=SkwAcLKcS9tf91t14lRAPRslAI Nnf0ewsnndnF8WUU3gHSkJUzbeu0D/RRCJh2lNc4i/m7ZYoHB3cd6JGkL/jcgGJ8en3FfgqC5QqSJ ZENHquAK9+SobybVikkhFThKH; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56868 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ow3RB-002Ieg-6I; Fri, 18 Nov 2022 08:37:53 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , ro@gcc.gnu.org Subject: Re: [PATCH] gdb: fix symtab.c build on 32 bit targets References: <20221117183226.1632406-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 18 Nov 2022 08:37:51 -0700 In-Reply-To: <20221117183226.1632406-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 17 Nov 2022 13:32:26 -0500") Message-ID: <87wn7sqnn4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ow3RB-002Ieg-6I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56868 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> PR 29798 shows a similar error message but on Solaris. It should say "PR build/29798" here, so the commit script can pick it up. Simon> Work around that by using string_printf. It is a good thing to get rid Simon> of the alloca anyway. Indeed. IMO alloca should be poisoned. The patch looks good to me. Simon> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29798 ... we should teach that commit script to pick this up. I don't know how to access it, though. Tom