From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 387D33858439 for ; Mon, 24 Oct 2022 15:41:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 387D33858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666626071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=itvf7SXWLbdJfr/ITOjyhV38kgw9DyRr2X+GyJE8YPg=; b=InyLIPHIHNKP4cN22hCtrMi85cgevTGvb4tSIv52OqaEhcV7gK79n9SvmFrCTiIbxX2dKb Ygt5yjaDsryMnHrZMViusEFS1S3paypQtjG/r8Gg1FnqIxvmRn2BmcIuvOLxKGaphZh2VO sf9WsnD1hy6HnV+j/0WbvhIXnyYVnTg= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-50-pKvsV8bENj2j1rre83jAIw-1; Mon, 24 Oct 2022 11:41:10 -0400 X-MC-Unique: pKvsV8bENj2j1rre83jAIw-1 Received: by mail-qk1-f200.google.com with SMTP id bq17-20020a05620a469100b006eeb0bbe02bso9219581qkb.5 for ; Mon, 24 Oct 2022 08:41:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=itvf7SXWLbdJfr/ITOjyhV38kgw9DyRr2X+GyJE8YPg=; b=CgBsz5YV3pFQgq3mJhZiyBkoX1aevV3m9K6Y90PUvEnqdAMglrZ/WEnGTN/J5ynncb bYrX7coIAn0RtVWV9G1WI0EmuCND5naE3FYimnGZNGHhdVxjc2P2b0nQWAnUgg2Rz9Zn 2uIHnJFuQ4nZRg77olOFadwKv6UdkIszid6kJda2/TE+VBXWJMO7C+I7ejK6latriIVp f/nu9I1KFJl6rViAbYsOBs59MYpL9vUXu0Xxburf8uD3+b+0lCkdqKIAmX0K5MmSrvm9 75JHUgczERVCjeahCQwGjMM9PNDxqfW7Ofsuzb1ybNmuwuYSyFToFGQW6NALJGicup7C yQHA== X-Gm-Message-State: ACrzQf0noDJ9gE59i147VUb2vTCOQyIfvF7cO/aUdaELCyCUJl9CBPld ijfh3fKWnfYGDmTMiBOv+vxOVMWRBqK+sp2kX5tvsOsU5kotbWOVu0jXBRYeTLA/gn8HIL+hHUw 6lAesjBK1xnxFQ9nYwGaZhg== X-Received: by 2002:a05:620a:2698:b0:6f5:8236:8e82 with SMTP id c24-20020a05620a269800b006f582368e82mr3637442qkp.100.1666626069533; Mon, 24 Oct 2022 08:41:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45eSYi1YmaA5PEW2DxWzeMIUweRcw6fKZdnyP8llQLYHDYPO54mrTqaAfHWVNmwBdKG5AKpA== X-Received: by 2002:a05:620a:2698:b0:6f5:8236:8e82 with SMTP id c24-20020a05620a269800b006f582368e82mr3637424qkp.100.1666626069279; Mon, 24 Oct 2022 08:41:09 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id i8-20020a05620a248800b006bb0f9b89cfsm149457qkn.87.2022.10.24.08.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 08:41:08 -0700 (PDT) From: Andrew Burgess To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] sim/ppc: fix warnings related to printf format strings In-Reply-To: References: <97bcb87aa4ece94b30b62ec5d1845909dbb933a1.1665578246.git.aburgess@redhat.com> Date: Mon, 24 Oct 2022 16:41:06 +0100 Message-ID: <87wn8p8c19.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Mike Frysinger writes: > On 12 Oct 2022 13:38, Andrew Burgess via Gdb-patches wrote: >> --- a/sim/ppc/igen.c >> +++ b/sim/ppc/igen.c >> @@ -442,7 +442,7 @@ main(int argc, >> code |= generate_with_icache; >> break; >> default: >> - error (NULL, "Expecting -Ggen-icache or -Ggen-icache=\n"); >> + error ("Expecting -Ggen-icache or -Ggen-icache=\n"); > > the file is using inconsistent whitespace now > >> --- a/sim/ppc/ld-cache.c >> +++ b/sim/ppc/ld-cache.c >> @@ -88,13 +88,13 @@ static void >> dump_cache_rule(cache_table* rule, >> int indent) >> { >> - dumpf(indent, "((cache_table*)0x%x\n", rule); >> + dumpf(indent, "((cache_table*)0x%p\n", rule); > > you don't want 0x with %p as %p already includes it > > comes up multiple times in this patch Tsukasa OI already pointed this out: https://sourceware.org/pipermail/gdb-patches/2022-October/192598.html The version I pushed fixed this error. Thanks, Andrew