From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 7DB013858CDA for ; Fri, 7 Oct 2022 19:34:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7DB013858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id CB59A100445D4 for ; Fri, 7 Oct 2022 19:34:28 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id gt76oedx97nBmgt76obsgF; Fri, 07 Oct 2022 19:34:28 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=KJ2fsHJo c=1 sm=1 tr=0 ts=63407f44 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=1itmR_pQIM_GV9r5KN0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UzBSBxR8bJDgkzpBYLznRdE0mBbJn+2kA0pcjo0COxI=; b=HcNkyCSqL1giRrGP3VWsw/gvyk rBmsKdtSJsB5VnqzpjMntsDKwJnoTjc1iRHY+xmDHpaDOv6F/3LrCPngxMvcQTngC1C99sVAJt0HG soU1XcRC13RsE75ccWDJ5aNN7; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56624 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ogt75-000UYy-Is; Fri, 07 Oct 2022 13:34:27 -0600 From: Tom Tromey To: Bruno Larsen via Gdb-patches Subject: Re: [PATCH v4 5/5] gdb/frame: Add reinflation method for frame_info_ptr References: <20220830100837.926692-1-blarsen@redhat.com> <20220830100837.926692-6-blarsen@redhat.com> X-Attribution: Tom Date: Fri, 07 Oct 2022 13:34:21 -0600 In-Reply-To: <20220830100837.926692-6-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Tue, 30 Aug 2022 12:08:37 +0200") Message-ID: <87wn9bsa0y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ogt75-000UYy-Is X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56624 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2022 19:34:42 -0000 >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> + /* Cache the frame_id that the pointer will use to reinflate. */ Bruno> + void prepare_reinflate () Bruno> + { Bruno> + m_cached_id = get_frame_id(*this); Missing space before the "(". Bruno> + /* Use the cached frame_id to reinflate the pointer. */ Bruno> + void reinflate () Bruno> + { Bruno> + gdb_assert (m_cached_id != null_frame_id); Bruno> + Bruno> + if(m_ptr == nullptr) Here too. Bruno> diff --git a/gdb/infcmd.c b/gdb/infcmd.c Bruno> index d292a0e55bf..bc171d8818a 100644 Bruno> --- a/gdb/infcmd.c Bruno> +++ b/gdb/infcmd.c Bruno> @@ -1814,6 +1814,7 @@ finish_command (const char *arg, int from_tty) Bruno> frame = get_prev_frame (get_selected_frame (_("No selected frame."))); Bruno> if (frame == 0) Bruno> error (_("\"finish\" not meaningful in the outermost frame.")); Bruno> + frame.prepare_reinflate (); Bruno> clear_proceed_status (0); Bruno> @@ -1872,6 +1873,7 @@ finish_command (const char *arg, int from_tty) Bruno> print_stack_frame (get_selected_frame (NULL), 1, LOCATION, 0); Bruno> } Bruno> + frame.reinflate (); I'm curious about this change. Did you add this to avoid a crash? I.e., it's a latent bug of some kind? Bruno> if (execution_direction == EXEC_REVERSE) Bruno> finish_backward (sm); Bruno> diff --git a/gdb/mi/mi-cmd-stack.c b/gdb/mi/mi-cmd-stack.c Bruno> index f23559f886c..2c5bd2db96d 100644 Bruno> --- a/gdb/mi/mi-cmd-stack.c Bruno> +++ b/gdb/mi/mi-cmd-stack.c Bruno> @@ -39,6 +39,7 @@ Bruno> #include "inferior.h" Bruno> #include "observable.h" Bruno> + Bruno> enum what_to_list { locals, arguments, all }; Spurious change. Tom