From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id D6327385734F for ; Wed, 21 Sep 2022 14:43:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6327385734F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 159651003F59E for ; Wed, 21 Sep 2022 14:42:49 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id b0w4oomPClpGeb0w4ocK4Z; Wed, 21 Sep 2022 14:42:49 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=UZmU9IeN c=1 sm=1 tr=0 ts=632b22e9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=h-8ZGIICXp541AEXz5QA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MYIgD0REbJWZSyqYGAZNX96oi0w1KXcoN/jQG6ABT9M=; b=wFHtJpMpnWK+ttBFRBEo00uvW9 JVebjeZPVpzlRwSPFspJcnvkMm5+dvZ7dwSTo3ND95AgTlixdtBIX5QGqbmkv3KgIENWpp3rv1HaY 3c0UXgD2VvKil4lkL8b3/kX0N; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56520 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ob0w3-004A4a-Nj; Wed, 21 Sep 2022 08:42:47 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Subject: Re: [PATCH] gdb/python: restrict the names accepted by gdb.register_window_type References: <20220914142904.1071745-1-aburgess@redhat.com> X-Attribution: Tom Date: Wed, 21 Sep 2022 08:42:44 -0600 In-Reply-To: <20220914142904.1071745-1-aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 14 Sep 2022 15:29:04 +0100") Message-ID: <87wn9w4wm3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ob0w3-004A4a-Nj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56520 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 14:43:03 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> In the end I figured it might make sense to place some restrictive Andrew> rules in place, and then relax the rules later if/when users complain, Andrew> we can consider each relaxation as its requested. Andrew> So, I propose that window names should match this regular expression: Andrew> [a-zA-Z][-_.a-zA-Z0-9]* Makes sense to me. Andrew> There is a chance that there is user code in the wild which will break Andrew> with the addition of this change, but hopefully adapting to the new Andrew> restrictions shouldn't be too difficult. It's possible but I wouldn't worry about it. This patch looks good to me. Tom