From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 1F0593858C83 for ; Thu, 10 Mar 2022 17:06:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F0593858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 862361004733A for ; Thu, 10 Mar 2022 17:06:27 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id SMF8nVnY4wm8iSMF9nXKef; Thu, 10 Mar 2022 17:06:27 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DpSTREz+ c=1 sm=1 tr=0 ts=622a3013 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=N9q1xJWqXY3b6Q17aDgA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=o3bwvmDvMiH/yVSU6EdwcgNbsc59wP4FAhtQSA2Ddc8=; b=ifKAi9ThKmuqWm6pQzZvt5jhg0 u2lKjiD2FlyxCNwOgLQOipSs0/tH31eMaPwx0OYhj7F9s9TjKcP+wKlz+z7xL+XhaHymmXmmVVds6 44HXVO7EAeXU0lZDYvwsBjDy4; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37956 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSMF8-003SPQ-KZ; Thu, 10 Mar 2022 10:06:26 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH 1/2] gdb/gdbarch: remove the predicate function for gdbarch_register_type References: X-Attribution: Tom Date: Thu, 10 Mar 2022 10:06:26 -0700 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Thu, 10 Mar 2022 13:31:23 +0000") Message-ID: <87wnh1ohyl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nSMF8-003SPQ-KZ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37956 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 17:06:29 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> I don't believe that the gdbarch_register_type_p predicate is called Andrew> anywhere in GDB, and the gdbarch_register_type function is called Andrew> without checking the gdbarch_register_type_p predicate function Andrew> everywhere it is used, for example in Andrew> init_regcache_descr (regcache.c). Andrew> My claim is that the gdbarch_register_type function is required for Andrew> every architecture, and GDB will not work if this function is not Andrew> supplied. Andrew> And so, in this commit, I remove the 'predicate=True' from Andrew> gdbarch-components.py for the 'register_type' field, and regenerate Andrew> the gdbarch files. Looks ok to me. thanks, Tom